| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:03af9ed5-4de6-6eb6-72de-142021380e6f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 947E:1F44:B27C66:E9EE9C:6B011606 |
| html-safe-nonce | d38e591e063abcff2fc456181b58e6c88549d2c59599d04ef5bc999233d2996a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDdFOjFGNDQ6QjI3QzY2OkU5RUU5Qzo2QjAxMTYwNiIsInZpc2l0b3JfaWQiOiI2NDQ5NjAyMzc5ODc1Njg1ODk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a8b9f9a575740eee34b1e6cfb8542354d4f8b6335354a60566f98809a5cc498f |
| hovercard-subject-tag | pull_request:372374009 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/35227/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c63903300ac6786d637f7a6f17e051e7b8abc42ebacb873bedb1d614a6c60b8e/angular/angular/pull/35227 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c63903300ac6786d637f7a6f17e051e7b8abc42ebacb873bedb1d614a6c60b8e/angular/angular/pull/35227 |
| og:image:alt | The TargetedEntryPointFinder must work out what the
containing package is for each entry-point that it finds.
The logic for doing this was flawed in the case that the
package was in a path-mapped d... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | petebacondarwin |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/35227#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35227 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35227 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/35227 |
| Reload | https://github.com/angular/angular/pull/35227 |
| Reload | https://github.com/angular/angular/pull/35227 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| petebacondarwin | https://github.com/petebacondarwin |
| angular:master | https://github.com/angular/angular/tree/master |
| petebacondarwin:ngcc-targeted-dist-secondary-entry-points-35188 | https://github.com/petebacondarwin/angular/tree/ngcc-targeted-dist-secondary-entry-points-35188 |
| Conversation | https://github.com/angular/angular/pull/35227 |
| Commits1 (1) | https://github.com/angular/angular/pull/35227/commits |
| Checks | https://github.com/angular/angular/pull/35227/checks |
| Files changed | https://github.com/angular/angular/pull/35227/files |
| fix(ngcc): ensure that path-mapped secondary entry-points are processed correctly | https://github.com/angular/angular/pull/35227#top |
| petebacondarwin | https://github.com/petebacondarwin |
| angular:master | https://github.com/angular/angular/tree/master |
| petebacondarwin:ngcc-targeted-dist-secondary-entry-points-35188 | https://github.com/petebacondarwin/angular/tree/ngcc-targeted-dist-secondary-entry-points-35188 |
|
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Feb 7, 2020 | https://github.com/angular/angular/pull/35227#issue-561591709 |
| Please reload this page | https://github.com/angular/angular/pull/35227 |
| #35188 | https://github.com/angular/angular/issues/35188 |
| #34755 | https://github.com/angular/angular/issues/34755 |
| Please reload this page | https://github.com/angular/angular/pull/35227 |
|
| https://github.com/petebacondarwin |
| fix(ngcc): ensure that path-mapped secondary entry-points are process… | https://github.com/angular/angular/pull/35227/commits/d8aa74936a29e3e737b01210ba0e933ddf304913 |
| d8aa749 | https://github.com/angular/angular/pull/35227/commits/d8aa74936a29e3e737b01210ba0e933ddf304913 |
| angular#35188 | https://github.com/angular/angular/issues/35188 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
comp: ngcc
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22 |
| Feb 7, 2020 | https://github.com/angular/angular/pull/35227#event-3017377918 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Feb 7, 2020 | https://github.com/angular/angular/pull/35227#event-3017378019 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Feb 7, 2020 | https://github.com/angular/angular/pull/35227#event-3017378073 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| AndrewKushnir | https://github.com/AndrewKushnir |
| JoostK | https://github.com/JoostK |
| February 7, 2020 11:50 | https://github.com/angular/angular/pull/35227#event-3017378151 |
|
Ivy compiler doesn't work with secondary entry points in libraries using dist folder
#35188
| https://github.com/angular/angular/issues/35188 |
|
ngcc fails in monorepo setup with libraries built with view engine and consumed with tsconfig paths
#34755
| https://github.com/angular/angular/issues/34755 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Feb 7, 2020 | https://github.com/angular/angular/pull/35227#event-3017841199 |
|
ngcc fails in monorepo setup with libraries built with view engine and consumed with tsconfig paths
#34755
| https://github.com/angular/angular/issues/34755 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
Feb 7, 2020
| https://github.com/angular/angular/pull/35227#pullrequestreview-355338218 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35227/files/d8aa74936a29e3e737b01210ba0e933ddf304913 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| AndrewKushnir | https://github.com/AndrewKushnir |
| JoostK | https://github.com/JoostK |
| February 7, 2020 18:08 | https://github.com/angular/angular/pull/35227#event-3018598054 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Feb 7, 2020 | https://github.com/angular/angular/pull/35227#event-3018598555 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Feb 7, 2020
| https://github.com/angular/angular/pull/35227#pullrequestreview-355339406 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35227/files/d8aa74936a29e3e737b01210ba0e933ddf304913 |
| gkalpak | https://github.com/gkalpak |
| https://github.com/angular/angular/pull/35227#pullrequestreview-355339406 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35227 |
| kara | https://github.com/kara |
|
Feb 7, 2020
| https://github.com/angular/angular/pull/35227#ref-commit-c3c1140 |
|
| https://github.com/petebacondarwin |
|
| https://github.com/kara |
| fix(ngcc): ensure that path-mapped secondary entry-points are process… | https://github.com/angular/angular/commit/c3c11403c0f3a65d7e7993e5a76a3ed0157c1b76 |
| c3c1140 | https://github.com/angular/angular/commit/c3c11403c0f3a65d7e7993e5a76a3ed0157c1b76 |
| #35227 | https://github.com/angular/angular/pull/35227 |
| #35188 | https://github.com/angular/angular/issues/35188 |
| #35227 | https://github.com/angular/angular/pull/35227 |
| https://github.com/kara |
| kara | https://github.com/kara |
| 54c3a5d | https://github.com/angular/angular/commit/54c3a5da3f9c40e6e1157eff6337898993636170 |
| Feb 7, 2020 | https://github.com/angular/angular/pull/35227#event-3018844554 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| February 10, 2020 12:34 | https://github.com/angular/angular/pull/35227#event-3022529225 |
| https://github.com/jeripeierSBB |
| jeripeierSBB | https://github.com/jeripeierSBB |
|
Feb 11, 2020
| https://github.com/angular/angular/pull/35227#ref-issue-563182891 |
|
Try to upgrade angular 8.1 to angular 9.
#35332
| https://github.com/angular/angular/issues/35332 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Mar 12, 2020 | https://github.com/angular/angular/pull/35227#issuecomment-598272966 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/35227 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Mar 12, 2020 | https://github.com/angular/angular/pull/35227#event-3123499933 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35227 |
|
| https://github.com/alxhub |
|
alxhub
| https://github.com/alxhub |
|
| https://github.com/angular/angular/pull/35227/files/d8aa74936a29e3e737b01210ba0e933ddf304913 |
|
| https://github.com/gkalpak |
|
gkalpak
| https://github.com/gkalpak |
|
| https://github.com/angular/angular/pull/35227/files/d8aa74936a29e3e737b01210ba0e933ddf304913 |
| Please reload this page | https://github.com/angular/angular/pull/35227 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
|
Ivy compiler doesn't work with secondary entry points in libraries using dist folder
| https://github.com/angular/angular/issues/35188 |
|
ngcc fails in monorepo setup with libraries built with view engine and consumed with tsconfig paths
| https://github.com/angular/angular/issues/34755 |
| Please reload this page | https://github.com/angular/angular/pull/35227 |
|
| https://github.com/petebacondarwin |
|
| https://github.com/alxhub |
|
| https://github.com/gkalpak |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |