René's URL Explorer Experiment


Title: fix(ngcc): ensure that path-mapped secondary entry-points are processed correctly by petebacondarwin · Pull Request #35227 · angular/angular · GitHub

Open Graph Title: fix(ngcc): ensure that path-mapped secondary entry-points are processed correctly by petebacondarwin · Pull Request #35227 · angular/angular

X Title: fix(ngcc): ensure that path-mapped secondary entry-points are processed correctly by petebacondarwin · Pull Request #35227 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: The TargetedEntryPointFinder must work out what the containing package is for each entry-point that it finds. The logic for doing this was flawed in the case that the package was in a path-mapped d...

X Description: The TargetedEntryPointFinder must work out what the containing package is for each entry-point that it finds. The logic for doing this was flawed in the case that the package was in a path-mapped d...

Opengraph URL: https://github.com/angular/angular/pull/35227

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:03af9ed5-4de6-6eb6-72de-142021380e6f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id947E:1F44:B27C66:E9EE9C:6B011606
html-safe-nonced38e591e063abcff2fc456181b58e6c88549d2c59599d04ef5bc999233d2996a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDdFOjFGNDQ6QjI3QzY2OkU5RUU5Qzo2QjAxMTYwNiIsInZpc2l0b3JfaWQiOiI2NDQ5NjAyMzc5ODc1Njg1ODk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca8b9f9a575740eee34b1e6cfb8542354d4f8b6335354a60566f98809a5cc498f
hovercard-subject-tagpull_request:372374009
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/35227/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c63903300ac6786d637f7a6f17e051e7b8abc42ebacb873bedb1d614a6c60b8e/angular/angular/pull/35227
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c63903300ac6786d637f7a6f17e051e7b8abc42ebacb873bedb1d614a6c60b8e/angular/angular/pull/35227
og:image:altThe TargetedEntryPointFinder must work out what the containing package is for each entry-point that it finds. The logic for doing this was flawed in the case that the package was in a path-mapped d...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepetebacondarwin
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/35227#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35227
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35227
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/35227
Reloadhttps://github.com/angular/angular/pull/35227
Reloadhttps://github.com/angular/angular/pull/35227
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-targeted-dist-secondary-entry-points-35188https://github.com/petebacondarwin/angular/tree/ngcc-targeted-dist-secondary-entry-points-35188
Conversationhttps://github.com/angular/angular/pull/35227
Commits1 (1)https://github.com/angular/angular/pull/35227/commits
Checkshttps://github.com/angular/angular/pull/35227/checks
Files changedhttps://github.com/angular/angular/pull/35227/files
fix(ngcc): ensure that path-mapped secondary entry-points are processed correctlyhttps://github.com/angular/angular/pull/35227#top
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-targeted-dist-secondary-entry-points-35188https://github.com/petebacondarwin/angular/tree/ngcc-targeted-dist-secondary-entry-points-35188
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Feb 7, 2020https://github.com/angular/angular/pull/35227#issue-561591709
Please reload this pagehttps://github.com/angular/angular/pull/35227
#35188https://github.com/angular/angular/issues/35188
#34755https://github.com/angular/angular/issues/34755
Please reload this pagehttps://github.com/angular/angular/pull/35227
https://github.com/petebacondarwin
fix(ngcc): ensure that path-mapped secondary entry-points are process…https://github.com/angular/angular/pull/35227/commits/d8aa74936a29e3e737b01210ba0e933ddf304913
d8aa749https://github.com/angular/angular/pull/35227/commits/d8aa74936a29e3e737b01210ba0e933ddf304913
angular#35188https://github.com/angular/angular/issues/35188
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
comp: ngcc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
Feb 7, 2020https://github.com/angular/angular/pull/35227#event-3017377918
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Feb 7, 2020https://github.com/angular/angular/pull/35227#event-3017378019
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Feb 7, 2020https://github.com/angular/angular/pull/35227#event-3017378073
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
AndrewKushnirhttps://github.com/AndrewKushnir
JoostKhttps://github.com/JoostK
February 7, 2020 11:50https://github.com/angular/angular/pull/35227#event-3017378151
Ivy compiler doesn't work with secondary entry points in libraries using dist folder #35188 https://github.com/angular/angular/issues/35188
ngcc fails in monorepo setup with libraries built with view engine and consumed with tsconfig paths #34755 https://github.com/angular/angular/issues/34755
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Feb 7, 2020https://github.com/angular/angular/pull/35227#event-3017841199
ngcc fails in monorepo setup with libraries built with view engine and consumed with tsconfig paths #34755 https://github.com/angular/angular/issues/34755
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Feb 7, 2020 https://github.com/angular/angular/pull/35227#pullrequestreview-355338218
View reviewed changes https://github.com/angular/angular/pull/35227/files/d8aa74936a29e3e737b01210ba0e933ddf304913
https://github.com/alxhub
alxhubhttps://github.com/alxhub
AndrewKushnirhttps://github.com/AndrewKushnir
JoostKhttps://github.com/JoostK
February 7, 2020 18:08https://github.com/angular/angular/pull/35227#event-3018598054
https://github.com/alxhub
alxhubhttps://github.com/alxhub
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Feb 7, 2020https://github.com/angular/angular/pull/35227#event-3018598555
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Feb 7, 2020 https://github.com/angular/angular/pull/35227#pullrequestreview-355339406
View reviewed changes https://github.com/angular/angular/pull/35227/files/d8aa74936a29e3e737b01210ba0e933ddf304913
gkalpakhttps://github.com/gkalpak
https://github.com/angular/angular/pull/35227#pullrequestreview-355339406
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/35227
karahttps://github.com/kara
Feb 7, 2020 https://github.com/angular/angular/pull/35227#ref-commit-c3c1140
https://github.com/petebacondarwin
https://github.com/kara
fix(ngcc): ensure that path-mapped secondary entry-points are process…https://github.com/angular/angular/commit/c3c11403c0f3a65d7e7993e5a76a3ed0157c1b76
c3c1140https://github.com/angular/angular/commit/c3c11403c0f3a65d7e7993e5a76a3ed0157c1b76
#35227https://github.com/angular/angular/pull/35227
#35188https://github.com/angular/angular/issues/35188
#35227https://github.com/angular/angular/pull/35227
https://github.com/kara
karahttps://github.com/kara
54c3a5dhttps://github.com/angular/angular/commit/54c3a5da3f9c40e6e1157eff6337898993636170
Feb 7, 2020https://github.com/angular/angular/pull/35227#event-3018844554
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
February 10, 2020 12:34https://github.com/angular/angular/pull/35227#event-3022529225
https://github.com/jeripeierSBB
jeripeierSBBhttps://github.com/jeripeierSBB
Feb 11, 2020 https://github.com/angular/angular/pull/35227#ref-issue-563182891
Try to upgrade angular 8.1 to angular 9. #35332 https://github.com/angular/angular/issues/35332
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Mar 12, 2020https://github.com/angular/angular/pull/35227#issuecomment-598272966
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/35227
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Mar 12, 2020https://github.com/angular/angular/pull/35227#event-3123499933
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35227
https://github.com/alxhub
alxhub https://github.com/alxhub
https://github.com/angular/angular/pull/35227/files/d8aa74936a29e3e737b01210ba0e933ddf304913
https://github.com/gkalpak
gkalpak https://github.com/gkalpak
https://github.com/angular/angular/pull/35227/files/d8aa74936a29e3e737b01210ba0e933ddf304913
Please reload this pagehttps://github.com/angular/angular/pull/35227
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
Ivy compiler doesn't work with secondary entry points in libraries using dist folder https://github.com/angular/angular/issues/35188
ngcc fails in monorepo setup with libraries built with view engine and consumed with tsconfig paths https://github.com/angular/angular/issues/34755
Please reload this pagehttps://github.com/angular/angular/pull/35227
https://github.com/petebacondarwin
https://github.com/alxhub
https://github.com/gkalpak
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.