| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7f71ada7-42cb-0f2f-0556-342b298cf5bc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D4FC:19F84C:1293ECD:17CA5D4:6B010D60 |
| html-safe-nonce | 8c3c1a3d3e4f39f57e9e3a0a75ecb270da3cf2071145c2dab61088a87e5f3e64 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENEZDOjE5Rjg0QzoxMjkzRUNEOjE3Q0E1RDQ6NkIwMTBENjAiLCJ2aXNpdG9yX2lkIjoiNTE0Nzg1OTQyNTIzODc4MTI4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 05c95b7326465962f6dfcf75f2988b2203c884c4cb5add01f581704050a8d82c |
| hovercard-subject-tag | pull_request:372023807 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/35191/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1fec41513d9239fcb0aeb974f6dec95d4f37d540cd40a20e0d1be60ac8c51d22/angular/angular/pull/35191 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1fec41513d9239fcb0aeb974f6dec95d4f37d540cd40a20e0d1be60ac8c51d22/angular/angular/pull/35191 |
| og:image:alt | In ES5 code, TypeScript requires certain helpers (such as __spreadArrays()) to be able to support ES2015+ features. These helpers can be either imported from tslib (by setting the importHelpers TS ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gkalpak |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/35191#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35191 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35191 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/35191 |
| Reload | https://github.com/angular/angular/pull/35191 |
| Reload | https://github.com/angular/angular/pull/35191 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-ngcc-emitted-helpers | https://github.com/gkalpak/angular/tree/fix-ngcc-emitted-helpers |
| Conversation | https://github.com/angular/angular/pull/35191 |
| Commits6 (6) | https://github.com/angular/angular/pull/35191/commits |
| Checks | https://github.com/angular/angular/pull/35191/checks |
| Files changed | https://github.com/angular/angular/pull/35191/files |
| fix(ngcc): correctly detect emitted TS helpers in ES5 | https://github.com/angular/angular/pull/35191#top |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-ngcc-emitted-helpers | https://github.com/gkalpak/angular/tree/fix-ngcc-emitted-helpers |
|
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Feb 6, 2020 | https://github.com/angular/angular/pull/35191#issue-561162740 |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| FW-1689 | https://angular-team.atlassian.net/browse/FW-1689 |
| Test PR angular/angular#35191 ngcc-validation#838 | https://github.com/angular/ngcc-validation/pull/838 |
| CI run | https://circleci.com/workflow-run/0cf476fd-319e-4821-93f9-2f3716761c22 |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
comp: ngcc
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22 |
| Feb 6, 2020 | https://github.com/angular/angular/pull/35191#event-3014814653 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Feb 6, 2020 | https://github.com/angular/angular/pull/35191#event-3014814821 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Feb 6, 2020 | https://github.com/angular/angular/pull/35191#event-3014815219 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Feb 6, 2020
| https://github.com/angular/angular/pull/35191#ref-pullrequest-530767200 |
|
fix(ngcc): several fixes
#34169
| https://github.com/angular/angular/pull/34169 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Feb 6, 2020 | https://github.com/angular/angular/pull/35191#issuecomment-583023054 |
| https://pr35191-b0896dc.ngbuilds.io/ | https://pr35191-b0896dc.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/b0896dc2812efb44cea5fc5aed3a3ee3894cb81b..ab91c4c97c5f78e92ba3126d06a013e779172d00 |
| b0896dc | https://github.com/angular/angular/commit/b0896dc2812efb44cea5fc5aed3a3ee3894cb81b |
| ab91c4c | https://github.com/angular/angular/commit/ab91c4c97c5f78e92ba3126d06a013e779172d00 |
|
Compare
| https://github.com/angular/angular/compare/b0896dc2812efb44cea5fc5aed3a3ee3894cb81b..ab91c4c97c5f78e92ba3126d06a013e779172d00 |
| February 10, 2020 15:33 | https://github.com/angular/angular/pull/35191#event-3023203169 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Feb 10, 2020 | https://github.com/angular/angular/pull/35191#issuecomment-584184339 |
| https://pr35191-ab91c4c.ngbuilds.io/ | https://pr35191-ab91c4c.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/fe69710578277911e828178b64132f5f00a0b8ee..77155beb7d265c33d6b8846bd5f14271c021e33d |
| fe69710 | https://github.com/angular/angular/commit/fe69710578277911e828178b64132f5f00a0b8ee |
| 77155be | https://github.com/angular/angular/commit/77155beb7d265c33d6b8846bd5f14271c021e33d |
|
Compare
| https://github.com/angular/angular/compare/fe69710578277911e828178b64132f5f00a0b8ee..77155beb7d265c33d6b8846bd5f14271c021e33d |
| February 10, 2020 21:00 | https://github.com/angular/angular/pull/35191#event-3024348488 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Feb 10, 2020 | https://github.com/angular/angular/pull/35191#issuecomment-584356020 |
| https://pr35191-77155be.ngbuilds.io/ | https://pr35191-77155be.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Feb 10, 2020 | https://github.com/angular/angular/pull/35191#event-3024422407 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| kara | https://github.com/kara |
| February 10, 2020 21:24 | https://github.com/angular/angular/pull/35191#event-3024422717 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| February 10, 2020 21:24 | https://github.com/angular/angular/pull/35191#event-3024422801 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Feb 10, 2020
| https://github.com/angular/angular/pull/35191#pullrequestreview-356283343 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35191/files |
| petebacondarwin | https://github.com/petebacondarwin |
| https://github.com/angular/angular/pull/35191#pullrequestreview-356283343 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| https://github.com/kara |
| kara | https://github.com/kara |
| alxhub | https://github.com/alxhub |
| kara | https://github.com/kara |
| February 11, 2020 00:42 | https://github.com/angular/angular/pull/35191#event-3024898052 |
| https://github.com/kara |
| kara | https://github.com/kara |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Feb 11, 2020 | https://github.com/angular/angular/pull/35191#event-3024898200 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| February 11, 2020 08:37 | https://github.com/angular/angular/pull/35191#event-3025610789 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Feb 11, 2020
| https://github.com/angular/angular/pull/35191#pullrequestreview-356488404 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35191/files |
| packages/compiler-cli/ngcc/src/host/esm5_host.ts | https://github.com/angular/angular/pull/35191/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0 |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| packages/compiler-cli/ngcc/src/host/esm5_host.ts | https://github.com/angular/angular/pull/35191/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0 |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| packages/compiler-cli/src/ngtsc/partial_evaluator/src/ts_helpers.ts | https://github.com/angular/angular/pull/35191/files#diff-052683763802ce3f36d749d7e05a23ec88fcd4bba204850d4f972e34b034fca7 |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| packages/compiler-cli/src/ngtsc/partial_evaluator/test/evaluator_spec.ts | https://github.com/angular/angular/pull/35191/files#diff-c6c2f00ba140770ed45ec68adb15c6d80246277144625ef7793843e98063a829 |
| petebacondarwin | https://github.com/petebacondarwin |
| Feb 11, 2020 | https://github.com/angular/angular/pull/35191#discussion_r377506146 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| petebacondarwin | https://github.com/petebacondarwin |
| Feb 11, 2020 | https://github.com/angular/angular/pull/35191#discussion_r377506469 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| gkalpak | https://github.com/gkalpak |
| Feb 11, 2020 | https://github.com/angular/angular/pull/35191#discussion_r377613787 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| petebacondarwin | https://github.com/petebacondarwin |
| Feb 11, 2020 | https://github.com/angular/angular/pull/35191#discussion_r377711297 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| petebacondarwin | https://github.com/petebacondarwin |
| Feb 12, 2020 | https://github.com/angular/angular/pull/35191#discussion_r378130210 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| gkalpak | https://github.com/gkalpak |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35191#discussion_r378824100 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| integration/ngcc_spec.ts | https://github.com/angular/angular/blob/d6bc63fa3/packages/compiler-cli/ngcc/test/integration/ngcc_spec.ts |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Feb 11, 2020 | https://github.com/angular/angular/pull/35191#event-3025688244 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/77155beb7d265c33d6b8846bd5f14271c021e33d..b93c5372e95da4d747897fa4e4a71fd394f9729c |
| 77155be | https://github.com/angular/angular/commit/77155beb7d265c33d6b8846bd5f14271c021e33d |
| b93c537 | https://github.com/angular/angular/commit/b93c5372e95da4d747897fa4e4a71fd394f9729c |
|
Compare
| https://github.com/angular/angular/compare/77155beb7d265c33d6b8846bd5f14271c021e33d..b93c5372e95da4d747897fa4e4a71fd394f9729c |
| February 11, 2020 19:29 | https://github.com/angular/angular/pull/35191#event-3027915295 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Feb 11, 2020 | https://github.com/angular/angular/pull/35191#issuecomment-584810788 |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Feb 11, 2020 | https://github.com/angular/angular/pull/35191#event-3027921093 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Feb 11, 2020 | https://github.com/angular/angular/pull/35191#issuecomment-584813251 |
| https://pr35191-b93c537.ngbuilds.io/ | https://pr35191-b93c537.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Feb 12, 2020
| https://github.com/angular/angular/pull/35191#pullrequestreview-357288615 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35191/files |
| petebacondarwin | https://github.com/petebacondarwin |
| https://github.com/angular/angular/pull/35191#pullrequestreview-357288615 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @gkalpak | https://github.com/gkalpak |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| packages/compiler-cli/ngcc/test/host/commonjs_host_spec.ts | https://github.com/angular/angular/pull/35191/files#diff-0db82dee3e42c4dd42541af6804480af5c328f5b679cf2d9f33972527eca27c5 |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| packages/compiler-cli/ngcc/test/utils_spec.ts | https://github.com/angular/angular/pull/35191/files#diff-2a8d3f3a5281715816581a94ae9f6c7cd258be1b8a02e0ee64df87a737efb6be |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| packages/compiler-cli/src/ngtsc/partial_evaluator/test/evaluator_spec.ts | https://github.com/angular/angular/pull/35191/files#diff-c6c2f00ba140770ed45ec68adb15c6d80246277144625ef7793843e98063a829 |
| petebacondarwin | https://github.com/petebacondarwin |
| Feb 12, 2020 | https://github.com/angular/angular/pull/35191#discussion_r378130210 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Feb 12, 2020 | https://github.com/angular/angular/pull/35191#event-3030005926 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/c822227596ccbd1896988ec1b4e0a1c17741c0a6..381a1dbf35a55494d9bdb0f895653d7f4ff0a56d |
| c822227 | https://github.com/angular/angular/commit/c822227596ccbd1896988ec1b4e0a1c17741c0a6 |
| 381a1db | https://github.com/angular/angular/commit/381a1dbf35a55494d9bdb0f895653d7f4ff0a56d |
|
Compare
| https://github.com/angular/angular/compare/c822227596ccbd1896988ec1b4e0a1c17741c0a6..381a1dbf35a55494d9bdb0f895653d7f4ff0a56d |
| February 13, 2020 12:22 | https://github.com/angular/angular/pull/35191#event-3034629647 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35191#event-3034630911 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35191#issuecomment-585733081 |
| https://pr35191-381a1db.ngbuilds.io/ | https://pr35191-381a1db.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Feb 13, 2020
| https://github.com/angular/angular/pull/35191#ref-issue-555323415 |
|
Appears in the NgModule.imports of , but could not be resolved to an NgModule class
#34983
| https://github.com/angular/angular/issues/34983 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Feb 13, 2020
| https://github.com/angular/angular/pull/35191#pullrequestreview-358629538 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35191/files |
| JoostK | https://github.com/JoostK |
| https://github.com/angular/angular/pull/35191#pullrequestreview-358629538 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| packages/compiler-cli/ngcc/src/host/esm5_host.ts | https://github.com/angular/angular/pull/35191/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0 |
| JoostK | https://github.com/JoostK |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35191#discussion_r379180954 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| gkalpak | https://github.com/gkalpak |
| Feb 18, 2020 | https://github.com/angular/angular/pull/35191#discussion_r380726787 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| packages/compiler-cli/ngcc/src/utils.ts | https://github.com/angular/angular/pull/35191/files#diff-80d7bef7a408f6f49d97d8436ae6ab20186b2f133c9101a65735943b0cd61b7d |
| JoostK | https://github.com/JoostK |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35191#discussion_r379181182 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| gkalpak | https://github.com/gkalpak |
| Feb 18, 2020 | https://github.com/angular/angular/pull/35191#discussion_r380730868 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| packages/compiler-cli/src/ngtsc/partial_evaluator/test/evaluator_spec.ts | https://github.com/angular/angular/pull/35191/files#diff-c6c2f00ba140770ed45ec68adb15c6d80246277144625ef7793843e98063a829 |
| JoostK | https://github.com/JoostK |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35191#discussion_r379183370 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| gkalpak | https://github.com/gkalpak |
| February 18, 2020 17:01 | https://github.com/angular/angular/pull/35191#commits-pushed-b110634 |
|
| https://github.com/gkalpak |
| fix(ngcc): handle imports in dts files when processing CommonJS | https://github.com/angular/angular/pull/35191/commits/b110634bac843c1d6dbb55276033615b3293a762 |
| b110634 | https://github.com/angular/angular/pull/35191/commits/b110634bac843c1d6dbb55276033615b3293a762 |
| angular#34356 | https://github.com/angular/angular/pull/34356 |
|
| https://github.com/gkalpak |
| refactor(compiler-cli): rename the BuiltinFn type to the more gener… | https://github.com/angular/angular/pull/35191/commits/f93ec819753978a0d92d43a7e06f13224d32455b |
| f93ec81 | https://github.com/angular/angular/pull/35191/commits/f93ec819753978a0d92d43a7e06f13224d32455b |
|
| https://github.com/gkalpak |
| fix(ngcc): correctly detect emitted TS helpers in ES5 | https://github.com/angular/angular/pull/35191/commits/df1dbd2cda94930d8b8d855a67eeff68eb235fb9 |
| df1dbd2 | https://github.com/angular/angular/pull/35191/commits/df1dbd2cda94930d8b8d855a67eeff68eb235fb9 |
| https://angular-team.atlassian.net/browse/FW-1689 | https://angular-team.atlassian.net/browse/FW-1689 |
|
| https://github.com/gkalpak |
| fixup! fix(ngcc): correctly detect emitted TS helpers in ES5 | https://github.com/angular/angular/pull/35191/commits/e29b70cfed132342447241364743c3d9c735df1c |
| e29b70c | https://github.com/angular/angular/pull/35191/commits/e29b70cfed132342447241364743c3d9c735df1c |
|
| https://github.com/gkalpak |
| fixup! fix(ngcc): correctly detect emitted TS helpers in ES5 | https://github.com/angular/angular/pull/35191/commits/e0f58eb38a21b00db250938d139d4963cb460db0 |
| e0f58eb | https://github.com/angular/angular/pull/35191/commits/e0f58eb38a21b00db250938d139d4963cb460db0 |
|
| https://github.com/gkalpak |
| fixup! fix(ngcc): correctly detect emitted TS helpers in ES5 | https://github.com/angular/angular/pull/35191/commits/7e8850a44932c8e467b2535b9e31cca9ba5622e7 |
| 7e8850a | https://github.com/angular/angular/pull/35191/commits/7e8850a44932c8e467b2535b9e31cca9ba5622e7 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/381a1dbf35a55494d9bdb0f895653d7f4ff0a56d..7e8850a44932c8e467b2535b9e31cca9ba5622e7 |
| 381a1db | https://github.com/angular/angular/commit/381a1dbf35a55494d9bdb0f895653d7f4ff0a56d |
| 7e8850a | https://github.com/angular/angular/commit/7e8850a44932c8e467b2535b9e31cca9ba5622e7 |
|
Compare
| https://github.com/angular/angular/compare/381a1dbf35a55494d9bdb0f895653d7f4ff0a56d..7e8850a44932c8e467b2535b9e31cca9ba5622e7 |
| February 18, 2020 15:07 | https://github.com/angular/angular/pull/35191#event-3047529561 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Feb 18, 2020 | https://github.com/angular/angular/pull/35191#issuecomment-587511972 |
| 7e8850a | https://github.com/angular/angular/commit/7e8850a44932c8e467b2535b9e31cca9ba5622e7 |
| https://pr35191-7e8850a.ngbuilds.io/ | https://pr35191-7e8850a.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| alxhub | https://github.com/alxhub |
| February 18, 2020 18:51 | https://github.com/angular/angular/pull/35191#event-3048395100 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Feb 18, 2020 | https://github.com/angular/angular/pull/35191#event-3048395739 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| Feb 18, 2020 | https://github.com/angular/angular/pull/35191#issuecomment-587846460 |
| Presubmit | http://test/OCL:295802858:BASE:295802915:1582059817262:ce8b54a |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Feb 20, 2020
| https://github.com/angular/angular/pull/35191#ref-issue-564402588 |
|
IVY Error NG6002: Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class
#35399
| https://github.com/angular/angular/issues/35399 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| b6e8847 | https://github.com/angular/angular/commit/b6e88479674f8caea633d99edf061060e2051e9c |
| Feb 21, 2020 | https://github.com/angular/angular/pull/35191#event-3061236817 |
| mhevery | https://github.com/mhevery |
|
Feb 21, 2020
| https://github.com/angular/angular/pull/35191#ref-commit-14744f2 |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| refactor(compiler-cli): rename the BuiltinFn type to the more gener… | https://github.com/angular/angular/commit/14744f27c581326fce13bd4f8c07474ba156aa89 |
| 14744f2 | https://github.com/angular/angular/commit/14744f27c581326fce13bd4f8c07474ba156aa89 |
| #35191 | https://github.com/angular/angular/pull/35191 |
| #35191 | https://github.com/angular/angular/pull/35191 |
| mhevery | https://github.com/mhevery |
|
Feb 21, 2020
| https://github.com/angular/angular/pull/35191#ref-commit-bd6a39c |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| fix(ngcc): correctly detect emitted TS helpers in ES5 ( | https://github.com/angular/angular/commit/bd6a39c364cbfe0b7a0a6aa3477c96fad027e89a |
| #35191 | https://github.com/angular/angular/pull/35191 |
| ) | https://github.com/angular/angular/commit/bd6a39c364cbfe0b7a0a6aa3477c96fad027e89a |
| bd6a39c | https://github.com/angular/angular/commit/bd6a39c364cbfe0b7a0a6aa3477c96fad027e89a |
| https://angular-team.atlassian.net/browse/FW-1689 | https://angular-team.atlassian.net/browse/FW-1689 |
| #35191 | https://github.com/angular/angular/pull/35191 |
| mhevery | https://github.com/mhevery |
|
Feb 21, 2020
| https://github.com/angular/angular/pull/35191#ref-commit-12e3db8 |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| fix(ngcc): handle imports in dts files when processing CommonJS ( | https://github.com/angular/angular/commit/12e3db8d6f717efdc9db51d89e34bb64c295c7a1 |
| #35191 | https://github.com/angular/angular/pull/35191 |
| ) | https://github.com/angular/angular/commit/12e3db8d6f717efdc9db51d89e34bb64c295c7a1 |
| 12e3db8 | https://github.com/angular/angular/commit/12e3db8d6f717efdc9db51d89e34bb64c295c7a1 |
| #34356 | https://github.com/angular/angular/pull/34356 |
| #35191 | https://github.com/angular/angular/pull/35191 |
| mhevery | https://github.com/mhevery |
|
Feb 21, 2020
| https://github.com/angular/angular/pull/35191#ref-commit-6faaec6 |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| refactor(compiler-cli): rename the BuiltinFn type to the more gener… | https://github.com/angular/angular/commit/6faaec60b1b6748f393d47e330c5a7ea7568ddf1 |
| 6faaec6 | https://github.com/angular/angular/commit/6faaec60b1b6748f393d47e330c5a7ea7568ddf1 |
| #35191 | https://github.com/angular/angular/pull/35191 |
| #35191 | https://github.com/angular/angular/pull/35191 |
| mhevery | https://github.com/mhevery |
|
Feb 21, 2020
| https://github.com/angular/angular/pull/35191#ref-commit-af4fe3a |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| fix(ngcc): correctly detect emitted TS helpers in ES5 ( | https://github.com/angular/angular/commit/af4fe3aa4e8c90726ce823e0810ecbb9a5ccd11e |
| #35191 | https://github.com/angular/angular/pull/35191 |
| ) | https://github.com/angular/angular/commit/af4fe3aa4e8c90726ce823e0810ecbb9a5ccd11e |
| af4fe3a | https://github.com/angular/angular/commit/af4fe3aa4e8c90726ce823e0810ecbb9a5ccd11e |
| https://angular-team.atlassian.net/browse/FW-1689 | https://angular-team.atlassian.net/browse/FW-1689 |
| #35191 | https://github.com/angular/angular/pull/35191 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| February 21, 2020 17:09 | https://github.com/angular/angular/pull/35191#event-3061246582 |
| https://github.com/patran |
| patran | https://github.com/patran |
|
Feb 27, 2020
| https://github.com/angular/angular/pull/35191#ref-issue-546734360 |
|
After upgrade to Angular 9 get error "ERROR in Cannot read property 'length' of undefined" when building aws-amplify-angular
aws-amplify/amplify-js#4681
| https://github.com/aws-amplify/amplify-js/issues/4681 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Mar 23, 2020 | https://github.com/angular/angular/pull/35191#issuecomment-602697655 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Mar 23, 2020 | https://github.com/angular/angular/pull/35191#event-3155932769 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35191 |
|
| https://github.com/JoostK |
|
JoostK
| https://github.com/JoostK |
|
| https://github.com/angular/angular/pull/35191/files/5a21703a476391c40ea1d2991c169283976560b7 |
|
| https://github.com/petebacondarwin |
|
petebacondarwin
| https://github.com/petebacondarwin |
|
| https://github.com/angular/angular/pull/35191/files/c822227596ccbd1896988ec1b4e0a1c17741c0a6 |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
| Please reload this page | https://github.com/angular/angular/pull/35191 |
|
| https://github.com/gkalpak |
|
| https://github.com/mary-poppins |
|
| https://github.com/alxhub |
|
| https://github.com/petebacondarwin |
|
| https://github.com/JoostK |
|
| https://github.com/kara |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |