René's URL Explorer Experiment


Title: fix(ivy): set namespace for host elements of dynamically created components by AndrewKushnir · Pull Request #35136 · angular/angular · GitHub

Open Graph Title: fix(ivy): set namespace for host elements of dynamically created components by AndrewKushnir · Pull Request #35136 · angular/angular

X Title: fix(ivy): set namespace for host elements of dynamically created components by AndrewKushnir · Pull Request #35136 · angular/angular

Description: Prior to this change, element namespace was not set for host elements of dynamically created components that resulted in incorrect rendering in a browser. This commit adds the logic to pick and set correct namespace for host element when component is created dynamically. Fixes #34256, #34866. PR Type What kind of change does this PR introduce? Bugfix Does this PR introduce a breaking change? Yes No

Open Graph Description: Prior to this change, element namespace was not set for host elements of dynamically created components that resulted in incorrect rendering in a browser. This commit adds the logic to pick and set...

X Description: Prior to this change, element namespace was not set for host elements of dynamically created components that resulted in incorrect rendering in a browser. This commit adds the logic to pick and set...

Opengraph URL: https://github.com/angular/angular/pull/35136

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9880a40f-df9b-0e8a-2b00-a3e15c6d6201
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC2D6:ADA9D:1BF17E0:23E1D4B:6B0146E1
html-safe-nonceacb84b571b1fe847b3c6b436f128c7619e1c5e272b68538320a67679978eab32
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkQ2OkFEQTlEOjFCRjE3RTA6MjNFMUQ0Qjo2QjAxNDZFMSIsInZpc2l0b3JfaWQiOiIyNTM2MzkyMDQ1MDk0ODQ4MjI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac878557e99173fc74cb3bf9a42fbd123a551933e0ae98470ac4ab92cd6d8198cb
hovercard-subject-tagpull_request:370611340
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/35136/files
twitter:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
og:image:altPrior to this change, element namespace was not set for host elements of dynamically created components that resulted in incorrect rendering in a browser. This commit adds the logic to pick and set...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/35136/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35136%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35136%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/35136/files
Reloadhttps://github.com/angular/angular/pull/35136/files
Reloadhttps://github.com/angular/angular/pull/35136/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:namespace-for-dynamic-component-hosthttps://github.com/AndrewKushnir/angular/tree/namespace-for-dynamic-component-host
Conversation 10 https://github.com/angular/angular/pull/35136
Commits 3 https://github.com/angular/angular/pull/35136/commits
Checks 0 https://github.com/angular/angular/pull/35136/checks
Files changed https://github.com/angular/angular/pull/35136/files
Please reload this pagehttps://github.com/angular/angular/pull/35136/files
fix(ivy): set namespace for host elements of dynamically created components https://github.com/angular/angular/pull/35136/files#top
Show all changes 3 commits https://github.com/angular/angular/pull/35136/files
19daea3 fix(ivy): set namespace for host elements of dynamically created comp… AndrewKushnir Feb 4, 2020 https://github.com/angular/angular/pull/35136/commits/19daea36bc0d0cc477ccdb0be6a79cab58955c1e
9f5d9d4 fixup! fix(ivy): set namespace for host elements of dynamically creat… AndrewKushnir Feb 4, 2020 https://github.com/angular/angular/pull/35136/commits/9f5d9d4ba857d93cf3f5eb29c53bba767b187506
b132e5d fixup! fix(ivy): set namespace for host elements of dynamically creat… AndrewKushnir Feb 4, 2020 https://github.com/angular/angular/pull/35136/commits/b132e5db3714aaf2fc31ed09433fb5e23bedd170
Clear filters https://github.com/angular/angular/pull/35136/files
Please reload this pagehttps://github.com/angular/angular/pull/35136/files
Please reload this pagehttps://github.com/angular/angular/pull/35136/files
component_ref.ts https://github.com/angular/angular/pull/35136/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
namespaces.ts https://github.com/angular/angular/pull/35136/files#diff-abdeed459c296f100dd5688ebb40649d6311805808a5e7d33155aebec02eff56
state.ts https://github.com/angular/angular/pull/35136/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
view_container_ref_spec.ts https://github.com/angular/angular/pull/35136/files#diff-1e38ce2b6dd3a923c6a35770a92b258d314e4916167d32ea687ebe74df339fcb
dom_renderer.ts https://github.com/angular/angular/pull/35136/files#diff-0947a499c3c9edb99e4a89bb12a231a5ffae06b51464e0e52e4c025a76e6fcd6
server_renderer.ts https://github.com/angular/angular/pull/35136/files#diff-fe6768f58e32d9fdc70a4aedceefdc19d4d7394ac3a6996e32b9590c508fe6c7
packages/core/src/render3/component_ref.tshttps://github.com/angular/angular/pull/35136/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
View file https://github.com/AndrewKushnir/angular/blob/b132e5db3714aaf2fc31ed09433fb5e23bedd170/packages/core/src/render3/component_ref.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35136/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35136/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
https://github.com/angular/angular/pull/35136/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
https://github.com/angular/angular/pull/35136/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
https://github.com/angular/angular/pull/35136/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
https://github.com/angular/angular/pull/35136/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
https://github.com/angular/angular/pull/35136/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
https://github.com/angular/angular/pull/35136/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
packages/core/src/render3/namespaces.tshttps://github.com/angular/angular/pull/35136/files#diff-abdeed459c296f100dd5688ebb40649d6311805808a5e7d33155aebec02eff56
View file https://github.com/AndrewKushnir/angular/blob/b132e5db3714aaf2fc31ed09433fb5e23bedd170/packages/core/src/render3/namespaces.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35136/{{ revealButtonHref }}
packages/core/src/render3/state.tshttps://github.com/angular/angular/pull/35136/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
View file https://github.com/AndrewKushnir/angular/blob/b132e5db3714aaf2fc31ed09433fb5e23bedd170/packages/core/src/render3/state.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35136/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35136/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
https://github.com/angular/angular/pull/35136/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
https://github.com/angular/angular/pull/35136/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
https://github.com/angular/angular/pull/35136/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
https://github.com/angular/angular/pull/35136/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
packages/core/test/acceptance/view_container_ref_spec.tshttps://github.com/angular/angular/pull/35136/files#diff-1e38ce2b6dd3a923c6a35770a92b258d314e4916167d32ea687ebe74df339fcb
View file https://github.com/AndrewKushnir/angular/blob/b132e5db3714aaf2fc31ed09433fb5e23bedd170/packages/core/test/acceptance/view_container_ref_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35136/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35136/files#diff-1e38ce2b6dd3a923c6a35770a92b258d314e4916167d32ea687ebe74df339fcb
https://github.com/angular/angular/pull/35136/files#diff-1e38ce2b6dd3a923c6a35770a92b258d314e4916167d32ea687ebe74df339fcb
https://github.com/angular/angular/pull/35136/files#diff-1e38ce2b6dd3a923c6a35770a92b258d314e4916167d32ea687ebe74df339fcb
Please reload this pagehttps://github.com/angular/angular/pull/35136/files
https://github.com/angular/angular/pull/35136/files#diff-1e38ce2b6dd3a923c6a35770a92b258d314e4916167d32ea687ebe74df339fcb
packages/platform-browser/src/dom/dom_renderer.tshttps://github.com/angular/angular/pull/35136/files#diff-0947a499c3c9edb99e4a89bb12a231a5ffae06b51464e0e52e4c025a76e6fcd6
View file https://github.com/AndrewKushnir/angular/blob/b132e5db3714aaf2fc31ed09433fb5e23bedd170/packages/platform-browser/src/dom/dom_renderer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35136/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35136/files#diff-0947a499c3c9edb99e4a89bb12a231a5ffae06b51464e0e52e4c025a76e6fcd6
karahttps://github.com/kara
Feb 8, 2020https://github.com/angular/angular/pull/35136/files#r376673949
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/35136/files
https://github.com/angular/angular/pull/35136/files#diff-0947a499c3c9edb99e4a89bb12a231a5ffae06b51464e0e52e4c025a76e6fcd6
https://github.com/angular/angular/pull/35136/files#diff-0947a499c3c9edb99e4a89bb12a231a5ffae06b51464e0e52e4c025a76e6fcd6
packages/platform-server/src/server_renderer.tshttps://github.com/angular/angular/pull/35136/files#diff-fe6768f58e32d9fdc70a4aedceefdc19d4d7394ac3a6996e32b9590c508fe6c7
View file https://github.com/AndrewKushnir/angular/blob/b132e5db3714aaf2fc31ed09433fb5e23bedd170/packages/platform-server/src/server_renderer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35136/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35136/files#diff-fe6768f58e32d9fdc70a4aedceefdc19d4d7394ac3a6996e32b9590c508fe6c7
https://github.com/angular/angular/pull/35136/files#diff-fe6768f58e32d9fdc70a4aedceefdc19d4d7394ac3a6996e32b9590c508fe6c7
https://github.com/angular/angular/pull/35136/files#diff-fe6768f58e32d9fdc70a4aedceefdc19d4d7394ac3a6996e32b9590c508fe6c7
https://github.com/angular/angular/pull/35136/files#diff-fe6768f58e32d9fdc70a4aedceefdc19d4d7394ac3a6996e32b9590c508fe6c7
https://github.com/angular/angular/pull/35136/files#diff-fe6768f58e32d9fdc70a4aedceefdc19d4d7394ac3a6996e32b9590c508fe6c7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.