René's URL Explorer Experiment


Title: fix(ivy): set namespace for host elements of dynamically created components by AndrewKushnir · Pull Request #35136 · angular/angular · GitHub

Open Graph Title: fix(ivy): set namespace for host elements of dynamically created components by AndrewKushnir · Pull Request #35136 · angular/angular

X Title: fix(ivy): set namespace for host elements of dynamically created components by AndrewKushnir · Pull Request #35136 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Prior to this change, element namespace was not set for host elements of dynamically created components that resulted in incorrect rendering in a browser. This commit adds the logic to pick and set...

X Description: Prior to this change, element namespace was not set for host elements of dynamically created components that resulted in incorrect rendering in a browser. This commit adds the logic to pick and set...

Opengraph URL: https://github.com/angular/angular/pull/35136

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fd8551e3-0b64-e016-067a-64fa616cf73e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8DD8:29FFA9:1659120:1C55F9A:6B013355
html-safe-nonce92e060359f4100888b3e98fdf90f451091cce2b140615ce8cfd97bdf4064a54a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4REQ4OjI5RkZBOToxNjU5MTIwOjFDNTVGOUE6NkIwMTMzNTUiLCJ2aXNpdG9yX2lkIjoiMzc5MzIyNTExMjI4Nzc4NTgxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac01a8e4c341f63ae8fe125ebf597eb588f24c60248fbf6707516b5328407ab1a2
hovercard-subject-tagpull_request:370611340
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/35136/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a2a190a563df91bbb5d2d8e0bddee5890f8dc3dd995cc45dd8d69b3df35b67e7/angular/angular/pull/35136
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a2a190a563df91bbb5d2d8e0bddee5890f8dc3dd995cc45dd8d69b3df35b67e7/angular/angular/pull/35136
og:image:altPrior to this change, element namespace was not set for host elements of dynamically created components that resulted in incorrect rendering in a browser. This commit adds the logic to pick and set...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAndrewKushnir
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/35136#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35136
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35136
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/35136
Reloadhttps://github.com/angular/angular/pull/35136
Reloadhttps://github.com/angular/angular/pull/35136
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:namespace-for-dynamic-component-hosthttps://github.com/AndrewKushnir/angular/tree/namespace-for-dynamic-component-host
Conversationhttps://github.com/angular/angular/pull/35136
Commits3 (3)https://github.com/angular/angular/pull/35136/commits
Checkshttps://github.com/angular/angular/pull/35136/checks
Files changedhttps://github.com/angular/angular/pull/35136/files
fix(ivy): set namespace for host elements of dynamically created componentshttps://github.com/angular/angular/pull/35136#top
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:namespace-for-dynamic-component-hosthttps://github.com/AndrewKushnir/angular/tree/namespace-for-dynamic-component-host
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Feb 4, 2020https://github.com/angular/angular/pull/35136#issue-559443754
#34256https://github.com/angular/angular/issues/34256
#34866https://github.com/angular/angular/issues/34866
Please reload this pagehttps://github.com/angular/angular/pull/35136
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
comp: ivy https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
Feb 4, 2020https://github.com/angular/angular/pull/35136#event-3004464342
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
karahttps://github.com/kara
February 4, 2020 02:09https://github.com/angular/angular/pull/35136#event-3004464351
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Feb 4, 2020https://github.com/angular/angular/pull/35136#event-3004464425
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Feb 4, 2020https://github.com/angular/angular/pull/35136#event-3004464963
[RC5 IVY] Nested SVG doesn't work anymore #34256 https://github.com/angular/angular/issues/34256
ViewContainerRef.createComponent with svg component #34866 https://github.com/angular/angular/issues/34866
https://github.com/kara
karahttps://github.com/kara
Feb 4, 2020 https://github.com/angular/angular/pull/35136#pullrequestreview-352688845
View reviewed changes https://github.com/angular/angular/pull/35136/files
karahttps://github.com/kara
https://github.com/angular/angular/pull/35136#pullrequestreview-352688845
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/35136
packages/core/test/acceptance/view_container_ref_spec.tshttps://github.com/angular/angular/pull/35136/files#diff-1e38ce2b6dd3a923c6a35770a92b258d314e4916167d32ea687ebe74df339fcb
Please reload this pagehttps://github.com/angular/angular/pull/35136
packages/core/test/acceptance/view_container_ref_spec.tshttps://github.com/angular/angular/pull/35136/files#diff-1e38ce2b6dd3a923c6a35770a92b258d314e4916167d32ea687ebe74df339fcb
Please reload this pagehttps://github.com/angular/angular/pull/35136
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
February 4, 2020 18:48https://github.com/angular/angular/pull/35136#event-3007280675
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Feb 4, 2020https://github.com/angular/angular/pull/35136#issuecomment-582060962
@karahttps://github.com/kara
Please reload this pagehttps://github.com/angular/angular/pull/35136
AndrewKushnirhttps://github.com/AndrewKushnir
February 4, 2020 14:20https://github.com/angular/angular/pull/35136#commits-pushed-19daea3
https://github.com/AndrewKushnir
fix(ivy): set namespace for host elements of dynamically created comp…https://github.com/angular/angular/pull/35136/commits/19daea36bc0d0cc477ccdb0be6a79cab58955c1e
19daea3https://github.com/angular/angular/pull/35136/commits/19daea36bc0d0cc477ccdb0be6a79cab58955c1e
https://github.com/AndrewKushnir
fixup! fix(ivy): set namespace for host elements of dynamically creat…https://github.com/angular/angular/pull/35136/commits/9f5d9d4ba857d93cf3f5eb29c53bba767b187506
9f5d9d4https://github.com/angular/angular/pull/35136/commits/9f5d9d4ba857d93cf3f5eb29c53bba767b187506
https://github.com/AndrewKushnir
fixup! fix(ivy): set namespace for host elements of dynamically creat…https://github.com/angular/angular/pull/35136/commits/b132e5db3714aaf2fc31ed09433fb5e23bedd170
b132e5dhttps://github.com/angular/angular/pull/35136/commits/b132e5db3714aaf2fc31ed09433fb5e23bedd170
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
force-pushedhttps://github.com/angular/angular/compare/12b83e1c1d57f572933aeaa6a9202fddac9c706e..b132e5db3714aaf2fc31ed09433fb5e23bedd170
12b83e1https://github.com/angular/angular/commit/12b83e1c1d57f572933aeaa6a9202fddac9c706e
b132e5dhttps://github.com/angular/angular/commit/b132e5db3714aaf2fc31ed09433fb5e23bedd170
Compare https://github.com/angular/angular/compare/12b83e1c1d57f572933aeaa6a9202fddac9c706e..b132e5db3714aaf2fc31ed09433fb5e23bedd170
February 4, 2020 22:22https://github.com/angular/angular/pull/35136#event-3007931403
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Feb 4, 2020https://github.com/angular/angular/pull/35136#issuecomment-582148536
Presubmithttp://test/OCL:293230250:BASE:293230328:1580855448390:6775e8fd
Please reload this pagehttps://github.com/angular/angular/pull/35136
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Feb 4, 2020https://github.com/angular/angular/pull/35136#event-3007959616
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Feb 5, 2020 https://github.com/angular/angular/pull/35136#ref-pullrequest-540009445
fix(ivy): add attributes and classes to host elements based on selector #34481 https://github.com/angular/angular/pull/34481
https://github.com/kara
karahttps://github.com/kara
Feb 8, 2020 https://github.com/angular/angular/pull/35136#pullrequestreview-355517479
View reviewed changes https://github.com/angular/angular/pull/35136/files/b132e5db3714aaf2fc31ed09433fb5e23bedd170
karahttps://github.com/kara
https://github.com/angular/angular/pull/35136#pullrequestreview-355517479
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/35136
packages/platform-browser/src/dom/dom_renderer.tshttps://github.com/angular/angular/pull/35136/files/b132e5db3714aaf2fc31ed09433fb5e23bedd170#diff-0947a499c3c9edb99e4a89bb12a231a5ffae06b51464e0e52e4c025a76e6fcd6
karahttps://github.com/kara
Feb 8, 2020https://github.com/angular/angular/pull/35136#discussion_r376673949
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/35136
https://github.com/kara
karahttps://github.com/kara
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Feb 8, 2020https://github.com/angular/angular/pull/35136#event-3019570327
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Feb 8, 2020https://github.com/angular/angular/pull/35136#event-3019571585
https://github.com/kara
karahttps://github.com/kara
ae0253fhttps://github.com/angular/angular/commit/ae0253f34adad0e37d2a5e6596a08aa049ba3072
Feb 8, 2020https://github.com/angular/angular/pull/35136#event-3019572987
karahttps://github.com/kara
Feb 8, 2020 https://github.com/angular/angular/pull/35136#ref-commit-480a4c3
https://github.com/AndrewKushnir
https://github.com/kara
fix(ivy): set namespace for host elements of dynamically created comp…https://github.com/angular/angular/commit/480a4c30614c419e625e9728ae8ef339f6bf95ec
480a4c3https://github.com/angular/angular/commit/480a4c30614c419e625e9728ae8ef339f6bf95ec
#35136https://github.com/angular/angular/pull/35136
#35136https://github.com/angular/angular/pull/35136
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Mar 10, 2020https://github.com/angular/angular/pull/35136#issuecomment-597171606
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/35136
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Mar 10, 2020https://github.com/angular/angular/pull/35136#event-3115406090
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35136
https://github.com/kara
kara https://github.com/kara
https://github.com/angular/angular/pull/35136/files/b132e5db3714aaf2fc31ed09433fb5e23bedd170
Please reload this pagehttps://github.com/angular/angular/pull/35136
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
[RC5 IVY] Nested SVG doesn't work anymore https://github.com/angular/angular/issues/34256
Please reload this pagehttps://github.com/angular/angular/pull/35136
https://github.com/AndrewKushnir
https://github.com/kara
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.