René's URL Explorer Experiment


Title: fix(ngcc): switch ngcc over to use the `TraitCompiler` by JoostK · Pull Request #34889 · angular/angular · GitHub

Open Graph Title: fix(ngcc): switch ngcc over to use the `TraitCompiler` by JoostK · Pull Request #34889 · angular/angular

X Title: fix(ngcc): switch ngcc over to use the `TraitCompiler` by JoostK · Pull Request #34889 · angular/angular

Description: fix(ngcc): do not attempt compilation when analysis fails In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this model, any errors in one phase transition the trait into an error state, which prevents it from being ran through subsequent phases. The ngcc compiler on the other hand did not adopt this strict error model, which would cause incomplete metadata—due to errors in earlier phases—to be offered for compilation that could result in a hard crash. This commit updates ngcc to take advantage of ngtsc's TraitCompiler, that internally manages all Ivy classes that are part of the compilation. This effectively replaces ngcc's own AnalyzedFile and AnalyzedClass types, together with all of the logic to drive the DecoratorHandlers. All of this is now handled in the TraitCompiler, benefiting from its explicit state transitions of Traits so that the ngcc crash is a thing of the past. Fixes #34500 Resolves FW-1788

Open Graph Description: fix(ngcc): do not attempt compilation when analysis fails In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this mo...

X Description: fix(ngcc): do not attempt compilation when analysis fails In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this mo...

Opengraph URL: https://github.com/angular/angular/pull/34889

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:344d1954-b56e-3eef-6220-bcc3bc2fa6e1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA950:DB09F:1A1AA10:214C39B:6B015205
html-safe-nonced85e4d3f34bb2185c943786b3cd1b7a3051304af6d5521cecb0e37f81a80952e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTUwOkRCMDlGOjFBMUFBMTA6MjE0QzM5Qjo2QjAxNTIwNSIsInZpc2l0b3JfaWQiOiI1NDY5NjQzNTI5MDE1ODc0MDUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8047cd6af0fafea3d527dd1494f9790159e78dc84572ff49e0d3f36557c241dd
hovercard-subject-tagpull_request:365573448
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/34889/files
twitter:imagehttps://avatars.githubusercontent.com/u/123679?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/123679?s=400&v=4
og:image:altfix(ngcc): do not attempt compilation when analysis fails In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this mo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/34889/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34889%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34889%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34889/files
Reloadhttps://github.com/angular/angular/pull/34889/files
Reloadhttps://github.com/angular/angular/pull/34889/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JoostKhttps://github.com/JoostK
angular:masterhttps://github.com/angular/angular/tree/master
JoostK:ngcc-with-trait-compilerhttps://github.com/JoostK/angular/tree/ngcc-with-trait-compiler
Conversation 27 https://github.com/angular/angular/pull/34889
Commits 3 https://github.com/angular/angular/pull/34889/commits
Checks 0 https://github.com/angular/angular/pull/34889/checks
Files changed https://github.com/angular/angular/pull/34889/files
Please reload this pagehttps://github.com/angular/angular/pull/34889/files
fix(ngcc): switch ngcc over to use the TraitCompiler https://github.com/angular/angular/pull/34889/files#top
Show all changes 3 commits https://github.com/angular/angular/pull/34889/files
461397c test(ngcc): remove usage of ES2015 syntax in ES5/UMD/CommonJS tests JoostK Jan 18, 2020 https://github.com/angular/angular/pull/34889/commits/461397c9e08dd102f9859b2a3dc2e0e25d9d993e
d92b167 fix(ngcc): do not attempt compilation when analysis fails JoostK Jan 6, 2020 https://github.com/angular/angular/pull/34889/commits/d92b1673ad9d9bba0400aeb27fd7ab0cce0c4ff8
daa2f30 fixup! fix(ngcc): do not attempt compilation when analysis fails JoostK Jan 23, 2020 https://github.com/angular/angular/pull/34889/commits/daa2f30f64e3ac26d141c5b167f76aff65962f2d
Clear filters https://github.com/angular/angular/pull/34889/files
Please reload this pagehttps://github.com/angular/angular/pull/34889/files
Please reload this pagehttps://github.com/angular/angular/pull/34889/files
decoration_analyzer.ts https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
migration_host.ts https://github.com/angular/angular/pull/34889/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc
ngcc_trait_compiler.ts https://github.com/angular/angular/pull/34889/files#diff-5fc3f7f9d1ae4e6c290e5b74b9dabaa3110d8d4624f2ce6be6c83c255d6baa9e
types.ts https://github.com/angular/angular/pull/34889/files#diff-bde13171e54be2831f17f02cf579180847a01a88ca5fd64ed5f13f67b06ba6f3
util.ts https://github.com/angular/angular/pull/34889/files#diff-fb7c3d99903c107de38c7279e8ebc8e509ce181fedffb2920a19b6155ab6521d
migration.ts https://github.com/angular/angular/pull/34889/files#diff-d2ff50c2c79466e2cf3b278f8606354016278ae1cfbac4315007355c6605be30
dts_renderer.ts https://github.com/angular/angular/pull/34889/files#diff-bf6dc45866aaaf4b7caddd8cb6c98d742f3cb480ff80ecf354c149a7ad51ec9a
renderer.ts https://github.com/angular/angular/pull/34889/files#diff-722bf18677f8fe787cdd375de1f33493d424aa2c400d7ed8f07356dfddad2c7f
decoration_analyzer_spec.ts https://github.com/angular/angular/pull/34889/files#diff-e8650a61025a99f4301da5b57cf1f46c788e761f40b54be2a8f0462addff4177
migration_host_spec.ts https://github.com/angular/angular/pull/34889/files#diff-ca4f1324dea02a65f9793d9ef0c0fe64ea20ab089a8c428f899ca7244e1c194b
ngcc_trait_compiler_spec.ts https://github.com/angular/angular/pull/34889/files#diff-7fab41628150e101de783270453ec3221b0df347ee70a84571f7ef28d81ea553
commonjs_rendering_formatter_spec.ts https://github.com/angular/angular/pull/34889/files#diff-2ceff9c84e6c94d41403567d69981875cc771b138c8d9f9ef185c7bc03e24e57
esm5_rendering_formatter_spec.ts https://github.com/angular/angular/pull/34889/files#diff-8ff836bc6f3de0d1a50c5b56d7475691f06603629e2e37f0305ce905d3b3ce9c
umd_rendering_formatter_spec.ts https://github.com/angular/angular/pull/34889/files#diff-f314ca24a8682553ae5f18fa3ffad03f482fd8757f52c3c4b8dcc0560039862e
component.ts https://github.com/angular/angular/pull/34889/files#diff-f2bb60ef38f35f7d41b0ac0868cc4267738c5e4c78e044336aec52d86a6e2d29
directive.ts https://github.com/angular/angular/pull/34889/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400
injectable.ts https://github.com/angular/angular/pull/34889/files#diff-ff6958d9fff47e0156915cac8202d78930adcf33d353c70e60b230981cc36f20
ng_module.ts https://github.com/angular/angular/pull/34889/files#diff-8b9c0d2955b2182ee8ebd745a4f737de1207244d83ef08bdc00f9c8d9139c2a8
pipe.ts https://github.com/angular/angular/pull/34889/files#diff-cca09745361bb2d9844269a54bb34dfc82c87e86ceac4f72ffe7b740634b2437
code.ts https://github.com/angular/angular/pull/34889/files#diff-45cb08a4c5971f12609933b6cc1dd4ae36b9cb51ab2d24082aacae929459e25f
index.ts https://github.com/angular/angular/pull/34889/files#diff-232ceaacaefb9dfc22e2b67b87ab2c309dc66611491115ea9ff753d4ed35d200
api.ts https://github.com/angular/angular/pull/34889/files#diff-4cc36228b60775f1cea63e113140ddb244fa5e45cb35389deda942a7a5ee47d8
compilation.ts https://github.com/angular/angular/pull/34889/files#diff-5b07d44c0481be82108af4ee3fe5cae1f2f1bf98c657f266512b77b1c2dfef1b
packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.tshttps://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
View file https://github.com/JoostK/angular/blob/daa2f30f64e3ac26d141c5b167f76aff65962f2d/packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34889/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
Please reload this pagehttps://github.com/angular/angular/pull/34889/files
packages/compiler-cli/ngcc/src/analysis/migration_host.tshttps://github.com/angular/angular/pull/34889/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc
View file https://github.com/JoostK/angular/blob/daa2f30f64e3ac26d141c5b167f76aff65962f2d/packages/compiler-cli/ngcc/src/analysis/migration_host.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34889/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34889/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc
https://github.com/angular/angular/pull/34889/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc
Please reload this pagehttps://github.com/angular/angular/pull/34889/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.