| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:344d1954-b56e-3eef-6220-bcc3bc2fa6e1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A950:DB09F:1A1AA10:214C39B:6B015205 |
| html-safe-nonce | d85e4d3f34bb2185c943786b3cd1b7a3051304af6d5521cecb0e37f81a80952e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTUwOkRCMDlGOjFBMUFBMTA6MjE0QzM5Qjo2QjAxNTIwNSIsInZpc2l0b3JfaWQiOiI1NDY5NjQzNTI5MDE1ODc0MDUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 8047cd6af0fafea3d527dd1494f9790159e78dc84572ff49e0d3f36557c241dd |
| hovercard-subject-tag | pull_request:365573448 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/34889/files |
| twitter:image | https://avatars.githubusercontent.com/u/123679?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/123679?s=400&v=4 |
| og:image:alt | fix(ngcc): do not attempt compilation when analysis fails
In #34288, ngtsc was refactored to separate the result of the analysis
and resolve phase for more granular incremental rebuilds. In this mo... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/34889/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34889%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34889%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/34889/files |
| Reload | https://github.com/angular/angular/pull/34889/files |
| Reload | https://github.com/angular/angular/pull/34889/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| JoostK | https://github.com/JoostK |
| angular:master | https://github.com/angular/angular/tree/master |
| JoostK:ngcc-with-trait-compiler | https://github.com/JoostK/angular/tree/ngcc-with-trait-compiler |
|
Conversation
27
| https://github.com/angular/angular/pull/34889 |
|
Commits
3
| https://github.com/angular/angular/pull/34889/commits |
|
Checks
0
| https://github.com/angular/angular/pull/34889/checks |
|
Files changed
| https://github.com/angular/angular/pull/34889/files |
| Please reload this page | https://github.com/angular/angular/pull/34889/files |
|
fix(ngcc): switch ngcc over to use the TraitCompiler
| https://github.com/angular/angular/pull/34889/files#top |
|
Show all changes
3 commits
| https://github.com/angular/angular/pull/34889/files |
|
461397c
test(ngcc): remove usage of ES2015 syntax in ES5/UMD/CommonJS tests
JoostK Jan 18, 2020
| https://github.com/angular/angular/pull/34889/commits/461397c9e08dd102f9859b2a3dc2e0e25d9d993e |
|
d92b167
fix(ngcc): do not attempt compilation when analysis fails
JoostK Jan 6, 2020
| https://github.com/angular/angular/pull/34889/commits/d92b1673ad9d9bba0400aeb27fd7ab0cce0c4ff8 |
|
daa2f30
fixup! fix(ngcc): do not attempt compilation when analysis fails
JoostK Jan 23, 2020
| https://github.com/angular/angular/pull/34889/commits/daa2f30f64e3ac26d141c5b167f76aff65962f2d |
|
Clear filters
| https://github.com/angular/angular/pull/34889/files |
| Please reload this page | https://github.com/angular/angular/pull/34889/files |
| Please reload this page | https://github.com/angular/angular/pull/34889/files |
|
decoration_analyzer.ts
| https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
migration_host.ts
| https://github.com/angular/angular/pull/34889/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc |
|
ngcc_trait_compiler.ts
| https://github.com/angular/angular/pull/34889/files#diff-5fc3f7f9d1ae4e6c290e5b74b9dabaa3110d8d4624f2ce6be6c83c255d6baa9e |
|
types.ts
| https://github.com/angular/angular/pull/34889/files#diff-bde13171e54be2831f17f02cf579180847a01a88ca5fd64ed5f13f67b06ba6f3 |
|
util.ts
| https://github.com/angular/angular/pull/34889/files#diff-fb7c3d99903c107de38c7279e8ebc8e509ce181fedffb2920a19b6155ab6521d |
|
migration.ts
| https://github.com/angular/angular/pull/34889/files#diff-d2ff50c2c79466e2cf3b278f8606354016278ae1cfbac4315007355c6605be30 |
|
dts_renderer.ts
| https://github.com/angular/angular/pull/34889/files#diff-bf6dc45866aaaf4b7caddd8cb6c98d742f3cb480ff80ecf354c149a7ad51ec9a |
|
renderer.ts
| https://github.com/angular/angular/pull/34889/files#diff-722bf18677f8fe787cdd375de1f33493d424aa2c400d7ed8f07356dfddad2c7f |
|
decoration_analyzer_spec.ts
| https://github.com/angular/angular/pull/34889/files#diff-e8650a61025a99f4301da5b57cf1f46c788e761f40b54be2a8f0462addff4177 |
|
migration_host_spec.ts
| https://github.com/angular/angular/pull/34889/files#diff-ca4f1324dea02a65f9793d9ef0c0fe64ea20ab089a8c428f899ca7244e1c194b |
|
ngcc_trait_compiler_spec.ts
| https://github.com/angular/angular/pull/34889/files#diff-7fab41628150e101de783270453ec3221b0df347ee70a84571f7ef28d81ea553 |
|
commonjs_rendering_formatter_spec.ts
| https://github.com/angular/angular/pull/34889/files#diff-2ceff9c84e6c94d41403567d69981875cc771b138c8d9f9ef185c7bc03e24e57 |
|
esm5_rendering_formatter_spec.ts
| https://github.com/angular/angular/pull/34889/files#diff-8ff836bc6f3de0d1a50c5b56d7475691f06603629e2e37f0305ce905d3b3ce9c |
|
umd_rendering_formatter_spec.ts
| https://github.com/angular/angular/pull/34889/files#diff-f314ca24a8682553ae5f18fa3ffad03f482fd8757f52c3c4b8dcc0560039862e |
|
component.ts
| https://github.com/angular/angular/pull/34889/files#diff-f2bb60ef38f35f7d41b0ac0868cc4267738c5e4c78e044336aec52d86a6e2d29 |
|
directive.ts
| https://github.com/angular/angular/pull/34889/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400 |
|
injectable.ts
| https://github.com/angular/angular/pull/34889/files#diff-ff6958d9fff47e0156915cac8202d78930adcf33d353c70e60b230981cc36f20 |
|
ng_module.ts
| https://github.com/angular/angular/pull/34889/files#diff-8b9c0d2955b2182ee8ebd745a4f737de1207244d83ef08bdc00f9c8d9139c2a8 |
|
pipe.ts
| https://github.com/angular/angular/pull/34889/files#diff-cca09745361bb2d9844269a54bb34dfc82c87e86ceac4f72ffe7b740634b2437 |
|
code.ts
| https://github.com/angular/angular/pull/34889/files#diff-45cb08a4c5971f12609933b6cc1dd4ae36b9cb51ab2d24082aacae929459e25f |
|
index.ts
| https://github.com/angular/angular/pull/34889/files#diff-232ceaacaefb9dfc22e2b67b87ab2c309dc66611491115ea9ff753d4ed35d200 |
|
api.ts
| https://github.com/angular/angular/pull/34889/files#diff-4cc36228b60775f1cea63e113140ddb244fa5e45cb35389deda942a7a5ee47d8 |
|
compilation.ts
| https://github.com/angular/angular/pull/34889/files#diff-5b07d44c0481be82108af4ee3fe5cae1f2f1bf98c657f266512b77b1c2dfef1b |
| packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.ts | https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
View file
| https://github.com/JoostK/angular/blob/daa2f30f64e3ac26d141c5b167f76aff65962f2d/packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/34889/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
| https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
| https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
| https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
| https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
| https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
| https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
| Please reload this page | https://github.com/angular/angular/pull/34889/files |
| packages/compiler-cli/ngcc/src/analysis/migration_host.ts | https://github.com/angular/angular/pull/34889/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc |
|
View file
| https://github.com/JoostK/angular/blob/daa2f30f64e3ac26d141c5b167f76aff65962f2d/packages/compiler-cli/ngcc/src/analysis/migration_host.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/34889/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/34889/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc |
|
| https://github.com/angular/angular/pull/34889/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc |
| Please reload this page | https://github.com/angular/angular/pull/34889/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |