René's URL Explorer Experiment


Title: fix(ngcc): switch ngcc over to use the `TraitCompiler` by JoostK · Pull Request #34889 · angular/angular · GitHub

Open Graph Title: fix(ngcc): switch ngcc over to use the `TraitCompiler` by JoostK · Pull Request #34889 · angular/angular

X Title: fix(ngcc): switch ngcc over to use the `TraitCompiler` by JoostK · Pull Request #34889 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: fix(ngcc): do not attempt compilation when analysis fails In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this mo...

X Description: fix(ngcc): do not attempt compilation when analysis fails In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this mo...

Opengraph URL: https://github.com/angular/angular/pull/34889

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d066a662-9813-eb80-2d14-d0ee37a51134
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB180:21AC3F:15C2C67:1BA0C51:6B0119D2
html-safe-nonce8b362d7ef9c0fc10f059e90ed419e69b180b0e9f0796f85465051fdf478717a9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTgwOjIxQUMzRjoxNUMyQzY3OjFCQTBDNTE6NkIwMTE5RDIiLCJ2aXNpdG9yX2lkIjoiMTYwNTU2NjgwNDA1NzQ2MzI1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4a4cd4983f0c4ae8b95b010c6e347c395cd55d879061860e082ab8faa36bbf7a
hovercard-subject-tagpull_request:365573448
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34889/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/584654f944c9569077073dff1795f7f2c146fd45b0322b3dd855ed39b85d9d50/angular/angular/pull/34889
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/584654f944c9569077073dff1795f7f2c146fd45b0322b3dd855ed39b85d9d50/angular/angular/pull/34889
og:image:altfix(ngcc): do not attempt compilation when analysis fails In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this mo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJoostK
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/34889#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34889
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34889
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34889
Reloadhttps://github.com/angular/angular/pull/34889
Reloadhttps://github.com/angular/angular/pull/34889
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
JoostKhttps://github.com/JoostK
angular:masterhttps://github.com/angular/angular/tree/master
JoostK:ngcc-with-trait-compilerhttps://github.com/JoostK/angular/tree/ngcc-with-trait-compiler
Conversationhttps://github.com/angular/angular/pull/34889
Commits3 (3)https://github.com/angular/angular/pull/34889/commits
Checkshttps://github.com/angular/angular/pull/34889/checks
Files changedhttps://github.com/angular/angular/pull/34889/files
fix(ngcc): switch ngcc over to use the TraitCompilerhttps://github.com/angular/angular/pull/34889#top
JoostKhttps://github.com/JoostK
angular:masterhttps://github.com/angular/angular/tree/master
JoostK:ngcc-with-trait-compilerhttps://github.com/JoostK/angular/tree/ngcc-with-trait-compiler
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Jan 21, 2020https://github.com/angular/angular/pull/34889#issue-553200410
#34288https://github.com/angular/angular/pull/34288
#34500https://github.com/angular/angular/issues/34500
Please reload this pagehttps://github.com/angular/angular/pull/34889
https://github.com/JoostK
JoostKhttps://github.com/JoostK
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
severity3: broken https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
risk: medium https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22risk%3A%20medium%22
Jan 21, 2020https://github.com/angular/angular/pull/34889#event-2968121250
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Jan 21, 2020https://github.com/angular/angular/pull/34889#event-2968121347
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jan 21, 2020https://github.com/angular/angular/pull/34889#event-2968121486
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Jan 21, 2020https://github.com/angular/angular/pull/34889#issuecomment-576931839
#34652https://github.com/angular/angular/pull/34652
Please reload this pagehttps://github.com/angular/angular/pull/34889
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Jan 22, 2020 https://github.com/angular/angular/pull/34889#pullrequestreview-346971031
View reviewed changes https://github.com/angular/angular/pull/34889/files
https://github.com/JoostK
JoostKhttps://github.com/JoostK
January 23, 2020 06:26https://github.com/angular/angular/pull/34889#event-2972588151
https://github.com/JoostK
JoostKhttps://github.com/JoostK
petebacondarwinhttps://github.com/petebacondarwin
January 23, 2020 06:26https://github.com/angular/angular/pull/34889#event-2972588167
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jan 23, 2020 https://github.com/angular/angular/pull/34889#pullrequestreview-347107514
View reviewed changes https://github.com/angular/angular/pull/34889/files
petebacondarwinhttps://github.com/petebacondarwin
https://github.com/angular/angular/pull/34889#pullrequestreview-347107514
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34889
packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.tshttps://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
Please reload this pagehttps://github.com/angular/angular/pull/34889
packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.tshttps://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
Please reload this pagehttps://github.com/angular/angular/pull/34889
packages/compiler-cli/ngcc/src/analysis/ngcc_trait_compiler.tshttps://github.com/angular/angular/pull/34889/files#diff-5fc3f7f9d1ae4e6c290e5b74b9dabaa3110d8d4624f2ce6be6c83c255d6baa9e
Please reload this pagehttps://github.com/angular/angular/pull/34889
packages/compiler-cli/ngcc/src/rendering/dts_renderer.tshttps://github.com/angular/angular/pull/34889/files#diff-bf6dc45866aaaf4b7caddd8cb6c98d742f3cb480ff80ecf354c149a7ad51ec9a
Please reload this pagehttps://github.com/angular/angular/pull/34889
packages/compiler-cli/ngcc/test/analysis/decoration_analyzer_spec.tshttps://github.com/angular/angular/pull/34889/files#diff-e8650a61025a99f4301da5b57cf1f46c788e761f40b54be2a8f0462addff4177
Please reload this pagehttps://github.com/angular/angular/pull/34889
packages/compiler-cli/ngcc/test/analysis/migration_host_spec.tshttps://github.com/angular/angular/pull/34889/files#diff-ca4f1324dea02a65f9793d9ef0c0fe64ea20ab089a8c428f899ca7244e1c194b
petebacondarwinhttps://github.com/petebacondarwin
Jan 23, 2020https://github.com/angular/angular/pull/34889#discussion_r369987915
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34889
JoostKhttps://github.com/JoostK
Jan 23, 2020https://github.com/angular/angular/pull/34889#discussion_r370290378
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34889
packages/compiler-cli/src/ngtsc/transform/src/api.tshttps://github.com/angular/angular/pull/34889/files#diff-4cc36228b60775f1cea63e113140ddb244fa5e45cb35389deda942a7a5ee47d8
Please reload this pagehttps://github.com/angular/angular/pull/34889
packages/compiler-cli/src/ngtsc/transform/src/compilation.tshttps://github.com/angular/angular/pull/34889/files#diff-5b07d44c0481be82108af4ee3fe5cae1f2f1bf98c657f266512b77b1c2dfef1b
Please reload this pagehttps://github.com/angular/angular/pull/34889
packages/compiler-cli/src/ngtsc/transform/src/compilation.tshttps://github.com/angular/angular/pull/34889/files#diff-5b07d44c0481be82108af4ee3fe5cae1f2f1bf98c657f266512b77b1c2dfef1b
Please reload this pagehttps://github.com/angular/angular/pull/34889
packages/compiler-cli/src/ngtsc/transform/src/compilation.tshttps://github.com/angular/angular/pull/34889/files#diff-5b07d44c0481be82108af4ee3fe5cae1f2f1bf98c657f266512b77b1c2dfef1b
Please reload this pagehttps://github.com/angular/angular/pull/34889
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Jan 23, 2020 https://github.com/angular/angular/pull/34889#ref-pullrequest-545967616
fix(ngcc): do not attempt compilation when analysis fails #34652 https://github.com/angular/angular/pull/34652
JoostKhttps://github.com/JoostK
January 23, 2020 19:35https://github.com/angular/angular/pull/34889#commits-pushed-461397c
https://github.com/JoostK
test(ngcc): remove usage of ES2015 syntax in ES5/UMD/CommonJS testshttps://github.com/angular/angular/pull/34889/commits/461397c9e08dd102f9859b2a3dc2e0e25d9d993e
461397chttps://github.com/angular/angular/pull/34889/commits/461397c9e08dd102f9859b2a3dc2e0e25d9d993e
https://github.com/JoostK
fix(ngcc): do not attempt compilation when analysis failshttps://github.com/angular/angular/pull/34889/commits/d92b1673ad9d9bba0400aeb27fd7ab0cce0c4ff8
d92b167https://github.com/angular/angular/pull/34889/commits/d92b1673ad9d9bba0400aeb27fd7ab0cce0c4ff8
angular#34288https://github.com/angular/angular/pull/34288
angular#34500https://github.com/angular/angular/issues/34500
https://github.com/JoostK
fixup! fix(ngcc): do not attempt compilation when analysis failshttps://github.com/angular/angular/pull/34889/commits/daa2f30f64e3ac26d141c5b167f76aff65962f2d
daa2f30https://github.com/angular/angular/pull/34889/commits/daa2f30f64e3ac26d141c5b167f76aff65962f2d
https://github.com/JoostK
JoostKhttps://github.com/JoostK
force-pushedhttps://github.com/angular/angular/compare/63425005c285256fe6d1d389f8e04258f8ac6322..daa2f30f64e3ac26d141c5b167f76aff65962f2d
6342500https://github.com/angular/angular/commit/63425005c285256fe6d1d389f8e04258f8ac6322
daa2f30https://github.com/angular/angular/commit/daa2f30f64e3ac26d141c5b167f76aff65962f2d
Compare https://github.com/angular/angular/compare/63425005c285256fe6d1d389f8e04258f8ac6322..daa2f30f64e3ac26d141c5b167f76aff65962f2d
January 23, 2020 18:35https://github.com/angular/angular/pull/34889#event-2974813446
JoostKhttps://github.com/JoostK
Jan 23, 2020 https://github.com/angular/angular/pull/34889#ref-commit-6771c94
https://github.com/JoostK
previewhttps://github.com/JoostK/ngcc-validation/commit/6771c940ef0c29196c8a9587ab05fb27d8563041
angular/angular#34889https://github.com/angular/angular/pull/34889
6771c94https://github.com/JoostK/ngcc-validation/commit/6771c940ef0c29196c8a9587ab05fb27d8563041
JoostKhttps://github.com/JoostK
Jan 23, 2020 https://github.com/angular/angular/pull/34889#ref-commit-4e71f7e
https://github.com/JoostK
previewhttps://github.com/JoostK/ngcc-validation/commit/4e71f7eb2fcd7ce4574dc67d990ceb81710f46c3
angular/angular#34889https://github.com/angular/angular/pull/34889
4e71f7ehttps://github.com/JoostK/ngcc-validation/commit/4e71f7eb2fcd7ce4574dc67d990ceb81710f46c3
JoostKhttps://github.com/JoostK
Jan 23, 2020 https://github.com/angular/angular/pull/34889#ref-commit-6a365fb
https://github.com/JoostK
previewhttps://github.com/JoostK/ngcc-validation/commit/6a365fb26759e43ca31649438f2ee1cb78f423cc
angular/angular#34889https://github.com/angular/angular/pull/34889
6a365fbhttps://github.com/JoostK/ngcc-validation/commit/6a365fb26759e43ca31649438f2ee1cb78f423cc
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Jan 23, 2020https://github.com/angular/angular/pull/34889#issuecomment-577857933
angular/ngcc-validation#792https://github.com/angular/ngcc-validation/pull/792
@petebacondarwinhttps://github.com/petebacondarwin
Please reload this pagehttps://github.com/angular/angular/pull/34889
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jan 23, 2020 https://github.com/angular/angular/pull/34889#pullrequestreview-347625281
View reviewed changes https://github.com/angular/angular/pull/34889/files/daa2f30f64e3ac26d141c5b167f76aff65962f2d
petebacondarwinhttps://github.com/petebacondarwin
https://github.com/angular/angular/pull/34889#pullrequestreview-347625281
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34889
https://github.com/JoostK
JoostKhttps://github.com/JoostK
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Jan 23, 2020https://github.com/angular/angular/pull/34889#event-2975393482
https://github.com/JoostK
JoostKhttps://github.com/JoostK
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Jan 23, 2020https://github.com/angular/angular/pull/34889#event-2975394444
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Jan 23, 2020https://github.com/angular/angular/pull/34889#issuecomment-577892284
Please reload this pagehttps://github.com/angular/angular/pull/34889
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jan 23, 2020https://github.com/angular/angular/pull/34889#issuecomment-577893584
Presubmithttp://test/OCL:291236444:BASE:291236504:1579816192037:1b275da2
Please reload this pagehttps://github.com/angular/angular/pull/34889
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Jan 23, 2020https://github.com/angular/angular/pull/34889#event-2975551042
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
ba82532https://github.com/angular/angular/commit/ba82532812bb975d5c272959c974a4e3bfeea621
Jan 23, 2020https://github.com/angular/angular/pull/34889#event-2975553344
AndrewKushnirhttps://github.com/AndrewKushnir
Jan 23, 2020 https://github.com/angular/angular/pull/34889#ref-commit-7659f2e
https://github.com/JoostK
https://github.com/AndrewKushnir
fix(ngcc): do not attempt compilation when analysis fails (https://github.com/angular/angular/commit/7659f2e24b5caf6f4c28256b12d9a2187515ff8f
#34889https://github.com/angular/angular/pull/34889
)https://github.com/angular/angular/commit/7659f2e24b5caf6f4c28256b12d9a2187515ff8f
7659f2ehttps://github.com/angular/angular/commit/7659f2e24b5caf6f4c28256b12d9a2187515ff8f
#34288https://github.com/angular/angular/pull/34288
#34500https://github.com/angular/angular/issues/34500
#34889https://github.com/angular/angular/pull/34889
AndrewKushnirhttps://github.com/AndrewKushnir
Jan 23, 2020 https://github.com/angular/angular/pull/34889#ref-commit-8f5c920
https://github.com/JoostK
https://github.com/AndrewKushnir
test(ngcc): remove usage of ES2015 syntax in ES5/UMD/CommonJS tests (https://github.com/angular/angular/commit/8f5c920474ff6b3f12b9fe8146736bf541c641ac
#…https://github.com/angular/angular/pull/34889
8f5c920https://github.com/angular/angular/commit/8f5c920474ff6b3f12b9fe8146736bf541c641ac
…34889https://github.com/angular/angular/pull/34889
#34889https://github.com/angular/angular/pull/34889
AndrewKushnirhttps://github.com/AndrewKushnir
Jan 23, 2020 https://github.com/angular/angular/pull/34889#ref-commit-080a8bf
https://github.com/JoostK
https://github.com/AndrewKushnir
fix(ngcc): do not attempt compilation when analysis fails (https://github.com/angular/angular/commit/080a8bfd43f76c42c7f9242d1807b2c73914ea7c
#34889https://github.com/angular/angular/pull/34889
)https://github.com/angular/angular/commit/080a8bfd43f76c42c7f9242d1807b2c73914ea7c
080a8bfhttps://github.com/angular/angular/commit/080a8bfd43f76c42c7f9242d1807b2c73914ea7c
#34288https://github.com/angular/angular/pull/34288
#34500https://github.com/angular/angular/issues/34500
#34889https://github.com/angular/angular/pull/34889
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Feb 23, 2020https://github.com/angular/angular/pull/34889#issuecomment-590084898
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/34889
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Feb 23, 2020https://github.com/angular/angular/pull/34889#event-3063520272
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34889
https://github.com/alxhub
alxhub https://github.com/alxhub
https://github.com/angular/angular/pull/34889/files/63425005c285256fe6d1d389f8e04258f8ac6322
https://github.com/petebacondarwin
petebacondarwin https://github.com/petebacondarwin
https://github.com/angular/angular/pull/34889/files/daa2f30f64e3ac26d141c5b167f76aff65962f2d
Please reload this pagehttps://github.com/angular/angular/pull/34889
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
risk: medium https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22risk%3A%20medium%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
ngcc: packages that fail with errors causes a crash https://github.com/angular/angular/issues/34500
Please reload this pagehttps://github.com/angular/angular/pull/34889
https://github.com/JoostK
https://github.com/AndrewKushnir
https://github.com/petebacondarwin
https://github.com/alxhub
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.