| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d066a662-9813-eb80-2d14-d0ee37a51134 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B180:21AC3F:15C2C67:1BA0C51:6B0119D2 |
| html-safe-nonce | 8b362d7ef9c0fc10f059e90ed419e69b180b0e9f0796f85465051fdf478717a9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTgwOjIxQUMzRjoxNUMyQzY3OjFCQTBDNTE6NkIwMTE5RDIiLCJ2aXNpdG9yX2lkIjoiMTYwNTU2NjgwNDA1NzQ2MzI1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4a4cd4983f0c4ae8b95b010c6e347c395cd55d879061860e082ab8faa36bbf7a |
| hovercard-subject-tag | pull_request:365573448 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34889/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/584654f944c9569077073dff1795f7f2c146fd45b0322b3dd855ed39b85d9d50/angular/angular/pull/34889 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/584654f944c9569077073dff1795f7f2c146fd45b0322b3dd855ed39b85d9d50/angular/angular/pull/34889 |
| og:image:alt | fix(ngcc): do not attempt compilation when analysis fails
In #34288, ngtsc was refactored to separate the result of the analysis
and resolve phase for more granular incremental rebuilds. In this mo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JoostK |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/34889#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34889 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34889 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/34889 |
| Reload | https://github.com/angular/angular/pull/34889 |
| Reload | https://github.com/angular/angular/pull/34889 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| JoostK | https://github.com/JoostK |
| angular:master | https://github.com/angular/angular/tree/master |
| JoostK:ngcc-with-trait-compiler | https://github.com/JoostK/angular/tree/ngcc-with-trait-compiler |
| Conversation | https://github.com/angular/angular/pull/34889 |
| Commits3 (3) | https://github.com/angular/angular/pull/34889/commits |
| Checks | https://github.com/angular/angular/pull/34889/checks |
| Files changed | https://github.com/angular/angular/pull/34889/files |
| fix(ngcc): switch ngcc over to use the TraitCompiler | https://github.com/angular/angular/pull/34889#top |
| JoostK | https://github.com/JoostK |
| angular:master | https://github.com/angular/angular/tree/master |
| JoostK:ngcc-with-trait-compiler | https://github.com/JoostK/angular/tree/ngcc-with-trait-compiler |
|
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| Jan 21, 2020 | https://github.com/angular/angular/pull/34889#issue-553200410 |
| #34288 | https://github.com/angular/angular/pull/34288 |
| #34500 | https://github.com/angular/angular/issues/34500 |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
severity3: broken
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
risk: medium
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22risk%3A%20medium%22 |
| Jan 21, 2020 | https://github.com/angular/angular/pull/34889#event-2968121250 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Jan 21, 2020 | https://github.com/angular/angular/pull/34889#event-2968121347 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Jan 21, 2020 | https://github.com/angular/angular/pull/34889#event-2968121486 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| Jan 21, 2020 | https://github.com/angular/angular/pull/34889#issuecomment-576931839 |
| #34652 | https://github.com/angular/angular/pull/34652 |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
Jan 22, 2020
| https://github.com/angular/angular/pull/34889#pullrequestreview-346971031 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34889/files |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| January 23, 2020 06:26 | https://github.com/angular/angular/pull/34889#event-2972588151 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| petebacondarwin | https://github.com/petebacondarwin |
| January 23, 2020 06:26 | https://github.com/angular/angular/pull/34889#event-2972588167 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Jan 23, 2020
| https://github.com/angular/angular/pull/34889#pullrequestreview-347107514 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34889/files |
| petebacondarwin | https://github.com/petebacondarwin |
| https://github.com/angular/angular/pull/34889#pullrequestreview-347107514 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.ts | https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.ts | https://github.com/angular/angular/pull/34889/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| packages/compiler-cli/ngcc/src/analysis/ngcc_trait_compiler.ts | https://github.com/angular/angular/pull/34889/files#diff-5fc3f7f9d1ae4e6c290e5b74b9dabaa3110d8d4624f2ce6be6c83c255d6baa9e |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| packages/compiler-cli/ngcc/src/rendering/dts_renderer.ts | https://github.com/angular/angular/pull/34889/files#diff-bf6dc45866aaaf4b7caddd8cb6c98d742f3cb480ff80ecf354c149a7ad51ec9a |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| packages/compiler-cli/ngcc/test/analysis/decoration_analyzer_spec.ts | https://github.com/angular/angular/pull/34889/files#diff-e8650a61025a99f4301da5b57cf1f46c788e761f40b54be2a8f0462addff4177 |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| packages/compiler-cli/ngcc/test/analysis/migration_host_spec.ts | https://github.com/angular/angular/pull/34889/files#diff-ca4f1324dea02a65f9793d9ef0c0fe64ea20ab089a8c428f899ca7244e1c194b |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 23, 2020 | https://github.com/angular/angular/pull/34889#discussion_r369987915 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| JoostK | https://github.com/JoostK |
| Jan 23, 2020 | https://github.com/angular/angular/pull/34889#discussion_r370290378 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| packages/compiler-cli/src/ngtsc/transform/src/api.ts | https://github.com/angular/angular/pull/34889/files#diff-4cc36228b60775f1cea63e113140ddb244fa5e45cb35389deda942a7a5ee47d8 |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| packages/compiler-cli/src/ngtsc/transform/src/compilation.ts | https://github.com/angular/angular/pull/34889/files#diff-5b07d44c0481be82108af4ee3fe5cae1f2f1bf98c657f266512b77b1c2dfef1b |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| packages/compiler-cli/src/ngtsc/transform/src/compilation.ts | https://github.com/angular/angular/pull/34889/files#diff-5b07d44c0481be82108af4ee3fe5cae1f2f1bf98c657f266512b77b1c2dfef1b |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| packages/compiler-cli/src/ngtsc/transform/src/compilation.ts | https://github.com/angular/angular/pull/34889/files#diff-5b07d44c0481be82108af4ee3fe5cae1f2f1bf98c657f266512b77b1c2dfef1b |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Jan 23, 2020
| https://github.com/angular/angular/pull/34889#ref-pullrequest-545967616 |
|
fix(ngcc): do not attempt compilation when analysis fails
#34652
| https://github.com/angular/angular/pull/34652 |
| JoostK | https://github.com/JoostK |
| January 23, 2020 19:35 | https://github.com/angular/angular/pull/34889#commits-pushed-461397c |
|
| https://github.com/JoostK |
| test(ngcc): remove usage of ES2015 syntax in ES5/UMD/CommonJS tests | https://github.com/angular/angular/pull/34889/commits/461397c9e08dd102f9859b2a3dc2e0e25d9d993e |
| 461397c | https://github.com/angular/angular/pull/34889/commits/461397c9e08dd102f9859b2a3dc2e0e25d9d993e |
|
| https://github.com/JoostK |
| fix(ngcc): do not attempt compilation when analysis fails | https://github.com/angular/angular/pull/34889/commits/d92b1673ad9d9bba0400aeb27fd7ab0cce0c4ff8 |
| d92b167 | https://github.com/angular/angular/pull/34889/commits/d92b1673ad9d9bba0400aeb27fd7ab0cce0c4ff8 |
| angular#34288 | https://github.com/angular/angular/pull/34288 |
| angular#34500 | https://github.com/angular/angular/issues/34500 |
|
| https://github.com/JoostK |
| fixup! fix(ngcc): do not attempt compilation when analysis fails | https://github.com/angular/angular/pull/34889/commits/daa2f30f64e3ac26d141c5b167f76aff65962f2d |
| daa2f30 | https://github.com/angular/angular/pull/34889/commits/daa2f30f64e3ac26d141c5b167f76aff65962f2d |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| force-pushed | https://github.com/angular/angular/compare/63425005c285256fe6d1d389f8e04258f8ac6322..daa2f30f64e3ac26d141c5b167f76aff65962f2d |
| 6342500 | https://github.com/angular/angular/commit/63425005c285256fe6d1d389f8e04258f8ac6322 |
| daa2f30 | https://github.com/angular/angular/commit/daa2f30f64e3ac26d141c5b167f76aff65962f2d |
|
Compare
| https://github.com/angular/angular/compare/63425005c285256fe6d1d389f8e04258f8ac6322..daa2f30f64e3ac26d141c5b167f76aff65962f2d |
| January 23, 2020 18:35 | https://github.com/angular/angular/pull/34889#event-2974813446 |
| JoostK | https://github.com/JoostK |
|
Jan 23, 2020
| https://github.com/angular/angular/pull/34889#ref-commit-6771c94 |
|
| https://github.com/JoostK |
| preview | https://github.com/JoostK/ngcc-validation/commit/6771c940ef0c29196c8a9587ab05fb27d8563041 |
| angular/angular#34889 | https://github.com/angular/angular/pull/34889 |
| 6771c94 | https://github.com/JoostK/ngcc-validation/commit/6771c940ef0c29196c8a9587ab05fb27d8563041 |
| JoostK | https://github.com/JoostK |
|
Jan 23, 2020
| https://github.com/angular/angular/pull/34889#ref-commit-4e71f7e |
|
| https://github.com/JoostK |
| preview | https://github.com/JoostK/ngcc-validation/commit/4e71f7eb2fcd7ce4574dc67d990ceb81710f46c3 |
| angular/angular#34889 | https://github.com/angular/angular/pull/34889 |
| 4e71f7e | https://github.com/JoostK/ngcc-validation/commit/4e71f7eb2fcd7ce4574dc67d990ceb81710f46c3 |
| JoostK | https://github.com/JoostK |
|
Jan 23, 2020
| https://github.com/angular/angular/pull/34889#ref-commit-6a365fb |
|
| https://github.com/JoostK |
| preview | https://github.com/JoostK/ngcc-validation/commit/6a365fb26759e43ca31649438f2ee1cb78f423cc |
| angular/angular#34889 | https://github.com/angular/angular/pull/34889 |
| 6a365fb | https://github.com/JoostK/ngcc-validation/commit/6a365fb26759e43ca31649438f2ee1cb78f423cc |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| Jan 23, 2020 | https://github.com/angular/angular/pull/34889#issuecomment-577857933 |
| angular/ngcc-validation#792 | https://github.com/angular/ngcc-validation/pull/792 |
| @petebacondarwin | https://github.com/petebacondarwin |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Jan 23, 2020
| https://github.com/angular/angular/pull/34889#pullrequestreview-347625281 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34889/files/daa2f30f64e3ac26d141c5b167f76aff65962f2d |
| petebacondarwin | https://github.com/petebacondarwin |
| https://github.com/angular/angular/pull/34889#pullrequestreview-347625281 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Jan 23, 2020 | https://github.com/angular/angular/pull/34889#event-2975393482 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
| Jan 23, 2020 | https://github.com/angular/angular/pull/34889#event-2975394444 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| Jan 23, 2020 | https://github.com/angular/angular/pull/34889#issuecomment-577892284 |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Jan 23, 2020 | https://github.com/angular/angular/pull/34889#issuecomment-577893584 |
| Presubmit | http://test/OCL:291236444:BASE:291236504:1579816192037:1b275da2 |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
| Jan 23, 2020 | https://github.com/angular/angular/pull/34889#event-2975551042 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| ba82532 | https://github.com/angular/angular/commit/ba82532812bb975d5c272959c974a4e3bfeea621 |
| Jan 23, 2020 | https://github.com/angular/angular/pull/34889#event-2975553344 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Jan 23, 2020
| https://github.com/angular/angular/pull/34889#ref-commit-7659f2e |
|
| https://github.com/JoostK |
|
| https://github.com/AndrewKushnir |
| fix(ngcc): do not attempt compilation when analysis fails ( | https://github.com/angular/angular/commit/7659f2e24b5caf6f4c28256b12d9a2187515ff8f |
| #34889 | https://github.com/angular/angular/pull/34889 |
| ) | https://github.com/angular/angular/commit/7659f2e24b5caf6f4c28256b12d9a2187515ff8f |
| 7659f2e | https://github.com/angular/angular/commit/7659f2e24b5caf6f4c28256b12d9a2187515ff8f |
| #34288 | https://github.com/angular/angular/pull/34288 |
| #34500 | https://github.com/angular/angular/issues/34500 |
| #34889 | https://github.com/angular/angular/pull/34889 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Jan 23, 2020
| https://github.com/angular/angular/pull/34889#ref-commit-8f5c920 |
|
| https://github.com/JoostK |
|
| https://github.com/AndrewKushnir |
| test(ngcc): remove usage of ES2015 syntax in ES5/UMD/CommonJS tests ( | https://github.com/angular/angular/commit/8f5c920474ff6b3f12b9fe8146736bf541c641ac |
| #… | https://github.com/angular/angular/pull/34889 |
| 8f5c920 | https://github.com/angular/angular/commit/8f5c920474ff6b3f12b9fe8146736bf541c641ac |
| …34889 | https://github.com/angular/angular/pull/34889 |
| #34889 | https://github.com/angular/angular/pull/34889 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Jan 23, 2020
| https://github.com/angular/angular/pull/34889#ref-commit-080a8bf |
|
| https://github.com/JoostK |
|
| https://github.com/AndrewKushnir |
| fix(ngcc): do not attempt compilation when analysis fails ( | https://github.com/angular/angular/commit/080a8bfd43f76c42c7f9242d1807b2c73914ea7c |
| #34889 | https://github.com/angular/angular/pull/34889 |
| ) | https://github.com/angular/angular/commit/080a8bfd43f76c42c7f9242d1807b2c73914ea7c |
| 080a8bf | https://github.com/angular/angular/commit/080a8bfd43f76c42c7f9242d1807b2c73914ea7c |
| #34288 | https://github.com/angular/angular/pull/34288 |
| #34500 | https://github.com/angular/angular/issues/34500 |
| #34889 | https://github.com/angular/angular/pull/34889 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Feb 23, 2020 | https://github.com/angular/angular/pull/34889#issuecomment-590084898 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Feb 23, 2020 | https://github.com/angular/angular/pull/34889#event-3063520272 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34889 |
|
| https://github.com/alxhub |
|
alxhub
| https://github.com/alxhub |
|
| https://github.com/angular/angular/pull/34889/files/63425005c285256fe6d1d389f8e04258f8ac6322 |
|
| https://github.com/petebacondarwin |
|
petebacondarwin
| https://github.com/petebacondarwin |
|
| https://github.com/angular/angular/pull/34889/files/daa2f30f64e3ac26d141c5b167f76aff65962f2d |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
|
risk: medium
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22risk%3A%20medium%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
|
ngcc: packages that fail with errors causes a crash
| https://github.com/angular/angular/issues/34500 |
| Please reload this page | https://github.com/angular/angular/pull/34889 |
|
| https://github.com/JoostK |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/petebacondarwin |
|
| https://github.com/alxhub |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |