René's URL Explorer Experiment


Title: refactor(ivy): introduce the 'core' package and split apart NgtscProgram by alxhub · Pull Request #34887 · angular/angular · GitHub

Open Graph Title: refactor(ivy): introduce the 'core' package and split apart NgtscProgram by alxhub · Pull Request #34887 · angular/angular

X Title: refactor(ivy): introduce the 'core' package and split apart NgtscProgram by alxhub · Pull Request #34887 · angular/angular

Description: Previously, NgtscProgram lived in the main @angular/compiler-cli package alongside the legacy View Engine compiler. As a result, the main package depended on all of the ngtsc internal packages, and a significant portion of ngtsc logic lived in NgtscProgram. This commit refactors NgtscProgram and moves the main logic of compilation into a new 'core' package. The new package defines a new API which enables implementers of TypeScript compilers (compilers built using the TS API) to support Angular transpilation as well. It involves a new NgCompiler type which takes a ts.Program and performs Angular analysis and transformations, as well as an NgCompilerHost which wraps an input ts.CompilerHost and adds any extra Angular files. Together, these two classes are used to implement a new NgtscProgram which adapts the legacy api.Program interface used by the View Engine compiler onto operations on the new types. The new NgtscProgram implementation is significantly smaller and easier to reason about. The new NgCompilerHost replaces the previous GeneratedShimsHostWrapper which lived in the 'shims' package. A new 'resource' package is added to support the HostResourceLoader which previously lived in the outer compiler package. As a result of the refactoring, the dependencies of the outer @angular/compiler-cli package on ngtsc internal packages are significantly trimmed. This refactoring was driven by the desire to build a plugin interface to the compiler so that tsc_wrapped (another consumer of the TS compiler APIs) can perform Angular transpilation on user request.

Open Graph Description: Previously, NgtscProgram lived in the main @angular/compiler-cli package alongside the legacy View Engine compiler. As a result, the main package depended on all of the ngtsc internal packages, and...

X Description: Previously, NgtscProgram lived in the main @angular/compiler-cli package alongside the legacy View Engine compiler. As a result, the main package depended on all of the ngtsc internal packages, and...

Opengraph URL: https://github.com/angular/angular/pull/34887

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5c0c3aaf-af4f-537e-a9d1-cde3b93cc122
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB836:3E4205:1AE8CCE:23EF670:6B015FAC
html-safe-nonced5dbf19f22809a0d46ce5b92257da82dd84fa6b6c01f71e0934d6728f434459e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCODM2OjNFNDIwNToxQUU4Q0NFOjIzRUY2NzA6NkIwMTVGQUMiLCJ2aXNpdG9yX2lkIjoiNzA5NjA1MTM2MzcyOTIwMzExNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc9f4baa4c45cb83056ce34dc36ce1f9dd59d48db7128be6fd8fb99b246d9f4ee
hovercard-subject-tagpull_request:365567711
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/34887/files
twitter:imagehttps://avatars.githubusercontent.com/u/4175141?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4175141?s=400&v=4
og:image:altPreviously, NgtscProgram lived in the main @angular/compiler-cli package alongside the legacy View Engine compiler. As a result, the main package depended on all of the ngtsc internal packages, and...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/34887/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34887%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34887%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34887/files
Reloadhttps://github.com/angular/angular/pull/34887/files
Reloadhttps://github.com/angular/angular/pull/34887/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
alxhubhttps://github.com/alxhub
angular:masterhttps://github.com/angular/angular/tree/master
alxhub:ngtsc/core-refactorhttps://github.com/alxhub/angular/tree/ngtsc/core-refactor
Conversation 53 https://github.com/angular/angular/pull/34887
Commits 1 https://github.com/angular/angular/pull/34887/commits
Checks 0 https://github.com/angular/angular/pull/34887/checks
Files changed https://github.com/angular/angular/pull/34887/files
Please reload this pagehttps://github.com/angular/angular/pull/34887/files
refactor(ivy): introduce the 'core' package and split apart NgtscProgram https://github.com/angular/angular/pull/34887/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/34887/files
dd02363 refactor(ivy): introduce the 'core' package and split apart NgtscProgram alxhub Jan 18, 2020 https://github.com/angular/angular/pull/34887/commits/dd02363a17ff961d6a68b69745790f84eda4bac1
Clear filters https://github.com/angular/angular/pull/34887/files
Please reload this pagehttps://github.com/angular/angular/pull/34887/files
Please reload this pagehttps://github.com/angular/angular/pull/34887/files
BUILD.bazel https://github.com/angular/angular/pull/34887/files#diff-92a050ad91a15158adb65ab2bc5a2744eab7c6a9e60a60a3b2c44f01ba755e9e
component.ts https://github.com/angular/angular/pull/34887/files#diff-f2bb60ef38f35f7d41b0ac0868cc4267738c5e4c78e044336aec52d86a6e2d29
BUILD.bazel https://github.com/angular/angular/pull/34887/files#diff-03913a67a069b7bc225402fdd87f330a2f76c7bc27a7b2f0dcb81b6ea4d4a4be
README.md https://github.com/angular/angular/pull/34887/files#diff-e9debd6b1b37471ab951e4a307c236dbaf66366f1519be2e03cf96d2b4a73f0d
api.ts https://github.com/angular/angular/pull/34887/files#diff-87d0e01e4b3eccfc25ea0568b768ab98195655c9451e1857b973e3c566d8c4a6
index.ts https://github.com/angular/angular/pull/34887/files#diff-75e77dcdd1609c273ecf69d397c830a08d8a07dd570590c3df48dccbce9731ee
compiler.ts https://github.com/angular/angular/pull/34887/files#diff-f610248af7a32ea1af63f53a77acf0c7f71d890089d8dd88c189aa829c50c7cc
host.ts https://github.com/angular/angular/pull/34887/files#diff-f6c3c54f989894e8103284463fe492f2eccc9733e443065b8117c1567ec75173
BUILD.bazel https://github.com/angular/angular/pull/34887/files#diff-652c14ce3f948db9a5c3efd8a9ff74fd6e5e9ea10fe7edd4668a0058ff9b2cfd
compiler_test.ts https://github.com/angular/angular/pull/34887/files#diff-a9bf1361db0f634f065c876f12e73aab19bf48e50df9b22a5a4338cb22c3eb27
BUILD.bazel https://github.com/angular/angular/pull/34887/files#diff-0356084fedfbf869aad05d9243c24dc5e7084d27ebc71f3bc4539853e01ca0e1
README.md https://github.com/angular/angular/pull/34887/files#diff-1f4612bc1953492fc195de93e1d916a8ad4536544200979b76d1899b55c7e2f0
index.ts https://github.com/angular/angular/pull/34887/files#diff-a89199cc04d6292d42dea14fd590937ac1c3bdb17613d2727be4f28b50dfc42f
alias.ts https://github.com/angular/angular/pull/34887/files#diff-e31bdef0c760b2172713afc9982200d45b5da13eb6a1d39c611ee9f3a834d90e
emitter.ts https://github.com/angular/angular/pull/34887/files#diff-77fcf5bac7538e535664f90fd4f95465c6b303e79753a91e21841f09ca9de38f
index.ts https://github.com/angular/angular/pull/34887/files#diff-952513c5aafc076d3302f8851f715ac3c89233dd4d71bffcedcffcac73747d96
program.ts https://github.com/angular/angular/pull/34887/files#diff-93dbdc32d59a16281adf01949af174d5e2406a4666384825b3b0a35bb8e0893b
BUILD.bazel https://github.com/angular/angular/pull/34887/files#diff-f08011d089cefe6da6044b9e790376811f0ca6828e71c65aa47a744db826a198
index.ts https://github.com/angular/angular/pull/34887/files#diff-f4e811c141638e1b57bb9318b6cce989145e648585fd7c779063f34415e0a93f
loader.ts https://github.com/angular/angular/pull/34887/files#diff-6ecb1fedc528f20e9b8fa75e17654fcef785614ad8d8ec16291aa1d77e140c5c
BUILD.bazel https://github.com/angular/angular/pull/34887/files#diff-15ebee82f096319d95fa50bed4b75316b408f4918f8459c76e1287d309ecb423
dependency_spec.ts https://github.com/angular/angular/pull/34887/files#diff-d7b5cb0e6c4d61080f0414c2f4f04d38bfd252a7f40e2884077642b1f264ff23
index.ts https://github.com/angular/angular/pull/34887/files#diff-f483bb302de4473c8ee98ee210d88afda09ef2a621c7dc54a18ba700b4f99583
api.ts https://github.com/angular/angular/pull/34887/files#diff-3e219a1bdf6ae79264b570e630c50a822e817b707dc025f1141ea1ce95a1b576
factory_generator.ts https://github.com/angular/angular/pull/34887/files#diff-34942edfa80112677aad308d03a9e00cbcb5b7af41a505b806b9767245e64dbd
host.ts https://github.com/angular/angular/pull/34887/files#diff-d81b5df76a5d5dd92d0fe030424feb8923c7a932752fd1910c4abb83c746d927
summary_generator.ts https://github.com/angular/angular/pull/34887/files#diff-2eb5a3e8089076eba39ed1e6185206ae93eec186a3dc4ec099dc6f086ee60b81
typecheck_shim.ts https://github.com/angular/angular/pull/34887/files#diff-7133e07561fffc8f4c447d0792c067a3640837bb669161a11415d3105c7f22db
host_spec.ts https://github.com/angular/angular/pull/34887/files#diff-aef02ef0a050208b37a36aed55e8c4abb3db34ba55355ec1ab47ace2730dec23
BUILD.bazel https://github.com/angular/angular/pull/34887/files#diff-df53916f8b58d39142d4398428c93fd0528fcfc016371426c680480d660665c4
index.ts https://github.com/angular/angular/pull/34887/files#diff-232ceaacaefb9dfc22e2b67b87ab2c309dc66611491115ea9ff753d4ed35d200
alias.ts https://github.com/angular/angular/pull/34887/files#diff-7d5d584433f04a27752eaeafa86d37c5fe33e5e3c5978e2fbbe2222ef4f4ab29
declaration.ts https://github.com/angular/angular/pull/34887/files#diff-698a740cef3694ad4fa70091300a7320e21440ad73a0c55b5c69c81cbea7623b
index.ts https://github.com/angular/angular/pull/34887/files#diff-3e7f388135f8f0efef41cdd93c123560b8a6b8d5f3ab7982d31dce778536d3d0
diagnostics.ts https://github.com/angular/angular/pull/34887/files#diff-665b728d3d70d8449025a8798ebbdd565358d7a5074c317aaa3920db260e8bc4
api.ts https://github.com/angular/angular/pull/34887/files#diff-6be45432905608c44eb83e52b9f1c975f6667c8cde6aa3cae0def55502a33fcc
program.ts https://github.com/angular/angular/pull/34887/files#diff-e04ccb5e7b934167e316864d50c1592cd1906261c191ea7d14ba3902aa102c4b
template_typecheck_spec.ts https://github.com/angular/angular/pull/34887/files#diff-4338bcab035efc17fedac8da7ef2cdfaa3f171d673ed2cd22cbe42641c998fb1
packages/compiler-cli/BUILD.bazelhttps://github.com/angular/angular/pull/34887/files#diff-92a050ad91a15158adb65ab2bc5a2744eab7c6a9e60a60a3b2c44f01ba755e9e
View file https://github.com/alxhub/angular/blob/dd02363a17ff961d6a68b69745790f84eda4bac1/packages/compiler-cli/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34887/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34887/files#diff-92a050ad91a15158adb65ab2bc5a2744eab7c6a9e60a60a3b2c44f01ba755e9e
https://github.com/angular/angular/pull/34887/files#diff-92a050ad91a15158adb65ab2bc5a2744eab7c6a9e60a60a3b2c44f01ba755e9e
packages/compiler-cli/src/ngtsc/annotations/src/component.tshttps://github.com/angular/angular/pull/34887/files#diff-f2bb60ef38f35f7d41b0ac0868cc4267738c5e4c78e044336aec52d86a6e2d29
View file https://github.com/alxhub/angular/blob/dd02363a17ff961d6a68b69745790f84eda4bac1/packages/compiler-cli/src/ngtsc/annotations/src/component.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34887/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34887/files#diff-f2bb60ef38f35f7d41b0ac0868cc4267738c5e4c78e044336aec52d86a6e2d29
https://github.com/angular/angular/pull/34887/files#diff-f2bb60ef38f35f7d41b0ac0868cc4267738c5e4c78e044336aec52d86a6e2d29
packages/compiler-cli/src/ngtsc/core/BUILD.bazelhttps://github.com/angular/angular/pull/34887/files#diff-03913a67a069b7bc225402fdd87f330a2f76c7bc27a7b2f0dcb81b6ea4d4a4be
View file https://github.com/alxhub/angular/blob/dd02363a17ff961d6a68b69745790f84eda4bac1/packages/compiler-cli/src/ngtsc/core/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34887/{{ revealButtonHref }}
packages/compiler-cli/src/ngtsc/core/README.mdhttps://github.com/angular/angular/pull/34887/files#diff-e9debd6b1b37471ab951e4a307c236dbaf66366f1519be2e03cf96d2b4a73f0d
View file https://github.com/alxhub/angular/blob/dd02363a17ff961d6a68b69745790f84eda4bac1/packages/compiler-cli/src/ngtsc/core/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34887/{{ revealButtonHref }}
petebacondarwinhttps://github.com/petebacondarwin
Jan 22, 2020https://github.com/angular/angular/pull/34887/files#r369415899
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34887/files
alxhubhttps://github.com/alxhub
Jan 23, 2020https://github.com/angular/angular/pull/34887/files#r370289798
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34887/files
petebacondarwinhttps://github.com/petebacondarwin
Jan 23, 2020https://github.com/angular/angular/pull/34887/files#r370308523
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.github.com/gfm/#paragraphshttps://github.github.com/gfm/#paragraphs
Please reload this pagehttps://github.com/angular/angular/pull/34887/files
petebacondarwinhttps://github.com/petebacondarwin
Jan 22, 2020https://github.com/angular/angular/pull/34887/files#r369416999
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34887/files
alxhubhttps://github.com/alxhub
Jan 23, 2020https://github.com/angular/angular/pull/34887/files#r370291484
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34887/files
Please reload this pagehttps://github.com/angular/angular/pull/34887/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.