René's URL Explorer Experiment


Title: fix(ivy): support @SkipSelf while injecting special DI tokens by AndrewKushnir · Pull Request #34839 · angular/angular · GitHub

Open Graph Title: fix(ivy): support @SkipSelf while injecting special DI tokens by AndrewKushnir · Pull Request #34839 · angular/angular

X Title: fix(ivy): support @SkipSelf while injecting special DI tokens by AndrewKushnir · Pull Request #34839 · angular/angular

Description: Currently Ivy doesn't support adding @SkipSelf for some of the special DI tokens (e.g. Injector, ViewContainerRef, ElementRef, ChangeDetectorRef). These changes add support for @SkipSelf flag and align the behavior with View Engine. Closes #34066. Closes #34819. PR Type What kind of change does this PR introduce? Bugfix Does this PR introduce a breaking change? Yes No

Open Graph Description: Currently Ivy doesn't support adding @SkipSelf for some of the special DI tokens (e.g. Injector, ViewContainerRef, ElementRef, ChangeDetectorRef). These changes add support for @SkipSelf flag a...

X Description: Currently Ivy doesn't support adding @SkipSelf for some of the special DI tokens (e.g. Injector, ViewContainerRef, ElementRef, ChangeDetectorRef). These changes add support for @SkipSelf fl...

Opengraph URL: https://github.com/angular/angular/pull/34839

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b588e41d-2680-10bc-222f-7a6eeac8a431
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD04:3A4875:14929A4:1B629C6:6B012F96
html-safe-noncea0a4d4434410cd3e750ebb18d8c67ba05742bca0fc6f9ba00ba680918dd5d668
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDA0OjNBNDg3NToxNDkyOUE0OjFCNjI5QzY6NkIwMTJGOTYiLCJ2aXNpdG9yX2lkIjoiNTc2ODA3MzE1MDA5Nzc3NTU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac81b97f78fdebc7b7e5a5b5ddefdce2fd1960b8b2383c8fbc8461d4b86f27bdb9
hovercard-subject-tagpull_request:364311674
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/34839/files
twitter:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
og:image:altCurrently Ivy doesn't support adding @SkipSelf for some of the special DI tokens (e.g. Injector, ViewContainerRef, ElementRef, ChangeDetectorRef). These changes add support for @SkipSelf flag a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/34839/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34839%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34839%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34839/files
Reloadhttps://github.com/angular/angular/pull/34839/files
Reloadhttps://github.com/angular/angular/pull/34839/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:skip_self_injectorhttps://github.com/AndrewKushnir/angular/tree/skip_self_injector
Conversation 24 https://github.com/angular/angular/pull/34839
Commits 5 https://github.com/angular/angular/pull/34839/commits
Checks 0 https://github.com/angular/angular/pull/34839/checks
Files changed https://github.com/angular/angular/pull/34839/files
Please reload this pagehttps://github.com/angular/angular/pull/34839/files
fix(ivy): support @SkipSelf while injecting special DI tokens https://github.com/angular/angular/pull/34839/files#top
Show all changes 5 commits https://github.com/angular/angular/pull/34839/files
d0ec82a fix(ivy): support @SkipSelf when injecting Injectors AndrewKushnir Jan 17, 2020 https://github.com/angular/angular/pull/34839/commits/d0ec82aab9eef4dc2e10257db05bb09b0ea61449
d2aa929 fix(ivy): support SkipSelf when injecting ViewContainerRef, ElementRe… crisbeto Jan 23, 2020 https://github.com/angular/angular/pull/34839/commits/d2aa92953b09345e41671b5d895bf604a7a260e6
7c6d947 fixup! fix(ivy): support SkipSelf when injecting ViewContainerRef, El… AndrewKushnir Feb 21, 2020 https://github.com/angular/angular/pull/34839/commits/7c6d9478206aa9a71f5e6b006d72227a613d78f8
58bd925 fixup! fix(ivy): support SkipSelf when injecting ViewContainerRef, El… AndrewKushnir Feb 26, 2020 https://github.com/angular/angular/pull/34839/commits/58bd925058005b5a8ce296916cf561c8b0fb75d9
5deedff fixup! fix(ivy): support SkipSelf when injecting ViewContainerRef, El… AndrewKushnir Mar 3, 2020 https://github.com/angular/angular/pull/34839/commits/5deedffa215e638829cfab890ca27c5109bcaff1
Clear filters https://github.com/angular/angular/pull/34839/files
Please reload this pagehttps://github.com/angular/angular/pull/34839/files
Please reload this pagehttps://github.com/angular/angular/pull/34839/files
_payload-limits.json https://github.com/angular/angular/pull/34839/files#diff-d448965a02cb5d495dd879762b88e38c77c918ed1adcf8269354708d8b575b84
_payload-limits.json https://github.com/angular/angular/pull/34839/files#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
di.ts https://github.com/angular/angular/pull/34839/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
container.ts https://github.com/angular/angular/pull/34839/files#diff-e5b7b08f5d71ba4fa91036f8ec0bb232c095eabef0afd9b4e48fcc5d16764f4f
di_spec.ts https://github.com/angular/angular/pull/34839/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
bundle.golden_symbols.json https://github.com/angular/angular/pull/34839/files#diff-c8a15946b2828a34229ac187045402b1ea37f0cb736063560a2a20f2744c23fc
aio/scripts/_payload-limits.jsonhttps://github.com/angular/angular/pull/34839/files#diff-d448965a02cb5d495dd879762b88e38c77c918ed1adcf8269354708d8b575b84
View file https://github.com/AndrewKushnir/angular/blob/5deedffa215e638829cfab890ca27c5109bcaff1/aio/scripts/_payload-limits.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34839/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34839/files#diff-d448965a02cb5d495dd879762b88e38c77c918ed1adcf8269354708d8b575b84
Please reload this pagehttps://github.com/angular/angular/pull/34839/files
https://github.com/angular/angular/pull/34839/files#diff-d448965a02cb5d495dd879762b88e38c77c918ed1adcf8269354708d8b575b84
integration/_payload-limits.jsonhttps://github.com/angular/angular/pull/34839/files#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
View file https://github.com/AndrewKushnir/angular/blob/5deedffa215e638829cfab890ca27c5109bcaff1/integration/_payload-limits.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34839/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34839/files#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
https://github.com/angular/angular/pull/34839/files#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
https://github.com/angular/angular/pull/34839/files#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
https://github.com/angular/angular/pull/34839/files#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
https://github.com/angular/angular/pull/34839/files#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
https://github.com/angular/angular/pull/34839/files#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
packages/core/src/render3/di.tshttps://github.com/angular/angular/pull/34839/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
View file https://github.com/AndrewKushnir/angular/blob/5deedffa215e638829cfab890ca27c5109bcaff1/packages/core/src/render3/di.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34839/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34839/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/34839/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/34839/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/34839/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/34839/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
Please reload this pagehttps://github.com/angular/angular/pull/34839/files
https://github.com/angular/angular/pull/34839/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/34839/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/34839/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
https://github.com/angular/angular/pull/34839/files#diff-76ca3a00c53f485c62ce5ace8d6a7653512845be3942696e3adeb288d6121110
packages/core/src/render3/instructions/container.tshttps://github.com/angular/angular/pull/34839/files#diff-e5b7b08f5d71ba4fa91036f8ec0bb232c095eabef0afd9b4e48fcc5d16764f4f
View file https://github.com/AndrewKushnir/angular/blob/5deedffa215e638829cfab890ca27c5109bcaff1/packages/core/src/render3/instructions/container.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34839/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34839/files#diff-e5b7b08f5d71ba4fa91036f8ec0bb232c095eabef0afd9b4e48fcc5d16764f4f
https://github.com/angular/angular/pull/34839/files#diff-e5b7b08f5d71ba4fa91036f8ec0bb232c095eabef0afd9b4e48fcc5d16764f4f
Please reload this pagehttps://github.com/angular/angular/pull/34839/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.