René's URL Explorer Experiment


Title: fix(ivy): ensure that `LOCALE_ID` is set after app initializers by petebacondarwin · Pull Request #34830 · angular/angular · GitHub

Open Graph Title: fix(ivy): ensure that `LOCALE_ID` is set after app initializers by petebacondarwin · Pull Request #34830 · angular/angular

X Title: fix(ivy): ensure that `LOCALE_ID` is set after app initializers by petebacondarwin · Pull Request #34830 · angular/angular

Description: Before ivy it was possible to configure a mutable service value in an application initializer (by providing an APP_INITIALIZER) that could be read in the provider of LOCALE_ID. This is a common scenario if you wanted to load the locale id asynchronously from an HTTP request for instance. When using the ivy, the runtime needs to be told what the current locale is, which is done by calling the setLocaleId() function with the value injected by the LOCALE_ID token. Previously this was being done before the application initializers were run, which meant that the LOCALE_ID provider was being executed before the app initializers had a chance to get a new value for it. Now this initalization of the locale for the ivy runtime is done after the application initializers have been run. Closes #34701

Open Graph Description: Before ivy it was possible to configure a mutable service value in an application initializer (by providing an APP_INITIALIZER) that could be read in the provider of LOCALE_ID. This is a common sce...

X Description: Before ivy it was possible to configure a mutable service value in an application initializer (by providing an APP_INITIALIZER) that could be read in the provider of LOCALE_ID. This is a common sce...

Opengraph URL: https://github.com/angular/angular/pull/34830

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8b1ec166-5b8b-8d88-3776-573248db3a9d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC40E:A99C2:1A9EAC6:21EA9B9:6B013911
html-safe-noncea9986f4ab48da8fc51684f458ca5a912b6035458e063ae81ced32a376bba7e5c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDBFOkE5OUMyOjFBOUVBQzY6MjFFQTlCOTo2QjAxMzkxMSIsInZpc2l0b3JfaWQiOiIzNzc3NTE3MjI3MTgwMzc0Mjg5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1346d0cf128c7729630021f6efdf6a446cdcb1e0b20b4051f30d09e20d4ff132
hovercard-subject-tagpull_request:364130405
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/34830/files
twitter:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
og:image:altBefore ivy it was possible to configure a mutable service value in an application initializer (by providing an APP_INITIALIZER) that could be read in the provider of LOCALE_ID. This is a common sce...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/34830/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34830%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34830%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34830/files
Reloadhttps://github.com/angular/angular/pull/34830/files
Reloadhttps://github.com/angular/angular/pull/34830/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:i18n-locale-app-initializerhttps://github.com/petebacondarwin/angular/tree/i18n-locale-app-initializer
Conversation 6 https://github.com/angular/angular/pull/34830
Commits 1 https://github.com/angular/angular/pull/34830/commits
Checks 0 https://github.com/angular/angular/pull/34830/checks
Files changed https://github.com/angular/angular/pull/34830/files
Please reload this pagehttps://github.com/angular/angular/pull/34830/files
fix(ivy): ensure that LOCALE_ID is set after app initializers https://github.com/angular/angular/pull/34830/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/34830/files
a6b86b7 fix(ivy): ensure that `LOCALE_ID` is set after app initializers petebacondarwin Jan 17, 2020 https://github.com/angular/angular/pull/34830/commits/a6b86b7040742fedd1d7192b351f7f53775c24fa
Clear filters https://github.com/angular/angular/pull/34830/files
Please reload this pagehttps://github.com/angular/angular/pull/34830/files
Please reload this pagehttps://github.com/angular/angular/pull/34830/files
application_ref.ts https://github.com/angular/angular/pull/34830/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897
application_ref_spec.ts https://github.com/angular/angular/pull/34830/files#diff-afa1cbf5d6f53fbdb7d6024f388412fc4e0f805606492ebd36d5edf98c5a0b4f
packages/core/src/application_ref.tshttps://github.com/angular/angular/pull/34830/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897
View file https://github.com/petebacondarwin/angular/blob/a6b86b7040742fedd1d7192b351f7f53775c24fa/packages/core/src/application_ref.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34830/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34830/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897
https://github.com/angular/angular/pull/34830/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897
https://github.com/angular/angular/pull/34830/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897
packages/core/test/application_ref_spec.tshttps://github.com/angular/angular/pull/34830/files#diff-afa1cbf5d6f53fbdb7d6024f388412fc4e0f805606492ebd36d5edf98c5a0b4f
View file https://github.com/petebacondarwin/angular/blob/a6b86b7040742fedd1d7192b351f7f53775c24fa/packages/core/test/application_ref_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34830/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34830/files#diff-afa1cbf5d6f53fbdb7d6024f388412fc4e0f805606492ebd36d5edf98c5a0b4f
https://github.com/angular/angular/pull/34830/files#diff-afa1cbf5d6f53fbdb7d6024f388412fc4e0f805606492ebd36d5edf98c5a0b4f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.