René's URL Explorer Experiment


Title: fix(ivy): ensure that `LOCALE_ID` is set after app initializers by petebacondarwin · Pull Request #34830 · angular/angular · GitHub

Open Graph Title: fix(ivy): ensure that `LOCALE_ID` is set after app initializers by petebacondarwin · Pull Request #34830 · angular/angular

X Title: fix(ivy): ensure that `LOCALE_ID` is set after app initializers by petebacondarwin · Pull Request #34830 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Before ivy it was possible to configure a mutable service value in an application initializer (by providing an APP_INITIALIZER) that could be read in the provider of LOCALE_ID. This is a common sce...

X Description: Before ivy it was possible to configure a mutable service value in an application initializer (by providing an APP_INITIALIZER) that could be read in the provider of LOCALE_ID. This is a common sce...

Opengraph URL: https://github.com/angular/angular/pull/34830

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7a997e24-f376-a61f-46fe-35aba8dbf78f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD826:A71F9:9FDA9A:C8B761:6B0128EB
html-safe-noncee87092a77ac7f9288ea548927097c94b2b62050058cb36930dbecc4489ee7188
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODI2OkE3MUY5OjlGREE5QTpDOEI3NjE6NkIwMTI4RUIiLCJ2aXNpdG9yX2lkIjoiNjgxNzc5Mzc1OTkwNDg2ODU4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac73d2284ef2c2566a7304ff373ce812b19bbc954a23fa49a65af1563810d9f713
hovercard-subject-tagpull_request:364130405
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34830/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/82c5011d7ae1d92d980c42b85e32903387dbce8fd7c6ed26278857acf48d2bdf/angular/angular/pull/34830
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/82c5011d7ae1d92d980c42b85e32903387dbce8fd7c6ed26278857acf48d2bdf/angular/angular/pull/34830
og:image:altBefore ivy it was possible to configure a mutable service value in an application initializer (by providing an APP_INITIALIZER) that could be read in the provider of LOCALE_ID. This is a common sce...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepetebacondarwin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/34830#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34830
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34830
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34830
Reloadhttps://github.com/angular/angular/pull/34830
Reloadhttps://github.com/angular/angular/pull/34830
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:i18n-locale-app-initializerhttps://github.com/petebacondarwin/angular/tree/i18n-locale-app-initializer
Conversationhttps://github.com/angular/angular/pull/34830
Commits1 (1)https://github.com/angular/angular/pull/34830/commits
Checkshttps://github.com/angular/angular/pull/34830/checks
Files changedhttps://github.com/angular/angular/pull/34830/files
fix(ivy): ensure that LOCALE_ID is set after app initializershttps://github.com/angular/angular/pull/34830#top
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:i18n-locale-app-initializerhttps://github.com/petebacondarwin/angular/tree/i18n-locale-app-initializer
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jan 17, 2020https://github.com/angular/angular/pull/34830#issue-551401987
#34701https://github.com/angular/angular/issues/34701
Please reload this pagehttps://github.com/angular/angular/pull/34830
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: i18n https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
comp: ivy https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
Jan 17, 2020https://github.com/angular/angular/pull/34830#event-2958062390
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Jan 17, 2020https://github.com/angular/angular/pull/34830#event-2958062474
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jan 17, 2020https://github.com/angular/angular/pull/34830#event-2958062580
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
January 17, 2020 14:21https://github.com/angular/angular/pull/34830#event-2958310590
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
January 17, 2020 14:21https://github.com/angular/angular/pull/34830#event-2958310621
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Jan 17, 2020https://github.com/angular/angular/pull/34830#event-2958325794
https://github.com/ocombe
ocombehttps://github.com/ocombe
Jan 17, 2020 https://github.com/angular/angular/pull/34830#pullrequestreview-344633726
View reviewed changes https://github.com/angular/angular/pull/34830/files
https://github.com/alfaproject
alfaprojecthttps://github.com/alfaproject
Jan 17, 2020 https://github.com/angular/angular/pull/34830#pullrequestreview-344747186
View reviewed changes https://github.com/angular/angular/pull/34830/files
packages/core/src/application_ref.tshttps://github.com/angular/angular/pull/34830/files#diff-c3bc2f4d2923398d46897c1233ab19cec2611e44ea60592e7e0d5ed03747a897
alfaprojecthttps://github.com/alfaproject
Jan 17, 2020https://github.com/angular/angular/pull/34830#discussion_r368063797
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34830
petebacondarwinhttps://github.com/petebacondarwin
Jan 17, 2020https://github.com/angular/angular/pull/34830#discussion_r368076191
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34830
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jan 17, 2020 https://github.com/angular/angular/pull/34830#pullrequestreview-344751505
View reviewed changes https://github.com/angular/angular/pull/34830/files
AndrewKushnirhttps://github.com/AndrewKushnir
https://github.com/angular/angular/pull/34830#pullrequestreview-344751505
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34830
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jan 17, 2020https://github.com/angular/angular/pull/34830#issuecomment-575735286
Presubmithttp://test/OCL:290292504:BASE:290292534:1579284646370:5b6d8bf8
Please reload this pagehttps://github.com/angular/angular/pull/34830
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Jan 17, 2020https://github.com/angular/angular/pull/34830#event-2959046798
https://github.com/petebacondarwin
fix(ivy): ensure that LOCALE_ID is set after app initializershttps://github.com/angular/angular/pull/34830/commits/a6b86b7040742fedd1d7192b351f7f53775c24fa
a6b86b7https://github.com/angular/angular/pull/34830/commits/a6b86b7040742fedd1d7192b351f7f53775c24fa
angular#34701https://github.com/angular/angular/issues/34701
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/d96581dca29debb3a521d69c246ac65bd1623f9e..a6b86b7040742fedd1d7192b351f7f53775c24fa
d96581dhttps://github.com/angular/angular/commit/d96581dca29debb3a521d69c246ac65bd1623f9e
a6b86b7https://github.com/angular/angular/commit/a6b86b7040742fedd1d7192b351f7f53775c24fa
Compare https://github.com/angular/angular/compare/d96581dca29debb3a521d69c246ac65bd1623f9e..a6b86b7040742fedd1d7192b351f7f53775c24fa
January 17, 2020 18:32https://github.com/angular/angular/pull/34830#event-2959099221
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jan 17, 2020https://github.com/angular/angular/pull/34830#issuecomment-575743167
@AndrewKushnirhttps://github.com/AndrewKushnir
@alfaprojecthttps://github.com/alfaproject
Please reload this pagehttps://github.com/angular/angular/pull/34830
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Jan 17, 2020https://github.com/angular/angular/pull/34830#event-2959292533
https://github.com/matsko
matskohttps://github.com/matsko
e0ad9echttps://github.com/angular/angular/commit/e0ad9ecda0b8a541b405d2ab35335b90ceb21fd1
Jan 17, 2020https://github.com/angular/angular/pull/34830#event-2959536058
matskohttps://github.com/matsko
Jan 17, 2020 https://github.com/angular/angular/pull/34830#ref-commit-7643913
https://github.com/petebacondarwin
https://github.com/matsko
fix(ivy): ensure thathttps://github.com/angular/angular/commit/76439132989f9935b19d961bd827d0e9c0b5bc81
LOCALE_IDhttps://github.com/angular/angular/commit/76439132989f9935b19d961bd827d0e9c0b5bc81
is set after app initializers (https://github.com/angular/angular/commit/76439132989f9935b19d961bd827d0e9c0b5bc81
#34830https://github.com/angular/angular/pull/34830
)https://github.com/angular/angular/commit/76439132989f9935b19d961bd827d0e9c0b5bc81
7643913https://github.com/angular/angular/commit/76439132989f9935b19d961bd827d0e9c0b5bc81
#34701https://github.com/angular/angular/issues/34701
#34830https://github.com/angular/angular/pull/34830
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
January 18, 2020 11:16https://github.com/angular/angular/pull/34830#event-2960166647
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Feb 18, 2020https://github.com/angular/angular/pull/34830#issuecomment-587538486
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/34830
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Feb 18, 2020https://github.com/angular/angular/pull/34830#event-3047788226
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34830
https://github.com/AndrewKushnir
AndrewKushnir https://github.com/AndrewKushnir
https://github.com/angular/angular/pull/34830/files/d96581dca29debb3a521d69c246ac65bd1623f9e
https://github.com/alfaproject
alfaproject https://github.com/alfaproject
https://github.com/angular/angular/pull/34830/files/d96581dca29debb3a521d69c246ac65bd1623f9e
https://github.com/ocombe
ocombe https://github.com/ocombe
https://github.com/angular/angular/pull/34830/files/d96581dca29debb3a521d69c246ac65bd1623f9e
Please reload this pagehttps://github.com/angular/angular/pull/34830
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: i18n https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
LOCALE_ID is being set before APP_INITIALIZER finish execution - [ng serve only] https://github.com/angular/angular/issues/34701
Please reload this pagehttps://github.com/angular/angular/pull/34830
https://github.com/petebacondarwin
https://github.com/AndrewKushnir
https://github.com/alfaproject
https://github.com/ocombe
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.