René's URL Explorer Experiment


Title: fix(ngcc): do not collect private declarations from external packages by gkalpak · Pull Request #34811 · angular/angular · GitHub

Open Graph Title: fix(ngcc): do not collect private declarations from external packages by gkalpak · Pull Request #34811 · angular/angular

X Title: fix(ngcc): do not collect private declarations from external packages by gkalpak · Pull Request #34811 · angular/angular

Description: Previously, while trying to build an NgccReflectionHost's privateDtsDeclarationMap, computePrivateDtsDeclarationMap() would try to collect exported declarations from all source files of the program (i.e. without checking whether they were within the target entry-point, as happens for declarations in .d.ts files). Most of the time, that would not be a problem, because external packages would be represented as .d.ts files in the program. But when an external package had no typings, the JS files would be used instead. As a result, the ReflectionHost would try to (unnecessarilly) parse the file in order to extract exported declarations, which in turn would be harmless in most cases. There are certain cases, though, where the ReflectionHost would throw an error, because it cannot not parse the external package's JS file. This could happen, for example, in UmdReflectionHost, which expects the file to contain exactly one statement. See #34544 for more details on a real-world failure. This commit fixes the issue by ensuring that computePrivateDtsDeclarationMap() will only collect exported declarations from files within the target entry-point. Jira issue: FW-1794 Fixes #34544. For good measure, I have also tested it on the ngcc-validation repo (angular/ngcc-validation#777) and nothing broke.

Open Graph Description: Previously, while trying to build an NgccReflectionHost's privateDtsDeclarationMap, computePrivateDtsDeclarationMap() would try to collect exported declarations from all source files of the pro...

X Description: Previously, while trying to build an NgccReflectionHost's privateDtsDeclarationMap, computePrivateDtsDeclarationMap() would try to collect exported declarations from all source files of the...

Opengraph URL: https://github.com/angular/angular/pull/34811

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:85b59c63-fdb6-d580-f3f2-f591d99697ab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBCD8:EDA7A:1672C1E:1C87944:6B013654
html-safe-nonce00e96ee97e9125687e98a4fdef2bb6f5c1ef7843f50a9b634ee839bdf9367d8f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0Q4OkVEQTdBOjE2NzJDMUU6MUM4Nzk0NDo2QjAxMzY1NCIsInZpc2l0b3JfaWQiOiIxNDg2ODAxOTMwMzAxODE0MzU2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca0cff0aade4ba57f0f86f1744fde7261da32d7b6af0d0a427cf107c943181125
hovercard-subject-tagpull_request:363600570
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/34811/files
twitter:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
og:image:altPreviously, while trying to build an NgccReflectionHost's privateDtsDeclarationMap, computePrivateDtsDeclarationMap() would try to collect exported declarations from all source files of the pro...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/34811/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34811%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34811%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34811/files
Reloadhttps://github.com/angular/angular/pull/34811/files
Reloadhttps://github.com/angular/angular/pull/34811/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-ngcc-ignore-nodejs-builtinshttps://github.com/gkalpak/angular/tree/fix-ngcc-ignore-nodejs-builtins
Conversation 17 https://github.com/angular/angular/pull/34811
Commits 3 https://github.com/angular/angular/pull/34811/commits
Checks 0 https://github.com/angular/angular/pull/34811/checks
Files changed https://github.com/angular/angular/pull/34811/files
Please reload this pagehttps://github.com/angular/angular/pull/34811/files
fix(ngcc): do not collect private declarations from external packages https://github.com/angular/angular/pull/34811/files#top
Show all changes 3 commits https://github.com/angular/angular/pull/34811/files
2fe8897 refactor(compiler-cli): fix typo in `TypeScriptCompilerHost#getExport… gkalpak Jan 15, 2020 https://github.com/angular/angular/pull/34811/commits/2fe8897562d93d2810f0bb4d34bc34c06c772068
8e53a2b fix(ngcc): do not collect private declarations from external packages gkalpak Jan 15, 2020 https://github.com/angular/angular/pull/34811/commits/8e53a2b034969633147f75b73c8352b066668f50
74e8273 fixup! fix(ngcc): do not collect private declarations from external p… gkalpak Jan 18, 2020 https://github.com/angular/angular/pull/34811/commits/74e827315ae1c264bac05dc119d764a58f0aa8a0
Clear filters https://github.com/angular/angular/pull/34811/files
Please reload this pagehttps://github.com/angular/angular/pull/34811/files
Please reload this pagehttps://github.com/angular/angular/pull/34811/files
debug-test.sh https://github.com/angular/angular/pull/34811/files#diff-d178c8201208811a723b2f8f46ccf938436b126d99f495966e643c63f95283bf
package.json https://github.com/angular/angular/pull/34811/files#diff-14fe715d7db3599a170d639e506d3d80ca1c23703d06f30839b525838a2d0f5e
test.sh https://github.com/angular/angular/pull/34811/files#diff-54b4c35645c846047e48b8b463846c17ff9649900407cd6d565c563ace86ce63
yarn.lock https://github.com/angular/angular/pull/34811/files#diff-48175895774660ca23c907c96fb2765842124129df657c76a3e8a1eba49fc74e
run_tests.sh https://github.com/angular/angular/pull/34811/files#diff-9a1876fe502fa6b024f84a6f9abc011b450750ffd887ab2164be43c2409c8279
esm2015_host.ts https://github.com/angular/angular/pull/34811/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
commonjs_host_spec.ts https://github.com/angular/angular/pull/34811/files#diff-0db82dee3e42c4dd42541af6804480af5c328f5b679cf2d9f33972527eca27c5
esm2015_host_spec.ts https://github.com/angular/angular/pull/34811/files#diff-18452185ddea0470affbb7aeb782082f03c1950adf928cf5a5c12ed88045f427
esm5_host_spec.ts https://github.com/angular/angular/pull/34811/files#diff-42557bc6689586acf48908cc8f6488ebcb7bd0239e54fe478ed2b8f008eb58b6
umd_host_spec.ts https://github.com/angular/angular/pull/34811/files#diff-284ab9d6a8ea565f9239b8ba018bd21140c2739accdf565dc7e7a8cae08cd893
typescript.ts https://github.com/angular/angular/pull/34811/files#diff-f64171de3bc6bd3aca1ecb9a6f9711ee7b5e5e87d8c01bb4759aca4831baa71d
integration/ngcc/debug-test.shhttps://github.com/angular/angular/pull/34811/files#diff-d178c8201208811a723b2f8f46ccf938436b126d99f495966e643c63f95283bf
View file https://github.com/gkalpak/angular/blob/74e827315ae1c264bac05dc119d764a58f0aa8a0/integration/ngcc/debug-test.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34811/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34811/files#diff-d178c8201208811a723b2f8f46ccf938436b126d99f495966e643c63f95283bf
https://github.com/angular/angular/pull/34811/files#diff-d178c8201208811a723b2f8f46ccf938436b126d99f495966e643c63f95283bf
integration/ngcc/package.jsonhttps://github.com/angular/angular/pull/34811/files#diff-14fe715d7db3599a170d639e506d3d80ca1c23703d06f30839b525838a2d0f5e
View file https://github.com/gkalpak/angular/blob/74e827315ae1c264bac05dc119d764a58f0aa8a0/integration/ngcc/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34811/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34811/files#diff-14fe715d7db3599a170d639e506d3d80ca1c23703d06f30839b525838a2d0f5e
https://github.com/angular/angular/pull/34811/files#diff-14fe715d7db3599a170d639e506d3d80ca1c23703d06f30839b525838a2d0f5e
integration/ngcc/test.shhttps://github.com/angular/angular/pull/34811/files#diff-54b4c35645c846047e48b8b463846c17ff9649900407cd6d565c563ace86ce63
View file https://github.com/gkalpak/angular/blob/74e827315ae1c264bac05dc119d764a58f0aa8a0/integration/ngcc/test.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34811/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34811/files#diff-54b4c35645c846047e48b8b463846c17ff9649900407cd6d565c563ace86ce63
https://github.com/angular/angular/pull/34811/files#diff-54b4c35645c846047e48b8b463846c17ff9649900407cd6d565c563ace86ce63
integration/ngcc/yarn.lockhttps://github.com/angular/angular/pull/34811/files#diff-48175895774660ca23c907c96fb2765842124129df657c76a3e8a1eba49fc74e
View file https://github.com/gkalpak/angular/blob/74e827315ae1c264bac05dc119d764a58f0aa8a0/integration/ngcc/yarn.lock
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34811/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34811/files#diff-48175895774660ca23c907c96fb2765842124129df657c76a3e8a1eba49fc74e
https://github.com/angular/angular/pull/34811/files#diff-48175895774660ca23c907c96fb2765842124129df657c76a3e8a1eba49fc74e
https://github.com/angular/angular/pull/34811/files#diff-48175895774660ca23c907c96fb2765842124129df657c76a3e8a1eba49fc74e
https://github.com/angular/angular/pull/34811/files#diff-48175895774660ca23c907c96fb2765842124129df657c76a3e8a1eba49fc74e
https://github.com/angular/angular/pull/34811/files#diff-48175895774660ca23c907c96fb2765842124129df657c76a3e8a1eba49fc74e
https://github.com/angular/angular/pull/34811/files#diff-48175895774660ca23c907c96fb2765842124129df657c76a3e8a1eba49fc74e
integration/run_tests.shhttps://github.com/angular/angular/pull/34811/files#diff-9a1876fe502fa6b024f84a6f9abc011b450750ffd887ab2164be43c2409c8279
View file https://github.com/gkalpak/angular/blob/74e827315ae1c264bac05dc119d764a58f0aa8a0/integration/run_tests.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34811/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34811/files#diff-9a1876fe502fa6b024f84a6f9abc011b450750ffd887ab2164be43c2409c8279
petebacondarwinhttps://github.com/petebacondarwin
Jan 17, 2020https://github.com/angular/angular/pull/34811/files#r367806985
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34811/files
gkalpakhttps://github.com/gkalpak
Jan 18, 2020https://github.com/angular/angular/pull/34811/files#r368241678
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34811/files
https://github.com/angular/angular/pull/34811/files#diff-9a1876fe502fa6b024f84a6f9abc011b450750ffd887ab2164be43c2409c8279
packages/compiler-cli/ngcc/src/host/esm2015_host.tshttps://github.com/angular/angular/pull/34811/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
View file https://github.com/gkalpak/angular/blob/74e827315ae1c264bac05dc119d764a58f0aa8a0/packages/compiler-cli/ngcc/src/host/esm2015_host.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34811/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34811/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
https://github.com/angular/angular/pull/34811/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
https://github.com/angular/angular/pull/34811/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
https://github.com/angular/angular/pull/34811/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
https://github.com/angular/angular/pull/34811/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
packages/compiler-cli/ngcc/test/host/commonjs_host_spec.tshttps://github.com/angular/angular/pull/34811/files#diff-0db82dee3e42c4dd42541af6804480af5c328f5b679cf2d9f33972527eca27c5
View file https://github.com/gkalpak/angular/blob/74e827315ae1c264bac05dc119d764a58f0aa8a0/packages/compiler-cli/ngcc/test/host/commonjs_host_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34811/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34811/files#diff-0db82dee3e42c4dd42541af6804480af5c328f5b679cf2d9f33972527eca27c5
Please reload this pagehttps://github.com/angular/angular/pull/34811/files
https://github.com/angular/angular/pull/34811/files#diff-0db82dee3e42c4dd42541af6804480af5c328f5b679cf2d9f33972527eca27c5
packages/compiler-cli/ngcc/test/host/esm2015_host_spec.tshttps://github.com/angular/angular/pull/34811/files#diff-18452185ddea0470affbb7aeb782082f03c1950adf928cf5a5c12ed88045f427
View file https://github.com/gkalpak/angular/blob/74e827315ae1c264bac05dc119d764a58f0aa8a0/packages/compiler-cli/ngcc/test/host/esm2015_host_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34811/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34811/files#diff-18452185ddea0470affbb7aeb782082f03c1950adf928cf5a5c12ed88045f427
https://github.com/angular/angular/pull/34811/files#diff-18452185ddea0470affbb7aeb782082f03c1950adf928cf5a5c12ed88045f427
https://github.com/angular/angular/pull/34811/files#diff-18452185ddea0470affbb7aeb782082f03c1950adf928cf5a5c12ed88045f427
https://github.com/angular/angular/pull/34811/files#diff-18452185ddea0470affbb7aeb782082f03c1950adf928cf5a5c12ed88045f427
https://github.com/angular/angular/pull/34811/files#diff-18452185ddea0470affbb7aeb782082f03c1950adf928cf5a5c12ed88045f427
https://github.com/angular/angular/pull/34811/files#diff-18452185ddea0470affbb7aeb782082f03c1950adf928cf5a5c12ed88045f427
https://github.com/angular/angular/pull/34811/files#diff-18452185ddea0470affbb7aeb782082f03c1950adf928cf5a5c12ed88045f427
petebacondarwinhttps://github.com/petebacondarwin
Jan 17, 2020https://github.com/angular/angular/pull/34811/files#r367815470
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34811/files
gkalpakhttps://github.com/gkalpak
Jan 18, 2020https://github.com/angular/angular/pull/34811/files#r368243334
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34811/files
https://github.com/angular/angular/pull/34811/files#diff-18452185ddea0470affbb7aeb782082f03c1950adf928cf5a5c12ed88045f427
packages/compiler-cli/ngcc/test/host/esm5_host_spec.tshttps://github.com/angular/angular/pull/34811/files#diff-42557bc6689586acf48908cc8f6488ebcb7bd0239e54fe478ed2b8f008eb58b6
View file https://github.com/gkalpak/angular/blob/74e827315ae1c264bac05dc119d764a58f0aa8a0/packages/compiler-cli/ngcc/test/host/esm5_host_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34811/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34811/files#diff-42557bc6689586acf48908cc8f6488ebcb7bd0239e54fe478ed2b8f008eb58b6
https://github.com/angular/angular/pull/34811/files#diff-42557bc6689586acf48908cc8f6488ebcb7bd0239e54fe478ed2b8f008eb58b6
packages/compiler-cli/ngcc/test/host/umd_host_spec.tshttps://github.com/angular/angular/pull/34811/files#diff-284ab9d6a8ea565f9239b8ba018bd21140c2739accdf565dc7e7a8cae08cd893
View file https://github.com/gkalpak/angular/blob/74e827315ae1c264bac05dc119d764a58f0aa8a0/packages/compiler-cli/ngcc/test/host/umd_host_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34811/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34811/files#diff-284ab9d6a8ea565f9239b8ba018bd21140c2739accdf565dc7e7a8cae08cd893
https://github.com/angular/angular/pull/34811/files#diff-284ab9d6a8ea565f9239b8ba018bd21140c2739accdf565dc7e7a8cae08cd893
packages/compiler-cli/src/ngtsc/reflection/src/typescript.tshttps://github.com/angular/angular/pull/34811/files#diff-f64171de3bc6bd3aca1ecb9a6f9711ee7b5e5e87d8c01bb4759aca4831baa71d
View file https://github.com/gkalpak/angular/blob/74e827315ae1c264bac05dc119d764a58f0aa8a0/packages/compiler-cli/src/ngtsc/reflection/src/typescript.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34811/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34811/files#diff-f64171de3bc6bd3aca1ecb9a6f9711ee7b5e5e87d8c01bb4759aca4831baa71d
https://github.com/angular/angular/pull/34811/files#diff-f64171de3bc6bd3aca1ecb9a6f9711ee7b5e5e87d8c01bb4759aca4831baa71d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.