| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bddc2872-5536-bf8a-959d-b05e6205d3e5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DC3E:1F8F:7921D6:9E636D:6B0128FC |
| html-safe-nonce | fd337164e5a4e0c14f648f0230be1d313c0b885e0e3300d225f4e0af1e74723e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzNFOjFGOEY6NzkyMUQ2OjlFNjM2RDo2QjAxMjhGQyIsInZpc2l0b3JfaWQiOiIzNTY0NjI5OTU3NjA5MDcyODkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 6c5962d78938848a7ff041e6b0560ef87304225416e2447c80964b534ea13f00 |
| hovercard-subject-tag | pull_request:363600570 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34811/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a58af5536da1faa6a575c854afde6b69ef0831aab812e424103808eb82150279/angular/angular/pull/34811 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a58af5536da1faa6a575c854afde6b69ef0831aab812e424103808eb82150279/angular/angular/pull/34811 |
| og:image:alt | Previously, while trying to build an NgccReflectionHost's privateDtsDeclarationMap, computePrivateDtsDeclarationMap() would try to collect exported declarations from all source files of the pro... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gkalpak |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/34811#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34811 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34811 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/34811 |
| Reload | https://github.com/angular/angular/pull/34811 |
| Reload | https://github.com/angular/angular/pull/34811 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-ngcc-ignore-nodejs-builtins | https://github.com/gkalpak/angular/tree/fix-ngcc-ignore-nodejs-builtins |
| Conversation | https://github.com/angular/angular/pull/34811 |
| Commits3 (3) | https://github.com/angular/angular/pull/34811/commits |
| Checks | https://github.com/angular/angular/pull/34811/checks |
| Files changed | https://github.com/angular/angular/pull/34811/files |
| fix(ngcc): do not collect private declarations from external packages | https://github.com/angular/angular/pull/34811#top |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-ngcc-ignore-nodejs-builtins | https://github.com/gkalpak/angular/tree/fix-ngcc-ignore-nodejs-builtins |
|
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Jan 16, 2020 | https://github.com/angular/angular/pull/34811#issue-550752290 |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| #34544 | https://github.com/angular/angular/issues/34544 |
| FW-1794 | https://angular-team.atlassian.net/browse/FW-1794 |
| #34544 | https://github.com/angular/angular/issues/34544 |
| angular/ngcc-validation#777 | https://github.com/angular/ngcc-validation/pull/777 |
| nothing broke | https://circleci.com/workflow-run/6c3c8973-665c-4f25-ae33-5df4d592cf01 |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
comp: ngcc
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22 |
| Jan 16, 2020 | https://github.com/angular/angular/pull/34811#event-2954208609 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Jan 16, 2020 | https://github.com/angular/angular/pull/34811#event-2954208701 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Jan 16, 2020 | https://github.com/angular/angular/pull/34811#event-2954208865 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/53c2d7b4af6f4f69c1a89e99f1903756b5dac68e..a8b07f67620ab645c6054580eaa9a4e6437c0fc1 |
| 53c2d7b | https://github.com/angular/angular/commit/53c2d7b4af6f4f69c1a89e99f1903756b5dac68e |
| a8b07f6 | https://github.com/angular/angular/commit/a8b07f67620ab645c6054580eaa9a4e6437c0fc1 |
|
Compare
| https://github.com/angular/angular/compare/53c2d7b4af6f4f69c1a89e99f1903756b5dac68e..a8b07f67620ab645c6054580eaa9a4e6437c0fc1 |
| January 16, 2020 12:05 | https://github.com/angular/angular/pull/34811#event-2954282317 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jan 16, 2020 | https://github.com/angular/angular/pull/34811#issuecomment-575125193 |
| https://pr34811-a8b07f6.ngbuilds.io/ | https://pr34811-a8b07f6.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| gkalpak | https://github.com/gkalpak |
|
Jan 16, 2020
| https://github.com/angular/angular/pull/34811#ref-commit-6ecdba9 |
|
| https://github.com/gkalpak |
| Test PR | https://github.com/gkalpak/ngcc-validation/commit/6ecdba954ef8304a00bb94cc0d2ada614068044d |
| angular/angular#34811 | https://github.com/angular/angular/pull/34811 |
| 6ecdba9 | https://github.com/gkalpak/ngcc-validation/commit/6ecdba954ef8304a00bb94cc0d2ada614068044d |
| gkalpak | https://github.com/gkalpak |
|
Jan 16, 2020
| https://github.com/angular/angular/pull/34811#ref-commit-6389c75 |
|
| https://github.com/gkalpak |
| Test PR | https://github.com/gkalpak/ngcc-validation/commit/6389c75fc894640b2afe06890198344e88182707 |
| angular/angular#34811 | https://github.com/angular/angular/pull/34811 |
| 6389c75 | https://github.com/gkalpak/ngcc-validation/commit/6389c75fc894640b2afe06890198344e88182707 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/eb0c337da863c5fe83cd7d1400f42316894ba2ab..38e9d9ef1ad3d2b8c6f423cd2de47282e9e892b4 |
| eb0c337 | https://github.com/angular/angular/commit/eb0c337da863c5fe83cd7d1400f42316894ba2ab |
| 38e9d9e | https://github.com/angular/angular/commit/38e9d9ef1ad3d2b8c6f423cd2de47282e9e892b4 |
|
Compare
| https://github.com/angular/angular/compare/eb0c337da863c5fe83cd7d1400f42316894ba2ab..38e9d9ef1ad3d2b8c6f423cd2de47282e9e892b4 |
| January 16, 2020 18:54 | https://github.com/angular/angular/pull/34811#event-2955678685 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Jan 16, 2020 | https://github.com/angular/angular/pull/34811#event-2955679064 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jan 16, 2020 | https://github.com/angular/angular/pull/34811#issuecomment-575297005 |
| https://pr34811-38e9d9e.ngbuilds.io/ | https://pr34811-38e9d9e.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| gkalpak | https://github.com/gkalpak |
|
Jan 16, 2020
| https://github.com/angular/angular/pull/34811#ref-commit-b2a282c |
|
| https://github.com/gkalpak |
| Test PR | https://github.com/gkalpak/ngcc-validation/commit/b2a282c4d4a493ad0ee84ea3fb0cefa839aea26c |
| angular/angular#34811 | https://github.com/angular/angular/pull/34811 |
| b2a282c | https://github.com/gkalpak/ngcc-validation/commit/b2a282c4d4a493ad0ee84ea3fb0cefa839aea26c |
| gkalpak | https://github.com/gkalpak |
|
Jan 16, 2020
| https://github.com/angular/angular/pull/34811#ref-commit-d095c53 |
|
| https://github.com/gkalpak |
| Test PR | https://github.com/gkalpak/ngcc-validation/commit/d095c5367b1047fbd22e46642551a0ef695c93d9 |
| angular/angular#34811 | https://github.com/angular/angular/pull/34811 |
| d095c53 | https://github.com/gkalpak/ngcc-validation/commit/d095c5367b1047fbd22e46642551a0ef695c93d9 |
| gkalpak | https://github.com/gkalpak |
|
Jan 16, 2020
| https://github.com/angular/angular/pull/34811#ref-commit-54ad524 |
|
| https://github.com/gkalpak |
| Test PR | https://github.com/gkalpak/ngcc-validation/commit/54ad524f207f9f78d005b78cd891ab1fab59effd |
| angular/angular#34811 | https://github.com/angular/angular/pull/34811 |
| 54ad524 | https://github.com/gkalpak/ngcc-validation/commit/54ad524f207f9f78d005b78cd891ab1fab59effd |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| January 16, 2020 20:39 | https://github.com/angular/angular/pull/34811#event-2955989921 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| January 16, 2020 20:39 | https://github.com/angular/angular/pull/34811#event-2955989939 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Jan 16, 2020
| https://github.com/angular/angular/pull/34811#ref-issue-541795169 |
|
platform-server errors with ivy-ngcc - UMD module - Angular 9.0.0-rc.7
#34544
| https://github.com/angular/angular/issues/34544 |
| https://github.com/kapunahelewong |
| kapunahelewong | https://github.com/kapunahelewong |
|
Jan 16, 2020
| https://github.com/angular/angular/pull/34811#pullrequestreview-344233117 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34811/files |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Jan 17, 2020
| https://github.com/angular/angular/pull/34811#pullrequestreview-344410396 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34811/files |
| petebacondarwin | https://github.com/petebacondarwin |
| https://github.com/angular/angular/pull/34811#pullrequestreview-344410396 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| integration/run_tests.sh | https://github.com/angular/angular/pull/34811/files#diff-9a1876fe502fa6b024f84a6f9abc011b450750ffd887ab2164be43c2409c8279 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 17, 2020 | https://github.com/angular/angular/pull/34811#discussion_r367806985 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| gkalpak | https://github.com/gkalpak |
| Jan 18, 2020 | https://github.com/angular/angular/pull/34811#discussion_r368241678 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| packages/compiler-cli/ngcc/test/host/commonjs_host_spec.ts | https://github.com/angular/angular/pull/34811/files#diff-0db82dee3e42c4dd42541af6804480af5c328f5b679cf2d9f33972527eca27c5 |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| packages/compiler-cli/ngcc/test/host/esm2015_host_spec.ts | https://github.com/angular/angular/pull/34811/files#diff-18452185ddea0470affbb7aeb782082f03c1950adf928cf5a5c12ed88045f427 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 17, 2020 | https://github.com/angular/angular/pull/34811#discussion_r367813058 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| gkalpak | https://github.com/gkalpak |
| Jan 18, 2020 | https://github.com/angular/angular/pull/34811#discussion_r368243539 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| packages/compiler-cli/ngcc/test/host/esm2015_host_spec.ts | https://github.com/angular/angular/pull/34811/files#diff-18452185ddea0470affbb7aeb782082f03c1950adf928cf5a5c12ed88045f427 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 17, 2020 | https://github.com/angular/angular/pull/34811#discussion_r367813532 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| gkalpak | https://github.com/gkalpak |
| Jan 18, 2020 | https://github.com/angular/angular/pull/34811#discussion_r368243528 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| packages/compiler-cli/ngcc/test/host/esm2015_host_spec.ts | https://github.com/angular/angular/pull/34811/files#diff-18452185ddea0470affbb7aeb782082f03c1950adf928cf5a5c12ed88045f427 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 17, 2020 | https://github.com/angular/angular/pull/34811#discussion_r367815470 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| gkalpak | https://github.com/gkalpak |
| Jan 18, 2020 | https://github.com/angular/angular/pull/34811#discussion_r368243334 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Jan 17, 2020 | https://github.com/angular/angular/pull/34811#event-2957297539 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Jan 17, 2020 | https://github.com/angular/angular/pull/34811#event-2957297540 |
| gkalpak | https://github.com/gkalpak |
| January 18, 2020 20:28 | https://github.com/angular/angular/pull/34811#commits-pushed-2fe8897 |
|
| https://github.com/gkalpak |
| refactor(compiler-cli): fix typo in `TypeScriptCompilerHost#getExport… | https://github.com/angular/angular/pull/34811/commits/2fe8897562d93d2810f0bb4d34bc34c06c772068 |
| 2fe8897 | https://github.com/angular/angular/pull/34811/commits/2fe8897562d93d2810f0bb4d34bc34c06c772068 |
|
| https://github.com/gkalpak |
| fix(ngcc): do not collect private declarations from external packages | https://github.com/angular/angular/pull/34811/commits/8e53a2b034969633147f75b73c8352b066668f50 |
| 8e53a2b | https://github.com/angular/angular/pull/34811/commits/8e53a2b034969633147f75b73c8352b066668f50 |
| angular#34544 | https://github.com/angular/angular/issues/34544 |
| https://angular-team.atlassian.net/browse/FW-1794 | https://angular-team.atlassian.net/browse/FW-1794 |
| angular#34544 | https://github.com/angular/angular/issues/34544 |
|
| https://github.com/gkalpak |
| fixup! fix(ngcc): do not collect private declarations from external p… | https://github.com/angular/angular/pull/34811/commits/74e827315ae1c264bac05dc119d764a58f0aa8a0 |
| 74e8273 | https://github.com/angular/angular/pull/34811/commits/74e827315ae1c264bac05dc119d764a58f0aa8a0 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/38e9d9ef1ad3d2b8c6f423cd2de47282e9e892b4..74e827315ae1c264bac05dc119d764a58f0aa8a0 |
| 38e9d9e | https://github.com/angular/angular/commit/38e9d9ef1ad3d2b8c6f423cd2de47282e9e892b4 |
| 74e8273 | https://github.com/angular/angular/commit/74e827315ae1c264bac05dc119d764a58f0aa8a0 |
|
Compare
| https://github.com/angular/angular/compare/38e9d9ef1ad3d2b8c6f423cd2de47282e9e892b4..74e827315ae1c264bac05dc119d764a58f0aa8a0 |
| January 18, 2020 19:15 | https://github.com/angular/angular/pull/34811#event-2960406160 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Jan 18, 2020 | https://github.com/angular/angular/pull/34811#event-2960406512 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jan 18, 2020 | https://github.com/angular/angular/pull/34811#issuecomment-575930685 |
| 74e8273 | https://github.com/angular/angular/commit/74e827315ae1c264bac05dc119d764a58f0aa8a0 |
| https://pr34811-74e8273.ngbuilds.io/ | https://pr34811-74e8273.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| https://github.com/kainiedziela |
| kainiedziela | https://github.com/kainiedziela |
| Jan 22, 2020 | https://github.com/angular/angular/pull/34811#issuecomment-577410103 |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| Jan 23, 2020 | https://github.com/angular/angular/pull/34811#event-2974529088 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
Jan 23, 2020
| https://github.com/angular/angular/pull/34811#pullrequestreview-347494628 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34811/files/74e827315ae1c264bac05dc119d764a58f0aa8a0 |
| https://github.com/josephperrott |
| josephperrott | https://github.com/josephperrott |
|
Jan 23, 2020
| https://github.com/angular/angular/pull/34811#pullrequestreview-347631560 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34811/files/74e827315ae1c264bac05dc119d764a58f0aa8a0 |
| josephperrott | https://github.com/josephperrott |
| https://github.com/angular/angular/pull/34811#pullrequestreview-347631560 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Jan 23, 2020 | https://github.com/angular/angular/pull/34811#issuecomment-577895701 |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Jan 23, 2020
| https://github.com/angular/angular/pull/34811#ref-commit-92d26e2 |
|
| https://github.com/gkalpak |
|
| https://github.com/AndrewKushnir |
| refactor(compiler-cli): fix typo in `TypeScriptCompilerHost#getExport… | https://github.com/angular/angular/commit/92d26e26ea69dc63ab89be5bf8fca02476950d13 |
| 92d26e2 | https://github.com/angular/angular/commit/92d26e26ea69dc63ab89be5bf8fca02476950d13 |
| #34811 | https://github.com/angular/angular/pull/34811 |
| #34811 | https://github.com/angular/angular/pull/34811 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Jan 23, 2020
| https://github.com/angular/angular/pull/34811#ref-commit-c80392b |
|
| https://github.com/gkalpak |
|
| https://github.com/AndrewKushnir |
| fix(ngcc): do not collect private declarations from external packages ( | https://github.com/angular/angular/commit/c80392bcd2915ee4238bd60dbb5af9064a310e19 |
| … | https://github.com/angular/angular/pull/34811 |
| c80392b | https://github.com/angular/angular/commit/c80392bcd2915ee4238bd60dbb5af9064a310e19 |
| …#34811 | https://github.com/angular/angular/pull/34811 |
| #34544 | https://github.com/angular/angular/issues/34544 |
| https://angular-team.atlassian.net/browse/FW-1794 | https://angular-team.atlassian.net/browse/FW-1794 |
| #34544 | https://github.com/angular/angular/issues/34544 |
| #34811 | https://github.com/angular/angular/pull/34811 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| ba2bf82 | https://github.com/angular/angular/commit/ba2bf82540408b4a1361344b6868a37181c002da |
| Jan 23, 2020 | https://github.com/angular/angular/pull/34811#event-2975430024 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Jan 23, 2020
| https://github.com/angular/angular/pull/34811#ref-commit-5b42084 |
|
| https://github.com/gkalpak |
|
| https://github.com/AndrewKushnir |
| fix(ngcc): do not collect private declarations from external packages ( | https://github.com/angular/angular/commit/5b42084912f6bc8bdc419b0893fe3e25351719dc |
| … | https://github.com/angular/angular/pull/34811 |
| 5b42084 | https://github.com/angular/angular/commit/5b42084912f6bc8bdc419b0893fe3e25351719dc |
| …#34811 | https://github.com/angular/angular/pull/34811 |
| #34544 | https://github.com/angular/angular/issues/34544 |
| https://angular-team.atlassian.net/browse/FW-1794 | https://angular-team.atlassian.net/browse/FW-1794 |
| #34544 | https://github.com/angular/angular/issues/34544 |
| #34811 | https://github.com/angular/angular/pull/34811 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| January 23, 2020 22:04 | https://github.com/angular/angular/pull/34811#event-2975447254 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Feb 23, 2020 | https://github.com/angular/angular/pull/34811#issuecomment-590084861 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Feb 23, 2020 | https://github.com/angular/angular/pull/34811#event-3063520060 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34811 |
|
| https://github.com/alxhub |
|
alxhub
| https://github.com/alxhub |
|
| https://github.com/angular/angular/pull/34811/files/74e827315ae1c264bac05dc119d764a58f0aa8a0 |
|
| https://github.com/josephperrott |
|
josephperrott
| https://github.com/josephperrott |
|
| https://github.com/angular/angular/pull/34811/files/74e827315ae1c264bac05dc119d764a58f0aa8a0 |
|
| https://github.com/petebacondarwin |
|
petebacondarwin
| https://github.com/petebacondarwin |
|
| https://github.com/angular/angular/pull/34811/files/38e9d9ef1ad3d2b8c6f423cd2de47282e9e892b4 |
|
| https://github.com/kapunahelewong |
|
kapunahelewong
| https://github.com/kapunahelewong |
|
| https://github.com/angular/angular/pull/34811/files/38e9d9ef1ad3d2b8c6f423cd2de47282e9e892b4 |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
|
| https://github.com/alxhub |
|
alxhub
| https://github.com/alxhub |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
|
platform-server errors with ivy-ngcc - UMD module - Angular 9.0.0-rc.7
| https://github.com/angular/angular/issues/34544 |
| Please reload this page | https://github.com/angular/angular/pull/34811 |
|
| https://github.com/gkalpak |
|
| https://github.com/mary-poppins |
|
| https://github.com/kainiedziela |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/petebacondarwin |
|
| https://github.com/kapunahelewong |
|
| https://github.com/alxhub |
|
| https://github.com/josephperrott |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |