René's URL Explorer Experiment


Title: refactor(language-service): cleanup of low-hanging TODOs by ayazhafiz · Pull Request #34784 · angular/angular · GitHub

Open Graph Title: refactor(language-service): cleanup of low-hanging TODOs by ayazhafiz · Pull Request #34784 · angular/angular

X Title: refactor(language-service): cleanup of low-hanging TODOs by ayazhafiz · Pull Request #34784 · angular/angular

Description: Cleans up some simple TODOs. Also removes typescript_symbols#getTypeWrapper, which I thought I had but failed to remove in #34571. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Refactoring (no functional changes, no api changes) Does this PR introduce a breaking change? Yes No

Open Graph Description: Cleans up some simple TODOs. Also removes typescript_symbols#getTypeWrapper, which I thought I had but failed to remove in #34571. PR Checklist Please check if your PR fulfills the following requir...

X Description: Cleans up some simple TODOs. Also removes typescript_symbols#getTypeWrapper, which I thought I had but failed to remove in #34571. PR Checklist Please check if your PR fulfills the following requir...

Opengraph URL: https://github.com/angular/angular/pull/34784

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ae73957e-b2cd-b08a-41dd-67752124b122
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA24:1AE20C:1C63F18:23EF51B:6B01532A
html-safe-nonce2220d15989f15ff7335aa92eacc832cbad25f3d43392110f6f9362b6ce31c71b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTI0OjFBRTIwQzoxQzYzRjE4OjIzRUY1MUI6NkIwMTUzMkEiLCJ2aXNpdG9yX2lkIjoiNzc1NDY4NzIyNzA5MDc4NTA2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca1a5cb8fcf92695b8a41766c4e5290b03d5a47340062bdf54e28ac58f7dc031e
hovercard-subject-tagpull_request:362983949
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/34784/files
twitter:imagehttps://avatars.githubusercontent.com/u/20735482?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20735482?s=400&v=4
og:image:altCleans up some simple TODOs. Also removes typescript_symbols#getTypeWrapper, which I thought I had but failed to remove in #34571. PR Checklist Please check if your PR fulfills the following requir...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/34784/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34784%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34784%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34784/files
Reloadhttps://github.com/angular/angular/pull/34784/files
Reloadhttps://github.com/angular/angular/pull/34784/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
ayazhafizhttps://github.com/ayazhafiz
angular:masterhttps://github.com/angular/angular/tree/master
ayazhafiz:i/typeargshttps://github.com/ayazhafiz/angular/tree/i/typeargs
Conversation 1 https://github.com/angular/angular/pull/34784
Commits 2 https://github.com/angular/angular/pull/34784/commits
Checks 0 https://github.com/angular/angular/pull/34784/checks
Files changed https://github.com/angular/angular/pull/34784/files
Please reload this pagehttps://github.com/angular/angular/pull/34784/files
refactor(language-service): cleanup of low-hanging TODOs https://github.com/angular/angular/pull/34784/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/34784/files
a94658b refactor(language-service): cleanup of low-hanging TODOs ayazhafiz Jan 15, 2020 https://github.com/angular/angular/pull/34784/commits/a94658bff5f6b161eb5bebedcd3ab130f2f41c57
5c3c290 fixup! refactor(language-service): cleanup of low-hanging TODOs ayazhafiz Jan 18, 2020 https://github.com/angular/angular/pull/34784/commits/5c3c290be2284c046072597aed5a3f4295378603
Clear filters https://github.com/angular/angular/pull/34784/files
Please reload this pagehttps://github.com/angular/angular/pull/34784/files
Please reload this pagehttps://github.com/angular/angular/pull/34784/files
expression_diagnostics.ts https://github.com/angular/angular/pull/34784/files#diff-74b0efc8090d579160c144864b333a79c85aeb4c50a39bc3d3a3b703300e84e4
expression_type.ts https://github.com/angular/angular/pull/34784/files#diff-1247f9a23a9dc0aa79faaf27dc635e9da6cf4323425200b67a3380ffdc3c683f
locate_symbol.ts https://github.com/angular/angular/pull/34784/files#diff-4d56f03e4585b313cea9c364391d5613e6160e754e524d9587869a53ccdccc60
typescript_symbols.ts https://github.com/angular/angular/pull/34784/files#diff-2d3b62b42d426aecbb3c52bcad3e2c2b754cdd85958e57123d84848e8ea71e9f
mocks.ts https://github.com/angular/angular/pull/34784/files#diff-e8d4a51dfdaaa30ad14005f90c6c359f35ffbc41a1161fed89d7a68077a33672
packages/language-service/src/expression_diagnostics.tshttps://github.com/angular/angular/pull/34784/files#diff-74b0efc8090d579160c144864b333a79c85aeb4c50a39bc3d3a3b703300e84e4
View file https://github.com/ayazhafiz/angular/blob/5c3c290be2284c046072597aed5a3f4295378603/packages/language-service/src/expression_diagnostics.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34784/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34784/files#diff-74b0efc8090d579160c144864b333a79c85aeb4c50a39bc3d3a3b703300e84e4
https://github.com/angular/angular/pull/34784/files#diff-74b0efc8090d579160c144864b333a79c85aeb4c50a39bc3d3a3b703300e84e4
packages/language-service/src/expression_type.tshttps://github.com/angular/angular/pull/34784/files#diff-1247f9a23a9dc0aa79faaf27dc635e9da6cf4323425200b67a3380ffdc3c683f
View file https://github.com/ayazhafiz/angular/blob/5c3c290be2284c046072597aed5a3f4295378603/packages/language-service/src/expression_type.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34784/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34784/files#diff-1247f9a23a9dc0aa79faaf27dc635e9da6cf4323425200b67a3380ffdc3c683f
https://github.com/angular/angular/pull/34784/files#diff-1247f9a23a9dc0aa79faaf27dc635e9da6cf4323425200b67a3380ffdc3c683f
https://github.com/angular/angular/pull/34784/files#diff-1247f9a23a9dc0aa79faaf27dc635e9da6cf4323425200b67a3380ffdc3c683f
https://github.com/angular/angular/pull/34784/files#diff-1247f9a23a9dc0aa79faaf27dc635e9da6cf4323425200b67a3380ffdc3c683f
https://github.com/angular/angular/pull/34784/files#diff-1247f9a23a9dc0aa79faaf27dc635e9da6cf4323425200b67a3380ffdc3c683f
packages/language-service/src/locate_symbol.tshttps://github.com/angular/angular/pull/34784/files#diff-4d56f03e4585b313cea9c364391d5613e6160e754e524d9587869a53ccdccc60
View file https://github.com/ayazhafiz/angular/blob/5c3c290be2284c046072597aed5a3f4295378603/packages/language-service/src/locate_symbol.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34784/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34784/files#diff-4d56f03e4585b313cea9c364391d5613e6160e754e524d9587869a53ccdccc60
https://github.com/angular/angular/pull/34784/files#diff-4d56f03e4585b313cea9c364391d5613e6160e754e524d9587869a53ccdccc60
packages/language-service/src/typescript_symbols.tshttps://github.com/angular/angular/pull/34784/files#diff-2d3b62b42d426aecbb3c52bcad3e2c2b754cdd85958e57123d84848e8ea71e9f
View file https://github.com/ayazhafiz/angular/blob/5c3c290be2284c046072597aed5a3f4295378603/packages/language-service/src/typescript_symbols.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34784/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34784/files#diff-2d3b62b42d426aecbb3c52bcad3e2c2b754cdd85958e57123d84848e8ea71e9f
https://github.com/angular/angular/pull/34784/files#diff-2d3b62b42d426aecbb3c52bcad3e2c2b754cdd85958e57123d84848e8ea71e9f
https://github.com/angular/angular/pull/34784/files#diff-2d3b62b42d426aecbb3c52bcad3e2c2b754cdd85958e57123d84848e8ea71e9f
https://github.com/angular/angular/pull/34784/files#diff-2d3b62b42d426aecbb3c52bcad3e2c2b754cdd85958e57123d84848e8ea71e9f
https://github.com/angular/angular/pull/34784/files#diff-2d3b62b42d426aecbb3c52bcad3e2c2b754cdd85958e57123d84848e8ea71e9f
https://github.com/angular/angular/pull/34784/files#diff-2d3b62b42d426aecbb3c52bcad3e2c2b754cdd85958e57123d84848e8ea71e9f
https://github.com/angular/angular/pull/34784/files#diff-2d3b62b42d426aecbb3c52bcad3e2c2b754cdd85958e57123d84848e8ea71e9f
https://github.com/angular/angular/pull/34784/files#diff-2d3b62b42d426aecbb3c52bcad3e2c2b754cdd85958e57123d84848e8ea71e9f
https://github.com/angular/angular/pull/34784/files#diff-2d3b62b42d426aecbb3c52bcad3e2c2b754cdd85958e57123d84848e8ea71e9f
packages/language-service/test/mocks.tshttps://github.com/angular/angular/pull/34784/files#diff-e8d4a51dfdaaa30ad14005f90c6c359f35ffbc41a1161fed89d7a68077a33672
View file https://github.com/ayazhafiz/angular/blob/5c3c290be2284c046072597aed5a3f4295378603/packages/language-service/test/mocks.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34784/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34784/files#diff-e8d4a51dfdaaa30ad14005f90c6c359f35ffbc41a1161fed89d7a68077a33672
https://github.com/angular/angular/pull/34784/files#diff-e8d4a51dfdaaa30ad14005f90c6c359f35ffbc41a1161fed89d7a68077a33672
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.