| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1f0192ff-5e05-f521-d787-8a4f32db5b9e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AFB8:31B4CC:1799D6F:1F0A15C:6B01338A |
| html-safe-nonce | 22c96ac5233c48ca44e4a1158f90470bde68862980d31d8433a67dbeb99b7010 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkI4OjMxQjRDQzoxNzk5RDZGOjFGMEExNUM6NkIwMTMzOEEiLCJ2aXNpdG9yX2lkIjoiNjczMzI0MTc3NTI5MDM5NzU3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 481f78c03486de9d67b7bddcfac494b5aadc0cc2b0c403b1e4433b167df78d3b |
| hovercard-subject-tag | pull_request:361877385 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34750/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f6ee4eccc31ca99944399ae0e6bcc7e1cfba7459ec708d056178cc55f637fe8a/angular/angular/pull/34750 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f6ee4eccc31ca99944399ae0e6bcc7e1cfba7459ec708d056178cc55f637fe8a/angular/angular/pull/34750 |
| og:image:alt | Windows CI for #34736 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gregmagolan |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/34750#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34750 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34750 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/34750 |
| Reload | https://github.com/angular/angular/pull/34750 |
| Reload | https://github.com/angular/angular/pull/34750 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| gregmagolan | https://github.com/gregmagolan |
| angular:master | https://github.com/angular/angular/tree/master |
| Conversation | https://github.com/angular/angular/pull/34750 |
| Commits20 (20) | https://github.com/angular/angular/pull/34750/commits |
| Checks | https://github.com/angular/angular/pull/34750/checks |
| Files changed | https://github.com/angular/angular/pull/34750/files |
| Rules nodejs 1.0.0 windows ci | https://github.com/angular/angular/pull/34750#top |
| gregmagolan | https://github.com/gregmagolan |
| angular:master | https://github.com/angular/angular/tree/master |
|
| https://github.com/gregmagolan |
| gregmagolan | https://github.com/gregmagolan |
| Jan 12, 2020 | https://github.com/angular/angular/pull/34750#issue-548635968 |
| #34736 | https://github.com/angular/angular/pull/34736 |
| Please reload this page | https://github.com/angular/angular/pull/34750 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Jan 12, 2020 | https://github.com/angular/angular/pull/34750#event-2941544441 |
| https://github.com/gregmagolan |
| gregmagolan | https://github.com/gregmagolan |
|
Jan 12, 2020
| https://github.com/angular/angular/pull/34750#ref-pullrequest-548346603 |
|
Rules nodejs 1.0 redo
#34736
| https://github.com/angular/angular/pull/34736 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
area: build & ci
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20build%20%26%20ci%22 |
| Jan 14, 2020 | https://github.com/angular/angular/pull/34750#event-2948969156 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Jan 14, 2020 | https://github.com/angular/angular/pull/34750#event-2948969200 |
| gregmagolan | https://github.com/gregmagolan |
| January 14, 2020 19:30 | https://github.com/angular/angular/pull/34750#commits-pushed-4398240 |
|
| https://github.com/gregmagolan |
| build: upgrade to rules_nodejs 1.0.0 (first stable release) | https://github.com/angular/angular/pull/34750/commits/439824009b368325d6ef33396a9d59758e2b9455 |
| 4398240 | https://github.com/angular/angular/pull/34750/commits/439824009b368325d6ef33396a9d59758e2b9455 |
|
| https://github.com/gregmagolan |
| build: upgrade to io_bazel_rules_sass 1.24.0 | https://github.com/angular/angular/pull/34750/commits/825d3d8c960dff67e23d0080e4b2f392e259c5b3 |
| 825d3d8 | https://github.com/angular/angular/pull/34750/commits/825d3d8c960dff67e23d0080e4b2f392e259c5b3 |
|
| https://github.com/gregmagolan |
| refactor: handle breaking changes in rules_nodejs 1.0.0 | https://github.com/angular/angular/pull/34750/commits/a2ff79d5e672e18c8f231e42f7d4c17140a57e78 |
| a2ff79d | https://github.com/angular/angular/pull/34750/commits/a2ff79d5e672e18c8f231e42f7d4c17140a57e78 |
|
| https://github.com/gregmagolan |
| build: package-build & release scripts should handle new pkg_npm naming | https://github.com/angular/angular/pull/34750/commits/b1501783e30ca363890a750dac508de53f773826 |
| b150178 | https://github.com/angular/angular/pull/34750/commits/b1501783e30ca363890a750dac508de53f773826 |
|
| https://github.com/gregmagolan |
| build: update integration/bazel & @angular/bazel schematics to rules_… | https://github.com/angular/angular/pull/34750/commits/ce3da3829d98cd8eb17d86b36bd6bbb2c2f5e29a |
| ce3da38 | https://github.com/angular/angular/pull/34750/commits/ce3da3829d98cd8eb17d86b36bd6bbb2c2f5e29a |
|
| https://github.com/gregmagolan |
| build: update to @angular/cli 9.0.0-rc.4 | https://github.com/angular/angular/pull/34750/commits/7eb983e55374a103837cda12fdd38c0e4bb26bb3 |
| 7eb983e | https://github.com/angular/angular/pull/34750/commits/7eb983e55374a103837cda12fdd38c0e4bb26bb3 |
|
| https://github.com/gregmagolan |
| build: update to rules nodejs 1.0.1 | https://github.com/angular/angular/pull/34750/commits/aaa3e7d58adb6041bef270396e62260a7e1bcddb |
| aaa3e7d | https://github.com/angular/angular/pull/34750/commits/aaa3e7d58adb6041bef270396e62260a7e1bcddb |
|
| https://github.com/gregmagolan |
| test: handle bootstrap templated_args in jasmine_node_test defaults.bzl | https://github.com/angular/angular/pull/34750/commits/08c0df1f9406938fc7c3f8289689797a40048fac |
| 08c0df1 | https://github.com/angular/angular/pull/34750/commits/08c0df1f9406938fc7c3f8289689797a40048fac |
|
| https://github.com/gregmagolan |
| test: keep diff in integration/bazel minimal by not introducing addit… | https://github.com/angular/angular/pull/34750/commits/087336299c61cafbfa74835fdd83a68380b1e0f4 |
| 0873362 | https://github.com/angular/angular/pull/34750/commits/087336299c61cafbfa74835fdd83a68380b1e0f4 |
|
| https://github.com/gregmagolan |
| build: renamed "injected_scripts" target to "asset_injected_index_html" | https://github.com/angular/angular/pull/34750/commits/f8ca3f340a546a738a7631593320f65c1efa9f5c |
| f8ca3f3 | https://github.com/angular/angular/pull/34750/commits/f8ca3f340a546a738a7631593320f65c1efa9f5c |
|
| https://github.com/gregmagolan |
| build: add a before-all-other bootstrap script that patches require | https://github.com/angular/angular/pull/34750/commits/48d1d957d2808638119ef9ac3f446f4971969fe4 |
| 48d1d95 | https://github.com/angular/angular/pull/34750/commits/48d1d957d2808638119ef9ac3f446f4971969fe4 |
|
| https://github.com/gregmagolan |
| build: should use $(execpath) in npm_package_bin args | https://github.com/angular/angular/pull/34750/commits/37c0a0cdbb5851c8c39801baac4330f2d5bc59c9 |
| 37c0a0c | https://github.com/angular/angular/pull/34750/commits/37c0a0cdbb5851c8c39801baac4330f2d5bc59c9 |
|
| https://github.com/gregmagolan |
| build: derive ts_library dep from jasmine_node_test boostrap label if… | https://github.com/angular/angular/pull/34750/commits/4b291514de8cae0a3077a5b7a27fbd2e9c1e952a |
| 4b29151 | https://github.com/angular/angular/pull/34750/commits/4b291514de8cae0a3077a5b7a27fbd2e9c1e952a |
|
| https://github.com/gregmagolan |
| build: add better comments to defaults.bzl jasmine_node_test macro | https://github.com/angular/angular/pull/34750/commits/515898786d15c85f633685e50609d04374996188 |
| 5158987 | https://github.com/angular/angular/pull/34750/commits/515898786d15c85f633685e50609d04374996188 |
|
| https://github.com/gregmagolan |
| build: cleanup //tools/ts-api-guardian:tests target | https://github.com/angular/angular/pull/34750/commits/53b52ee8f551a6aa69b357a471d118913149e8f9 |
| 53b52ee | https://github.com/angular/angular/pull/34750/commits/53b52ee8f551a6aa69b357a471d118913149e8f9 |
|
| https://github.com/gregmagolan |
| test: add coverage to //tools/ts-api-guardian/... on WindowsCI | https://github.com/angular/angular/pull/34750/commits/d499337220102cb298cb190b52e47cc42945954e |
| d499337 | https://github.com/angular/angular/pull/34750/commits/d499337220102cb298cb190b52e47cc42945954e |
|
| https://github.com/gregmagolan |
| test: test for regression where jasmine_node_test passes silently | https://github.com/angular/angular/pull/34750/commits/38687ac663d8d09890f28e98b53f9eb89a83d6ab |
| 38687ac | https://github.com/angular/angular/pull/34750/commits/38687ac663d8d09890f28e98b53f9eb89a83d6ab |
| bazel-contrib/rules_nodejs#1540 | https://github.com/bazel-contrib/rules_nodejs/pull/1540 |
|
| https://github.com/gregmagolan |
| build: update to rules_nodejs 1.1.0 | https://github.com/angular/angular/pull/34750/commits/527b566adb66464a8276331105583b383cbffbbd |
| 527b566 | https://github.com/angular/angular/pull/34750/commits/527b566adb66464a8276331105583b383cbffbbd |
|
| https://github.com/gregmagolan |
| fixup! refactor: handle breaking changes in rules_nodejs 1.0.0 | https://github.com/angular/angular/pull/34750/commits/9bcebacaf5c695c15c9cb2b2baa51af534f98f8c |
| 9bcebac | https://github.com/angular/angular/pull/34750/commits/9bcebacaf5c695c15c9cb2b2baa51af534f98f8c |
|
| https://github.com/gregmagolan |
| test: windows CI | https://github.com/angular/angular/pull/34750/commits/7bc2c1daabea96595724cae7e628d8a1cb715e31 |
| 7bc2c1d | https://github.com/angular/angular/pull/34750/commits/7bc2c1daabea96595724cae7e628d8a1cb715e31 |
| https://github.com/gregmagolan |
| gregmagolan | https://github.com/gregmagolan |
| Jan 15, 2020 | https://github.com/angular/angular/pull/34750#issuecomment-574860667 |
| #34736 | https://github.com/angular/angular/pull/34736 |
| Please reload this page | https://github.com/angular/angular/pull/34750 |
| https://github.com/gregmagolan |
| gregmagolan | https://github.com/gregmagolan |
| Jan 15, 2020 | https://github.com/angular/angular/pull/34750#event-2952352544 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Feb 15, 2020 | https://github.com/angular/angular/pull/34750#issuecomment-586614083 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/34750 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Feb 15, 2020 | https://github.com/angular/angular/pull/34750#event-3040981844 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34750 |
| Please reload this page | https://github.com/angular/angular/pull/34750 |
|
area: build & ci
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20build%20%26%20ci%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
| Please reload this page | https://github.com/angular/angular/pull/34750 |
|
| https://github.com/gregmagolan |
|
| https://github.com/atscott |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |