René's URL Explorer Experiment


Title: Rules nodejs 1.0 redo by gregmagolan · Pull Request #34736 · angular/angular · GitHub

Open Graph Title: Rules nodejs 1.0 redo by gregmagolan · Pull Request #34736 · angular/angular

X Title: Rules nodejs 1.0 redo by gregmagolan · Pull Request #34736 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Redo of #34589 which broke jasmine_node_test and was reverted. Added a commit tests for this regression which will fail without the fix that is coming in rules_nodejs.

X Description: Redo of #34589 which broke jasmine_node_test and was reverted. Added a commit tests for this regression which will fail without the fix that is coming in rules_nodejs.

Opengraph URL: https://github.com/angular/angular/pull/34736

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3933080e-69ce-e80e-c910-3148be00b8d2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8596:1DCB8C:168D886:1DC008A:6B013046
html-safe-nonced9a14f8085edf3669477743b0617c238e24f19f452b476fd976e06cd899ff4c6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTk2OjFEQ0I4QzoxNjhEODg2OjFEQzAwOEE6NkIwMTMwNDYiLCJ2aXNpdG9yX2lkIjoiNjQwNzEyNjczNTUwMTMxOTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf159eecd576e456bb971fdf1d58aa291ddefce3b9dd442c7c3e3f63a9a8f7878
hovercard-subject-tagpull_request:361667768
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34736/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/916872f4e2ed247f2651038634e6c4cfffb44b08cf0358dba4407668ae937fd5/angular/angular/pull/34736
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/916872f4e2ed247f2651038634e6c4cfffb44b08cf0358dba4407668ae937fd5/angular/angular/pull/34736
og:image:altRedo of #34589 which broke jasmine_node_test and was reverted. Added a commit tests for this regression which will fail without the fix that is coming in rules_nodejs.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegregmagolan
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/34736#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34736
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34736
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34736
Reloadhttps://github.com/angular/angular/pull/34736
Reloadhttps://github.com/angular/angular/pull/34736
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
gregmagolanhttps://github.com/gregmagolan
angular:masterhttps://github.com/angular/angular/tree/master
Conversationhttps://github.com/angular/angular/pull/34736
Commits19 (19)https://github.com/angular/angular/pull/34736/commits
Checkshttps://github.com/angular/angular/pull/34736/checks
Files changedhttps://github.com/angular/angular/pull/34736/files
Rules nodejs 1.0 redohttps://github.com/angular/angular/pull/34736#top
gregmagolanhttps://github.com/gregmagolan
angular:masterhttps://github.com/angular/angular/tree/master
https://github.com/gregmagolan
gregmagolanhttps://github.com/gregmagolan
Jan 11, 2020https://github.com/angular/angular/pull/34736#issue-548346603
Please reload this pagehttps://github.com/angular/angular/pull/34736
#34589https://github.com/angular/angular/pull/34589
Please reload this pagehttps://github.com/angular/angular/pull/34736
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jan 11, 2020https://github.com/angular/angular/pull/34736#event-2940210614
https://github.com/gregmagolan
gregmagolanhttps://github.com/gregmagolan
Jan 12, 2020 https://github.com/angular/angular/pull/34736#ref-pullrequest-548635968
Rules nodejs 1.0.0 windows ci #34750 https://github.com/angular/angular/pull/34750
https://github.com/gregmagolan
gregmagolanhttps://github.com/gregmagolan
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
area: bazel https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20bazel%22
Jan 12, 2020https://github.com/angular/angular/pull/34736#event-2941566578
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Jan 12, 2020https://github.com/angular/angular/pull/34736#event-2941566658
https://github.com/gregmagolan
gregmagolanhttps://github.com/gregmagolan
area: build & ci https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20build%20%26%20ci%22
Jan 12, 2020https://github.com/angular/angular/pull/34736#event-2941566661
https://github.com/gregmagolan
gregmagolanhttps://github.com/gregmagolan
Jan 12, 2020https://github.com/angular/angular/pull/34736#issuecomment-573467303
Please reload this pagehttps://github.com/angular/angular/pull/34736
Please reload this pagehttps://github.com/angular/angular/pull/34736
https://github.com/gregmagolan
gregmagolanhttps://github.com/gregmagolan
January 12, 2020 23:03https://github.com/angular/angular/pull/34736#event-2941571599
https://github.com/gregmagolan
gregmagolanhttps://github.com/gregmagolan
IgorMinarhttps://github.com/IgorMinar
code ownerhttps://github.com/angular/angular/blob/6d534f10e69e0c7763bc44c108017eba1bd230b5/.github/CODEOWNERS#L379
January 12, 2020 23:03https://github.com/angular/angular/pull/34736#event-2941571608
https://github.com/gregmagolan
gregmagolanhttps://github.com/gregmagolan
January 12, 2020 23:03https://github.com/angular/angular/pull/34736#event-2941571610
https://github.com/gregmagolan
gregmagolanhttps://github.com/gregmagolan
Jan 13, 2020https://github.com/angular/angular/pull/34736#issuecomment-573508504
#34750https://github.com/angular/angular/pull/34750
Please reload this pagehttps://github.com/angular/angular/pull/34736
gregmagolanhttps://github.com/gregmagolan
January 14, 2020 19:30https://github.com/angular/angular/pull/34736#commits-pushed-4398240
https://github.com/gregmagolan
build: upgrade to rules_nodejs 1.0.0 (first stable release)https://github.com/angular/angular/pull/34736/commits/439824009b368325d6ef33396a9d59758e2b9455
4398240https://github.com/angular/angular/pull/34736/commits/439824009b368325d6ef33396a9d59758e2b9455
https://github.com/gregmagolan
build: upgrade to io_bazel_rules_sass 1.24.0https://github.com/angular/angular/pull/34736/commits/825d3d8c960dff67e23d0080e4b2f392e259c5b3
825d3d8https://github.com/angular/angular/pull/34736/commits/825d3d8c960dff67e23d0080e4b2f392e259c5b3
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-d1bac3b
https://github.com/gregmagolan
https://github.com/matsko
build: update integration/bazel & @angular/bazel schematics to rules_…https://github.com/angular/angular/commit/d1bac3bbbebf24faf36fde2b7f2a874ac45a75d7
d1bac3bhttps://github.com/angular/angular/commit/d1bac3bbbebf24faf36fde2b7f2a874ac45a75d7
#34736https://github.com/angular/angular/pull/34736
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-1cf2892
https://github.com/gregmagolan
https://github.com/matsko
build: update to @angular/cli 9.0.0-rc.4 (https://github.com/angular/angular/commit/1cf28929f17e25aa1aa40034d0e84b645a33549a
#34736https://github.com/angular/angular/pull/34736
)https://github.com/angular/angular/commit/1cf28929f17e25aa1aa40034d0e84b645a33549a
1cf2892https://github.com/angular/angular/commit/1cf28929f17e25aa1aa40034d0e84b645a33549a
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-fa30e31
https://github.com/gregmagolan
https://github.com/matsko
build: update to rules nodejs 1.0.1 (https://github.com/angular/angular/commit/fa30e31cd510e785b3263d57728b98490d768f3b
#34736https://github.com/angular/angular/pull/34736
)https://github.com/angular/angular/commit/fa30e31cd510e785b3263d57728b98490d768f3b
fa30e31https://github.com/angular/angular/commit/fa30e31cd510e785b3263d57728b98490d768f3b
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-7fb43d0
https://github.com/gregmagolan
https://github.com/matsko
test: handle bootstrap templated_args in jasmine_node_test defaults.b…https://github.com/angular/angular/commit/7fb43d0d02f6e4885870dbbd1772a02c1faf1671
7fb43d0https://github.com/angular/angular/commit/7fb43d0d02f6e4885870dbbd1772a02c1faf1671
#34736https://github.com/angular/angular/pull/34736
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-cdf5bd7
https://github.com/gregmagolan
https://github.com/matsko
test: keep diff in integration/bazel minimal by not introducing addit…https://github.com/angular/angular/commit/cdf5bd76e7ed504eff14453053a3bc1633e6d3ca
cdf5bd7https://github.com/angular/angular/commit/cdf5bd76e7ed504eff14453053a3bc1633e6d3ca
#34736https://github.com/angular/angular/pull/34736
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-449a9fc
https://github.com/gregmagolan
https://github.com/matsko
build: renamed "injected_scripts" target to "asset_injected_index_htm…https://github.com/angular/angular/commit/449a9fccc243ccde28b5434b29d82cd40e4f52e7
449a9fchttps://github.com/angular/angular/commit/449a9fccc243ccde28b5434b29d82cd40e4f52e7
#34736https://github.com/angular/angular/pull/34736
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-8560f01
https://github.com/gregmagolan
https://github.com/matsko
build: add a before-all-other bootstrap script that patches require (https://github.com/angular/angular/commit/8560f016cdf4f2e751dbfa02f7ebc6faaf1308be
#…https://github.com/angular/angular/pull/34736
8560f01https://github.com/angular/angular/commit/8560f016cdf4f2e751dbfa02f7ebc6faaf1308be
…34736https://github.com/angular/angular/pull/34736
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-51a9f6c
https://github.com/gregmagolan
https://github.com/matsko
build: should use $(execpath) in npm_package_bin args (https://github.com/angular/angular/commit/51a9f6c540bc95d64eb325845a43074c597adbdf
#34736https://github.com/angular/angular/pull/34736
)https://github.com/angular/angular/commit/51a9f6c540bc95d64eb325845a43074c597adbdf
51a9f6chttps://github.com/angular/angular/commit/51a9f6c540bc95d64eb325845a43074c597adbdf
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-ae38e1e
https://github.com/gregmagolan
https://github.com/matsko
build: derive ts_library dep from jasmine_node_test boostrap label if…https://github.com/angular/angular/commit/ae38e1e57c842036bd1aaf7cdb40d6530755937e
ae38e1ehttps://github.com/angular/angular/commit/ae38e1e57c842036bd1aaf7cdb40d6530755937e
#34736https://github.com/angular/angular/pull/34736
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-484af46
https://github.com/gregmagolan
https://github.com/matsko
build: add better comments to defaults.bzl jasmine_node_test macro (https://github.com/angular/angular/commit/484af4699e8bea353c7b84f32b88108b7a02d1e3
#…https://github.com/angular/angular/pull/34736
484af46https://github.com/angular/angular/commit/484af4699e8bea353c7b84f32b88108b7a02d1e3
…34736https://github.com/angular/angular/pull/34736
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-2f88faf
https://github.com/gregmagolan
https://github.com/matsko
build: cleanup //tools/ts-api-guardian:tests target (https://github.com/angular/angular/commit/2f88faf5d93e0199ced671e9707bca3dec5d5692
#34736https://github.com/angular/angular/pull/34736
)https://github.com/angular/angular/commit/2f88faf5d93e0199ced671e9707bca3dec5d5692
2f88fafhttps://github.com/angular/angular/commit/2f88faf5d93e0199ced671e9707bca3dec5d5692
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-04ebe12
https://github.com/gregmagolan
https://github.com/matsko
test: add coverage to //tools/ts-api-guardian/... on WindowsCI (https://github.com/angular/angular/commit/04ebe125b278b9e9ee5bd226ce1719e12a618b30
#34736https://github.com/angular/angular/pull/34736
)https://github.com/angular/angular/commit/04ebe125b278b9e9ee5bd226ce1719e12a618b30
04ebe12https://github.com/angular/angular/commit/04ebe125b278b9e9ee5bd226ce1719e12a618b30
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-0945f28
https://github.com/gregmagolan
https://github.com/matsko
test: test for regression where jasmine_node_test passes silently (https://github.com/angular/angular/commit/0945f2808f101310a6307f076d48a89a214e0eb0
#3…https://github.com/angular/angular/pull/34736
0945f28https://github.com/angular/angular/commit/0945f2808f101310a6307f076d48a89a214e0eb0
…4736https://github.com/angular/angular/pull/34736
bazel-contrib/rules_nodejs#1540https://github.com/bazel-contrib/rules_nodejs/pull/1540
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-762c531
https://github.com/gregmagolan
https://github.com/matsko
build: update to rules_nodejs 1.1.0 (https://github.com/angular/angular/commit/762c531e307b75206ca4960aecde765d2a7a342f
#34736https://github.com/angular/angular/pull/34736
)https://github.com/angular/angular/commit/762c531e307b75206ca4960aecde765d2a7a342f
762c531https://github.com/angular/angular/commit/762c531e307b75206ca4960aecde765d2a7a342f
#34736https://github.com/angular/angular/pull/34736
https://github.com/matsko
matskohttps://github.com/matsko
93c2df2https://github.com/angular/angular/commit/93c2df23bfd893fd0ff8c5e9c03b332b9b8e7124
Jan 15, 2020https://github.com/angular/angular/pull/34736#event-2952129358
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-ba662fa
https://github.com/gregmagolan
https://github.com/matsko
build: upgrade to io_bazel_rules_sass 1.24.0 (https://github.com/angular/angular/commit/ba662fa7a94ba0be01b3537b12723f35dc3b3622
#34736https://github.com/angular/angular/pull/34736
)https://github.com/angular/angular/commit/ba662fa7a94ba0be01b3537b12723f35dc3b3622
ba662fahttps://github.com/angular/angular/commit/ba662fa7a94ba0be01b3537b12723f35dc3b3622
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-dcff76e
https://github.com/gregmagolan
https://github.com/matsko
refactor: handle breaking changes in rules_nodejs 1.0.0 (https://github.com/angular/angular/commit/dcff76e8b91f1627a6f92ed61a1795ba33c7f40f
#34736https://github.com/angular/angular/pull/34736
)https://github.com/angular/angular/commit/dcff76e8b91f1627a6f92ed61a1795ba33c7f40f
dcff76ehttps://github.com/angular/angular/commit/dcff76e8b91f1627a6f92ed61a1795ba33c7f40f
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-45ae627
https://github.com/gregmagolan
https://github.com/matsko
build: package-build & release scripts should handle new pkg_npm nami…https://github.com/angular/angular/commit/45ae62787ac4e6801bc8ca5e10a7bf26307ee65f
45ae627https://github.com/angular/angular/commit/45ae62787ac4e6801bc8ca5e10a7bf26307ee65f
#34736https://github.com/angular/angular/pull/34736
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-96a61d2
https://github.com/gregmagolan
https://github.com/matsko
build: update integration/bazel & @angular/bazel schematics to rules_…https://github.com/angular/angular/commit/96a61d21db7b77aece9bd728418bf40a9f35f902
96a61d2https://github.com/angular/angular/commit/96a61d21db7b77aece9bd728418bf40a9f35f902
#34736https://github.com/angular/angular/pull/34736
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-99d7390
https://github.com/gregmagolan
https://github.com/matsko
build: update to @angular/cli 9.0.0-rc.4 (https://github.com/angular/angular/commit/99d73906a8afe9548eb6e647a961a8bf78e1cb3a
#34736https://github.com/angular/angular/pull/34736
)https://github.com/angular/angular/commit/99d73906a8afe9548eb6e647a961a8bf78e1cb3a
99d7390https://github.com/angular/angular/commit/99d73906a8afe9548eb6e647a961a8bf78e1cb3a
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-a4bbc35
https://github.com/gregmagolan
https://github.com/matsko
build: update to rules nodejs 1.0.1 (https://github.com/angular/angular/commit/a4bbc35005ec3e56080938d31a59b4db32fac983
#34736https://github.com/angular/angular/pull/34736
)https://github.com/angular/angular/commit/a4bbc35005ec3e56080938d31a59b4db32fac983
a4bbc35https://github.com/angular/angular/commit/a4bbc35005ec3e56080938d31a59b4db32fac983
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-aee67f0
https://github.com/gregmagolan
https://github.com/matsko
test: handle bootstrap templated_args in jasmine_node_test defaults.b…https://github.com/angular/angular/commit/aee67f08d93dc29666f3f90474bedec90ab32dda
aee67f0https://github.com/angular/angular/commit/aee67f08d93dc29666f3f90474bedec90ab32dda
#34736https://github.com/angular/angular/pull/34736
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-cc0f3c1
https://github.com/gregmagolan
https://github.com/matsko
test: keep diff in integration/bazel minimal by not introducing addit…https://github.com/angular/angular/commit/cc0f3c142296a1285cef96b5768c32bec56aa4a8
cc0f3c1https://github.com/angular/angular/commit/cc0f3c142296a1285cef96b5768c32bec56aa4a8
#34736https://github.com/angular/angular/pull/34736
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-e0827f2
https://github.com/gregmagolan
https://github.com/matsko
build: renamed "injected_scripts" target to "asset_injected_index_htm…https://github.com/angular/angular/commit/e0827f2ad5c3c00e06cce13015bc668f61b1047a
e0827f2https://github.com/angular/angular/commit/e0827f2ad5c3c00e06cce13015bc668f61b1047a
#34736https://github.com/angular/angular/pull/34736
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-81f6da1
https://github.com/gregmagolan
https://github.com/matsko
build: add a before-all-other bootstrap script that patches require (https://github.com/angular/angular/commit/81f6da173baa0f101bbcdb11ecf12689db9d96ec
#…https://github.com/angular/angular/pull/34736
81f6da1https://github.com/angular/angular/commit/81f6da173baa0f101bbcdb11ecf12689db9d96ec
…34736https://github.com/angular/angular/pull/34736
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-1e3f41b
https://github.com/gregmagolan
https://github.com/matsko
build: should use $(execpath) in npm_package_bin args (https://github.com/angular/angular/commit/1e3f41be8f82b2e9799e4a90b18bf963f3c391a3
#34736https://github.com/angular/angular/pull/34736
)https://github.com/angular/angular/commit/1e3f41be8f82b2e9799e4a90b18bf963f3c391a3
1e3f41bhttps://github.com/angular/angular/commit/1e3f41be8f82b2e9799e4a90b18bf963f3c391a3
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-a28c02b
https://github.com/gregmagolan
https://github.com/matsko
build: derive ts_library dep from jasmine_node_test boostrap label if…https://github.com/angular/angular/commit/a28c02bf898963859a5ae278412302bf1c0aa052
a28c02bhttps://github.com/angular/angular/commit/a28c02bf898963859a5ae278412302bf1c0aa052
#34736https://github.com/angular/angular/pull/34736
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-0b377bd
https://github.com/gregmagolan
https://github.com/matsko
build: add better comments to defaults.bzl jasmine_node_test macro (https://github.com/angular/angular/commit/0b377bd445a2a31e34c5166b4f42318ab10b45a7
#…https://github.com/angular/angular/pull/34736
0b377bdhttps://github.com/angular/angular/commit/0b377bd445a2a31e34c5166b4f42318ab10b45a7
…34736https://github.com/angular/angular/pull/34736
#34736https://github.com/angular/angular/pull/34736
matskohttps://github.com/matsko
Jan 15, 2020 https://github.com/angular/angular/pull/34736#ref-commit-e0601df
https://github.com/gregmagolan
https://github.com/matsko
build: cleanup //tools/ts-api-guardian:tests target (https://github.com/angular/angular/commit/e0601df59d153f570e5c23442ef5b4635c4041b2
#34736https://github.com/angular/angular/pull/34736
)https://github.com/angular/angular/commit/e0601df59d153f570e5c23442ef5b4635c4041b2
e0601dfhttps://github.com/angular/angular/commit/e0601df59d153f570e5c23442ef5b4635c4041b2
#34736https://github.com/angular/angular/pull/34736
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Feb 15, 2020https://github.com/angular/angular/pull/34736#issuecomment-586614073
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/34736
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34736
https://github.com/josephperrott
josephperrott https://github.com/josephperrott
https://github.com/angular/angular/pull/34736/files/9bcebacaf5c695c15c9cb2b2baa51af534f98f8c
https://github.com/IgorMinar
IgorMinar https://github.com/IgorMinar
Please reload this pagehttps://github.com/angular/angular/pull/34736
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: bazel https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20bazel%22
area: build & ci https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20build%20%26%20ci%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/34736
https://github.com/gregmagolan
https://github.com/josephperrott
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.