| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b422eb0a-6995-0645-775d-4ed1e44827ad |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A4B4:39BC20:E3DF9B:130A7B1:6AED49E5 |
| html-safe-nonce | 8aef00f04c99380a22ee86c376544adb0d01bdc9dd30e174e3e12e09a4e13f61 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEI0OjM5QkMyMDpFM0RGOUI6MTMwQTdCMTo2QUVENDlFNSIsInZpc2l0b3JfaWQiOiI1OTI5MTczNjAzNDEwODU2NDIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0817bad38a9467a938250e4b3bf69f44c3f8df93a536abb0705720644de999c0 |
| hovercard-subject-tag | pull_request:360022470 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34661/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4b596f1571e677d16be0f893fae3a2696f4780972a2e8058233df5763a0d4269/angular/angular/pull/34661 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4b596f1571e677d16be0f893fae3a2696f4780972a2e8058233df5763a0d4269/angular/angular/pull/34661 |
| og:image:alt | Consider a library that uses a shared constant for host bindings. e.g.
export const BASE_BINDINGS= {
'[class.mat-themed]': '_isThemed',
}
----
@Directive({
host: {...BASE_BIND... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | devversion |
| hostname | github.com |
| expected-hostname | github.com |
| None | 56fb42677ae87ed3e64410323d67980aa65d0485568a7858f874e7edfc6d1c11 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c9a37e2423ed382cf39f70b5aa4b4858b40a3b0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/34661#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34661 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34661 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/34661 |
| Reload | https://github.com/angular/angular/pull/34661 |
| Reload | https://github.com/angular/angular/pull/34661 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues847 (847) | https://github.com/angular/angular/issues |
| Pull requests180 (180) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality39 (39) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/pulse |
| https://github.com/angular/angular |
| devversion | https://github.com/devversion |
| angular:master | https://github.com/angular/angular/tree/master |
| devversion:fix/ngcc-libraries-transpiled-spread-object | https://github.com/devversion/angular/tree/fix/ngcc-libraries-transpiled-spread-object |
| Conversation | https://github.com/angular/angular/pull/34661 |
| Commits3 (3) | https://github.com/angular/angular/pull/34661/commits |
| Checks | https://github.com/angular/angular/pull/34661/checks |
| Files changed | https://github.com/angular/angular/pull/34661/files |
| fix(ngcc): libraries using spread in object literals cannot be processed | https://github.com/angular/angular/pull/34661#top |
| devversion | https://github.com/devversion |
| angular:master | https://github.com/angular/angular/tree/master |
| devversion:fix/ngcc-libraries-transpiled-spread-object | https://github.com/devversion/angular/tree/fix/ngcc-libraries-transpiled-spread-object |
|
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| Jan 7, 2020 | https://github.com/angular/angular/pull/34661#issue-546323557 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| #34659 | https://github.com/angular/angular/issues/34659 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Jan 7, 2020 | https://github.com/angular/angular/pull/34661#event-2927872584 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Jan 7, 2020 | https://github.com/angular/angular/pull/34661#event-2927873194 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
|
Jan 7, 2020
| https://github.com/angular/angular/pull/34661#pullrequestreview-339281580 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34661/files |
| packages/compiler-cli/src/ngtsc/partial_evaluator/src/interpreter.ts | https://github.com/angular/angular/pull/34661/files#diff-98cea8a12b382bb5d7c5d5d599a879b253adf3baa865dbc533fec578538980b9 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| force-pushed | https://github.com/angular/angular/compare/18bef0c566feb90372137aafba7551691b03c493..a73b0f84557187608b3e5513a492e983d200fe14 |
| 18bef0c | https://github.com/angular/angular/commit/18bef0c566feb90372137aafba7551691b03c493 |
| a73b0f8 | https://github.com/angular/angular/commit/a73b0f84557187608b3e5513a492e983d200fe14 |
|
Compare
| https://github.com/angular/angular/compare/18bef0c566feb90372137aafba7551691b03c493..a73b0f84557187608b3e5513a492e983d200fe14 |
| January 8, 2020 14:48 | https://github.com/angular/angular/pull/34661#event-2931446614 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
|
comp: ngcc
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Jan 8, 2020 | https://github.com/angular/angular/pull/34661#event-2932010282 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Jan 8, 2020 | https://github.com/angular/angular/pull/34661#event-2932010393 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Jan 8, 2020 | https://github.com/angular/angular/pull/34661#event-2932010622 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| January 8, 2020 17:04 | https://github.com/angular/angular/pull/34661#event-2932010743 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| January 8, 2020 17:04 | https://github.com/angular/angular/pull/34661#event-2932010765 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Jan 8, 2020
| https://github.com/angular/angular/pull/34661#pullrequestreview-340071525 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34661/files |
| gkalpak | https://github.com/gkalpak |
| https://github.com/angular/angular/pull/34661#pullrequestreview-340071525 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| BuiltinFn | https://github.com/angular/angular/blob/725148a44/packages/compiler-cli/src/ngtsc/partial_evaluator/src/result.ts#L56 |
| TsHelperFn | https://github.com/angular/angular/blob/725148a44/packages/compiler-cli/src/ngtsc/reflection/src/host.ts#L334 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| packages/compiler-cli/ngcc/src/analysis/spread_object_literal_support.ts | https://github.com/angular/angular/pull/34661/files#diff-c42bfcdb768c5239c6955e678509dac3b25531f17b8e24e23f6c2713349a3641 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| Jan 8, 2020 | https://github.com/angular/angular/pull/34661#issuecomment-572232443 |
| @gkalpak | https://github.com/gkalpak |
| accessHelper | https://github.com/angular/angular/blob/725148a44db896f919fc0b6d7e256dbc35af3ec6/packages/compiler-cli/src/ngtsc/partial_evaluator/src/interpreter.ts#L328 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Jan 8, 2020 | https://github.com/angular/angular/pull/34661#event-2932537477 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Jan 9, 2020 | https://github.com/angular/angular/pull/34661#issuecomment-572677710 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| force-pushed | https://github.com/angular/angular/compare/a73b0f84557187608b3e5513a492e983d200fe14..9ba275533e8f47b621bac9b9c21c44462afe7ea1 |
| a73b0f8 | https://github.com/angular/angular/commit/a73b0f84557187608b3e5513a492e983d200fe14 |
| 9ba2755 | https://github.com/angular/angular/commit/9ba275533e8f47b621bac9b9c21c44462afe7ea1 |
|
Compare
| https://github.com/angular/angular/compare/a73b0f84557187608b3e5513a492e983d200fe14..9ba275533e8f47b621bac9b9c21c44462afe7ea1 |
| January 9, 2020 19:37 | https://github.com/angular/angular/pull/34661#event-2936198050 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
Jan 9, 2020
| https://github.com/angular/angular/pull/34661#pullrequestreview-340798556 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34661/files |
| packages/compiler-cli/src/ngtsc/partial_evaluator/src/builtin.ts | https://github.com/angular/angular/pull/34661/files#diff-7a6d7eadd908c6a86ca94c99ecd83ed56dd5c6ebce80ed647756f4358b18b2a3 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| packages/compiler-cli/src/ngtsc/partial_evaluator/src/builtin.ts | https://github.com/angular/angular/pull/34661/files#diff-7a6d7eadd908c6a86ca94c99ecd83ed56dd5c6ebce80ed647756f4358b18b2a3 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| packages/compiler-cli/src/ngtsc/reflection/src/host.ts | https://github.com/angular/angular/pull/34661/files#diff-e7f1562798d174a4ababbfbf02ea86bd4c83efa846959878d56db221cc3dd389 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| packages/compiler-cli/src/ngtsc/partial_evaluator/test/utils.ts | https://github.com/angular/angular/pull/34661/files#diff-2de92addea3c5f49371022347061c7a6a2a57f2332c5d16cca4e9177f4bf32cd |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| packages/compiler-cli/src/ngtsc/partial_evaluator/test/evaluator_spec.ts | https://github.com/angular/angular/pull/34661/files#diff-c6c2f00ba140770ed45ec68adb15c6d80246277144625ef7793843e98063a829 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| packages/compiler-cli/src/ngtsc/partial_evaluator/src/builtin.ts | https://github.com/angular/angular/pull/34661/files#diff-7a6d7eadd908c6a86ca94c99ecd83ed56dd5c6ebce80ed647756f4358b18b2a3 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| force-pushed | https://github.com/angular/angular/compare/bf0d49bea261025a99d44571f62e415ab5171513..e8bb35a505459019e9f57d333fd3d4bb8fc28986 |
| bf0d49b | https://github.com/angular/angular/commit/bf0d49bea261025a99d44571f62e415ab5171513 |
| e8bb35a | https://github.com/angular/angular/commit/e8bb35a505459019e9f57d333fd3d4bb8fc28986 |
|
Compare
| https://github.com/angular/angular/compare/bf0d49bea261025a99d44571f62e415ab5171513..e8bb35a505459019e9f57d333fd3d4bb8fc28986 |
| January 12, 2020 12:39 | https://github.com/angular/angular/pull/34661#event-2941213249 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Jan 12, 2020 | https://github.com/angular/angular/pull/34661#event-2941231014 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| JoostK | https://github.com/JoostK |
| alxhub | https://github.com/alxhub |
| Jan 14, 2020 | https://github.com/angular/angular/pull/34661#event-2946035954 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Jan 14, 2020 | https://github.com/angular/angular/pull/34661#event-2946036388 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Jan 14, 2020
| https://github.com/angular/angular/pull/34661#pullrequestreview-342773419 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34661/files |
| packages/compiler-cli/ngcc/src/host/esm2015_host.ts | https://github.com/angular/angular/pull/34661/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| packages/compiler-cli/ngcc/src/host/esm2015_host.ts | https://github.com/angular/angular/pull/34661/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| packages/compiler-cli/ngcc/src/host/esm5_host.ts | https://github.com/angular/angular/pull/34661/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| packages/compiler-cli/src/ngtsc/partial_evaluator/test/utils.ts | https://github.com/angular/angular/pull/34661/files#diff-2de92addea3c5f49371022347061c7a6a2a57f2332c5d16cca4e9177f4bf32cd |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| force-pushed | https://github.com/angular/angular/compare/e8bb35a505459019e9f57d333fd3d4bb8fc28986..d56f55ec5384fba7777aff1696f25451499b1abc |
| e8bb35a | https://github.com/angular/angular/commit/e8bb35a505459019e9f57d333fd3d4bb8fc28986 |
| d56f55e | https://github.com/angular/angular/commit/d56f55ec5384fba7777aff1696f25451499b1abc |
|
Compare
| https://github.com/angular/angular/compare/e8bb35a505459019e9f57d333fd3d4bb8fc28986..d56f55ec5384fba7777aff1696f25451499b1abc |
| January 16, 2020 13:31 | https://github.com/angular/angular/pull/34661#event-2954537427 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| Jan 16, 2020 | https://github.com/angular/angular/pull/34661#issuecomment-575159883 |
| @gkalpak | https://github.com/gkalpak |
| @JoostK | https://github.com/JoostK |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Jan 16, 2020
| https://github.com/angular/angular/pull/34661#pullrequestreview-344199693 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34661/files |
| gkalpak | https://github.com/gkalpak |
| https://github.com/angular/angular/pull/34661#pullrequestreview-344199693 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @devversion | https://github.com/devversion |
| #34661 (comment) | https://github.com/angular/angular/pull/34661#discussion_r367637113 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Jan 16, 2020
| https://github.com/angular/angular/pull/34661#pullrequestreview-344206738 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34661/files |
| JoostK | https://github.com/JoostK |
| https://github.com/angular/angular/pull/34661#pullrequestreview-344206738 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Jan 17, 2020 | https://github.com/angular/angular/pull/34661#event-2958093099 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| Jan 17, 2020 | https://github.com/angular/angular/pull/34661#issuecomment-575621513 |
| @gkalpak | https://github.com/gkalpak |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Jan 17, 2020 | https://github.com/angular/angular/pull/34661#issuecomment-575659789 |
| #34661 (comment) | https://github.com/angular/angular/pull/34661#discussion_r367637113 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| Jan 20, 2020 | https://github.com/angular/angular/pull/34661#issuecomment-576176180 |
| @petebacondarwin | https://github.com/petebacondarwin |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
| Jan 20, 2020 | https://github.com/angular/angular/pull/34661#event-2962116875 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 20, 2020 | https://github.com/angular/angular/pull/34661#issuecomment-576177189 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| alxhub | https://github.com/alxhub |
| January 20, 2020 09:33 | https://github.com/angular/angular/pull/34661#event-2962210334 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
Jan 22, 2020
| https://github.com/angular/angular/pull/34661#pullrequestreview-346931249 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34661/files |
| packages/compiler-cli/src/ngtsc/partial_evaluator/src/known_declaration.ts | https://github.com/angular/angular/pull/34661/files#diff-af987f284e38a45beab26ab471df9a1644a9c4741ad01a4dcf66907fedc7cc4f |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Jan 22, 2020 | https://github.com/angular/angular/pull/34661#issuecomment-577407079 |
| Presubmit | http://test/OCL:291025335:BASE:291025371:1579730515280:5bc45ba7 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Jan 23, 2020 | https://github.com/angular/angular/pull/34661#issuecomment-577442928 |
| @devversion | https://github.com/devversion |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| devversion | https://github.com/devversion |
| January 23, 2020 09:23 | https://github.com/angular/angular/pull/34661#commits-pushed-59552ce |
|
| https://github.com/devversion |
| fix(ngcc): libraries using spread in object literals cannot be processed | https://github.com/angular/angular/pull/34661/commits/59552cef78da90b40b06984f09f6225aff9700b2 |
| 59552ce | https://github.com/angular/angular/pull/34661/commits/59552cef78da90b40b06984f09f6225aff9700b2 |
| @directive | https://github.com/directive |
| @directive | https://github.com/directive |
| angular#34659 | https://github.com/angular/angular/issues/34659 |
|
| https://github.com/devversion |
| fixup! fix(ngcc): libraries using spread in object literals cannot be… | https://github.com/angular/angular/pull/34661/commits/bb3d040d32986c9570218c06ae7f305c7c834081 |
| bb3d040 | https://github.com/angular/angular/pull/34661/commits/bb3d040d32986c9570218c06ae7f305c7c834081 |
|
| https://github.com/devversion |
| fixup! fix(ngcc): libraries using spread in object literals cannot be… | https://github.com/angular/angular/pull/34661/commits/24ee1842ad06850715634501f9b13d6e80fd323f |
| 24ee184 | https://github.com/angular/angular/pull/34661/commits/24ee1842ad06850715634501f9b13d6e80fd323f |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| force-pushed | https://github.com/angular/angular/compare/d56f55ec5384fba7777aff1696f25451499b1abc..24ee1842ad06850715634501f9b13d6e80fd323f |
| d56f55e | https://github.com/angular/angular/commit/d56f55ec5384fba7777aff1696f25451499b1abc |
| 24ee184 | https://github.com/angular/angular/commit/24ee1842ad06850715634501f9b13d6e80fd323f |
|
Compare
| https://github.com/angular/angular/compare/d56f55ec5384fba7777aff1696f25451499b1abc..24ee1842ad06850715634501f9b13d6e80fd323f |
| January 23, 2020 08:33 | https://github.com/angular/angular/pull/34661#event-2972850045 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| January 23, 2020 08:33 | https://github.com/angular/angular/pull/34661#event-2972850047 |
| https://github.com/devversion |
| devversion | https://github.com/devversion |
| Jan 23, 2020 | https://github.com/angular/angular/pull/34661#issuecomment-577578968 |
| @AndrewKushnir | https://github.com/AndrewKushnir |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Jan 23, 2020
| https://github.com/angular/angular/pull/34661#pullrequestreview-347222854 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34661/files/24ee1842ad06850715634501f9b13d6e80fd323f |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
| Jan 23, 2020 | https://github.com/angular/angular/pull/34661#event-2974732615 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| 6b468f9 | https://github.com/angular/angular/commit/6b468f9b2e4b99cd9e784c2515484bce47147476 |
| Jan 23, 2020 | https://github.com/angular/angular/pull/34661#event-2974796811 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Jan 23, 2020
| https://github.com/angular/angular/pull/34661#ref-commit-4eeb6cf |
|
| https://github.com/devversion |
|
| https://github.com/AndrewKushnir |
| fix(ngcc): libraries using spread in object literals cannot be proces… | https://github.com/angular/angular/commit/4eeb6cf24db74770eb0dc26e17e913e3f33ccaa3 |
| 4eeb6cf | https://github.com/angular/angular/commit/4eeb6cf24db74770eb0dc26e17e913e3f33ccaa3 |
| #34661 | https://github.com/angular/angular/pull/34661 |
| @directive | https://github.com/directive |
| @directive | https://github.com/directive |
| #34659 | https://github.com/angular/angular/issues/34659 |
| #34661 | https://github.com/angular/angular/pull/34661 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Feb 23, 2020 | https://github.com/angular/angular/pull/34661#issuecomment-590084783 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Feb 23, 2020 | https://github.com/angular/angular/pull/34661#event-3063519742 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34661 |
|
| https://github.com/JoostK |
|
JoostK
| https://github.com/JoostK |
|
| https://github.com/angular/angular/pull/34661/files/d56f55ec5384fba7777aff1696f25451499b1abc |
|
| https://github.com/alxhub |
|
alxhub
| https://github.com/alxhub |
|
| https://github.com/angular/angular/pull/34661/files/d56f55ec5384fba7777aff1696f25451499b1abc |
|
| https://github.com/petebacondarwin |
|
petebacondarwin
| https://github.com/petebacondarwin |
|
| https://github.com/angular/angular/pull/34661/files/e8bb35a505459019e9f57d333fd3d4bb8fc28986 |
|
| https://github.com/gkalpak |
|
gkalpak
| https://github.com/gkalpak |
|
| https://github.com/angular/angular/pull/34661/files/24ee1842ad06850715634501f9b13d6e80fd323f |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
|
| https://github.com/JoostK |
|
JoostK
| https://github.com/JoostK |
|
| https://github.com/alxhub |
|
alxhub
| https://github.com/alxhub |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
merge: caretaker note
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
v9.x-candidates
| https://github.com/angular/angular/milestone/89 |
|
ngcc: libraries using spread operator in object literals cannot be processed
| https://github.com/angular/angular/issues/34659 |
| Please reload this page | https://github.com/angular/angular/pull/34661 |
|
| https://github.com/devversion |
|
| https://github.com/gkalpak |
|
| https://github.com/petebacondarwin |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/JoostK |
|
| https://github.com/alxhub |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |