René's URL Explorer Experiment


Title: fix(ngcc): do not attempt compilation when analysis fails by JoostK · Pull Request #34652 · angular/angular · GitHub

Open Graph Title: fix(ngcc): do not attempt compilation when analysis fails by JoostK · Pull Request #34652 · angular/angular

X Title: fix(ngcc): do not attempt compilation when analysis fails by JoostK · Pull Request #34652 · angular/angular

Description: In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this model, any errors in one phase transition the trait into an error state, which prevents it from being ran through subsequent phases. The ngcc compiler on the other hand did not adopt this strict error model, which would cause incomplete metadata—due to errors in earlier phases—to be offered for compilation that could result in a hard crash. This commit changes ngcc so that it starts using ngtsc's Trait concept to track transitions between the analysis, resolve and compile phase much more explicitly. This approach makes it illegal to attempt the compile phase when either analysis or resolve has produced errors, avoiding the crash. Fixes #34500 Resolves FW-1788

Open Graph Description: In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this model, any errors in one phase transition the trait into an ...

X Description: In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this model, any errors in one phase transition the trait into an ...

Opengraph URL: https://github.com/angular/angular/pull/34652

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3b9a9425-592d-0375-65cf-d8b3c17a0927
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1F8:395430:150F602:1BCBFF3:6B01272D
html-safe-noncef60e8baa22a99c5d2346fae5c9d50f0e68cb2ae85f72d7e7ca780487340a55a2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUY4OjM5NTQzMDoxNTBGNjAyOjFCQ0JGRjM6NkIwMTI3MkQiLCJ2aXNpdG9yX2lkIjoiNTM1NDg1Njk1MDMyMjUwNTUxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf911bc52d6f1a2cc13eb2752c995f6b1cc5abcb6703a7371193b0b00b7b157d7
hovercard-subject-tagpull_request:359736319
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/34652/files
twitter:imagehttps://avatars.githubusercontent.com/u/123679?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/123679?s=400&v=4
og:image:altIn #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this model, any errors in one phase transition the trait into an ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/34652/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34652%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34652%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34652/files
Reloadhttps://github.com/angular/angular/pull/34652/files
Reloadhttps://github.com/angular/angular/pull/34652/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JoostKhttps://github.com/JoostK
angular:masterhttps://github.com/angular/angular/tree/master
JoostK:ngcc-fix-crash-when-erroredhttps://github.com/JoostK/angular/tree/ngcc-fix-crash-when-errored
Conversation 11 https://github.com/angular/angular/pull/34652
Commits 2 https://github.com/angular/angular/pull/34652/commits
Checks 0 https://github.com/angular/angular/pull/34652/checks
Files changed https://github.com/angular/angular/pull/34652/files
Please reload this pagehttps://github.com/angular/angular/pull/34652/files
fix(ngcc): do not attempt compilation when analysis fails https://github.com/angular/angular/pull/34652/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/34652/files
c0b6466 fix(ngcc): do not attempt compilation when analysis fails JoostK Jan 6, 2020 https://github.com/angular/angular/pull/34652/commits/c0b6466653df1bc6ca9f8f3b3e753ed1da96a4ea
fa482d2 fixup! fix(ngcc): do not attempt compilation when analysis fails JoostK Jan 14, 2020 https://github.com/angular/angular/pull/34652/commits/fa482d264afd95ed647abf901de0d50d1915da05
Clear filters https://github.com/angular/angular/pull/34652/files
Please reload this pagehttps://github.com/angular/angular/pull/34652/files
Please reload this pagehttps://github.com/angular/angular/pull/34652/files
decoration_analyzer.ts https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
migration_host.ts https://github.com/angular/angular/pull/34652/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc
types.ts https://github.com/angular/angular/pull/34652/files#diff-bde13171e54be2831f17f02cf579180847a01a88ca5fd64ed5f13f67b06ba6f3
util.ts https://github.com/angular/angular/pull/34652/files#diff-fb7c3d99903c107de38c7279e8ebc8e509ce181fedffb2920a19b6155ab6521d
decoration_analyzer_spec.ts https://github.com/angular/angular/pull/34652/files#diff-e8650a61025a99f4301da5b57cf1f46c788e761f40b54be2a8f0462addff4177
migration_host_spec.ts https://github.com/angular/angular/pull/34652/files#diff-ca4f1324dea02a65f9793d9ef0c0fe64ea20ab089a8c428f899ca7244e1c194b
index.ts https://github.com/angular/angular/pull/34652/files#diff-232ceaacaefb9dfc22e2b67b87ab2c309dc66611491115ea9ff753d4ed35d200
compilation.ts https://github.com/angular/angular/pull/34652/files#diff-5b07d44c0481be82108af4ee3fe5cae1f2f1bf98c657f266512b77b1c2dfef1b
packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.tshttps://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
View file https://github.com/JoostK/angular/blob/fa482d264afd95ed647abf901de0d50d1915da05/packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34652/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
petebacondarwinhttps://github.com/petebacondarwin
Jan 15, 2020https://github.com/angular/angular/pull/34652/files#r367100339
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34652/files
https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
packages/compiler-cli/ngcc/src/analysis/migration_host.tshttps://github.com/angular/angular/pull/34652/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc
View file https://github.com/JoostK/angular/blob/fa482d264afd95ed647abf901de0d50d1915da05/packages/compiler-cli/ngcc/src/analysis/migration_host.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34652/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34652/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc
https://github.com/angular/angular/pull/34652/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc
https://github.com/angular/angular/pull/34652/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc
https://github.com/angular/angular/pull/34652/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc
https://github.com/angular/angular/pull/34652/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc
https://github.com/angular/angular/pull/34652/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc
packages/compiler-cli/ngcc/src/analysis/types.tshttps://github.com/angular/angular/pull/34652/files#diff-bde13171e54be2831f17f02cf579180847a01a88ca5fd64ed5f13f67b06ba6f3
View file https://github.com/JoostK/angular/blob/fa482d264afd95ed647abf901de0d50d1915da05/packages/compiler-cli/ngcc/src/analysis/types.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34652/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34652/files#diff-bde13171e54be2831f17f02cf579180847a01a88ca5fd64ed5f13f67b06ba6f3
https://github.com/angular/angular/pull/34652/files#diff-bde13171e54be2831f17f02cf579180847a01a88ca5fd64ed5f13f67b06ba6f3
petebacondarwinhttps://github.com/petebacondarwin
Jan 7, 2020https://github.com/angular/angular/pull/34652/files#r363706149
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34652/files
JoostKhttps://github.com/JoostK
Jan 7, 2020https://github.com/angular/angular/pull/34652/files#r363709603
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34652/files
https://github.com/angular/angular/pull/34652/files#diff-bde13171e54be2831f17f02cf579180847a01a88ca5fd64ed5f13f67b06ba6f3
packages/compiler-cli/ngcc/src/analysis/util.tshttps://github.com/angular/angular/pull/34652/files#diff-fb7c3d99903c107de38c7279e8ebc8e509ce181fedffb2920a19b6155ab6521d
View file https://github.com/JoostK/angular/blob/fa482d264afd95ed647abf901de0d50d1915da05/packages/compiler-cli/ngcc/src/analysis/util.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34652/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34652/files#diff-fb7c3d99903c107de38c7279e8ebc8e509ce181fedffb2920a19b6155ab6521d
https://github.com/angular/angular/pull/34652/files#diff-fb7c3d99903c107de38c7279e8ebc8e509ce181fedffb2920a19b6155ab6521d
https://github.com/angular/angular/pull/34652/files#diff-fb7c3d99903c107de38c7279e8ebc8e509ce181fedffb2920a19b6155ab6521d
Please reload this pagehttps://github.com/angular/angular/pull/34652/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.