| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3b9a9425-592d-0375-65cf-d8b3c17a0927 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E1F8:395430:150F602:1BCBFF3:6B01272D |
| html-safe-nonce | f60e8baa22a99c5d2346fae5c9d50f0e68cb2ae85f72d7e7ca780487340a55a2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUY4OjM5NTQzMDoxNTBGNjAyOjFCQ0JGRjM6NkIwMTI3MkQiLCJ2aXNpdG9yX2lkIjoiNTM1NDg1Njk1MDMyMjUwNTUxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f911bc52d6f1a2cc13eb2752c995f6b1cc5abcb6703a7371193b0b00b7b157d7 |
| hovercard-subject-tag | pull_request:359736319 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/34652/files |
| twitter:image | https://avatars.githubusercontent.com/u/123679?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/123679?s=400&v=4 |
| og:image:alt | In #34288, ngtsc was refactored to separate the result of the analysis
and resolve phase for more granular incremental rebuilds. In this model,
any errors in one phase transition the trait into an ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/34652/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34652%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34652%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/34652/files |
| Reload | https://github.com/angular/angular/pull/34652/files |
| Reload | https://github.com/angular/angular/pull/34652/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| JoostK | https://github.com/JoostK |
| angular:master | https://github.com/angular/angular/tree/master |
| JoostK:ngcc-fix-crash-when-errored | https://github.com/JoostK/angular/tree/ngcc-fix-crash-when-errored |
|
Conversation
11
| https://github.com/angular/angular/pull/34652 |
|
Commits
2
| https://github.com/angular/angular/pull/34652/commits |
|
Checks
0
| https://github.com/angular/angular/pull/34652/checks |
|
Files changed
| https://github.com/angular/angular/pull/34652/files |
| Please reload this page | https://github.com/angular/angular/pull/34652/files |
|
fix(ngcc): do not attempt compilation when analysis fails
| https://github.com/angular/angular/pull/34652/files#top |
|
Show all changes
2 commits
| https://github.com/angular/angular/pull/34652/files |
|
c0b6466
fix(ngcc): do not attempt compilation when analysis fails
JoostK Jan 6, 2020
| https://github.com/angular/angular/pull/34652/commits/c0b6466653df1bc6ca9f8f3b3e753ed1da96a4ea |
|
fa482d2
fixup! fix(ngcc): do not attempt compilation when analysis fails
JoostK Jan 14, 2020
| https://github.com/angular/angular/pull/34652/commits/fa482d264afd95ed647abf901de0d50d1915da05 |
|
Clear filters
| https://github.com/angular/angular/pull/34652/files |
| Please reload this page | https://github.com/angular/angular/pull/34652/files |
| Please reload this page | https://github.com/angular/angular/pull/34652/files |
|
decoration_analyzer.ts
| https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
migration_host.ts
| https://github.com/angular/angular/pull/34652/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc |
|
types.ts
| https://github.com/angular/angular/pull/34652/files#diff-bde13171e54be2831f17f02cf579180847a01a88ca5fd64ed5f13f67b06ba6f3 |
|
util.ts
| https://github.com/angular/angular/pull/34652/files#diff-fb7c3d99903c107de38c7279e8ebc8e509ce181fedffb2920a19b6155ab6521d |
|
decoration_analyzer_spec.ts
| https://github.com/angular/angular/pull/34652/files#diff-e8650a61025a99f4301da5b57cf1f46c788e761f40b54be2a8f0462addff4177 |
|
migration_host_spec.ts
| https://github.com/angular/angular/pull/34652/files#diff-ca4f1324dea02a65f9793d9ef0c0fe64ea20ab089a8c428f899ca7244e1c194b |
|
index.ts
| https://github.com/angular/angular/pull/34652/files#diff-232ceaacaefb9dfc22e2b67b87ab2c309dc66611491115ea9ff753d4ed35d200 |
|
compilation.ts
| https://github.com/angular/angular/pull/34652/files#diff-5b07d44c0481be82108af4ee3fe5cae1f2f1bf98c657f266512b77b1c2dfef1b |
| packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.ts | https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
View file
| https://github.com/JoostK/angular/blob/fa482d264afd95ed647abf901de0d50d1915da05/packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/34652/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
| https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
| https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
| https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 15, 2020 | https://github.com/angular/angular/pull/34652/files#r367100339 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34652/files |
|
| https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
| https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
| https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
|
| https://github.com/angular/angular/pull/34652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
| packages/compiler-cli/ngcc/src/analysis/migration_host.ts | https://github.com/angular/angular/pull/34652/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc |
|
View file
| https://github.com/JoostK/angular/blob/fa482d264afd95ed647abf901de0d50d1915da05/packages/compiler-cli/ngcc/src/analysis/migration_host.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/34652/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/34652/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc |
|
| https://github.com/angular/angular/pull/34652/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc |
|
| https://github.com/angular/angular/pull/34652/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc |
|
| https://github.com/angular/angular/pull/34652/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc |
|
| https://github.com/angular/angular/pull/34652/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc |
|
| https://github.com/angular/angular/pull/34652/files#diff-3a5a12e1d0eaacfebe28b370d8e9e8273ac2b5cbd77257e99f3b9ba2744592cc |
| packages/compiler-cli/ngcc/src/analysis/types.ts | https://github.com/angular/angular/pull/34652/files#diff-bde13171e54be2831f17f02cf579180847a01a88ca5fd64ed5f13f67b06ba6f3 |
|
View file
| https://github.com/JoostK/angular/blob/fa482d264afd95ed647abf901de0d50d1915da05/packages/compiler-cli/ngcc/src/analysis/types.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/34652/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/34652/files#diff-bde13171e54be2831f17f02cf579180847a01a88ca5fd64ed5f13f67b06ba6f3 |
|
| https://github.com/angular/angular/pull/34652/files#diff-bde13171e54be2831f17f02cf579180847a01a88ca5fd64ed5f13f67b06ba6f3 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 7, 2020 | https://github.com/angular/angular/pull/34652/files#r363706149 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34652/files |
| JoostK | https://github.com/JoostK |
| Jan 7, 2020 | https://github.com/angular/angular/pull/34652/files#r363709603 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34652/files |
|
| https://github.com/angular/angular/pull/34652/files#diff-bde13171e54be2831f17f02cf579180847a01a88ca5fd64ed5f13f67b06ba6f3 |
| packages/compiler-cli/ngcc/src/analysis/util.ts | https://github.com/angular/angular/pull/34652/files#diff-fb7c3d99903c107de38c7279e8ebc8e509ce181fedffb2920a19b6155ab6521d |
|
View file
| https://github.com/JoostK/angular/blob/fa482d264afd95ed647abf901de0d50d1915da05/packages/compiler-cli/ngcc/src/analysis/util.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/34652/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/34652/files#diff-fb7c3d99903c107de38c7279e8ebc8e509ce181fedffb2920a19b6155ab6521d |
|
| https://github.com/angular/angular/pull/34652/files#diff-fb7c3d99903c107de38c7279e8ebc8e509ce181fedffb2920a19b6155ab6521d |
|
| https://github.com/angular/angular/pull/34652/files#diff-fb7c3d99903c107de38c7279e8ebc8e509ce181fedffb2920a19b6155ab6521d |
| Please reload this page | https://github.com/angular/angular/pull/34652/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |