| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2bf847ce-9ae2-e7e4-73d1-9b200d4c20b2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E6D8:20AA01:155B4BD:1B3A090:6B011C4D |
| html-safe-nonce | 872067071f17c46bc21ebb64cd06c170d575374c88867eeb501333ae2312a0f4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkQ4OjIwQUEwMToxNTVCNEJEOjFCM0EwOTA6NkIwMTFDNEQiLCJ2aXNpdG9yX2lkIjoiMTQ2NjIyMzI2MDIyMjk1NDU3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a865d9a4c0619d6ed882e4e6a2e00180b90c1aa35a024c6924106f3c8c2f386c |
| hovercard-subject-tag | pull_request:359736319 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34652/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/29300e9f41bf3e6e788e0bff64d13d1f2e37bf8265c60a3232688a333168d373/angular/angular/pull/34652 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/29300e9f41bf3e6e788e0bff64d13d1f2e37bf8265c60a3232688a333168d373/angular/angular/pull/34652 |
| og:image:alt | In #34288, ngtsc was refactored to separate the result of the analysis
and resolve phase for more granular incremental rebuilds. In this model,
any errors in one phase transition the trait into an ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JoostK |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/34652#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34652 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34652 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/34652 |
| Reload | https://github.com/angular/angular/pull/34652 |
| Reload | https://github.com/angular/angular/pull/34652 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| JoostK | https://github.com/JoostK |
| angular:master | https://github.com/angular/angular/tree/master |
| JoostK:ngcc-fix-crash-when-errored | https://github.com/JoostK/angular/tree/ngcc-fix-crash-when-errored |
| Conversation | https://github.com/angular/angular/pull/34652 |
| Commits2 (2) | https://github.com/angular/angular/pull/34652/commits |
| Checks | https://github.com/angular/angular/pull/34652/checks |
| Files changed | https://github.com/angular/angular/pull/34652/files |
| fix(ngcc): do not attempt compilation when analysis fails | https://github.com/angular/angular/pull/34652#top |
| JoostK | https://github.com/JoostK |
| angular:master | https://github.com/angular/angular/tree/master |
| JoostK:ngcc-fix-crash-when-errored | https://github.com/JoostK/angular/tree/ngcc-fix-crash-when-errored |
|
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| Jan 6, 2020 | https://github.com/angular/angular/pull/34652#issue-545967616 |
| #34288 | https://github.com/angular/angular/pull/34288 |
| #34500 | https://github.com/angular/angular/issues/34500 |
| Please reload this page | https://github.com/angular/angular/pull/34652 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
severity3: broken
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Jan 6, 2020 | https://github.com/angular/angular/pull/34652#event-2925756895 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Jan 6, 2020 | https://github.com/angular/angular/pull/34652#event-2925756986 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Jan 6, 2020 | https://github.com/angular/angular/pull/34652#event-2925757045 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Jan 6, 2020 | https://github.com/angular/angular/pull/34652#event-2925757047 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| January 7, 2020 10:18 | https://github.com/angular/angular/pull/34652#event-2927118243 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Jan 7, 2020
| https://github.com/angular/angular/pull/34652#pullrequestreview-339180702 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34652/files |
| packages/compiler-cli/ngcc/src/analysis/types.ts | https://github.com/angular/angular/pull/34652/files#diff-bde13171e54be2831f17f02cf579180847a01a88ca5fd64ed5f13f67b06ba6f3 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 7, 2020 | https://github.com/angular/angular/pull/34652#discussion_r363706149 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34652 |
| JoostK | https://github.com/JoostK |
| Jan 7, 2020 | https://github.com/angular/angular/pull/34652#discussion_r363709603 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34652 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Jan 7, 2020
| https://github.com/angular/angular/pull/34652#pullrequestreview-339184363 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34652/files |
| packages/compiler-cli/ngcc/test/analysis/decoration_analyzer_spec.ts | https://github.com/angular/angular/pull/34652/files#diff-e8650a61025a99f4301da5b57cf1f46c788e761f40b54be2a8f0462addff4177 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 7, 2020 | https://github.com/angular/angular/pull/34652#discussion_r363709141 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34652 |
| JoostK | https://github.com/JoostK |
| Jan 7, 2020 | https://github.com/angular/angular/pull/34652#discussion_r363710399 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34652 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Jan 7, 2020
| https://github.com/angular/angular/pull/34652#pullrequestreview-339186259 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34652/files |
| packages/compiler-cli/ngcc/test/analysis/migration_host_spec.ts | https://github.com/angular/angular/pull/34652/files#diff-ca4f1324dea02a65f9793d9ef0c0fe64ea20ab089a8c428f899ca7244e1c194b |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 7, 2020 | https://github.com/angular/angular/pull/34652#discussion_r363710680 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34652 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 7, 2020 | https://github.com/angular/angular/pull/34652#issuecomment-571553804 |
| Please reload this page | https://github.com/angular/angular/pull/34652 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| Jan 8, 2020 | https://github.com/angular/angular/pull/34652#issuecomment-572298695 |
| Please reload this page | https://github.com/angular/angular/pull/34652 |
| @petebacondarwin | https://github.com/petebacondarwin |
| angular/packages/compiler-cli/ngcc/src/main.ts | https://github.com/angular/angular/blob/918d8c990904b35ba67ea60c4b985f22fab1e853/packages/compiler-cli/ngcc/src/main.ts#L263-L275 |
| 918d8c9 | https://github.com/angular/angular/commit/918d8c990904b35ba67ea60c4b985f22fab1e853 |
| Please reload this page | https://github.com/angular/angular/pull/34652 |
| JoostK | https://github.com/JoostK |
| January 14, 2020 21:43 | https://github.com/angular/angular/pull/34652#commits-pushed-c0b6466 |
|
| https://github.com/JoostK |
| fix(ngcc): do not attempt compilation when analysis fails | https://github.com/angular/angular/pull/34652/commits/c0b6466653df1bc6ca9f8f3b3e753ed1da96a4ea |
| c0b6466 | https://github.com/angular/angular/pull/34652/commits/c0b6466653df1bc6ca9f8f3b3e753ed1da96a4ea |
| angular#34288 | https://github.com/angular/angular/pull/34288 |
| angular#34500 | https://github.com/angular/angular/issues/34500 |
|
| https://github.com/JoostK |
| fixup! fix(ngcc): do not attempt compilation when analysis fails | https://github.com/angular/angular/pull/34652/commits/fa482d264afd95ed647abf901de0d50d1915da05 |
| fa482d2 | https://github.com/angular/angular/pull/34652/commits/fa482d264afd95ed647abf901de0d50d1915da05 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| force-pushed | https://github.com/angular/angular/compare/6aac5cd5a9921b75a350d0e0ec7deff5fe0dbc07..fa482d264afd95ed647abf901de0d50d1915da05 |
| 6aac5cd | https://github.com/angular/angular/commit/6aac5cd5a9921b75a350d0e0ec7deff5fe0dbc07 |
| fa482d2 | https://github.com/angular/angular/commit/fa482d264afd95ed647abf901de0d50d1915da05 |
|
Compare
| https://github.com/angular/angular/compare/6aac5cd5a9921b75a350d0e0ec7deff5fe0dbc07..fa482d264afd95ed647abf901de0d50d1915da05 |
| January 14, 2020 20:56 | https://github.com/angular/angular/pull/34652#event-2948598432 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| January 14, 2020 21:22 | https://github.com/angular/angular/pull/34652#event-2948674025 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| January 14, 2020 21:22 | https://github.com/angular/angular/pull/34652#event-2948674042 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Jan 15, 2020
| https://github.com/angular/angular/pull/34652#pullrequestreview-343512398 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34652/files/fa482d264afd95ed647abf901de0d50d1915da05 |
| petebacondarwin | https://github.com/petebacondarwin |
| https://github.com/angular/angular/pull/34652#pullrequestreview-343512398 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34652 |
| packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.ts | https://github.com/angular/angular/pull/34652/files/fa482d264afd95ed647abf901de0d50d1915da05#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674 |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 15, 2020 | https://github.com/angular/angular/pull/34652#discussion_r367100339 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34652 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Jan 17, 2020 | https://github.com/angular/angular/pull/34652#event-2957539760 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Jan 21, 2020
| https://github.com/angular/angular/pull/34652#ref-pullrequest-553200410 |
|
fix(ngcc): switch ngcc over to use the TraitCompiler
#34889
| https://github.com/angular/angular/pull/34889 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| Jan 23, 2020 | https://github.com/angular/angular/pull/34652#issuecomment-577810214 |
| #34889 | https://github.com/angular/angular/pull/34889 |
| Please reload this page | https://github.com/angular/angular/pull/34652 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| Jan 23, 2020 | https://github.com/angular/angular/pull/34652#event-2974784062 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Feb 23, 2020 | https://github.com/angular/angular/pull/34652#issuecomment-590084779 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/34652 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Feb 23, 2020 | https://github.com/angular/angular/pull/34652#event-3063519717 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| March 25, 2020 07:58 | https://github.com/angular/angular/pull/34652#event-3162851753 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34652 |
|
| https://github.com/petebacondarwin |
|
petebacondarwin
| https://github.com/petebacondarwin |
|
| https://github.com/angular/angular/pull/34652/files/fa482d264afd95ed647abf901de0d50d1915da05 |
| Please reload this page | https://github.com/angular/angular/pull/34652 |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
|
ngcc: packages that fail with errors causes a crash
| https://github.com/angular/angular/issues/34500 |
| Please reload this page | https://github.com/angular/angular/pull/34652 |
|
| https://github.com/JoostK |
|
| https://github.com/petebacondarwin |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |