René's URL Explorer Experiment


Title: fix(ngcc): do not attempt compilation when analysis fails by JoostK · Pull Request #34652 · angular/angular · GitHub

Open Graph Title: fix(ngcc): do not attempt compilation when analysis fails by JoostK · Pull Request #34652 · angular/angular

X Title: fix(ngcc): do not attempt compilation when analysis fails by JoostK · Pull Request #34652 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this model, any errors in one phase transition the trait into an ...

X Description: In #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this model, any errors in one phase transition the trait into an ...

Opengraph URL: https://github.com/angular/angular/pull/34652

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2bf847ce-9ae2-e7e4-73d1-9b200d4c20b2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE6D8:20AA01:155B4BD:1B3A090:6B011C4D
html-safe-nonce872067071f17c46bc21ebb64cd06c170d575374c88867eeb501333ae2312a0f4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkQ4OjIwQUEwMToxNTVCNEJEOjFCM0EwOTA6NkIwMTFDNEQiLCJ2aXNpdG9yX2lkIjoiMTQ2NjIyMzI2MDIyMjk1NDU3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca865d9a4c0619d6ed882e4e6a2e00180b90c1aa35a024c6924106f3c8c2f386c
hovercard-subject-tagpull_request:359736319
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34652/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/29300e9f41bf3e6e788e0bff64d13d1f2e37bf8265c60a3232688a333168d373/angular/angular/pull/34652
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/29300e9f41bf3e6e788e0bff64d13d1f2e37bf8265c60a3232688a333168d373/angular/angular/pull/34652
og:image:altIn #34288, ngtsc was refactored to separate the result of the analysis and resolve phase for more granular incremental rebuilds. In this model, any errors in one phase transition the trait into an ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJoostK
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/34652#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34652
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34652
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34652
Reloadhttps://github.com/angular/angular/pull/34652
Reloadhttps://github.com/angular/angular/pull/34652
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
JoostKhttps://github.com/JoostK
angular:masterhttps://github.com/angular/angular/tree/master
JoostK:ngcc-fix-crash-when-erroredhttps://github.com/JoostK/angular/tree/ngcc-fix-crash-when-errored
Conversationhttps://github.com/angular/angular/pull/34652
Commits2 (2)https://github.com/angular/angular/pull/34652/commits
Checkshttps://github.com/angular/angular/pull/34652/checks
Files changedhttps://github.com/angular/angular/pull/34652/files
fix(ngcc): do not attempt compilation when analysis failshttps://github.com/angular/angular/pull/34652#top
JoostKhttps://github.com/JoostK
angular:masterhttps://github.com/angular/angular/tree/master
JoostK:ngcc-fix-crash-when-erroredhttps://github.com/JoostK/angular/tree/ngcc-fix-crash-when-errored
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Jan 6, 2020https://github.com/angular/angular/pull/34652#issue-545967616
#34288https://github.com/angular/angular/pull/34288
#34500https://github.com/angular/angular/issues/34500
Please reload this pagehttps://github.com/angular/angular/pull/34652
https://github.com/JoostK
JoostKhttps://github.com/JoostK
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
severity3: broken https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Jan 6, 2020https://github.com/angular/angular/pull/34652#event-2925756895
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Jan 6, 2020https://github.com/angular/angular/pull/34652#event-2925756986
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jan 6, 2020https://github.com/angular/angular/pull/34652#event-2925757045
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Jan 6, 2020https://github.com/angular/angular/pull/34652#event-2925757047
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
January 7, 2020 10:18https://github.com/angular/angular/pull/34652#event-2927118243
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jan 7, 2020 https://github.com/angular/angular/pull/34652#pullrequestreview-339180702
View reviewed changes https://github.com/angular/angular/pull/34652/files
packages/compiler-cli/ngcc/src/analysis/types.tshttps://github.com/angular/angular/pull/34652/files#diff-bde13171e54be2831f17f02cf579180847a01a88ca5fd64ed5f13f67b06ba6f3
petebacondarwinhttps://github.com/petebacondarwin
Jan 7, 2020https://github.com/angular/angular/pull/34652#discussion_r363706149
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34652
JoostKhttps://github.com/JoostK
Jan 7, 2020https://github.com/angular/angular/pull/34652#discussion_r363709603
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34652
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jan 7, 2020 https://github.com/angular/angular/pull/34652#pullrequestreview-339184363
View reviewed changes https://github.com/angular/angular/pull/34652/files
packages/compiler-cli/ngcc/test/analysis/decoration_analyzer_spec.tshttps://github.com/angular/angular/pull/34652/files#diff-e8650a61025a99f4301da5b57cf1f46c788e761f40b54be2a8f0462addff4177
petebacondarwinhttps://github.com/petebacondarwin
Jan 7, 2020https://github.com/angular/angular/pull/34652#discussion_r363709141
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34652
JoostKhttps://github.com/JoostK
Jan 7, 2020https://github.com/angular/angular/pull/34652#discussion_r363710399
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34652
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jan 7, 2020 https://github.com/angular/angular/pull/34652#pullrequestreview-339186259
View reviewed changes https://github.com/angular/angular/pull/34652/files
packages/compiler-cli/ngcc/test/analysis/migration_host_spec.tshttps://github.com/angular/angular/pull/34652/files#diff-ca4f1324dea02a65f9793d9ef0c0fe64ea20ab089a8c428f899ca7244e1c194b
petebacondarwinhttps://github.com/petebacondarwin
Jan 7, 2020https://github.com/angular/angular/pull/34652#discussion_r363710680
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34652
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jan 7, 2020https://github.com/angular/angular/pull/34652#issuecomment-571553804
Please reload this pagehttps://github.com/angular/angular/pull/34652
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Jan 8, 2020https://github.com/angular/angular/pull/34652#issuecomment-572298695
Please reload this pagehttps://github.com/angular/angular/pull/34652
@petebacondarwinhttps://github.com/petebacondarwin
angular/packages/compiler-cli/ngcc/src/main.tshttps://github.com/angular/angular/blob/918d8c990904b35ba67ea60c4b985f22fab1e853/packages/compiler-cli/ngcc/src/main.ts#L263-L275
918d8c9https://github.com/angular/angular/commit/918d8c990904b35ba67ea60c4b985f22fab1e853
Please reload this pagehttps://github.com/angular/angular/pull/34652
JoostKhttps://github.com/JoostK
January 14, 2020 21:43https://github.com/angular/angular/pull/34652#commits-pushed-c0b6466
https://github.com/JoostK
fix(ngcc): do not attempt compilation when analysis failshttps://github.com/angular/angular/pull/34652/commits/c0b6466653df1bc6ca9f8f3b3e753ed1da96a4ea
c0b6466https://github.com/angular/angular/pull/34652/commits/c0b6466653df1bc6ca9f8f3b3e753ed1da96a4ea
angular#34288https://github.com/angular/angular/pull/34288
angular#34500https://github.com/angular/angular/issues/34500
https://github.com/JoostK
fixup! fix(ngcc): do not attempt compilation when analysis failshttps://github.com/angular/angular/pull/34652/commits/fa482d264afd95ed647abf901de0d50d1915da05
fa482d2https://github.com/angular/angular/pull/34652/commits/fa482d264afd95ed647abf901de0d50d1915da05
https://github.com/JoostK
JoostKhttps://github.com/JoostK
force-pushedhttps://github.com/angular/angular/compare/6aac5cd5a9921b75a350d0e0ec7deff5fe0dbc07..fa482d264afd95ed647abf901de0d50d1915da05
6aac5cdhttps://github.com/angular/angular/commit/6aac5cd5a9921b75a350d0e0ec7deff5fe0dbc07
fa482d2https://github.com/angular/angular/commit/fa482d264afd95ed647abf901de0d50d1915da05
Compare https://github.com/angular/angular/compare/6aac5cd5a9921b75a350d0e0ec7deff5fe0dbc07..fa482d264afd95ed647abf901de0d50d1915da05
January 14, 2020 20:56https://github.com/angular/angular/pull/34652#event-2948598432
https://github.com/JoostK
JoostKhttps://github.com/JoostK
January 14, 2020 21:22https://github.com/angular/angular/pull/34652#event-2948674025
https://github.com/JoostK
JoostKhttps://github.com/JoostK
January 14, 2020 21:22https://github.com/angular/angular/pull/34652#event-2948674042
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jan 15, 2020 https://github.com/angular/angular/pull/34652#pullrequestreview-343512398
View reviewed changes https://github.com/angular/angular/pull/34652/files/fa482d264afd95ed647abf901de0d50d1915da05
petebacondarwinhttps://github.com/petebacondarwin
https://github.com/angular/angular/pull/34652#pullrequestreview-343512398
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34652
packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.tshttps://github.com/angular/angular/pull/34652/files/fa482d264afd95ed647abf901de0d50d1915da05#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
petebacondarwinhttps://github.com/petebacondarwin
Jan 15, 2020https://github.com/angular/angular/pull/34652#discussion_r367100339
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34652
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Jan 17, 2020https://github.com/angular/angular/pull/34652#event-2957539760
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Jan 21, 2020 https://github.com/angular/angular/pull/34652#ref-pullrequest-553200410
fix(ngcc): switch ngcc over to use the TraitCompiler #34889 https://github.com/angular/angular/pull/34889
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Jan 23, 2020https://github.com/angular/angular/pull/34652#issuecomment-577810214
#34889https://github.com/angular/angular/pull/34889
Please reload this pagehttps://github.com/angular/angular/pull/34652
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Jan 23, 2020https://github.com/angular/angular/pull/34652#event-2974784062
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Feb 23, 2020https://github.com/angular/angular/pull/34652#issuecomment-590084779
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/34652
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Feb 23, 2020https://github.com/angular/angular/pull/34652#event-3063519717
https://github.com/JoostK
JoostKhttps://github.com/JoostK
March 25, 2020 07:58https://github.com/angular/angular/pull/34652#event-3162851753
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34652
https://github.com/petebacondarwin
petebacondarwin https://github.com/petebacondarwin
https://github.com/angular/angular/pull/34652/files/fa482d264afd95ed647abf901de0d50d1915da05
Please reload this pagehttps://github.com/angular/angular/pull/34652
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
ngcc: packages that fail with errors causes a crash https://github.com/angular/angular/issues/34500
Please reload this pagehttps://github.com/angular/angular/pull/34652
https://github.com/JoostK
https://github.com/petebacondarwin
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.