René's URL Explorer Experiment


Title: Fix nav focus active styles by sonukapoor · Pull Request #34634 · angular/angular · GitHub

Open Graph Title: Fix nav focus active styles by sonukapoor · Pull Request #34634 · angular/angular

X Title: Fix nav focus active styles by sonukapoor · Pull Request #34634 · angular/angular

Description: Fixes #33239 Improved focus styles for topnav and footer including visible color. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: #33239 What is the new behavior? Topnav: Footer: Does this PR introduce a breaking change? Yes No Other information This PR builds on top of #33255

Open Graph Description: Fixes #33239 Improved focus styles for topnav and footer including visible color. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelin...

X Description: Fixes #33239 Improved focus styles for topnav and footer including visible color. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelin...

Opengraph URL: https://github.com/angular/angular/pull/34634

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:803628f5-aa32-7fb5-21e4-4307dcefb01c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEBD2:2D2F2F:1C93EDE:248A1A7:6B01492D
html-safe-nonce4371639808a92a19d0bd57d6a69a22b13c89264dd66163e8e0eadbc3ae467aa4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkQyOjJEMkYyRjoxQzkzRURFOjI0OEExQTc6NkIwMTQ5MkQiLCJ2aXNpdG9yX2lkIjoiODM4ODM0NTc4MTE1NjkyMzY5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5e218e49a3b1d3900db25e8ad604de1a630fe191d3d3eba586ae650972a3f5f9
hovercard-subject-tagpull_request:359015130
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/34634/files
twitter:imagehttps://avatars.githubusercontent.com/u/59734?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/59734?s=400&v=4
og:image:altFixes #33239 Improved focus styles for topnav and footer including visible color. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelin...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/34634/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34634%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34634%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34634/files
Reloadhttps://github.com/angular/angular/pull/34634/files
Reloadhttps://github.com/angular/angular/pull/34634/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
sonukapoorhttps://github.com/sonukapoor
angular:masterhttps://github.com/angular/angular/tree/master
sonukapoor:fix-nav-focus-active-styleshttps://github.com/sonukapoor/angular/tree/fix-nav-focus-active-styles
Conversation 9 https://github.com/angular/angular/pull/34634
Commits 4 https://github.com/angular/angular/pull/34634/commits
Checks 0 https://github.com/angular/angular/pull/34634/checks
Files changed https://github.com/angular/angular/pull/34634/files
Please reload this pagehttps://github.com/angular/angular/pull/34634/files
Fix nav focus active styles https://github.com/angular/angular/pull/34634/files#top
Show all changes 4 commits https://github.com/angular/angular/pull/34634/files
9aeb274 fix(docs-infra): improve focus styles in topnav and footer sjtrimble Oct 18, 2019 https://github.com/angular/angular/pull/34634/commits/9aeb27489e2654b62cb88c4d4ec076a1f3f12f7f
6f9da12 fixup! fix(docs-infra): improve focus styles in topnav and footer sjtrimble Oct 18, 2019 https://github.com/angular/angular/pull/34634/commits/6f9da12e9a1238687d8fcf876224a9a6b72537e4
1cf604e fixup! fix(docs-infra): improve focus styles in topnav and footer sjtrimble Oct 18, 2019 https://github.com/angular/angular/pull/34634/commits/1cf604e35fb324d414bdc22901b03e0f11348221
1977441 fixup! fix(docs-infra): improve focus styles in topnav and footer sonukapoor Jan 18, 2020 https://github.com/angular/angular/pull/34634/commits/1977441ce3fa2e6cef3afd381a94c38a4219928e
Clear filters https://github.com/angular/angular/pull/34634/files
Please reload this pagehttps://github.com/angular/angular/pull/34634/files
Please reload this pagehttps://github.com/angular/angular/pull/34634/files
_typography.scss https://github.com/angular/angular/pull/34634/files#diff-c38c6f34bdf7e8661c3a5a07f3d8ea87ba4f1cbf961988ea9ef24f8020cef43e
_footer.scss https://github.com/angular/angular/pull/34634/files#diff-6ae287546ea0ad430da8f6e1968855bbb0d83dbf8de8474bd1a714efefb0a6f5
_marketing-layout.scss https://github.com/angular/angular/pull/34634/files#diff-2d372efdf11e90aad9bd396018db27e3880766032931720040c69a25c247466e
_sidenav.scss https://github.com/angular/angular/pull/34634/files#diff-ea8234f41aef43da3b7040106be6afe9d881fd51d3d453375230176ee4145c6e
_top-menu.scss https://github.com/angular/angular/pull/34634/files#diff-c4f72d4c4d5da4a0c1cfa79720a06929e26ae5604f7172dd939eb21dd21af888
_contributor.scss https://github.com/angular/angular/pull/34634/files#diff-a673d84e6d7e335d7cef51f9aadfbd530b6327bf63bef37e084e0714030bec19
_constants.scss https://github.com/angular/angular/pull/34634/files#diff-56cfda6e93e744ac3523807bce1df8aef54deb907dee3a90d7323bcd8f050239
scroll.e2e-spec.ts https://github.com/angular/angular/pull/34634/files#diff-44d8888fdd6166459ae58669369aa08305c7d206c1d0ec0bf7e0f3b30a55578a
aio/src/styles/0-base/_typography.scsshttps://github.com/angular/angular/pull/34634/files#diff-c38c6f34bdf7e8661c3a5a07f3d8ea87ba4f1cbf961988ea9ef24f8020cef43e
View file https://github.com/sonukapoor/angular/blob/1977441ce3fa2e6cef3afd381a94c38a4219928e/aio/src/styles/0-base/_typography.scss
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34634/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34634/files#diff-c38c6f34bdf7e8661c3a5a07f3d8ea87ba4f1cbf961988ea9ef24f8020cef43e
https://github.com/angular/angular/pull/34634/files#diff-c38c6f34bdf7e8661c3a5a07f3d8ea87ba4f1cbf961988ea9ef24f8020cef43e
aio/src/styles/1-layouts/_footer.scsshttps://github.com/angular/angular/pull/34634/files#diff-6ae287546ea0ad430da8f6e1968855bbb0d83dbf8de8474bd1a714efefb0a6f5
View file https://github.com/sonukapoor/angular/blob/1977441ce3fa2e6cef3afd381a94c38a4219928e/aio/src/styles/1-layouts/_footer.scss
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34634/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34634/files#diff-6ae287546ea0ad430da8f6e1968855bbb0d83dbf8de8474bd1a714efefb0a6f5
https://github.com/angular/angular/pull/34634/files#diff-6ae287546ea0ad430da8f6e1968855bbb0d83dbf8de8474bd1a714efefb0a6f5
https://github.com/angular/angular/pull/34634/files#diff-6ae287546ea0ad430da8f6e1968855bbb0d83dbf8de8474bd1a714efefb0a6f5
https://github.com/angular/angular/pull/34634/files#diff-6ae287546ea0ad430da8f6e1968855bbb0d83dbf8de8474bd1a714efefb0a6f5
aio/src/styles/1-layouts/_marketing-layout.scsshttps://github.com/angular/angular/pull/34634/files#diff-2d372efdf11e90aad9bd396018db27e3880766032931720040c69a25c247466e
View file https://github.com/sonukapoor/angular/blob/1977441ce3fa2e6cef3afd381a94c38a4219928e/aio/src/styles/1-layouts/_marketing-layout.scss
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34634/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34634/files#diff-2d372efdf11e90aad9bd396018db27e3880766032931720040c69a25c247466e
https://github.com/angular/angular/pull/34634/files#diff-2d372efdf11e90aad9bd396018db27e3880766032931720040c69a25c247466e
aio/src/styles/1-layouts/_sidenav.scsshttps://github.com/angular/angular/pull/34634/files#diff-ea8234f41aef43da3b7040106be6afe9d881fd51d3d453375230176ee4145c6e
View file https://github.com/sonukapoor/angular/blob/1977441ce3fa2e6cef3afd381a94c38a4219928e/aio/src/styles/1-layouts/_sidenav.scss
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34634/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34634/files#diff-ea8234f41aef43da3b7040106be6afe9d881fd51d3d453375230176ee4145c6e
https://github.com/angular/angular/pull/34634/files#diff-ea8234f41aef43da3b7040106be6afe9d881fd51d3d453375230176ee4145c6e
aio/src/styles/1-layouts/_top-menu.scsshttps://github.com/angular/angular/pull/34634/files#diff-c4f72d4c4d5da4a0c1cfa79720a06929e26ae5604f7172dd939eb21dd21af888
View file https://github.com/sonukapoor/angular/blob/1977441ce3fa2e6cef3afd381a94c38a4219928e/aio/src/styles/1-layouts/_top-menu.scss
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34634/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34634/files#diff-c4f72d4c4d5da4a0c1cfa79720a06929e26ae5604f7172dd939eb21dd21af888
https://github.com/angular/angular/pull/34634/files#diff-c4f72d4c4d5da4a0c1cfa79720a06929e26ae5604f7172dd939eb21dd21af888
https://github.com/angular/angular/pull/34634/files#diff-c4f72d4c4d5da4a0c1cfa79720a06929e26ae5604f7172dd939eb21dd21af888
https://github.com/angular/angular/pull/34634/files#diff-c4f72d4c4d5da4a0c1cfa79720a06929e26ae5604f7172dd939eb21dd21af888
https://github.com/angular/angular/pull/34634/files#diff-c4f72d4c4d5da4a0c1cfa79720a06929e26ae5604f7172dd939eb21dd21af888
https://github.com/angular/angular/pull/34634/files#diff-c4f72d4c4d5da4a0c1cfa79720a06929e26ae5604f7172dd939eb21dd21af888
https://github.com/angular/angular/pull/34634/files#diff-c4f72d4c4d5da4a0c1cfa79720a06929e26ae5604f7172dd939eb21dd21af888
https://github.com/angular/angular/pull/34634/files#diff-c4f72d4c4d5da4a0c1cfa79720a06929e26ae5604f7172dd939eb21dd21af888
https://github.com/angular/angular/pull/34634/files#diff-c4f72d4c4d5da4a0c1cfa79720a06929e26ae5604f7172dd939eb21dd21af888
aio/src/styles/2-modules/_contributor.scsshttps://github.com/angular/angular/pull/34634/files#diff-a673d84e6d7e335d7cef51f9aadfbd530b6327bf63bef37e084e0714030bec19
View file https://github.com/sonukapoor/angular/blob/1977441ce3fa2e6cef3afd381a94c38a4219928e/aio/src/styles/2-modules/_contributor.scss
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34634/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34634/files#diff-a673d84e6d7e335d7cef51f9aadfbd530b6327bf63bef37e084e0714030bec19
aio/src/styles/_constants.scsshttps://github.com/angular/angular/pull/34634/files#diff-56cfda6e93e744ac3523807bce1df8aef54deb907dee3a90d7323bcd8f050239
View file https://github.com/sonukapoor/angular/blob/1977441ce3fa2e6cef3afd381a94c38a4219928e/aio/src/styles/_constants.scss
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34634/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34634/files#diff-56cfda6e93e744ac3523807bce1df8aef54deb907dee3a90d7323bcd8f050239
https://github.com/angular/angular/pull/34634/files#diff-56cfda6e93e744ac3523807bce1df8aef54deb907dee3a90d7323bcd8f050239
aio/tests/e2e/src/scroll.e2e-spec.tshttps://github.com/angular/angular/pull/34634/files#diff-44d8888fdd6166459ae58669369aa08305c7d206c1d0ec0bf7e0f3b30a55578a
View file https://github.com/sonukapoor/angular/blob/1977441ce3fa2e6cef3afd381a94c38a4219928e/aio/tests/e2e/src/scroll.e2e-spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34634/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34634/files#diff-44d8888fdd6166459ae58669369aa08305c7d206c1d0ec0bf7e0f3b30a55578a
https://github.com/angular/angular/pull/34634/files#diff-44d8888fdd6166459ae58669369aa08305c7d206c1d0ec0bf7e0f3b30a55578a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.