René's URL Explorer Experiment


Title: feat(language-service): completions for output $event properties by ayazhafiz · Pull Request #34570 · angular/angular · GitHub

Open Graph Title: feat(language-service): completions for output $event properties by ayazhafiz · Pull Request #34570 · angular/angular

X Title: feat(language-service): completions for output $event properties by ayazhafiz · Pull Request #34570 · angular/angular

Description: This commit adds support for completions of properties on $event variables in bound outputs. This is the second major PR to support completions for $event variables (angular/vscode-ng-language-service#531). The final completion support that must be provided is for $event variables in bindings targeting DOM events, like (click). PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Feature Does this PR introduce a breaking change? Yes No

Open Graph Description: This commit adds support for completions of properties on $event variables in bound outputs. This is the second major PR to support completions for $event variables (angular/vscode-ng-language-serv...

X Description: This commit adds support for completions of properties on $event variables in bound outputs. This is the second major PR to support completions for $event variables (angular/vscode-ng-language-serv...

Opengraph URL: https://github.com/angular/angular/pull/34570

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7978bc82-59cf-4e90-4560-c70d22dffe36
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id930C:20AA01:21478B7:2A40955:6B015EBB
html-safe-nonce664cf8a84ae7a6568b22d6fba14c9cc67a9262f4e6d8dae09bc42937b714ffe4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzBDOjIwQUEwMToyMTQ3OEI3OjJBNDA5NTU6NkIwMTVFQkIiLCJ2aXNpdG9yX2lkIjoiMzY3OTEwMDk0ODAzNjc4MDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaced3b558eb2577ff7a901a4b4d28c53589539a4faf3afb056a3d13b499b07e26d
hovercard-subject-tagpull_request:357054570
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/34570/files
twitter:imagehttps://avatars.githubusercontent.com/u/20735482?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20735482?s=400&v=4
og:image:altThis commit adds support for completions of properties on $event variables in bound outputs. This is the second major PR to support completions for $event variables (angular/vscode-ng-language-serv...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/34570/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34570%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34570%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34570/files
Reloadhttps://github.com/angular/angular/pull/34570/files
Reloadhttps://github.com/angular/angular/pull/34570/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
ayazhafizhttps://github.com/ayazhafiz
angular:masterhttps://github.com/angular/angular/tree/master
ayazhafiz:i/$event-typehttps://github.com/ayazhafiz/angular/tree/i/%24event-type
Conversation 15 https://github.com/angular/angular/pull/34570
Commits 8 https://github.com/angular/angular/pull/34570/commits
Checks 0 https://github.com/angular/angular/pull/34570/checks
Files changed https://github.com/angular/angular/pull/34570/files
Please reload this pagehttps://github.com/angular/angular/pull/34570/files
feat(language-service): completions for output $event properties https://github.com/angular/angular/pull/34570/files#top
Show all changes 8 commits https://github.com/angular/angular/pull/34570/files
1b853ff feat(language-service): provide completion for $event variable ayazhafiz Dec 26, 2019 https://github.com/angular/angular/pull/34570/commits/1b853ffd0d25621a823f86e6c553abeff5c8036c
a75b215 feat(language-service): completions for output $event properties in ayazhafiz Dec 26, 2019 https://github.com/angular/angular/pull/34570/commits/a75b215a4e62be33e0a11b89fcd02c97b7578468
c925ae6 fixup! feat(language-service): completions for output $event properti… ayazhafiz Jan 18, 2020 https://github.com/angular/angular/pull/34570/commits/c925ae66cbaf96d63f09737bce7ddee514dbe771
b796300 fixup! feat(language-service): completions for output $event properti… ayazhafiz Jan 18, 2020 https://github.com/angular/angular/pull/34570/commits/b7963001051e410e940e35612fa60d88eb5839e8
6ce57fb fixup! feat(language-service): completions for output $event properti… ayazhafiz Jan 23, 2020 https://github.com/angular/angular/pull/34570/commits/6ce57fb9a0ac10edc25dad24b05879a5ff7b6fc1
bcd5883 fixup! feat(language-service): completions for output $event properti… Jan 24, 2020 https://github.com/angular/angular/pull/34570/commits/bcd58832aa7361c944f581d32788b74b1ecbd4f4
6ffd523 fixup! feat(language-service): completions for output $event properti… Jan 27, 2020 https://github.com/angular/angular/pull/34570/commits/6ffd523b2d078d9c8c89b309a415e0b7f1fc97d3
2b0175b fixup! feat(language-service): completions for output $event properti… Jan 28, 2020 https://github.com/angular/angular/pull/34570/commits/2b0175b7b3c0518b680833fc4529d47f4890e177
Clear filters https://github.com/angular/angular/pull/34570/files
Please reload this pagehttps://github.com/angular/angular/pull/34570/files
Please reload this pagehttps://github.com/angular/angular/pull/34570/files
expression_diagnostics.ts https://github.com/angular/angular/pull/34570/files#diff-74b0efc8090d579160c144864b333a79c85aeb4c50a39bc3d3a3b703300e84e4
locate_symbol.ts https://github.com/angular/angular/pull/34570/files#diff-4d56f03e4585b313cea9c364391d5613e6160e754e524d9587869a53ccdccc60
utils.ts https://github.com/angular/angular/pull/34570/files#diff-c78608405ed7a0f5cdd6df74cfe33f6670f8a5823333f56b6013178e05bf0efa
completions_spec.ts https://github.com/angular/angular/pull/34570/files#diff-46255867be28be9ac4aaef9c7125581359b3bd7b110371e66e666f7a38412b0f
diagnostics_spec.ts https://github.com/angular/angular/pull/34570/files#diff-7396fe021199d0f680d4548241314d6aa4c340ca734e7a18b332c98c178ad42e
packages/language-service/src/expression_diagnostics.tshttps://github.com/angular/angular/pull/34570/files#diff-74b0efc8090d579160c144864b333a79c85aeb4c50a39bc3d3a3b703300e84e4
View file https://github.com/ayazhafiz/angular/blob/2b0175b7b3c0518b680833fc4529d47f4890e177/packages/language-service/src/expression_diagnostics.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34570/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34570/files#diff-74b0efc8090d579160c144864b333a79c85aeb4c50a39bc3d3a3b703300e84e4
https://github.com/angular/angular/pull/34570/files#diff-74b0efc8090d579160c144864b333a79c85aeb4c50a39bc3d3a3b703300e84e4
https://github.com/angular/angular/pull/34570/files#diff-74b0efc8090d579160c144864b333a79c85aeb4c50a39bc3d3a3b703300e84e4
Please reload this pagehttps://github.com/angular/angular/pull/34570/files
https://github.com/angular/angular/pull/34570/files#diff-74b0efc8090d579160c144864b333a79c85aeb4c50a39bc3d3a3b703300e84e4
packages/language-service/src/locate_symbol.tshttps://github.com/angular/angular/pull/34570/files#diff-4d56f03e4585b313cea9c364391d5613e6160e754e524d9587869a53ccdccc60
View file https://github.com/ayazhafiz/angular/blob/2b0175b7b3c0518b680833fc4529d47f4890e177/packages/language-service/src/locate_symbol.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34570/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34570/files#diff-4d56f03e4585b313cea9c364391d5613e6160e754e524d9587869a53ccdccc60
https://github.com/angular/angular/pull/34570/files#diff-4d56f03e4585b313cea9c364391d5613e6160e754e524d9587869a53ccdccc60
packages/language-service/src/utils.tshttps://github.com/angular/angular/pull/34570/files#diff-c78608405ed7a0f5cdd6df74cfe33f6670f8a5823333f56b6013178e05bf0efa
View file https://github.com/ayazhafiz/angular/blob/2b0175b7b3c0518b680833fc4529d47f4890e177/packages/language-service/src/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34570/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34570/files#diff-c78608405ed7a0f5cdd6df74cfe33f6670f8a5823333f56b6013178e05bf0efa
https://github.com/angular/angular/pull/34570/files#diff-c78608405ed7a0f5cdd6df74cfe33f6670f8a5823333f56b6013178e05bf0efa
https://github.com/angular/angular/pull/34570/files#diff-c78608405ed7a0f5cdd6df74cfe33f6670f8a5823333f56b6013178e05bf0efa
https://github.com/angular/angular/pull/34570/files#diff-c78608405ed7a0f5cdd6df74cfe33f6670f8a5823333f56b6013178e05bf0efa
packages/language-service/test/completions_spec.tshttps://github.com/angular/angular/pull/34570/files#diff-46255867be28be9ac4aaef9c7125581359b3bd7b110371e66e666f7a38412b0f
View file https://github.com/ayazhafiz/angular/blob/2b0175b7b3c0518b680833fc4529d47f4890e177/packages/language-service/test/completions_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34570/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34570/files#diff-46255867be28be9ac4aaef9c7125581359b3bd7b110371e66e666f7a38412b0f
https://github.com/angular/angular/pull/34570/files#diff-46255867be28be9ac4aaef9c7125581359b3bd7b110371e66e666f7a38412b0f
packages/language-service/test/diagnostics_spec.tshttps://github.com/angular/angular/pull/34570/files#diff-7396fe021199d0f680d4548241314d6aa4c340ca734e7a18b332c98c178ad42e
View file https://github.com/ayazhafiz/angular/blob/2b0175b7b3c0518b680833fc4529d47f4890e177/packages/language-service/test/diagnostics_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34570/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34570/files#diff-7396fe021199d0f680d4548241314d6aa4c340ca734e7a18b332c98c178ad42e
https://github.com/angular/angular/pull/34570/files#diff-7396fe021199d0f680d4548241314d6aa4c340ca734e7a18b332c98c178ad42e
https://github.com/angular/angular/pull/34570/files#diff-7396fe021199d0f680d4548241314d6aa4c340ca734e7a18b332c98c178ad42e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.