René's URL Explorer Experiment


Title: fix(ngcc): do not add trailing commas in UMD imports by gkalpak · Pull Request #34545 · angular/angular · GitHub

Open Graph Title: fix(ngcc): do not add trailing commas in UMD imports by gkalpak · Pull Request #34545 · angular/angular

X Title: fix(ngcc): do not add trailing commas in UMD imports by gkalpak · Pull Request #34545 · angular/angular

Description: Previously, if UmdRenderingFormatter#addImports() was called with an empty list of imports to add (i.e. no new imports were needed), it would add trailing commas in several locations (arrays, function arguments, function parameters), thus making the code imcompatible with legacy browsers such as IE11. This commit fixes it by ensuring that no trailing commas are added if addImports() is called with an empty list of imports. This is a follow-up to #34353. Fixes #34525.

Open Graph Description: Previously, if UmdRenderingFormatter#addImports() was called with an empty list of imports to add (i.e. no new imports were needed), it would add trailing commas in several locations (arrays, funct...

X Description: Previously, if UmdRenderingFormatter#addImports() was called with an empty list of imports to add (i.e. no new imports were needed), it would add trailing commas in several locations (arrays, funct...

Opengraph URL: https://github.com/angular/angular/pull/34545

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6e669cc4-75f0-7122-f928-2041d8aa42d8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD4C:14F601:2165695:2A6D1BC:6B015CC1
html-safe-nonce7e135d4fe77bc455562a47210dcf4b9ed4aedef5b111edfd4bf88d8cdab3d609
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDRDOjE0RjYwMToyMTY1Njk1OjJBNkQxQkM6NkIwMTVDQzEiLCJ2aXNpdG9yX2lkIjoiNDQ3NTA4NTE5MDk2Mzc0ODAzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfa2c57024dc354c7e9712eae497d30315352f8e9322466f93ef642c6273881e3
hovercard-subject-tagpull_request:356365473
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/34545/files
twitter:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
og:image:altPreviously, if UmdRenderingFormatter#addImports() was called with an empty list of imports to add (i.e. no new imports were needed), it would add trailing commas in several locations (arrays, funct...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/34545/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34545%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34545%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34545/files
Reloadhttps://github.com/angular/angular/pull/34545/files
Reloadhttps://github.com/angular/angular/pull/34545/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-ngcc-umd-no-importshttps://github.com/gkalpak/angular/tree/fix-ngcc-umd-no-imports
Conversation 5 https://github.com/angular/angular/pull/34545
Commits 2 https://github.com/angular/angular/pull/34545/commits
Checks 0 https://github.com/angular/angular/pull/34545/checks
Files changed https://github.com/angular/angular/pull/34545/files
Please reload this pagehttps://github.com/angular/angular/pull/34545/files
fix(ngcc): do not add trailing commas in UMD imports https://github.com/angular/angular/pull/34545/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/34545/files
0e6f183 fix(ngcc): do not add trailing commas in UMD imports gkalpak Dec 23, 2019 https://github.com/angular/angular/pull/34545/commits/0e6f183f3123ef2d7fa1d5548a21757432dd98c1
c20cc4f fixup! fix(ngcc): do not add trailing commas in UMD imports gkalpak Dec 23, 2019 https://github.com/angular/angular/pull/34545/commits/c20cc4fb09dab4e915dc9100760f86c7b4bce57f
Clear filters https://github.com/angular/angular/pull/34545/files
Please reload this pagehttps://github.com/angular/angular/pull/34545/files
Please reload this pagehttps://github.com/angular/angular/pull/34545/files
test.sh https://github.com/angular/angular/pull/34545/files#diff-54b4c35645c846047e48b8b463846c17ff9649900407cd6d565c563ace86ce63
commonjs_rendering_formatter.ts https://github.com/angular/angular/pull/34545/files#diff-b3a5f86d61a3a770df347d28c14fae70065ff0b3083935998592977c09ce508c
esm_rendering_formatter.ts https://github.com/angular/angular/pull/34545/files#diff-a7ce6285a47dfe55b18d33cb40b7b18d1e71a6e4e7adce0045a23e427b8cacb7
umd_rendering_formatter.ts https://github.com/angular/angular/pull/34545/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5
commonjs_rendering_formatter_spec.ts https://github.com/angular/angular/pull/34545/files#diff-2ceff9c84e6c94d41403567d69981875cc771b138c8d9f9ef185c7bc03e24e57
esm5_rendering_formatter_spec.ts https://github.com/angular/angular/pull/34545/files#diff-8ff836bc6f3de0d1a50c5b56d7475691f06603629e2e37f0305ce905d3b3ce9c
esm_rendering_formatter_spec.ts https://github.com/angular/angular/pull/34545/files#diff-92c6090cd33562162301a9ee259408a6f49e8f522b171164de293a36f901fece
umd_rendering_formatter_spec.ts https://github.com/angular/angular/pull/34545/files#diff-f314ca24a8682553ae5f18fa3ffad03f482fd8757f52c3c4b8dcc0560039862e
integration/ngcc/test.shhttps://github.com/angular/angular/pull/34545/files#diff-54b4c35645c846047e48b8b463846c17ff9649900407cd6d565c563ace86ce63
View file https://github.com/gkalpak/angular/blob/c20cc4fb09dab4e915dc9100760f86c7b4bce57f/integration/ngcc/test.sh
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34545/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34545/files#diff-54b4c35645c846047e48b8b463846c17ff9649900407cd6d565c563ace86ce63
https://github.com/angular/angular/pull/34545/files#diff-54b4c35645c846047e48b8b463846c17ff9649900407cd6d565c563ace86ce63
packages/compiler-cli/ngcc/src/rendering/commonjs_rendering_formatter.tshttps://github.com/angular/angular/pull/34545/files#diff-b3a5f86d61a3a770df347d28c14fae70065ff0b3083935998592977c09ce508c
View file https://github.com/gkalpak/angular/blob/c20cc4fb09dab4e915dc9100760f86c7b4bce57f/packages/compiler-cli/ngcc/src/rendering/commonjs_rendering_formatter.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34545/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34545/files#diff-b3a5f86d61a3a770df347d28c14fae70065ff0b3083935998592977c09ce508c
Please reload this pagehttps://github.com/angular/angular/pull/34545/files
https://github.com/angular/angular/pull/34545/files#diff-b3a5f86d61a3a770df347d28c14fae70065ff0b3083935998592977c09ce508c
packages/compiler-cli/ngcc/src/rendering/esm_rendering_formatter.tshttps://github.com/angular/angular/pull/34545/files#diff-a7ce6285a47dfe55b18d33cb40b7b18d1e71a6e4e7adce0045a23e427b8cacb7
View file https://github.com/gkalpak/angular/blob/c20cc4fb09dab4e915dc9100760f86c7b4bce57f/packages/compiler-cli/ngcc/src/rendering/esm_rendering_formatter.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34545/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34545/files#diff-a7ce6285a47dfe55b18d33cb40b7b18d1e71a6e4e7adce0045a23e427b8cacb7
https://github.com/angular/angular/pull/34545/files#diff-a7ce6285a47dfe55b18d33cb40b7b18d1e71a6e4e7adce0045a23e427b8cacb7
https://github.com/angular/angular/pull/34545/files#diff-a7ce6285a47dfe55b18d33cb40b7b18d1e71a6e4e7adce0045a23e427b8cacb7
packages/compiler-cli/ngcc/src/rendering/umd_rendering_formatter.tshttps://github.com/angular/angular/pull/34545/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5
View file https://github.com/gkalpak/angular/blob/c20cc4fb09dab4e915dc9100760f86c7b4bce57f/packages/compiler-cli/ngcc/src/rendering/umd_rendering_formatter.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34545/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34545/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5
https://github.com/angular/angular/pull/34545/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5
packages/compiler-cli/ngcc/test/rendering/commonjs_rendering_formatter_spec.tshttps://github.com/angular/angular/pull/34545/files#diff-2ceff9c84e6c94d41403567d69981875cc771b138c8d9f9ef185c7bc03e24e57
View file https://github.com/gkalpak/angular/blob/c20cc4fb09dab4e915dc9100760f86c7b4bce57f/packages/compiler-cli/ngcc/test/rendering/commonjs_rendering_formatter_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34545/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34545/files#diff-2ceff9c84e6c94d41403567d69981875cc771b138c8d9f9ef185c7bc03e24e57
https://github.com/angular/angular/pull/34545/files#diff-2ceff9c84e6c94d41403567d69981875cc771b138c8d9f9ef185c7bc03e24e57
packages/compiler-cli/ngcc/test/rendering/esm5_rendering_formatter_spec.tshttps://github.com/angular/angular/pull/34545/files#diff-8ff836bc6f3de0d1a50c5b56d7475691f06603629e2e37f0305ce905d3b3ce9c
View file https://github.com/gkalpak/angular/blob/c20cc4fb09dab4e915dc9100760f86c7b4bce57f/packages/compiler-cli/ngcc/test/rendering/esm5_rendering_formatter_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34545/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34545/files#diff-8ff836bc6f3de0d1a50c5b56d7475691f06603629e2e37f0305ce905d3b3ce9c
https://github.com/angular/angular/pull/34545/files#diff-8ff836bc6f3de0d1a50c5b56d7475691f06603629e2e37f0305ce905d3b3ce9c
packages/compiler-cli/ngcc/test/rendering/esm_rendering_formatter_spec.tshttps://github.com/angular/angular/pull/34545/files#diff-92c6090cd33562162301a9ee259408a6f49e8f522b171164de293a36f901fece
View file https://github.com/gkalpak/angular/blob/c20cc4fb09dab4e915dc9100760f86c7b4bce57f/packages/compiler-cli/ngcc/test/rendering/esm_rendering_formatter_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34545/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34545/files#diff-92c6090cd33562162301a9ee259408a6f49e8f522b171164de293a36f901fece
https://github.com/angular/angular/pull/34545/files#diff-92c6090cd33562162301a9ee259408a6f49e8f522b171164de293a36f901fece
packages/compiler-cli/ngcc/test/rendering/umd_rendering_formatter_spec.tshttps://github.com/angular/angular/pull/34545/files#diff-f314ca24a8682553ae5f18fa3ffad03f482fd8757f52c3c4b8dcc0560039862e
View file https://github.com/gkalpak/angular/blob/c20cc4fb09dab4e915dc9100760f86c7b4bce57f/packages/compiler-cli/ngcc/test/rendering/umd_rendering_formatter_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34545/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34545/files#diff-f314ca24a8682553ae5f18fa3ffad03f482fd8757f52c3c4b8dcc0560039862e
https://github.com/angular/angular/pull/34545/files#diff-f314ca24a8682553ae5f18fa3ffad03f482fd8757f52c3c4b8dcc0560039862e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.