René's URL Explorer Experiment


Title: fix(ngcc): do not add trailing commas in UMD imports by gkalpak · Pull Request #34545 · angular/angular · GitHub

Open Graph Title: fix(ngcc): do not add trailing commas in UMD imports by gkalpak · Pull Request #34545 · angular/angular

X Title: fix(ngcc): do not add trailing commas in UMD imports by gkalpak · Pull Request #34545 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Previously, if UmdRenderingFormatter#addImports() was called with an empty list of imports to add (i.e. no new imports were needed), it would add trailing commas in several locations (arrays, funct...

X Description: Previously, if UmdRenderingFormatter#addImports() was called with an empty list of imports to add (i.e. no new imports were needed), it would add trailing commas in several locations (arrays, funct...

Opengraph URL: https://github.com/angular/angular/pull/34545

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:05675094-18a4-6d82-b672-4fd4806bf9fc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB8A8:38E318:B559BE:E48B24:6B013046
html-safe-noncef8060eed3e21a51fbc2d1e29c268ee56f72161eb11dafb99e37935665b2334e0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOEE4OjM4RTMxODpCNTU5QkU6RTQ4QjI0OjZCMDEzMDQ2IiwidmlzaXRvcl9pZCI6IjQ1NTI3MDIwNDg5MzU2ODYyMTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf1a5fc00083ac371174f46f4f075ef4000204f72078d5ed8516ec7cb50595fa8
hovercard-subject-tagpull_request:356365473
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34545/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2d51c63bbca7f94f0a68be2705123ddbf8f59aa9bab243fc023c065427bcd4f2/angular/angular/pull/34545
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2d51c63bbca7f94f0a68be2705123ddbf8f59aa9bab243fc023c065427bcd4f2/angular/angular/pull/34545
og:image:altPreviously, if UmdRenderingFormatter#addImports() was called with an empty list of imports to add (i.e. no new imports were needed), it would add trailing commas in several locations (arrays, funct...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegkalpak
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/34545#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34545
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34545
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34545
Reloadhttps://github.com/angular/angular/pull/34545
Reloadhttps://github.com/angular/angular/pull/34545
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-ngcc-umd-no-importshttps://github.com/gkalpak/angular/tree/fix-ngcc-umd-no-imports
Conversationhttps://github.com/angular/angular/pull/34545
Commits2 (2)https://github.com/angular/angular/pull/34545/commits
Checkshttps://github.com/angular/angular/pull/34545/checks
Files changedhttps://github.com/angular/angular/pull/34545/files
fix(ngcc): do not add trailing commas in UMD importshttps://github.com/angular/angular/pull/34545#top
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-ngcc-umd-no-importshttps://github.com/gkalpak/angular/tree/fix-ngcc-umd-no-imports
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 23, 2019https://github.com/angular/angular/pull/34545#issue-541798618
#34353https://github.com/angular/angular/pull/34353
#34525https://github.com/angular/angular/issues/34525
Please reload this pagehttps://github.com/angular/angular/pull/34545
https://github.com/gkalpak
fix(ngcc): do not add trailing commas in UMD importshttps://github.com/angular/angular/pull/34545/commits/0e6f183f3123ef2d7fa1d5548a21757432dd98c1
0e6f183https://github.com/angular/angular/pull/34545/commits/0e6f183f3123ef2d7fa1d5548a21757432dd98c1
angular#34353https://github.com/angular/angular/pull/34353
angular#34525https://github.com/angular/angular/issues/34525
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Dec 23, 2019https://github.com/angular/angular/pull/34545#event-2905024243
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
comp: ngcc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Dec 23, 2019https://github.com/angular/angular/pull/34545#event-2905024900
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Dec 23, 2019https://github.com/angular/angular/pull/34545#event-2905024977
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Dec 23, 2019https://github.com/angular/angular/pull/34545#issuecomment-568505319
0e6f183https://github.com/angular/angular/commit/0e6f183f3123ef2d7fa1d5548a21757432dd98c1
https://pr34545-0e6f183.ngbuilds.io/https://pr34545-0e6f183.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/34545
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
Dec 23, 2019https://github.com/angular/angular/pull/34545#event-2905095318
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
December 23, 2019 15:56https://github.com/angular/angular/pull/34545#event-2905095614
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
December 23, 2019 15:56https://github.com/angular/angular/pull/34545#event-2905095623
https://github.com/gkalpak
fixup! fix(ngcc): do not add trailing commas in UMD importshttps://github.com/angular/angular/pull/34545/commits/c20cc4fb09dab4e915dc9100760f86c7b4bce57f
c20cc4fhttps://github.com/angular/angular/pull/34545/commits/c20cc4fb09dab4e915dc9100760f86c7b4bce57f
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Dec 23, 2019 https://github.com/angular/angular/pull/34545#pullrequestreview-335957370
View reviewed changes https://github.com/angular/angular/pull/34545/files/0e6f183f3123ef2d7fa1d5548a21757432dd98c1
packages/compiler-cli/ngcc/src/rendering/commonjs_rendering_formatter.tshttps://github.com/angular/angular/pull/34545/files/0e6f183f3123ef2d7fa1d5548a21757432dd98c1#diff-b3a5f86d61a3a770df347d28c14fae70065ff0b3083935998592977c09ce508c
Please reload this pagehttps://github.com/angular/angular/pull/34545
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Dec 23, 2019https://github.com/angular/angular/pull/34545#issuecomment-568569956
c20cc4fhttps://github.com/angular/angular/commit/c20cc4fb09dab4e915dc9100760f86c7b4bce57f
https://pr34545-c20cc4f.ngbuilds.io/https://pr34545-c20cc4f.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/34545
alxhubhttps://github.com/alxhub
Jan 7, 2020 https://github.com/angular/angular/pull/34545#ref-commit-e6850a3
https://github.com/gkalpak
https://github.com/alxhub
fix(ngcc): do not add trailing commas in UMD imports (https://github.com/angular/angular/commit/e6850a3c519846d2742f29707a910e977edd5997
#34545https://github.com/angular/angular/pull/34545
)https://github.com/angular/angular/commit/e6850a3c519846d2742f29707a910e977edd5997
e6850a3https://github.com/angular/angular/commit/e6850a3c519846d2742f29707a910e977edd5997
#34353https://github.com/angular/angular/pull/34353
#34525https://github.com/angular/angular/issues/34525
#34545https://github.com/angular/angular/pull/34545
https://github.com/alxhub
alxhubhttps://github.com/alxhub
10e2935https://github.com/angular/angular/commit/10e29355db1864ba89cf5695dfc9c1e4017afc98
Jan 7, 2020https://github.com/angular/angular/pull/34545#event-2928652925
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
January 8, 2020 10:57https://github.com/angular/angular/pull/34545#event-2930732320
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Feb 8, 2020https://github.com/angular/angular/pull/34545#issuecomment-583750206
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/34545
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Feb 8, 2020https://github.com/angular/angular/pull/34545#event-3019993602
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
IgorMinarhttps://github.com/IgorMinar
February 8, 2020 16:07https://github.com/angular/angular/pull/34545#event-3019993669
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34545
https://github.com/IgorMinar
IgorMinar https://github.com/IgorMinar
https://github.com/petebacondarwin
petebacondarwin https://github.com/petebacondarwin
https://github.com/angular/angular/pull/34545/files/0e6f183f3123ef2d7fa1d5548a21757432dd98c1
Please reload this pagehttps://github.com/angular/angular/pull/34545
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
ngcc: processed umd bundles fail with syntax errors in IE11 https://github.com/angular/angular/issues/34525
Please reload this pagehttps://github.com/angular/angular/pull/34545
https://github.com/gkalpak
https://github.com/mary-poppins
https://github.com/petebacondarwin
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.