| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d223bca3-cfa3-feee-c452-2450a88577ba |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C12E:D5AA4:1347CC7:19B72F8:6B011D2F |
| html-safe-nonce | 0d178ceabb06890ecbc4413bcb0ad67b2d33b13065ff93162906b54f01427f06 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTJFOkQ1QUE0OjEzNDdDQzc6MTlCNzJGODo2QjAxMUQyRiIsInZpc2l0b3JfaWQiOiI2MDc5MjcwNjE1Nzc5NDUwMTU5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f11ad723292becf5e3b5b1072f9c8ea45a3e9ec3dffd17a6b8f8027af67a86e1 |
| hovercard-subject-tag | pull_request:356053957 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34533/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2d51c63bbca7f94f0a68be2705123ddbf8f59aa9bab243fc023c065427bcd4f2/angular/angular/pull/34533 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2d51c63bbca7f94f0a68be2705123ddbf8f59aa9bab243fc023c065427bcd4f2/angular/angular/pull/34533 |
| og:image:alt | PR Checklist
Please check if your PR fulfills the following requirements:
The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests f... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JiaLiPassion |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/34533#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34533 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34533 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/34533 |
| Reload | https://github.com/angular/angular/pull/34533 |
| Reload | https://github.com/angular/angular/pull/34533 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| JiaLiPassion | https://github.com/JiaLiPassion |
| angular:master | https://github.com/angular/angular/tree/master |
| JiaLiPassion:promise-subclass | https://github.com/JiaLiPassion/angular/tree/promise-subclass |
| Conversation | https://github.com/angular/angular/pull/34533 |
| Commits1 (1) | https://github.com/angular/angular/pull/34533/commits |
| Checks | https://github.com/angular/angular/pull/34533/checks |
| Files changed | https://github.com/angular/angular/pull/34533/files |
| fix: should also allow subclass Promise without Symbol.species | https://github.com/angular/angular/pull/34533#top |
| JiaLiPassion | https://github.com/JiaLiPassion |
| angular:master | https://github.com/angular/angular/tree/master |
| JiaLiPassion:promise-subclass | https://github.com/JiaLiPassion/angular/tree/promise-subclass |
|
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
| Dec 22, 2019 | https://github.com/angular/angular/pull/34533#issue-541405381 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| #34162 | https://github.com/angular/angular/pull/34162 |
| #34162 | https://github.com/angular/angular/pull/34162 |
| #34162 | https://github.com/angular/angular/pull/34162 |
| Please reload this page | https://github.com/angular/angular/pull/34533 |
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
| mhevery | https://github.com/mhevery |
| December 22, 2019 04:18 | https://github.com/angular/angular/pull/34533#event-2903012371 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Dec 22, 2019 | https://github.com/angular/angular/pull/34533#event-2903012426 |
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
|
Dec 22, 2019
| https://github.com/angular/angular/pull/34533#ref-pullrequest-540821629 |
|
release: cut the zone.js-0.10.3 release
#34508
| https://github.com/angular/angular/pull/34508 |
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
|
area: zones
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22 |
| Dec 22, 2019 | https://github.com/angular/angular/pull/34533#event-2903013203 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Dec 22, 2019 | https://github.com/angular/angular/pull/34533#event-2903013212 |
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Dec 22, 2019 | https://github.com/angular/angular/pull/34533#event-2903030061 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
Jan 29, 2020
| https://github.com/angular/angular/pull/34533#pullrequestreview-350457796 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34533/files |
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Jan 30, 2020 | https://github.com/angular/angular/pull/34533#event-2991533866 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
| Jan 30, 2020 | https://github.com/angular/angular/pull/34533#event-2991578994 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Jan 30, 2020 | https://github.com/angular/angular/pull/34533#issuecomment-580028116 |
| Presubmit | http://test/OCL:292242490:BASE:292242531:1580344071503:56a28111 |
| Please reload this page | https://github.com/angular/angular/pull/34533 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Jan 30, 2020
| https://github.com/angular/angular/pull/34533#pullrequestreview-351183325 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34533/files |
| packages/zone.js/test/common/Promise.spec.ts | https://github.com/angular/angular/pull/34533/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42 |
| Please reload this page | https://github.com/angular/angular/pull/34533 |
| packages/zone.js/test/common/Promise.spec.ts | https://github.com/angular/angular/pull/34533/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42 |
| Please reload this page | https://github.com/angular/angular/pull/34533 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Jan 30, 2020 | https://github.com/angular/angular/pull/34533#event-2995152630 |
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
| Jan 31, 2020 | https://github.com/angular/angular/pull/34533#issuecomment-580549615 |
| @AndrewKushnir | https://github.com/AndrewKushnir |
| Please reload this page | https://github.com/angular/angular/pull/34533 |
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
| force-pushed | https://github.com/angular/angular/compare/1f54e56a018a369355cc5cd86aa7004275b63101..e5e99cb06d0279a623d33e93138d4442ccea0335 |
| 1f54e56 | https://github.com/angular/angular/commit/1f54e56a018a369355cc5cd86aa7004275b63101 |
| e5e99cb | https://github.com/angular/angular/commit/e5e99cb06d0279a623d33e93138d4442ccea0335 |
|
Compare
| https://github.com/angular/angular/compare/1f54e56a018a369355cc5cd86aa7004275b63101..e5e99cb06d0279a623d33e93138d4442ccea0335 |
| January 31, 2020 02:08 | https://github.com/angular/angular/pull/34533#event-2995576773 |
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Jan 31, 2020 | https://github.com/angular/angular/pull/34533#event-2995577357 |
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
| force-pushed | https://github.com/angular/angular/compare/e5e99cb06d0279a623d33e93138d4442ccea0335..afb4defc6998bc208fc480f7799a9975f547850c |
| e5e99cb | https://github.com/angular/angular/commit/e5e99cb06d0279a623d33e93138d4442ccea0335 |
| afb4def | https://github.com/angular/angular/commit/afb4defc6998bc208fc480f7799a9975f547850c |
|
Compare
| https://github.com/angular/angular/compare/e5e99cb06d0279a623d33e93138d4442ccea0335..afb4defc6998bc208fc480f7799a9975f547850c |
| January 31, 2020 02:39 | https://github.com/angular/angular/pull/34533#event-2995625776 |
| https://github.com/alfaproject |
| alfaproject | https://github.com/alfaproject |
|
Jan 31, 2020
| https://github.com/angular/angular/pull/34533#pullrequestreview-351427372 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34533/files |
| packages/zone.js/test/common/Promise.spec.ts | https://github.com/angular/angular/pull/34533/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42 |
| Please reload this page | https://github.com/angular/angular/pull/34533 |
| packages/zone.js/test/common/Promise.spec.ts | https://github.com/angular/angular/pull/34533/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42 |
| Please reload this page | https://github.com/angular/angular/pull/34533 |
| packages/zone.js/test/common/Promise.spec.ts | https://github.com/angular/angular/pull/34533/files#diff-4c48eb8b914d9fc61cf6a227a24240c27e6904f322735e74dca324be1cba4b42 |
| Please reload this page | https://github.com/angular/angular/pull/34533 |
|
| https://github.com/JiaLiPassion |
| fix: should also allow subclass Promise without Symbol.species | https://github.com/angular/angular/pull/34533/commits/cd8d07e63a0196ac124166e3c3e685bc8b5d2980 |
| cd8d07e | https://github.com/angular/angular/pull/34533/commits/cd8d07e63a0196ac124166e3c3e685bc8b5d2980 |
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
| force-pushed | https://github.com/angular/angular/compare/afb4defc6998bc208fc480f7799a9975f547850c..cd8d07e63a0196ac124166e3c3e685bc8b5d2980 |
| afb4def | https://github.com/angular/angular/commit/afb4defc6998bc208fc480f7799a9975f547850c |
| cd8d07e | https://github.com/angular/angular/commit/cd8d07e63a0196ac124166e3c3e685bc8b5d2980 |
|
Compare
| https://github.com/angular/angular/compare/afb4defc6998bc208fc480f7799a9975f547850c..cd8d07e63a0196ac124166e3c3e685bc8b5d2980 |
| January 31, 2020 15:35 | https://github.com/angular/angular/pull/34533#event-2997504023 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| Jan 31, 2020 | https://github.com/angular/angular/pull/34533#issuecomment-580879578 |
| presubmit | http://test/OCL:292584711:BASE:292584745:1580499364936:a678be1c |
| Please reload this page | https://github.com/angular/angular/pull/34533 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| 58b29f1 | https://github.com/angular/angular/commit/58b29f1503a180fdfb8feb73a30d0c4448afad9a |
| Jan 31, 2020 | https://github.com/angular/angular/pull/34533#event-2998544311 |
| mhevery | https://github.com/mhevery |
|
Jan 31, 2020
| https://github.com/angular/angular/pull/34533#ref-commit-0de632a |
|
| https://github.com/JiaLiPassion |
|
| https://github.com/mhevery |
| fix: should also allow subclass Promise without Symbol.species ( | https://github.com/angular/angular/commit/0de632a1021222502e15f18cc92076efab02cbe7 |
| #34533 | https://github.com/angular/angular/pull/34533 |
| ) | https://github.com/angular/angular/commit/0de632a1021222502e15f18cc92076efab02cbe7 |
| 0de632a | https://github.com/angular/angular/commit/0de632a1021222502e15f18cc92076efab02cbe7 |
| #34533 | https://github.com/angular/angular/pull/34533 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Mar 2, 2020 | https://github.com/angular/angular/pull/34533#issuecomment-593479624 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/34533 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Mar 2, 2020 | https://github.com/angular/angular/pull/34533#event-3088598573 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34533 |
|
| https://github.com/AndrewKushnir |
|
AndrewKushnir
| https://github.com/AndrewKushnir |
|
| https://github.com/angular/angular/pull/34533/files/1f54e56a018a369355cc5cd86aa7004275b63101 |
|
| https://github.com/alfaproject |
|
alfaproject
| https://github.com/alfaproject |
|
| https://github.com/angular/angular/pull/34533/files/afb4defc6998bc208fc480f7799a9975f547850c |
|
| https://github.com/mhevery |
|
mhevery
| https://github.com/mhevery |
|
| https://github.com/angular/angular/pull/34533/files/1f54e56a018a369355cc5cd86aa7004275b63101 |
| Please reload this page | https://github.com/angular/angular/pull/34533 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
|
area: zones
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
| Please reload this page | https://github.com/angular/angular/pull/34533 |
|
| https://github.com/JiaLiPassion |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/mhevery |
|
| https://github.com/alfaproject |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |