| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:88b82cd4-105b-31bb-4b9a-adce66fd0004 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CE84:2E7EBB:12C8666:17C906D:6B011D32 |
| html-safe-nonce | eb79b34ea11c2a7fc024aca63d0f18d6552308a5412b044abde9d2037661c2c8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTg0OjJFN0VCQjoxMkM4NjY2OjE3QzkwNkQ6NkIwMTFEMzIiLCJ2aXNpdG9yX2lkIjoiNTUxMzMxMzIyMzE3ODI2Mzg1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fa83b88b98c6d369677fd1bd79a8c91cb5c7926df35a8fde65ecc720bfb4cfd9 |
| hovercard-subject-tag | pull_request:356011204 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34528/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b430045958329ffc3e1d609fbf67162230b319c8768e81fe474e6138ca502593/angular/angular/pull/34528 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b430045958329ffc3e1d609fbf67162230b319c8768e81fe474e6138ca502593/angular/angular/pull/34528 |
| og:image:alt | Builds on top of #34527 (so the first 9 commits are from there).
Rebased on master now that #34527 has been merged.
Previously, CommonJsDependencyHost.findDependencies() would only find dependenci... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gkalpak |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/34528#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34528 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34528 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/34528 |
| Reload | https://github.com/angular/angular/pull/34528 |
| Reload | https://github.com/angular/angular/pull/34528 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-ngcc-import-formats | https://github.com/gkalpak/angular/tree/fix-ngcc-import-formats |
| Conversation | https://github.com/angular/angular/pull/34528 |
| Commits2 (2) | https://github.com/angular/angular/pull/34528/commits |
| Checks | https://github.com/angular/angular/pull/34528/checks |
| Files changed | https://github.com/angular/angular/pull/34528/files |
| fix(ngcc): correctly detect dependencies in CommonJS | https://github.com/angular/angular/pull/34528#top |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-ngcc-import-formats | https://github.com/gkalpak/angular/tree/fix-ngcc-import-formats |
|
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Dec 21, 2019 | https://github.com/angular/angular/pull/34528#issue-541341559 |
| Please reload this page | https://github.com/angular/angular/pull/34528 |
| #34527 | https://github.com/angular/angular/pull/34527 |
| #34527 | https://github.com/angular/angular/pull/34527 |
| Please reload this page | https://github.com/angular/angular/pull/34528 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Dec 21, 2019 | https://github.com/angular/angular/pull/34528#event-2902760370 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
comp: ngcc
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Dec 21, 2019 | https://github.com/angular/angular/pull/34528#event-2902760415 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Dec 21, 2019 | https://github.com/angular/angular/pull/34528#issuecomment-568191459 |
| Please reload this page | https://github.com/angular/angular/pull/34528 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Dec 21, 2019 | https://github.com/angular/angular/pull/34528#event-2902760440 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Dec 21, 2019 | https://github.com/angular/angular/pull/34528#event-2902760443 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| December 21, 2019 16:02 | https://github.com/angular/angular/pull/34528#event-2902762231 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| December 21, 2019 16:02 | https://github.com/angular/angular/pull/34528#event-2902762232 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Dec 21, 2019
| https://github.com/angular/angular/pull/34528#ref-pullrequest-530767200 |
|
fix(ngcc): several fixes
#34169
| https://github.com/angular/angular/pull/34169 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Dec 21, 2019 | https://github.com/angular/angular/pull/34528#issuecomment-568191923 |
| https://pr34528-9505404.ngbuilds.io/ | https://pr34528-9505404.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34528 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Dec 23, 2019 | https://github.com/angular/angular/pull/34528#event-2905026876 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Dec 26, 2019
| https://github.com/angular/angular/pull/34528#pullrequestreview-336538772 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34528/files |
| petebacondarwin | https://github.com/petebacondarwin |
| https://github.com/angular/angular/pull/34528#pullrequestreview-336538772 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34528 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Dec 26, 2019 | https://github.com/angular/angular/pull/34528#event-2909194792 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/9505404763d723340c9ab3fb3ebec1824f8520a1..6a099e43501642f6d8023811195b4ef9d00fbe7a |
| 9505404 | https://github.com/angular/angular/commit/9505404763d723340c9ab3fb3ebec1824f8520a1 |
| 6a099e4 | https://github.com/angular/angular/commit/6a099e43501642f6d8023811195b4ef9d00fbe7a |
|
Compare
| https://github.com/angular/angular/compare/9505404763d723340c9ab3fb3ebec1824f8520a1..6a099e43501642f6d8023811195b4ef9d00fbe7a |
| December 29, 2019 14:05 | https://github.com/angular/angular/pull/34528#event-2912518773 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Dec 29, 2019 | https://github.com/angular/angular/pull/34528#issuecomment-569508694 |
| Please reload this page | https://github.com/angular/angular/pull/34528 |
| only detect dependencies | https://github.com/angular/angular/blob/9b9116c79/packages/compiler-cli/ngcc/src/host/umd_host.ts#L242-L252 |
| #34527 | https://github.com/angular/angular/pull/34527 |
| Please reload this page | https://github.com/angular/angular/pull/34528 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
state: blocked
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22 |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Dec 29, 2019 | https://github.com/angular/angular/pull/34528#event-2912519295 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Dec 29, 2019 | https://github.com/angular/angular/pull/34528#issuecomment-569509572 |
| https://pr34528-6a099e4.ngbuilds.io/ | https://pr34528-6a099e4.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34528 |
| https://github.com/gkalpak |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34528 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/6a099e43501642f6d8023811195b4ef9d00fbe7a..f7183438caecdce860b993e9a086dae7058eeeee |
| 6a099e4 | https://github.com/angular/angular/commit/6a099e43501642f6d8023811195b4ef9d00fbe7a |
| f718343 | https://github.com/angular/angular/commit/f7183438caecdce860b993e9a086dae7058eeeee |
|
Compare
| https://github.com/angular/angular/compare/6a099e43501642f6d8023811195b4ef9d00fbe7a..f7183438caecdce860b993e9a086dae7058eeeee |
| January 8, 2020 11:10 | https://github.com/angular/angular/pull/34528#event-2930770089 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jan 8, 2020 | https://github.com/angular/angular/pull/34528#issuecomment-572005791 |
| https://pr34528-f718343.ngbuilds.io/ | https://pr34528-f718343.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34528 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 8, 2020 | https://github.com/angular/angular/pull/34528#issuecomment-572075627 |
| Please reload this page | https://github.com/angular/angular/pull/34528 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/f7183438caecdce860b993e9a086dae7058eeeee..f25651b7d4df25b4a494db1f53d29d4e673d62f4 |
| f718343 | https://github.com/angular/angular/commit/f7183438caecdce860b993e9a086dae7058eeeee |
| f25651b | https://github.com/angular/angular/commit/f25651b7d4df25b4a494db1f53d29d4e673d62f4 |
|
Compare
| https://github.com/angular/angular/compare/f7183438caecdce860b993e9a086dae7058eeeee..f25651b7d4df25b4a494db1f53d29d4e673d62f4 |
| January 8, 2020 17:45 | https://github.com/angular/angular/pull/34528#event-2932140523 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jan 8, 2020 | https://github.com/angular/angular/pull/34528#issuecomment-572183146 |
| https://pr34528-f25651b.ngbuilds.io/ | https://pr34528-f25651b.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34528 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/f25651b7d4df25b4a494db1f53d29d4e673d62f4..7104227623798ce4b2cfdb7454fe0d6ea7f7e86b |
| f25651b | https://github.com/angular/angular/commit/f25651b7d4df25b4a494db1f53d29d4e673d62f4 |
| 7104227 | https://github.com/angular/angular/commit/7104227623798ce4b2cfdb7454fe0d6ea7f7e86b |
|
Compare
| https://github.com/angular/angular/compare/f25651b7d4df25b4a494db1f53d29d4e673d62f4..7104227623798ce4b2cfdb7454fe0d6ea7f7e86b |
| January 8, 2020 20:02 | https://github.com/angular/angular/pull/34528#event-2932542363 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jan 8, 2020 | https://github.com/angular/angular/pull/34528#issuecomment-572236649 |
| https://pr34528-7104227.ngbuilds.io/ | https://pr34528-7104227.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34528 |
| gkalpak | https://github.com/gkalpak |
| January 10, 2020 20:11 | https://github.com/angular/angular/pull/34528#commits-pushed-3f69153 |
|
| https://github.com/gkalpak |
| test(ngcc): fix typos in CommonJsDependencyHost tests (to avoid con… | https://github.com/angular/angular/pull/34528/commits/3f69153e23962f97a7af0b2c128e5cb192781068 |
| 3f69153 | https://github.com/angular/angular/pull/34528/commits/3f69153e23962f97a7af0b2c128e5cb192781068 |
|
| https://github.com/gkalpak |
| fix(ngcc): correctly detect dependencies in CommonJS | https://github.com/angular/angular/pull/34528/commits/eb3dfd1ca08b7375473f090ca80bc77c3da05c18 |
| eb3dfd1 | https://github.com/angular/angular/pull/34528/commits/eb3dfd1ca08b7375473f090ca80bc77c3da05c18 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/7104227623798ce4b2cfdb7454fe0d6ea7f7e86b..eb3dfd1ca08b7375473f090ca80bc77c3da05c18 |
| 7104227 | https://github.com/angular/angular/commit/7104227623798ce4b2cfdb7454fe0d6ea7f7e86b |
| eb3dfd1 | https://github.com/angular/angular/commit/eb3dfd1ca08b7375473f090ca80bc77c3da05c18 |
|
Compare
| https://github.com/angular/angular/compare/7104227623798ce4b2cfdb7454fe0d6ea7f7e86b..eb3dfd1ca08b7375473f090ca80bc77c3da05c18 |
| January 10, 2020 18:11 | https://github.com/angular/angular/pull/34528#event-2939401640 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
state: blocked
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22 |
| Jan 10, 2020 | https://github.com/angular/angular/pull/34528#event-2939420348 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jan 10, 2020 | https://github.com/angular/angular/pull/34528#issuecomment-573148901 |
| eb3dfd1 | https://github.com/angular/angular/commit/eb3dfd1ca08b7375473f090ca80bc77c3da05c18 |
| https://pr34528-eb3dfd1.ngbuilds.io/ | https://pr34528-eb3dfd1.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34528 |
| atscott | https://github.com/atscott |
|
Jan 13, 2020
| https://github.com/angular/angular/pull/34528#ref-commit-f48c81c |
|
| https://github.com/gkalpak |
|
| https://github.com/atscott |
| test(ngcc): fix typos in CommonJsDependencyHost tests (to avoid con… | https://github.com/angular/angular/commit/f48c81c1cae3a2d42dc4f514ab29ab8c286a7702 |
| f48c81c | https://github.com/angular/angular/commit/f48c81c1cae3a2d42dc4f514ab29ab8c286a7702 |
| #34528 | https://github.com/angular/angular/pull/34528 |
| #34528 | https://github.com/angular/angular/pull/34528 |
| atscott | https://github.com/atscott |
|
Jan 13, 2020
| https://github.com/angular/angular/pull/34528#ref-commit-ff02ddf |
|
| https://github.com/gkalpak |
|
| https://github.com/atscott |
| fix(ngcc): correctly detect dependencies in CommonJS ( | https://github.com/angular/angular/commit/ff02ddfd9bb0deacf0d666435c746675f92baa63 |
| #34528 | https://github.com/angular/angular/pull/34528 |
| ) | https://github.com/angular/angular/commit/ff02ddfd9bb0deacf0d666435c746675f92baa63 |
| ff02ddf | https://github.com/angular/angular/commit/ff02ddfd9bb0deacf0d666435c746675f92baa63 |
| #34528 | https://github.com/angular/angular/pull/34528 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| eb6e1af | https://github.com/angular/angular/commit/eb6e1af46daefbf6c928b1d1ed2becff67bcd85c |
| Jan 13, 2020 | https://github.com/angular/angular/pull/34528#event-2944152694 |
| atscott | https://github.com/atscott |
|
Jan 13, 2020
| https://github.com/angular/angular/pull/34528#ref-commit-cfbb1a1 |
|
| https://github.com/gkalpak |
|
| https://github.com/atscott |
| fix(ngcc): correctly detect dependencies in CommonJS ( | https://github.com/angular/angular/commit/cfbb1a1e77b8adf11a857c8ff75dcb9460bba4c0 |
| #34528 | https://github.com/angular/angular/pull/34528 |
| ) | https://github.com/angular/angular/commit/cfbb1a1e77b8adf11a857c8ff75dcb9460bba4c0 |
| cfbb1a1 | https://github.com/angular/angular/commit/cfbb1a1e77b8adf11a857c8ff75dcb9460bba4c0 |
| #34528 | https://github.com/angular/angular/pull/34528 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| January 13, 2020 19:24 | https://github.com/angular/angular/pull/34528#event-2944455350 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Feb 13, 2020 | https://github.com/angular/angular/pull/34528#issuecomment-585836243 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/34528 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Feb 13, 2020 | https://github.com/angular/angular/pull/34528#event-3035513728 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34528 |
|
| https://github.com/petebacondarwin |
|
petebacondarwin
| https://github.com/petebacondarwin |
|
| https://github.com/angular/angular/pull/34528/files/9505404763d723340c9ab3fb3ebec1824f8520a1 |
| Please reload this page | https://github.com/angular/angular/pull/34528 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
| Please reload this page | https://github.com/angular/angular/pull/34528 |
|
| https://github.com/gkalpak |
|
| https://github.com/googlebot |
|
| https://github.com/mary-poppins |
|
| https://github.com/petebacondarwin |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |