René's URL Explorer Experiment


Title: fix(ngcc): fix UMD inline exports and re-exports by gkalpak · Pull Request #34512 · angular/angular · GitHub

Open Graph Title: fix(ngcc): fix UMD inline exports and re-exports by gkalpak · Pull Request #34512 · angular/angular

X Title: fix(ngcc): fix UMD inline exports and re-exports by gkalpak · Pull Request #34512 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Several fixes regarding exports in UMD. See individual commits for more info.

X Description: Several fixes regarding exports in UMD. See individual commits for more info.

Opengraph URL: https://github.com/angular/angular/pull/34512

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0e8cc68d-09c0-528d-2825-76fad831be0a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idABBA:2F4BD9:136B210:19A449F:6B011D41
html-safe-nonce34d0d1a4f7f653524882f4c4c40f41b0a0701dc22a11908f944a1c0c7a29a2f2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkJBOjJGNEJEOToxMzZCMjEwOjE5QTQ0OUY6NkIwMTFENDEiLCJ2aXNpdG9yX2lkIjoiNTkxMjc3NzEzMTk2Nzk3ODgxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac525b207c86c14ff378b23c849319028c9f54f16d405b2a651353d194abfa0860
hovercard-subject-tagpull_request:355786864
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34512/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b430045958329ffc3e1d609fbf67162230b319c8768e81fe474e6138ca502593/angular/angular/pull/34512
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b430045958329ffc3e1d609fbf67162230b319c8768e81fe474e6138ca502593/angular/angular/pull/34512
og:image:altSeveral fixes regarding exports in UMD. See individual commits for more info.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegkalpak
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/34512#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34512
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34512
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34512
Reloadhttps://github.com/angular/angular/pull/34512
Reloadhttps://github.com/angular/angular/pull/34512
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-ngcc-umd-reexportshttps://github.com/gkalpak/angular/tree/fix-ngcc-umd-reexports
Conversationhttps://github.com/angular/angular/pull/34512
Commits7 (7)https://github.com/angular/angular/pull/34512/commits
Checkshttps://github.com/angular/angular/pull/34512/checks
Files changedhttps://github.com/angular/angular/pull/34512/files
fix(ngcc): fix UMD inline exports and re-exportshttps://github.com/angular/angular/pull/34512#top
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-ngcc-umd-reexportshttps://github.com/gkalpak/angular/tree/fix-ngcc-umd-reexports
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 20, 2019https://github.com/angular/angular/pull/34512#issue-541062726
Please reload this pagehttps://github.com/angular/angular/pull/34512
Please reload this pagehttps://github.com/angular/angular/pull/34512
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Dec 20, 2019https://github.com/angular/angular/pull/34512#event-2901162963
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 20, 2019 https://github.com/angular/angular/pull/34512#ref-pullrequest-533403431
fix(ngcc): dts declaration mapping #34254 https://github.com/angular/angular/pull/34254
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
comp: ngcc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
refactoring https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Arefactoring
Dec 20, 2019https://github.com/angular/angular/pull/34512#event-2901166705
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Dec 20, 2019https://github.com/angular/angular/pull/34512#event-2901166821
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 20, 2019https://github.com/angular/angular/pull/34512#event-2901167748
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Dec 20, 2019https://github.com/angular/angular/pull/34512#issuecomment-567974957
https://pr34512-4a27b8d.ngbuilds.io/https://pr34512-4a27b8d.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/34512
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 21, 2019 https://github.com/angular/angular/pull/34512#ref-pullrequest-541333793
fix(ngcc): recognize re-exports with imported TS helpers in CommonJS and UMD #34527 https://github.com/angular/angular/pull/34527
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
December 21, 2019 16:01https://github.com/angular/angular/pull/34512#event-2902761685
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
December 21, 2019 16:01https://github.com/angular/angular/pull/34512#event-2902761698
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 21, 2019 https://github.com/angular/angular/pull/34512#ref-pullrequest-530767200
fix(ngcc): several fixes #34169 https://github.com/angular/angular/pull/34169
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
Dec 23, 2019https://github.com/angular/angular/pull/34512#event-2905026041
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Dec 26, 2019 https://github.com/angular/angular/pull/34512#pullrequestreview-336534611
View reviewed changes https://github.com/angular/angular/pull/34512/files
petebacondarwinhttps://github.com/petebacondarwin
https://github.com/angular/angular/pull/34512#pullrequestreview-336534611
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34512
packages/compiler-cli/ngcc/src/host/umd_host.tshttps://github.com/angular/angular/pull/34512/files#diff-5d0863b117d9dd32f96881acfdd6ae2a16b1090835527627e3df661d0a3df0ce
petebacondarwinhttps://github.com/petebacondarwin
Dec 26, 2019https://github.com/angular/angular/pull/34512#discussion_r361466617
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34512
gkalpakhttps://github.com/gkalpak
Dec 29, 2019https://github.com/angular/angular/pull/34512#discussion_r361840602
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34512
gkalpakhttps://github.com/gkalpak
Dec 29, 2019https://github.com/angular/angular/pull/34512#discussion_r361850318
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34512
packages/compiler-cli/ngcc/src/utils.tshttps://github.com/angular/angular/pull/34512/files#diff-80d7bef7a408f6f49d97d8436ae6ab20186b2f133c9101a65735943b0cd61b7d
petebacondarwinhttps://github.com/petebacondarwin
Dec 26, 2019https://github.com/angular/angular/pull/34512#discussion_r361467992
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34512
gkalpakhttps://github.com/gkalpak
Dec 29, 2019https://github.com/angular/angular/pull/34512#discussion_r361850349
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34512
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Dec 26, 2019https://github.com/angular/angular/pull/34512#event-2909179634
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Dec 29, 2019https://github.com/angular/angular/pull/34512#event-2912382221
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/4a27b8d53860b1acc9f0c79d2f2b171812685346..a7bce149e3a565d750b97ea1968f22312261424e
4a27b8dhttps://github.com/angular/angular/commit/4a27b8d53860b1acc9f0c79d2f2b171812685346
a7bce14https://github.com/angular/angular/commit/a7bce149e3a565d750b97ea1968f22312261424e
Compare https://github.com/angular/angular/compare/4a27b8d53860b1acc9f0c79d2f2b171812685346..a7bce149e3a565d750b97ea1968f22312261424e
December 29, 2019 13:30https://github.com/angular/angular/pull/34512#event-2912492890
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Dec 29, 2019https://github.com/angular/angular/pull/34512#event-2912493532
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 29, 2019https://github.com/angular/angular/pull/34512#issuecomment-569505892
Please reload this pagehttps://github.com/angular/angular/pull/34512
@petebacondarwinhttps://github.com/petebacondarwin
Please reload this pagehttps://github.com/angular/angular/pull/34512
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Dec 29, 2019https://github.com/angular/angular/pull/34512#issuecomment-569506514
https://pr34512-a7bce14.ngbuilds.io/https://pr34512-a7bce14.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/34512
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 30, 2019https://github.com/angular/angular/pull/34512#event-2914572849
gkalpakhttps://github.com/gkalpak
January 8, 2020 01:29https://github.com/angular/angular/pull/34512#commits-pushed-4ea6b5e
https://github.com/gkalpak
fix(ngcc): correctly handle inline exports in UMDhttps://github.com/angular/angular/pull/34512/commits/4ea6b5efd27bb65aed99b6132cba190fd6efb99c
4ea6b5ehttps://github.com/angular/angular/pull/34512/commits/4ea6b5efd27bb65aed99b6132cba190fd6efb99c
02bab8chttps://github.com/gkalpak/angular/commit/02bab8cf90bba06ee723e87938e436918dc86bb0
02bab8chttps://github.com/gkalpak/angular/commit/02bab8cf90bba06ee723e87938e436918dc86bb0
angular#34254https://github.com/angular/angular/pull/34254
https://github.com/gkalpak
fix(ngcc): recognize re-exports with require() calls in UMDhttps://github.com/angular/angular/pull/34512/commits/79801a72d1f0c282c5efe84c35ce9599b1395317
79801a7https://github.com/angular/angular/pull/34512/commits/79801a72d1f0c282c5efe84c35ce9599b1395317
https://github.com/angular/angular/pull/34254/files#r359515373https://github.com/angular/angular/pull/34254/files#r359515373
https://github.com/gkalpak
refactor(ngcc): share code between CommonJsReflectionHost and `UmdR…https://github.com/angular/angular/pull/34512/commits/dc4547a967a912248311c9bec5ac61c850cccc34
dc4547ahttps://github.com/angular/angular/pull/34512/commits/dc4547a967a912248311c9bec5ac61c850cccc34
https://github.com/gkalpak
fixup! refactor(ngcc): share code between CommonJsReflectionHost an…https://github.com/angular/angular/pull/34512/commits/d2e71eb664146060897fcb7213748faa54f6c2c5
d2e71ebhttps://github.com/angular/angular/pull/34512/commits/d2e71eb664146060897fcb7213748faa54f6c2c5
https://github.com/gkalpak
refactor(ngcc): avoid returning the same top-level helper calls multi…https://github.com/angular/angular/pull/34512/commits/6c809c5d72d7db6353a6d5fdd922bfdbb0f253cc
6c809c5https://github.com/angular/angular/pull/34512/commits/6c809c5d72d7db6353a6d5fdd922bfdbb0f253cc
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/a7bce149e3a565d750b97ea1968f22312261424e..c310faec179d4f8b6f09be27d5d456fc80fd3c82
a7bce14https://github.com/angular/angular/commit/a7bce149e3a565d750b97ea1968f22312261424e
c310faehttps://github.com/angular/angular/commit/c310faec179d4f8b6f09be27d5d456fc80fd3c82
Compare https://github.com/angular/angular/compare/a7bce149e3a565d750b97ea1968f22312261424e..c310faec179d4f8b6f09be27d5d456fc80fd3c82
January 8, 2020 11:04https://github.com/angular/angular/pull/34512#event-2930751915
https://github.com/gkalpak
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34512
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Jan 8, 2020https://github.com/angular/angular/pull/34512#issuecomment-572003189
https://pr34512-c310fae.ngbuilds.io/https://pr34512-c310fae.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/34512
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jan 8, 2020https://github.com/angular/angular/pull/34512#issuecomment-572031112
Please reload this pagehttps://github.com/angular/angular/pull/34512
gkalpakhttps://github.com/gkalpak
January 8, 2020 19:05https://github.com/angular/angular/pull/34512#commits-pushed-713f336
https://github.com/gkalpak
refactor(ngcc): use a special map for memoizing expensive-to-compute …https://github.com/angular/angular/pull/34512/commits/713f336bfccd37d971ae4eb5d9a2484c98e249af
713f336https://github.com/angular/angular/pull/34512/commits/713f336bfccd37d971ae4eb5d9a2484c98e249af
https://github.com/gkalpak
fix(ngcc): avoid error due to circular dependency in EsmDependencyHosthttps://github.com/angular/angular/pull/34512/commits/f567fc3674d71c8af083c2c6f30b8022e19c9443
f567fc3https://github.com/angular/angular/pull/34512/commits/f567fc3674d71c8af083c2c6f30b8022e19c9443
https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/utils.ts#L10https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/utils.ts#L10
https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/esm_dependency_host.ts#L10https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/esm_dependency_host.ts#L10
https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/dependency_host.ts#L9https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/dependency_host.ts#L9
https://nodejs.org/api/modules.html#modules_cycleshttps://nodejs.org/api/modules.html#modules_cycles
https://circleci.com/gh/angular/angular/577581https://circleci.com/gh/angular/angular/577581
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/c310faec179d4f8b6f09be27d5d456fc80fd3c82..f567fc3674d71c8af083c2c6f30b8022e19c9443
c310faehttps://github.com/angular/angular/commit/c310faec179d4f8b6f09be27d5d456fc80fd3c82
f567fc3https://github.com/angular/angular/commit/f567fc3674d71c8af083c2c6f30b8022e19c9443
Compare https://github.com/angular/angular/compare/c310faec179d4f8b6f09be27d5d456fc80fd3c82..f567fc3674d71c8af083c2c6f30b8022e19c9443
January 8, 2020 17:41https://github.com/angular/angular/pull/34512#event-2932126188
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Jan 8, 2020https://github.com/angular/angular/pull/34512#issuecomment-572181419
f567fc3https://github.com/angular/angular/commit/f567fc3674d71c8af083c2c6f30b8022e19c9443
https://pr34512-f567fc3.ngbuilds.io/https://pr34512-f567fc3.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/34512
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jan 8, 2020https://github.com/angular/angular/pull/34512#issuecomment-572212926
Please reload this pagehttps://github.com/angular/angular/pull/34512
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
petebacondarwinhttps://github.com/petebacondarwin
January 8, 2020 19:12https://github.com/angular/angular/pull/34512#event-2932392854
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jan 8, 2020 https://github.com/angular/angular/pull/34512#pullrequestreview-340118934
View reviewed changes https://github.com/angular/angular/pull/34512/files/f567fc3674d71c8af083c2c6f30b8022e19c9443
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Jan 8, 2020https://github.com/angular/angular/pull/34512#event-2932583331
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jan 8, 2020https://github.com/angular/angular/pull/34512#issuecomment-572238693
Please reload this pagehttps://github.com/angular/angular/pull/34512
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Jan 8, 2020https://github.com/angular/angular/pull/34512#event-2932635245
alxhubhttps://github.com/alxhub
Jan 8, 2020 https://github.com/angular/angular/pull/34512#ref-commit-7bbfccf
https://github.com/gkalpak
https://github.com/alxhub
fix(ngcc): correctly handle inline exports in UMD (https://github.com/angular/angular/commit/7bbfccfcd83cfdab6ccc94133246dd9fd29f9d17
#34512https://github.com/angular/angular/pull/34512
)https://github.com/angular/angular/commit/7bbfccfcd83cfdab6ccc94133246dd9fd29f9d17
7bbfccfhttps://github.com/angular/angular/commit/7bbfccfcd83cfdab6ccc94133246dd9fd29f9d17
02bab8chttps://github.com/angular/angular/commit/02bab8cf90bba06ee723e87938e436918dc86bb0
02bab8chttps://github.com/angular/angular/commit/02bab8cf90bba06ee723e87938e436918dc86bb0
#34254https://github.com/angular/angular/pull/34254
#34512https://github.com/angular/angular/pull/34512
alxhubhttps://github.com/alxhub
Jan 8, 2020 https://github.com/angular/angular/pull/34512#ref-commit-79be354
https://github.com/gkalpak
https://github.com/alxhub
fix(ngcc): recognize re-exports withhttps://github.com/angular/angular/commit/79be3544c154268e12f99056ce9178b60d51fa97
require()https://github.com/angular/angular/commit/79be3544c154268e12f99056ce9178b60d51fa97
calls in UMD (https://github.com/angular/angular/commit/79be3544c154268e12f99056ce9178b60d51fa97
#34512https://github.com/angular/angular/pull/34512
)https://github.com/angular/angular/commit/79be3544c154268e12f99056ce9178b60d51fa97
79be354https://github.com/angular/angular/commit/79be3544c154268e12f99056ce9178b60d51fa97
https://github.com/angular/angular/pull/34254/files#r359515373https://github.com/angular/angular/pull/34254/files#r359515373
#34512https://github.com/angular/angular/pull/34512
alxhubhttps://github.com/alxhub
Jan 8, 2020 https://github.com/angular/angular/pull/34512#ref-commit-6274b02
https://github.com/gkalpak
https://github.com/alxhub
refactor(ngcc): share code between CommonJsReflectionHost and `UmdR…https://github.com/angular/angular/commit/6274b02e9926684df4117ccd1fab1fc566319c31
6274b02https://github.com/angular/angular/commit/6274b02e9926684df4117ccd1fab1fc566319c31
#34512https://github.com/angular/angular/pull/34512
#34512https://github.com/angular/angular/pull/34512
alxhubhttps://github.com/alxhub
Jan 8, 2020 https://github.com/angular/angular/pull/34512#ref-commit-619e68b
https://github.com/gkalpak
https://github.com/alxhub
refactor(ngcc): avoid returning the same top-level helper calls multi…https://github.com/angular/angular/commit/619e68b95ba13e91feb6c9ba5c09a8fd6f6ce7aa
619e68bhttps://github.com/angular/angular/commit/619e68b95ba13e91feb6c9ba5c09a8fd6f6ce7aa
#34512https://github.com/angular/angular/pull/34512
#34512https://github.com/angular/angular/pull/34512
alxhubhttps://github.com/alxhub
Jan 8, 2020 https://github.com/angular/angular/pull/34512#ref-commit-7ddf794
https://github.com/gkalpak
https://github.com/alxhub
refactor(ngcc): use a special map for memoizing expensive-to-compute …https://github.com/angular/angular/commit/7ddf794274d36302e0288bea1b4f53574eab070a
7ddf794https://github.com/angular/angular/commit/7ddf794274d36302e0288bea1b4f53574eab070a
#34512https://github.com/angular/angular/pull/34512
#34512https://github.com/angular/angular/pull/34512
alxhubhttps://github.com/alxhub
Jan 8, 2020 https://github.com/angular/angular/pull/34512#ref-commit-7c3172a
https://github.com/gkalpak
https://github.com/alxhub
fix(ngcc): avoid error due to circular dependency in `EsmDependencyHo…https://github.com/angular/angular/commit/7c3172a469b455413be676175bd2f8529a793326
7c3172ahttps://github.com/angular/angular/commit/7c3172a469b455413be676175bd2f8529a793326
#34512https://github.com/angular/angular/pull/34512
https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/utils.ts#L10https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/utils.ts#L10
https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/esm_dependency_host.ts#L10https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/esm_dependency_host.ts#L10
https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/dependency_host.ts#L9https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/dependency_host.ts#L9
https://nodejs.org/api/modules.html#modules_cycleshttps://nodejs.org/api/modules.html#modules_cycles
https://circleci.com/gh/angular/angular/577581https://circleci.com/gh/angular/angular/577581
#34512https://github.com/angular/angular/pull/34512
https://github.com/alxhub
alxhubhttps://github.com/alxhub
6654f82https://github.com/angular/angular/commit/6654f82522bffba139e15fc2d63fed43cd647cb3
Jan 8, 2020https://github.com/angular/angular/pull/34512#event-2933028286
alxhubhttps://github.com/alxhub
Jan 8, 2020 https://github.com/angular/angular/pull/34512#ref-commit-d5fd742
https://github.com/gkalpak
https://github.com/alxhub
fix(ngcc): recognize re-exports withhttps://github.com/angular/angular/commit/d5fd7427633a8dcb4a57d1284e024945752bffb7
require()https://github.com/angular/angular/commit/d5fd7427633a8dcb4a57d1284e024945752bffb7
calls in UMD (https://github.com/angular/angular/commit/d5fd7427633a8dcb4a57d1284e024945752bffb7
#34512https://github.com/angular/angular/pull/34512
)https://github.com/angular/angular/commit/d5fd7427633a8dcb4a57d1284e024945752bffb7
d5fd742https://github.com/angular/angular/commit/d5fd7427633a8dcb4a57d1284e024945752bffb7
https://github.com/angular/angular/pull/34254/files#r359515373https://github.com/angular/angular/pull/34254/files#r359515373
#34512https://github.com/angular/angular/pull/34512
alxhubhttps://github.com/alxhub
Jan 8, 2020 https://github.com/angular/angular/pull/34512#ref-commit-17d5e2b
https://github.com/gkalpak
https://github.com/alxhub
refactor(ngcc): share code between CommonJsReflectionHost and `UmdR…https://github.com/angular/angular/commit/17d5e2bc9921375c17811987d963faa4b3bc283a
17d5e2bhttps://github.com/angular/angular/commit/17d5e2bc9921375c17811987d963faa4b3bc283a
#34512https://github.com/angular/angular/pull/34512
#34512https://github.com/angular/angular/pull/34512
alxhubhttps://github.com/alxhub
Jan 8, 2020 https://github.com/angular/angular/pull/34512#ref-commit-6606ce6
https://github.com/gkalpak
https://github.com/alxhub
refactor(ngcc): avoid returning the same top-level helper calls multi…https://github.com/angular/angular/commit/6606ce69f623fcdf0337a151ad5272c03476e061
6606ce6https://github.com/angular/angular/commit/6606ce69f623fcdf0337a151ad5272c03476e061
#34512https://github.com/angular/angular/pull/34512
#34512https://github.com/angular/angular/pull/34512
alxhubhttps://github.com/alxhub
Jan 8, 2020 https://github.com/angular/angular/pull/34512#ref-commit-c38195f
https://github.com/gkalpak
https://github.com/alxhub
refactor(ngcc): use a special map for memoizing expensive-to-compute …https://github.com/angular/angular/commit/c38195f59e748005c43407b69b74f758aea588f4
c38195fhttps://github.com/angular/angular/commit/c38195f59e748005c43407b69b74f758aea588f4
#34512https://github.com/angular/angular/pull/34512
#34512https://github.com/angular/angular/pull/34512
alxhubhttps://github.com/alxhub
Jan 8, 2020 https://github.com/angular/angular/pull/34512#ref-commit-07ea6cf
https://github.com/gkalpak
https://github.com/alxhub
fix(ngcc): avoid error due to circular dependency in `EsmDependencyHo…https://github.com/angular/angular/commit/07ea6cf5822ed823774e106e3435ef0b2a9d6981
07ea6cfhttps://github.com/angular/angular/commit/07ea6cf5822ed823774e106e3435ef0b2a9d6981
#34512https://github.com/angular/angular/pull/34512
https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/utils.ts#L10https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/utils.ts#L10
https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/esm_dependency_host.ts#L10https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/esm_dependency_host.ts#L10
https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/dependency_host.ts#L9https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/dependency_host.ts#L9
https://nodejs.org/api/modules.html#modules_cycleshttps://nodejs.org/api/modules.html#modules_cycles
https://circleci.com/gh/angular/angular/577581https://circleci.com/gh/angular/angular/577581
#34512https://github.com/angular/angular/pull/34512
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
January 9, 2020 11:07https://github.com/angular/angular/pull/34512#event-2934540373
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Feb 9, 2020https://github.com/angular/angular/pull/34512#issuecomment-583862490
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/34512
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Feb 9, 2020https://github.com/angular/angular/pull/34512#event-3020694363
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34512
https://github.com/petebacondarwin
petebacondarwin https://github.com/petebacondarwin
https://github.com/angular/angular/pull/34512/files/f567fc3674d71c8af083c2c6f30b8022e19c9443
Please reload this pagehttps://github.com/angular/angular/pull/34512
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
refactoring https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Arefactoring
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/34512
https://github.com/gkalpak
https://github.com/mary-poppins
https://github.com/petebacondarwin
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.