| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0e8cc68d-09c0-528d-2825-76fad831be0a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ABBA:2F4BD9:136B210:19A449F:6B011D41 |
| html-safe-nonce | 34d0d1a4f7f653524882f4c4c40f41b0a0701dc22a11908f944a1c0c7a29a2f2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQkJBOjJGNEJEOToxMzZCMjEwOjE5QTQ0OUY6NkIwMTFENDEiLCJ2aXNpdG9yX2lkIjoiNTkxMjc3NzEzMTk2Nzk3ODgxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 525b207c86c14ff378b23c849319028c9f54f16d405b2a651353d194abfa0860 |
| hovercard-subject-tag | pull_request:355786864 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34512/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b430045958329ffc3e1d609fbf67162230b319c8768e81fe474e6138ca502593/angular/angular/pull/34512 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b430045958329ffc3e1d609fbf67162230b319c8768e81fe474e6138ca502593/angular/angular/pull/34512 |
| og:image:alt | Several fixes regarding exports in UMD.
See individual commits for more info. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gkalpak |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/34512#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34512 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34512 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/34512 |
| Reload | https://github.com/angular/angular/pull/34512 |
| Reload | https://github.com/angular/angular/pull/34512 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-ngcc-umd-reexports | https://github.com/gkalpak/angular/tree/fix-ngcc-umd-reexports |
| Conversation | https://github.com/angular/angular/pull/34512 |
| Commits7 (7) | https://github.com/angular/angular/pull/34512/commits |
| Checks | https://github.com/angular/angular/pull/34512/checks |
| Files changed | https://github.com/angular/angular/pull/34512/files |
| fix(ngcc): fix UMD inline exports and re-exports | https://github.com/angular/angular/pull/34512#top |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-ngcc-umd-reexports | https://github.com/gkalpak/angular/tree/fix-ngcc-umd-reexports |
|
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Dec 20, 2019 | https://github.com/angular/angular/pull/34512#issue-541062726 |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Dec 20, 2019 | https://github.com/angular/angular/pull/34512#event-2901162963 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Dec 20, 2019
| https://github.com/angular/angular/pull/34512#ref-pullrequest-533403431 |
|
fix(ngcc): dts declaration mapping
#34254
| https://github.com/angular/angular/pull/34254 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
comp: ngcc
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
refactoring
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Arefactoring |
| Dec 20, 2019 | https://github.com/angular/angular/pull/34512#event-2901166705 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Dec 20, 2019 | https://github.com/angular/angular/pull/34512#event-2901166821 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Dec 20, 2019 | https://github.com/angular/angular/pull/34512#event-2901167748 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Dec 20, 2019 | https://github.com/angular/angular/pull/34512#issuecomment-567974957 |
| https://pr34512-4a27b8d.ngbuilds.io/ | https://pr34512-4a27b8d.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Dec 21, 2019
| https://github.com/angular/angular/pull/34512#ref-pullrequest-541333793 |
|
fix(ngcc): recognize re-exports with imported TS helpers in CommonJS and UMD
#34527
| https://github.com/angular/angular/pull/34527 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| December 21, 2019 16:01 | https://github.com/angular/angular/pull/34512#event-2902761685 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| December 21, 2019 16:01 | https://github.com/angular/angular/pull/34512#event-2902761698 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Dec 21, 2019
| https://github.com/angular/angular/pull/34512#ref-pullrequest-530767200 |
|
fix(ngcc): several fixes
#34169
| https://github.com/angular/angular/pull/34169 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Dec 23, 2019 | https://github.com/angular/angular/pull/34512#event-2905026041 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Dec 26, 2019
| https://github.com/angular/angular/pull/34512#pullrequestreview-336534611 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34512/files |
| petebacondarwin | https://github.com/petebacondarwin |
| https://github.com/angular/angular/pull/34512#pullrequestreview-336534611 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
| packages/compiler-cli/ngcc/src/host/umd_host.ts | https://github.com/angular/angular/pull/34512/files#diff-5d0863b117d9dd32f96881acfdd6ae2a16b1090835527627e3df661d0a3df0ce |
| petebacondarwin | https://github.com/petebacondarwin |
| Dec 26, 2019 | https://github.com/angular/angular/pull/34512#discussion_r361466617 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
| gkalpak | https://github.com/gkalpak |
| Dec 29, 2019 | https://github.com/angular/angular/pull/34512#discussion_r361840602 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
| gkalpak | https://github.com/gkalpak |
| Dec 29, 2019 | https://github.com/angular/angular/pull/34512#discussion_r361850318 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
| packages/compiler-cli/ngcc/src/utils.ts | https://github.com/angular/angular/pull/34512/files#diff-80d7bef7a408f6f49d97d8436ae6ab20186b2f133c9101a65735943b0cd61b7d |
| petebacondarwin | https://github.com/petebacondarwin |
| Dec 26, 2019 | https://github.com/angular/angular/pull/34512#discussion_r361467992 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
| gkalpak | https://github.com/gkalpak |
| Dec 29, 2019 | https://github.com/angular/angular/pull/34512#discussion_r361850349 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Dec 26, 2019 | https://github.com/angular/angular/pull/34512#event-2909179634 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Dec 29, 2019 | https://github.com/angular/angular/pull/34512#event-2912382221 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/4a27b8d53860b1acc9f0c79d2f2b171812685346..a7bce149e3a565d750b97ea1968f22312261424e |
| 4a27b8d | https://github.com/angular/angular/commit/4a27b8d53860b1acc9f0c79d2f2b171812685346 |
| a7bce14 | https://github.com/angular/angular/commit/a7bce149e3a565d750b97ea1968f22312261424e |
|
Compare
| https://github.com/angular/angular/compare/4a27b8d53860b1acc9f0c79d2f2b171812685346..a7bce149e3a565d750b97ea1968f22312261424e |
| December 29, 2019 13:30 | https://github.com/angular/angular/pull/34512#event-2912492890 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Dec 29, 2019 | https://github.com/angular/angular/pull/34512#event-2912493532 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Dec 29, 2019 | https://github.com/angular/angular/pull/34512#issuecomment-569505892 |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
| @petebacondarwin | https://github.com/petebacondarwin |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Dec 29, 2019 | https://github.com/angular/angular/pull/34512#issuecomment-569506514 |
| https://pr34512-a7bce14.ngbuilds.io/ | https://pr34512-a7bce14.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Dec 30, 2019 | https://github.com/angular/angular/pull/34512#event-2914572849 |
| gkalpak | https://github.com/gkalpak |
| January 8, 2020 01:29 | https://github.com/angular/angular/pull/34512#commits-pushed-4ea6b5e |
|
| https://github.com/gkalpak |
| fix(ngcc): correctly handle inline exports in UMD | https://github.com/angular/angular/pull/34512/commits/4ea6b5efd27bb65aed99b6132cba190fd6efb99c |
| 4ea6b5e | https://github.com/angular/angular/pull/34512/commits/4ea6b5efd27bb65aed99b6132cba190fd6efb99c |
| 02bab8c | https://github.com/gkalpak/angular/commit/02bab8cf90bba06ee723e87938e436918dc86bb0 |
| 02bab8c | https://github.com/gkalpak/angular/commit/02bab8cf90bba06ee723e87938e436918dc86bb0 |
| angular#34254 | https://github.com/angular/angular/pull/34254 |
|
| https://github.com/gkalpak |
| fix(ngcc): recognize re-exports with require() calls in UMD | https://github.com/angular/angular/pull/34512/commits/79801a72d1f0c282c5efe84c35ce9599b1395317 |
| 79801a7 | https://github.com/angular/angular/pull/34512/commits/79801a72d1f0c282c5efe84c35ce9599b1395317 |
| https://github.com/angular/angular/pull/34254/files#r359515373 | https://github.com/angular/angular/pull/34254/files#r359515373 |
|
| https://github.com/gkalpak |
| refactor(ngcc): share code between CommonJsReflectionHost and `UmdR… | https://github.com/angular/angular/pull/34512/commits/dc4547a967a912248311c9bec5ac61c850cccc34 |
| dc4547a | https://github.com/angular/angular/pull/34512/commits/dc4547a967a912248311c9bec5ac61c850cccc34 |
|
| https://github.com/gkalpak |
| fixup! refactor(ngcc): share code between CommonJsReflectionHost an… | https://github.com/angular/angular/pull/34512/commits/d2e71eb664146060897fcb7213748faa54f6c2c5 |
| d2e71eb | https://github.com/angular/angular/pull/34512/commits/d2e71eb664146060897fcb7213748faa54f6c2c5 |
|
| https://github.com/gkalpak |
| refactor(ngcc): avoid returning the same top-level helper calls multi… | https://github.com/angular/angular/pull/34512/commits/6c809c5d72d7db6353a6d5fdd922bfdbb0f253cc |
| 6c809c5 | https://github.com/angular/angular/pull/34512/commits/6c809c5d72d7db6353a6d5fdd922bfdbb0f253cc |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/a7bce149e3a565d750b97ea1968f22312261424e..c310faec179d4f8b6f09be27d5d456fc80fd3c82 |
| a7bce14 | https://github.com/angular/angular/commit/a7bce149e3a565d750b97ea1968f22312261424e |
| c310fae | https://github.com/angular/angular/commit/c310faec179d4f8b6f09be27d5d456fc80fd3c82 |
|
Compare
| https://github.com/angular/angular/compare/a7bce149e3a565d750b97ea1968f22312261424e..c310faec179d4f8b6f09be27d5d456fc80fd3c82 |
| January 8, 2020 11:04 | https://github.com/angular/angular/pull/34512#event-2930751915 |
| https://github.com/gkalpak |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34512 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jan 8, 2020 | https://github.com/angular/angular/pull/34512#issuecomment-572003189 |
| https://pr34512-c310fae.ngbuilds.io/ | https://pr34512-c310fae.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 8, 2020 | https://github.com/angular/angular/pull/34512#issuecomment-572031112 |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
| gkalpak | https://github.com/gkalpak |
| January 8, 2020 19:05 | https://github.com/angular/angular/pull/34512#commits-pushed-713f336 |
|
| https://github.com/gkalpak |
| refactor(ngcc): use a special map for memoizing expensive-to-compute … | https://github.com/angular/angular/pull/34512/commits/713f336bfccd37d971ae4eb5d9a2484c98e249af |
| 713f336 | https://github.com/angular/angular/pull/34512/commits/713f336bfccd37d971ae4eb5d9a2484c98e249af |
|
| https://github.com/gkalpak |
| fix(ngcc): avoid error due to circular dependency in EsmDependencyHost | https://github.com/angular/angular/pull/34512/commits/f567fc3674d71c8af083c2c6f30b8022e19c9443 |
| f567fc3 | https://github.com/angular/angular/pull/34512/commits/f567fc3674d71c8af083c2c6f30b8022e19c9443 |
| https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/utils.ts#L10 | https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/utils.ts#L10 |
| https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/esm_dependency_host.ts#L10 | https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/esm_dependency_host.ts#L10 |
| https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/dependency_host.ts#L9 | https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/dependency_host.ts#L9 |
| https://nodejs.org/api/modules.html#modules_cycles | https://nodejs.org/api/modules.html#modules_cycles |
| https://circleci.com/gh/angular/angular/577581 | https://circleci.com/gh/angular/angular/577581 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/c310faec179d4f8b6f09be27d5d456fc80fd3c82..f567fc3674d71c8af083c2c6f30b8022e19c9443 |
| c310fae | https://github.com/angular/angular/commit/c310faec179d4f8b6f09be27d5d456fc80fd3c82 |
| f567fc3 | https://github.com/angular/angular/commit/f567fc3674d71c8af083c2c6f30b8022e19c9443 |
|
Compare
| https://github.com/angular/angular/compare/c310faec179d4f8b6f09be27d5d456fc80fd3c82..f567fc3674d71c8af083c2c6f30b8022e19c9443 |
| January 8, 2020 17:41 | https://github.com/angular/angular/pull/34512#event-2932126188 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Jan 8, 2020 | https://github.com/angular/angular/pull/34512#issuecomment-572181419 |
| f567fc3 | https://github.com/angular/angular/commit/f567fc3674d71c8af083c2c6f30b8022e19c9443 |
| https://pr34512-f567fc3.ngbuilds.io/ | https://pr34512-f567fc3.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Jan 8, 2020 | https://github.com/angular/angular/pull/34512#issuecomment-572212926 |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| petebacondarwin | https://github.com/petebacondarwin |
| January 8, 2020 19:12 | https://github.com/angular/angular/pull/34512#event-2932392854 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Jan 8, 2020
| https://github.com/angular/angular/pull/34512#pullrequestreview-340118934 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34512/files/f567fc3674d71c8af083c2c6f30b8022e19c9443 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Jan 8, 2020 | https://github.com/angular/angular/pull/34512#event-2932583331 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Jan 8, 2020 | https://github.com/angular/angular/pull/34512#issuecomment-572238693 |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Jan 8, 2020 | https://github.com/angular/angular/pull/34512#event-2932635245 |
| alxhub | https://github.com/alxhub |
|
Jan 8, 2020
| https://github.com/angular/angular/pull/34512#ref-commit-7bbfccf |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| fix(ngcc): correctly handle inline exports in UMD ( | https://github.com/angular/angular/commit/7bbfccfcd83cfdab6ccc94133246dd9fd29f9d17 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| ) | https://github.com/angular/angular/commit/7bbfccfcd83cfdab6ccc94133246dd9fd29f9d17 |
| 7bbfccf | https://github.com/angular/angular/commit/7bbfccfcd83cfdab6ccc94133246dd9fd29f9d17 |
| 02bab8c | https://github.com/angular/angular/commit/02bab8cf90bba06ee723e87938e436918dc86bb0 |
| 02bab8c | https://github.com/angular/angular/commit/02bab8cf90bba06ee723e87938e436918dc86bb0 |
| #34254 | https://github.com/angular/angular/pull/34254 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| alxhub | https://github.com/alxhub |
|
Jan 8, 2020
| https://github.com/angular/angular/pull/34512#ref-commit-79be354 |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| fix(ngcc): recognize re-exports with | https://github.com/angular/angular/commit/79be3544c154268e12f99056ce9178b60d51fa97 |
| require() | https://github.com/angular/angular/commit/79be3544c154268e12f99056ce9178b60d51fa97 |
| calls in UMD ( | https://github.com/angular/angular/commit/79be3544c154268e12f99056ce9178b60d51fa97 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| ) | https://github.com/angular/angular/commit/79be3544c154268e12f99056ce9178b60d51fa97 |
| 79be354 | https://github.com/angular/angular/commit/79be3544c154268e12f99056ce9178b60d51fa97 |
| https://github.com/angular/angular/pull/34254/files#r359515373 | https://github.com/angular/angular/pull/34254/files#r359515373 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| alxhub | https://github.com/alxhub |
|
Jan 8, 2020
| https://github.com/angular/angular/pull/34512#ref-commit-6274b02 |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| refactor(ngcc): share code between CommonJsReflectionHost and `UmdR… | https://github.com/angular/angular/commit/6274b02e9926684df4117ccd1fab1fc566319c31 |
| 6274b02 | https://github.com/angular/angular/commit/6274b02e9926684df4117ccd1fab1fc566319c31 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| alxhub | https://github.com/alxhub |
|
Jan 8, 2020
| https://github.com/angular/angular/pull/34512#ref-commit-619e68b |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| refactor(ngcc): avoid returning the same top-level helper calls multi… | https://github.com/angular/angular/commit/619e68b95ba13e91feb6c9ba5c09a8fd6f6ce7aa |
| 619e68b | https://github.com/angular/angular/commit/619e68b95ba13e91feb6c9ba5c09a8fd6f6ce7aa |
| #34512 | https://github.com/angular/angular/pull/34512 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| alxhub | https://github.com/alxhub |
|
Jan 8, 2020
| https://github.com/angular/angular/pull/34512#ref-commit-7ddf794 |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| refactor(ngcc): use a special map for memoizing expensive-to-compute … | https://github.com/angular/angular/commit/7ddf794274d36302e0288bea1b4f53574eab070a |
| 7ddf794 | https://github.com/angular/angular/commit/7ddf794274d36302e0288bea1b4f53574eab070a |
| #34512 | https://github.com/angular/angular/pull/34512 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| alxhub | https://github.com/alxhub |
|
Jan 8, 2020
| https://github.com/angular/angular/pull/34512#ref-commit-7c3172a |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| fix(ngcc): avoid error due to circular dependency in `EsmDependencyHo… | https://github.com/angular/angular/commit/7c3172a469b455413be676175bd2f8529a793326 |
| 7c3172a | https://github.com/angular/angular/commit/7c3172a469b455413be676175bd2f8529a793326 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/utils.ts#L10 | https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/utils.ts#L10 |
| https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/esm_dependency_host.ts#L10 | https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/esm_dependency_host.ts#L10 |
| https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/dependency_host.ts#L9 | https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/dependency_host.ts#L9 |
| https://nodejs.org/api/modules.html#modules_cycles | https://nodejs.org/api/modules.html#modules_cycles |
| https://circleci.com/gh/angular/angular/577581 | https://circleci.com/gh/angular/angular/577581 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| 6654f82 | https://github.com/angular/angular/commit/6654f82522bffba139e15fc2d63fed43cd647cb3 |
| Jan 8, 2020 | https://github.com/angular/angular/pull/34512#event-2933028286 |
| alxhub | https://github.com/alxhub |
|
Jan 8, 2020
| https://github.com/angular/angular/pull/34512#ref-commit-d5fd742 |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| fix(ngcc): recognize re-exports with | https://github.com/angular/angular/commit/d5fd7427633a8dcb4a57d1284e024945752bffb7 |
| require() | https://github.com/angular/angular/commit/d5fd7427633a8dcb4a57d1284e024945752bffb7 |
| calls in UMD ( | https://github.com/angular/angular/commit/d5fd7427633a8dcb4a57d1284e024945752bffb7 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| ) | https://github.com/angular/angular/commit/d5fd7427633a8dcb4a57d1284e024945752bffb7 |
| d5fd742 | https://github.com/angular/angular/commit/d5fd7427633a8dcb4a57d1284e024945752bffb7 |
| https://github.com/angular/angular/pull/34254/files#r359515373 | https://github.com/angular/angular/pull/34254/files#r359515373 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| alxhub | https://github.com/alxhub |
|
Jan 8, 2020
| https://github.com/angular/angular/pull/34512#ref-commit-17d5e2b |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| refactor(ngcc): share code between CommonJsReflectionHost and `UmdR… | https://github.com/angular/angular/commit/17d5e2bc9921375c17811987d963faa4b3bc283a |
| 17d5e2b | https://github.com/angular/angular/commit/17d5e2bc9921375c17811987d963faa4b3bc283a |
| #34512 | https://github.com/angular/angular/pull/34512 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| alxhub | https://github.com/alxhub |
|
Jan 8, 2020
| https://github.com/angular/angular/pull/34512#ref-commit-6606ce6 |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| refactor(ngcc): avoid returning the same top-level helper calls multi… | https://github.com/angular/angular/commit/6606ce69f623fcdf0337a151ad5272c03476e061 |
| 6606ce6 | https://github.com/angular/angular/commit/6606ce69f623fcdf0337a151ad5272c03476e061 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| alxhub | https://github.com/alxhub |
|
Jan 8, 2020
| https://github.com/angular/angular/pull/34512#ref-commit-c38195f |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| refactor(ngcc): use a special map for memoizing expensive-to-compute … | https://github.com/angular/angular/commit/c38195f59e748005c43407b69b74f758aea588f4 |
| c38195f | https://github.com/angular/angular/commit/c38195f59e748005c43407b69b74f758aea588f4 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| alxhub | https://github.com/alxhub |
|
Jan 8, 2020
| https://github.com/angular/angular/pull/34512#ref-commit-07ea6cf |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| fix(ngcc): avoid error due to circular dependency in `EsmDependencyHo… | https://github.com/angular/angular/commit/07ea6cf5822ed823774e106e3435ef0b2a9d6981 |
| 07ea6cf | https://github.com/angular/angular/commit/07ea6cf5822ed823774e106e3435ef0b2a9d6981 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/utils.ts#L10 | https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/utils.ts#L10 |
| https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/esm_dependency_host.ts#L10 | https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/esm_dependency_host.ts#L10 |
| https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/dependency_host.ts#L9 | https://github.com/angular/angular/blob/18d89c9c8/packages/compiler-cli/ngcc/src/dependencies/dependency_host.ts#L9 |
| https://nodejs.org/api/modules.html#modules_cycles | https://nodejs.org/api/modules.html#modules_cycles |
| https://circleci.com/gh/angular/angular/577581 | https://circleci.com/gh/angular/angular/577581 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| January 9, 2020 11:07 | https://github.com/angular/angular/pull/34512#event-2934540373 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Feb 9, 2020 | https://github.com/angular/angular/pull/34512#issuecomment-583862490 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Feb 9, 2020 | https://github.com/angular/angular/pull/34512#event-3020694363 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34512 |
|
| https://github.com/petebacondarwin |
|
petebacondarwin
| https://github.com/petebacondarwin |
|
| https://github.com/angular/angular/pull/34512/files/f567fc3674d71c8af083c2c6f30b8022e19c9443 |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
refactoring
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Arefactoring |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
| Please reload this page | https://github.com/angular/angular/pull/34512 |
|
| https://github.com/gkalpak |
|
| https://github.com/mary-poppins |
|
| https://github.com/petebacondarwin |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |