René's URL Explorer Experiment


Title: feat(ivy): improve `ExpressionChangedAfterChecked` error message for attributes by AndrewKushnir · Pull Request #34505 · angular/angular · GitHub

Open Graph Title: feat(ivy): improve `ExpressionChangedAfterChecked` error message for attributes by AndrewKushnir · Pull Request #34505 · angular/angular

X Title: feat(ivy): improve `ExpressionChangedAfterChecked` error message for attributes by AndrewKushnir · Pull Request #34505 · angular/angular

Description: This commit improves ExpressionChangedAfterChecked error message for attributes by including attribute name and the content of the entire expression that contains interpolation(s). In order to achieve that, metadata is now stored in TData array when attribute and attributeInterpolate instructions are being called (similar to property and propertyInterpolate instructions). PR Type What kind of change does this PR introduce? Bugfix Does this PR introduce a breaking change? Yes No

Open Graph Description: This commit improves ExpressionChangedAfterChecked error message for attributes by including attribute name and the content of the entire expression that contains interpolation(s). In order to achi...

X Description: This commit improves ExpressionChangedAfterChecked error message for attributes by including attribute name and the content of the entire expression that contains interpolation(s). In order to achi...

Opengraph URL: https://github.com/angular/angular/pull/34505

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2071cf25-643e-d8c1-3c5d-c987c8959d09
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A8A:23CF06:25F2E5D:3056038:6B017F77
html-safe-noncec7d259c19e299c529e009500a679761a3d7626f33def2a88b0ed83cfecd23a94
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QThBOjIzQ0YwNjoyNUYyRTVEOjMwNTYwMzg6NkIwMTdGNzciLCJ2aXNpdG9yX2lkIjoiNTE5MzQzOTQxNzc3NTI1OTUxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac245c470464b5c99c13054a1970e908f0d58c41cc63da7287aca103d4524f96ef
hovercard-subject-tagpull_request:355456971
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/34505/files
twitter:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
og:image:altThis commit improves ExpressionChangedAfterChecked error message for attributes by including attribute name and the content of the entire expression that contains interpolation(s). In order to achi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/34505/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34505%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34505%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34505/files
Reloadhttps://github.com/angular/angular/pull/34505/files
Reloadhttps://github.com/angular/angular/pull/34505/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:cd_error_details_for_attrshttps://github.com/AndrewKushnir/angular/tree/cd_error_details_for_attrs
Conversation 6 https://github.com/angular/angular/pull/34505
Commits 1 https://github.com/angular/angular/pull/34505/commits
Checks 0 https://github.com/angular/angular/pull/34505/checks
Files changed https://github.com/angular/angular/pull/34505/files
Please reload this pagehttps://github.com/angular/angular/pull/34505/files
feat(ivy): improve ExpressionChangedAfterChecked error message for attributes https://github.com/angular/angular/pull/34505/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/34505/files
f515947 feat(ivy): improve `ExpressionChangedAfterChecked` error message for … AndrewKushnir Dec 20, 2019 https://github.com/angular/angular/pull/34505/commits/f5159472cc0beb95bc6b06d20c91de152ff0fc2b
Clear filters https://github.com/angular/angular/pull/34505/files
Please reload this pagehttps://github.com/angular/angular/pull/34505/files
Please reload this pagehttps://github.com/angular/angular/pull/34505/files
attribute.ts https://github.com/angular/angular/pull/34505/files#diff-c863afa11a3d8308b717c10844c0e5024cb0ad1ddf3ab8a9a490e26d255f8c4f
attribute_interpolation.ts https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
property_interpolation.ts https://github.com/angular/angular/pull/34505/files#diff-6e3fb73896a87cb293d3191687cc3895de723df62c6255859a908e941806ecc1
change_detection_spec.ts https://github.com/angular/angular/pull/34505/files#diff-25d932b0d3748a7363626694f5f47c899c0d2de76ce0b209db4a3403ebad182e
packages/core/src/render3/instructions/attribute.tshttps://github.com/angular/angular/pull/34505/files#diff-c863afa11a3d8308b717c10844c0e5024cb0ad1ddf3ab8a9a490e26d255f8c4f
View file https://github.com/AndrewKushnir/angular/blob/f5159472cc0beb95bc6b06d20c91de152ff0fc2b/packages/core/src/render3/instructions/attribute.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34505/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34505/files#diff-c863afa11a3d8308b717c10844c0e5024cb0ad1ddf3ab8a9a490e26d255f8c4f
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Jan 9, 2020https://github.com/angular/angular/pull/34505/files#r364695784
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34505/files
https://github.com/angular/angular/pull/34505/files#diff-c863afa11a3d8308b717c10844c0e5024cb0ad1ddf3ab8a9a490e26d255f8c4f
packages/core/src/render3/instructions/attribute_interpolation.tshttps://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
View file https://github.com/AndrewKushnir/angular/blob/f5159472cc0beb95bc6b06d20c91de152ff0fc2b/packages/core/src/render3/instructions/attribute_interpolation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34505/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
https://github.com/angular/angular/pull/34505/files#diff-42fb4d17ad1c4096ba721748c13f815c6b727d4d2b204f5d68bd379a6bbc7e40
packages/core/src/render3/instructions/property_interpolation.tshttps://github.com/angular/angular/pull/34505/files#diff-6e3fb73896a87cb293d3191687cc3895de723df62c6255859a908e941806ecc1
View file https://github.com/AndrewKushnir/angular/blob/f5159472cc0beb95bc6b06d20c91de152ff0fc2b/packages/core/src/render3/instructions/property_interpolation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34505/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34505/files#diff-6e3fb73896a87cb293d3191687cc3895de723df62c6255859a908e941806ecc1
https://github.com/angular/angular/pull/34505/files#diff-6e3fb73896a87cb293d3191687cc3895de723df62c6255859a908e941806ecc1
packages/core/test/acceptance/change_detection_spec.tshttps://github.com/angular/angular/pull/34505/files#diff-25d932b0d3748a7363626694f5f47c899c0d2de76ce0b209db4a3403ebad182e
View file https://github.com/AndrewKushnir/angular/blob/f5159472cc0beb95bc6b06d20c91de152ff0fc2b/packages/core/test/acceptance/change_detection_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34505/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34505/files#diff-25d932b0d3748a7363626694f5f47c899c0d2de76ce0b209db4a3403ebad182e
https://github.com/angular/angular/pull/34505/files#diff-25d932b0d3748a7363626694f5f47c899c0d2de76ce0b209db4a3403ebad182e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.