René's URL Explorer Experiment


Title: fix(ivy): properly bootstrap components with attribute selectors by pkozlowski-opensource · Pull Request #34450 · angular/angular · GitHub

Open Graph Title: fix(ivy): properly bootstrap components with attribute selectors by pkozlowski-opensource · Pull Request #34450 · angular/angular

X Title: fix(ivy): properly bootstrap components with attribute selectors by pkozlowski-opensource · Pull Request #34450 · angular/angular

Description: Before this change ivy didn't properly bootstrap components that used selectors more complex than a tag name. The crux of the issue is that we were trying to use the selectors property of a component definition in 2 different code paths: bootstrap; dynamic instantiation. It tuns out that selector should be interpreted differently for those 2 scenarios: bootstrap: we need a selector as string (as written by a directive author); dynamic instantiation: we need a tag name only (defaulting to div if a given selector doesn't contain tag name). This PR tries to fix the identified issue by clearly separating 2 usage scenario (and hence having 2 separate fields on a ComponentFactory: selector and tagName). Sadly this PR has one obvious issue - it doesn't fully recreate a selector's string (as written by a user) - to do it properly we would have to add more code (non tree-shakable) to stringify a parsed selector in all cases. So it seems like we need to decide on the following trade-offs: correctness (as in this PR); fixed code size in the framework (fully re-create a selector string from its parsed version); generated code size (we could add oryginal selector string to a directive definition). I'm leaning on the "be correct and add more code to the framework) side, but opening a draft PR so we can discuss. Fixes #34349

Open Graph Description: Before this change ivy didn't properly bootstrap components that used selectors more complex than a tag name. The crux of the issue is that we were trying to use the selectors property of a com...

X Description: Before this change ivy didn't properly bootstrap components that used selectors more complex than a tag name. The crux of the issue is that we were trying to use the selectors property of a...

Opengraph URL: https://github.com/angular/angular/pull/34450

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f9ff0c14-64a9-211c-30f9-f40661bf5bf5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB20:E03FE:1B1C32:23B817:6B01651B
html-safe-nonce0280d220e3c80c4a87dcb1a6251e2720e682163d6b02440bde98de04136d6d71
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjIwOkUwM0ZFOjFCMUMzMjoyM0I4MTc6NkIwMTY1MUIiLCJ2aXNpdG9yX2lkIjoiMTMxNDU4OTM4ODI5ODA4NTY1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5d593403e2c3bf81838766c4a03c54ab8ac04e7c5873d565311b640a349e2357
hovercard-subject-tagpull_request:354210882
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/34450/files
twitter:imagehttps://avatars.githubusercontent.com/u/973550?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/973550?s=400&v=4
og:image:altBefore this change ivy didn't properly bootstrap components that used selectors more complex than a tag name. The crux of the issue is that we were trying to use the selectors property of a com...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/34450/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34450%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34450%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34450/files
Reloadhttps://github.com/angular/angular/pull/34450/files
Reloadhttps://github.com/angular/angular/pull/34450/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
angular:masterhttps://github.com/angular/angular/tree/master
pkozlowski-opensource:gh_34349https://github.com/pkozlowski-opensource/angular/tree/gh_34349
Conversation 37 https://github.com/angular/angular/pull/34450
Commits 9 https://github.com/angular/angular/pull/34450/commits
Checks 0 https://github.com/angular/angular/pull/34450/checks
Files changed https://github.com/angular/angular/pull/34450/files
Please reload this pagehttps://github.com/angular/angular/pull/34450/files
fix(ivy): properly bootstrap components with attribute selectors https://github.com/angular/angular/pull/34450/files#top
Show all changes 9 commits https://github.com/angular/angular/pull/34450/files
a7a5a81 fix(ivy): properly bootstrap components with attribute selectors pkozlowski-opensource Dec 18, 2019 https://github.com/angular/angular/pull/34450/commits/a7a5a8118a7a72cd279c2381c8216a42392e769f
d12ef37 fixup! fix(ivy): properly bootstrap components with attribute selectors AndrewKushnir Jan 7, 2020 https://github.com/angular/angular/pull/34450/commits/d12ef375c571f72132594d2f108a012c3e9946ec
a1702e3 fixup! fix(ivy): properly bootstrap components with attribute selectors AndrewKushnir Jan 8, 2020 https://github.com/angular/angular/pull/34450/commits/a1702e386cc4748769b3aa6729cbd93b1c0e31da
41f19e7 fixup! fix(ivy): properly bootstrap components with attribute selectors AndrewKushnir Jan 8, 2020 https://github.com/angular/angular/pull/34450/commits/41f19e76c064fc4bbafa400f8d78c20dcabf8dae
881c661 fixup! fix(ivy): properly bootstrap components with attribute selectors AndrewKushnir Jan 8, 2020 https://github.com/angular/angular/pull/34450/commits/881c661d1e3902117917dfbc6d5db38a3f4c31b7
f04513a fixup! fix(ivy): properly bootstrap components with attribute selectors AndrewKushnir Jan 11, 2020 https://github.com/angular/angular/pull/34450/commits/f04513a7a84d21e8b01610a538cc3c9c0e943ff4
cb175f2 fixup! fix(ivy): properly bootstrap components with attribute selectors AndrewKushnir Jan 11, 2020 https://github.com/angular/angular/pull/34450/commits/cb175f20c853666d6d776fa2727102ee81e30d39
361303b fixup! fix(ivy): properly bootstrap components with attribute selectors AndrewKushnir Jan 13, 2020 https://github.com/angular/angular/pull/34450/commits/361303be118e93a16293e8a121c5e00e56be21b8
1bd14bc fixup! fix(ivy): properly bootstrap components with attribute selectors AndrewKushnir Jan 13, 2020 https://github.com/angular/angular/pull/34450/commits/1bd14bc33844bb482ed2e0674bdb3c0ae1ed53b5
Clear filters https://github.com/angular/angular/pull/34450/files
Please reload this pagehttps://github.com/angular/angular/pull/34450/files
Please reload this pagehttps://github.com/angular/angular/pull/34450/files
_payload-limits.json https://github.com/angular/angular/pull/34450/files#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
component_ref.ts https://github.com/angular/angular/pull/34450/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
node_selector_matcher.ts https://github.com/angular/angular/pull/34450/files#diff-37dbb47bf0ccabfbd56c0d9f29af035b9f4b363305c08d61145f1c503ba294e3
bootstrap_spec.ts https://github.com/angular/angular/pull/34450/files#diff-a278c337cc132ab6dabc060051cf16464a4b79c3d44d30411109e6e5b5728462
component_spec.ts https://github.com/angular/angular/pull/34450/files#diff-643fb6fba30c079e8af789fb3b3a2fd56c42ec205130c76899932a0aba490f91
component_ref_spec.ts https://github.com/angular/angular/pull/34450/files#diff-093b19c444b6779f0fa21da49017c7992bfd73c61e9c77e62b7195b206aa64ea
node_selector_matcher_spec.ts https://github.com/angular/angular/pull/34450/files#diff-8b3bf6ade144e8ca4c55e8373ddb49c5feeda641ed00b6a2158bc06e4fe6d58f
integration/_payload-limits.jsonhttps://github.com/angular/angular/pull/34450/files#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
View file https://github.com/pkozlowski-opensource/angular/blob/1bd14bc33844bb482ed2e0674bdb3c0ae1ed53b5/integration/_payload-limits.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34450/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34450/files#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
https://github.com/angular/angular/pull/34450/files#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
https://github.com/angular/angular/pull/34450/files#diff-92e24bba3b8306d17009d4e80f9c1bca7c2b0df877510cb9ce29257827b4fc49
packages/core/src/render3/component_ref.tshttps://github.com/angular/angular/pull/34450/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
View file https://github.com/pkozlowski-opensource/angular/blob/1bd14bc33844bb482ed2e0674bdb3c0ae1ed53b5/packages/core/src/render3/component_ref.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34450/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34450/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
https://github.com/angular/angular/pull/34450/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
https://github.com/angular/angular/pull/34450/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
https://github.com/angular/angular/pull/34450/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
https://github.com/angular/angular/pull/34450/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
packages/core/src/render3/node_selector_matcher.tshttps://github.com/angular/angular/pull/34450/files#diff-37dbb47bf0ccabfbd56c0d9f29af035b9f4b363305c08d61145f1c503ba294e3
View file https://github.com/pkozlowski-opensource/angular/blob/1bd14bc33844bb482ed2e0674bdb3c0ae1ed53b5/packages/core/src/render3/node_selector_matcher.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34450/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34450/files#diff-37dbb47bf0ccabfbd56c0d9f29af035b9f4b363305c08d61145f1c503ba294e3
packages/core/test/acceptance/bootstrap_spec.tshttps://github.com/angular/angular/pull/34450/files#diff-a278c337cc132ab6dabc060051cf16464a4b79c3d44d30411109e6e5b5728462
View file https://github.com/pkozlowski-opensource/angular/blob/1bd14bc33844bb482ed2e0674bdb3c0ae1ed53b5/packages/core/test/acceptance/bootstrap_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34450/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34450/files#diff-a278c337cc132ab6dabc060051cf16464a4b79c3d44d30411109e6e5b5728462
Please reload this pagehttps://github.com/angular/angular/pull/34450/files
https://github.com/angular/angular/pull/34450/files#diff-a278c337cc132ab6dabc060051cf16464a4b79c3d44d30411109e6e5b5728462
packages/core/test/acceptance/component_spec.tshttps://github.com/angular/angular/pull/34450/files#diff-643fb6fba30c079e8af789fb3b3a2fd56c42ec205130c76899932a0aba490f91
View file https://github.com/pkozlowski-opensource/angular/blob/1bd14bc33844bb482ed2e0674bdb3c0ae1ed53b5/packages/core/test/acceptance/component_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34450/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34450/files#diff-643fb6fba30c079e8af789fb3b3a2fd56c42ec205130c76899932a0aba490f91
https://github.com/angular/angular/pull/34450/files#diff-643fb6fba30c079e8af789fb3b3a2fd56c42ec205130c76899932a0aba490f91
packages/core/test/render3/component_ref_spec.tshttps://github.com/angular/angular/pull/34450/files#diff-093b19c444b6779f0fa21da49017c7992bfd73c61e9c77e62b7195b206aa64ea
View file https://github.com/pkozlowski-opensource/angular/blob/1bd14bc33844bb482ed2e0674bdb3c0ae1ed53b5/packages/core/test/render3/component_ref_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34450/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34450/files#diff-093b19c444b6779f0fa21da49017c7992bfd73c61e9c77e62b7195b206aa64ea
https://github.com/angular/angular/pull/34450/files#diff-093b19c444b6779f0fa21da49017c7992bfd73c61e9c77e62b7195b206aa64ea
https://github.com/angular/angular/pull/34450/files#diff-093b19c444b6779f0fa21da49017c7992bfd73c61e9c77e62b7195b206aa64ea
https://github.com/angular/angular/pull/34450/files#diff-093b19c444b6779f0fa21da49017c7992bfd73c61e9c77e62b7195b206aa64ea
https://github.com/angular/angular/pull/34450/files#diff-093b19c444b6779f0fa21da49017c7992bfd73c61e9c77e62b7195b206aa64ea
packages/core/test/render3/node_selector_matcher_spec.tshttps://github.com/angular/angular/pull/34450/files#diff-8b3bf6ade144e8ca4c55e8373ddb49c5feeda641ed00b6a2158bc06e4fe6d58f
View file https://github.com/pkozlowski-opensource/angular/blob/1bd14bc33844bb482ed2e0674bdb3c0ae1ed53b5/packages/core/test/render3/node_selector_matcher_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34450/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34450/files#diff-8b3bf6ade144e8ca4c55e8373ddb49c5feeda641ed00b6a2158bc06e4fe6d58f
https://github.com/angular/angular/pull/34450/files#diff-8b3bf6ade144e8ca4c55e8373ddb49c5feeda641ed00b6a2158bc06e4fe6d58f
https://github.com/angular/angular/pull/34450/files#diff-8b3bf6ade144e8ca4c55e8373ddb49c5feeda641ed00b6a2158bc06e4fe6d58f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.