René's URL Explorer Experiment


Title: fix(ivy): properly bootstrap components with attribute selectors by pkozlowski-opensource · Pull Request #34450 · angular/angular · GitHub

Open Graph Title: fix(ivy): properly bootstrap components with attribute selectors by pkozlowski-opensource · Pull Request #34450 · angular/angular

X Title: fix(ivy): properly bootstrap components with attribute selectors by pkozlowski-opensource · Pull Request #34450 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Before this change ivy didn't properly bootstrap components that used selectors more complex than a tag name. The crux of the issue is that we were trying to use the selectors property of a com...

X Description: Before this change ivy didn't properly bootstrap components that used selectors more complex than a tag name. The crux of the issue is that we were trying to use the selectors property of a...

Opengraph URL: https://github.com/angular/angular/pull/34450

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8cc440ab-04f6-55f9-73fd-2fac14eefb43
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD76:2E5652:15C1016:1BB9C27:6B013380
html-safe-nonce1464b9a16b476e8ceefd574deaf20aaaa16c6835d09a855509f90fb6a65df62d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDc2OjJFNTY1MjoxNUMxMDE2OjFCQjlDMjc6NkIwMTMzODAiLCJ2aXNpdG9yX2lkIjoiMjAzMTczNTMyOTE0MDA2MTA1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf5a4c5fe594fd1345f83ccbee731878fb78f399b8b4ad4c101988e22c757baee
hovercard-subject-tagpull_request:354210882
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34450/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6cdf090cc80409d66e2ba197dd3ac75215a9a5c8d3591a759567ffed122f455c/angular/angular/pull/34450
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6cdf090cc80409d66e2ba197dd3ac75215a9a5c8d3591a759567ffed122f455c/angular/angular/pull/34450
og:image:altBefore this change ivy didn't properly bootstrap components that used selectors more complex than a tag name. The crux of the issue is that we were trying to use the selectors property of a com...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepkozlowski-opensource
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/34450#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34450
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34450
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34450
Reloadhttps://github.com/angular/angular/pull/34450
Reloadhttps://github.com/angular/angular/pull/34450
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
angular:masterhttps://github.com/angular/angular/tree/master
pkozlowski-opensource:gh_34349https://github.com/pkozlowski-opensource/angular/tree/gh_34349
Conversationhttps://github.com/angular/angular/pull/34450
Commits9 (9)https://github.com/angular/angular/pull/34450/commits
Checkshttps://github.com/angular/angular/pull/34450/checks
Files changedhttps://github.com/angular/angular/pull/34450/files
fix(ivy): properly bootstrap components with attribute selectorshttps://github.com/angular/angular/pull/34450#top
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
angular:masterhttps://github.com/angular/angular/tree/master
pkozlowski-opensource:gh_34349https://github.com/pkozlowski-opensource/angular/tree/gh_34349
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Dec 17, 2019https://github.com/angular/angular/pull/34450#issue-539192064
#34349https://github.com/angular/angular/issues/34349
Please reload this pagehttps://github.com/angular/angular/pull/34450
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Dec 17, 2019https://github.com/angular/angular/pull/34450#event-2890602673
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Dec 17, 2019https://github.com/angular/angular/pull/34450#issuecomment-566652721
#31812https://github.com/angular/angular/pull/31812
Please reload this pagehttps://github.com/angular/angular/pull/34450
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
force-pushedhttps://github.com/angular/angular/compare/b29ec677d6ed2591f0090e41d66688111afcc4c5..580142510e6166be50d2a65d5e737ebd5d4d48c6
b29ec67https://github.com/angular/angular/commit/b29ec677d6ed2591f0090e41d66688111afcc4c5
5801425https://github.com/angular/angular/commit/580142510e6166be50d2a65d5e737ebd5d4d48c6
Compare https://github.com/angular/angular/compare/b29ec677d6ed2591f0090e41d66688111afcc4c5..580142510e6166be50d2a65d5e737ebd5d4d48c6
December 17, 2019 17:35https://github.com/angular/angular/pull/34450#event-2890735632
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Dec 18, 2019 https://github.com/angular/angular/pull/34450#pullrequestreview-333668994
View reviewed changes https://github.com/angular/angular/pull/34450/files
packages/core/src/render3/component_ref.tshttps://github.com/angular/angular/pull/34450/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
Please reload this pagehttps://github.com/angular/angular/pull/34450
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
force-pushedhttps://github.com/angular/angular/compare/580142510e6166be50d2a65d5e737ebd5d4d48c6..7fc8417d4d6de88774ec6b33808537cf42fb64a9
5801425https://github.com/angular/angular/commit/580142510e6166be50d2a65d5e737ebd5d4d48c6
7fc8417https://github.com/angular/angular/commit/7fc8417d4d6de88774ec6b33808537cf42fb64a9
Compare https://github.com/angular/angular/compare/580142510e6166be50d2a65d5e737ebd5d4d48c6..7fc8417d4d6de88774ec6b33808537cf42fb64a9
December 18, 2019 13:36https://github.com/angular/angular/pull/34450#event-2893565767
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
comp: ivy https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Dec 18, 2019https://github.com/angular/angular/pull/34450#event-2893716514
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Dec 18, 2019https://github.com/angular/angular/pull/34450#event-2893716623
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Dec 18, 2019https://github.com/angular/angular/pull/34450#event-2893716769
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
December 18, 2019 14:20https://github.com/angular/angular/pull/34450#event-2893717809
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
December 18, 2019 14:20https://github.com/angular/angular/pull/34450#event-2893717817
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Dec 18, 2019 https://github.com/angular/angular/pull/34450#pullrequestreview-334167489
View reviewed changes https://github.com/angular/angular/pull/34450/files
AndrewKushnirhttps://github.com/AndrewKushnir
https://github.com/angular/angular/pull/34450#pullrequestreview-334167489
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Please reload this pagehttps://github.com/angular/angular/pull/34450
packages/core/src/render3/node_selector_matcher.tshttps://github.com/angular/angular/pull/34450/files#diff-37dbb47bf0ccabfbd56c0d9f29af035b9f4b363305c08d61145f1c503ba294e3
Please reload this pagehttps://github.com/angular/angular/pull/34450
packages/core/src/render3/node_selector_matcher.tshttps://github.com/angular/angular/pull/34450/files#diff-37dbb47bf0ccabfbd56c0d9f29af035b9f4b363305c08d61145f1c503ba294e3
Please reload this pagehttps://github.com/angular/angular/pull/34450
packages/core/src/render3/node_selector_matcher.tshttps://github.com/angular/angular/pull/34450/files#diff-37dbb47bf0ccabfbd56c0d9f29af035b9f4b363305c08d61145f1c503ba294e3
Please reload this pagehttps://github.com/angular/angular/pull/34450
packages/core/src/render3/node_selector_matcher.tshttps://github.com/angular/angular/pull/34450/files#diff-37dbb47bf0ccabfbd56c0d9f29af035b9f4b363305c08d61145f1c503ba294e3
Please reload this pagehttps://github.com/angular/angular/pull/34450
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
karahttps://github.com/kara
December 18, 2019 18:25https://github.com/angular/angular/pull/34450#event-2894562814
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Dec 19, 2019 https://github.com/angular/angular/pull/34450#ref-pullrequest-540009445
fix(ivy): add attributes and classes to host elements based on selector #34481 https://github.com/angular/angular/pull/34481
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
force-pushedhttps://github.com/angular/angular/compare/77921c9a1d19980ef8a42393b5d9c31fcc232b62..8cebb0744f9e3bc5b763f9126a500e92353237a8
77921c9https://github.com/angular/angular/commit/77921c9a1d19980ef8a42393b5d9c31fcc232b62
8cebb07https://github.com/angular/angular/commit/8cebb0744f9e3bc5b763f9126a500e92353237a8
Compare https://github.com/angular/angular/compare/77921c9a1d19980ef8a42393b5d9c31fcc232b62..8cebb0744f9e3bc5b763f9126a500e92353237a8
January 7, 2020 23:59https://github.com/angular/angular/pull/34450#event-2929450854
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
January 7, 2020 23:59https://github.com/angular/angular/pull/34450#event-2929451437
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jan 8, 2020https://github.com/angular/angular/pull/34450#issuecomment-571829902
@pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
@karahttps://github.com/kara
8cebb07https://github.com/angular/angular/commit/8cebb0744f9e3bc5b763f9126a500e92353237a8
Please reload this pagehttps://github.com/angular/angular/pull/34450
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Jan 8, 2020 https://github.com/angular/angular/pull/34450#pullrequestreview-339718950
View reviewed changes https://github.com/angular/angular/pull/34450/files
packages/core/src/render3/component_ref.tshttps://github.com/angular/angular/pull/34450/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
Please reload this pagehttps://github.com/angular/angular/pull/34450
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jan 8, 2020https://github.com/angular/angular/pull/34450#issuecomment-572229732
@pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Please reload this pagehttps://github.com/angular/angular/pull/34450
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
January 8, 2020 20:16https://github.com/angular/angular/pull/34450#event-2932582769
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jan 9, 2020https://github.com/angular/angular/pull/34450#issuecomment-572332148
Presubmithttp://test/OCL:288804718:BASE:288804753:1578531852265:a8e916b5
Please reload this pagehttps://github.com/angular/angular/pull/34450
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
Jan 9, 2020https://github.com/angular/angular/pull/34450#issuecomment-572492848
@AndrewKushnirhttps://github.com/AndrewKushnir
Please reload this pagehttps://github.com/angular/angular/pull/34450
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
January 9, 2020 18:52https://github.com/angular/angular/pull/34450#event-2936063361
https://github.com/kara
karahttps://github.com/kara
Jan 10, 2020 https://github.com/angular/angular/pull/34450#pullrequestreview-341469172
View reviewed changes https://github.com/angular/angular/pull/34450/files
karahttps://github.com/kara
https://github.com/angular/angular/pull/34450#pullrequestreview-341469172
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34450
packages/core/src/render3/component_ref.tshttps://github.com/angular/angular/pull/34450/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
Please reload this pagehttps://github.com/angular/angular/pull/34450
packages/core/test/render3/node_selector_matcher_spec.tshttps://github.com/angular/angular/pull/34450/files#diff-8b3bf6ade144e8ca4c55e8373ddb49c5feeda641ed00b6a2158bc06e4fe6d58f
Please reload this pagehttps://github.com/angular/angular/pull/34450
packages/core/src/render3/component_ref.tshttps://github.com/angular/angular/pull/34450/files#diff-fbe47ef469fbcadacf26a64f541e153f84265cc652a191a72ab3159abfcdb052
Please reload this pagehttps://github.com/angular/angular/pull/34450
packages/core/src/render3/node_selector_matcher.tshttps://github.com/angular/angular/pull/34450/files#diff-37dbb47bf0ccabfbd56c0d9f29af035b9f4b363305c08d61145f1c503ba294e3
Please reload this pagehttps://github.com/angular/angular/pull/34450
https://github.com/kara
karahttps://github.com/kara
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Jan 10, 2020https://github.com/angular/angular/pull/34450#event-2940177184
https://github.com/kara
karahttps://github.com/kara
AndrewKushnirhttps://github.com/AndrewKushnir
Jan 10, 2020https://github.com/angular/angular/pull/34450#event-2940177303
https://github.com/kara
karahttps://github.com/kara
AndrewKushnirhttps://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
January 10, 2020 23:39https://github.com/angular/angular/pull/34450#event-2940177357
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jan 11, 2020https://github.com/angular/angular/pull/34450#issuecomment-573260760
@karahttps://github.com/kara
Please reload this pagehttps://github.com/angular/angular/pull/34450
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Jan 11, 2020https://github.com/angular/angular/pull/34450#event-2940266155
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jan 11, 2020https://github.com/angular/angular/pull/34450#issuecomment-573261435
Presubmithttp://test/OCL:289191495:BASE:289191512:1578704263960:20ec2070
Please reload this pagehttps://github.com/angular/angular/pull/34450
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Jan 13, 2020https://github.com/angular/angular/pull/34450#event-2943886705
https://github.com/kara
karahttps://github.com/kara
January 13, 2020 21:03https://github.com/angular/angular/pull/34450#event-2944755715
https://github.com/kara
karahttps://github.com/kara
Jan 13, 2020 https://github.com/angular/angular/pull/34450#pullrequestreview-342202703
View reviewed changes https://github.com/angular/angular/pull/34450/files
karahttps://github.com/kara
https://github.com/angular/angular/pull/34450#pullrequestreview-342202703
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34450
packages/core/src/render3/node_selector_matcher.tshttps://github.com/angular/angular/pull/34450/files#diff-37dbb47bf0ccabfbd56c0d9f29af035b9f4b363305c08d61145f1c503ba294e3
Please reload this pagehttps://github.com/angular/angular/pull/34450
packages/core/src/render3/node_selector_matcher.tshttps://github.com/angular/angular/pull/34450/files#diff-37dbb47bf0ccabfbd56c0d9f29af035b9f4b363305c08d61145f1c503ba294e3
Please reload this pagehttps://github.com/angular/angular/pull/34450
packages/core/test/acceptance/bootstrap_spec.tshttps://github.com/angular/angular/pull/34450/files#diff-a278c337cc132ab6dabc060051cf16464a4b79c3d44d30411109e6e5b5728462
Please reload this pagehttps://github.com/angular/angular/pull/34450
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
January 13, 2020 15:30https://github.com/angular/angular/pull/34450#commits-pushed-a7a5a81
https://github.com/pkozlowski-opensource
https://github.com/AndrewKushnir
fix(ivy): properly bootstrap components with attribute selectorshttps://github.com/angular/angular/pull/34450/commits/a7a5a8118a7a72cd279c2381c8216a42392e769f
a7a5a81https://github.com/angular/angular/pull/34450/commits/a7a5a8118a7a72cd279c2381c8216a42392e769f
angular#34349https://github.com/angular/angular/issues/34349
https://github.com/AndrewKushnir
fixup! fix(ivy): properly bootstrap components with attribute selectorshttps://github.com/angular/angular/pull/34450/commits/d12ef375c571f72132594d2f108a012c3e9946ec
d12ef37https://github.com/angular/angular/pull/34450/commits/d12ef375c571f72132594d2f108a012c3e9946ec
https://github.com/AndrewKushnir
fixup! fix(ivy): properly bootstrap components with attribute selectorshttps://github.com/angular/angular/pull/34450/commits/a1702e386cc4748769b3aa6729cbd93b1c0e31da
a1702e3https://github.com/angular/angular/pull/34450/commits/a1702e386cc4748769b3aa6729cbd93b1c0e31da
https://github.com/AndrewKushnir
fixup! fix(ivy): properly bootstrap components with attribute selectorshttps://github.com/angular/angular/pull/34450/commits/41f19e76c064fc4bbafa400f8d78c20dcabf8dae
41f19e7https://github.com/angular/angular/pull/34450/commits/41f19e76c064fc4bbafa400f8d78c20dcabf8dae
https://github.com/AndrewKushnir
fixup! fix(ivy): properly bootstrap components with attribute selectorshttps://github.com/angular/angular/pull/34450/commits/881c661d1e3902117917dfbc6d5db38a3f4c31b7
881c661https://github.com/angular/angular/pull/34450/commits/881c661d1e3902117917dfbc6d5db38a3f4c31b7
https://github.com/AndrewKushnir
fixup! fix(ivy): properly bootstrap components with attribute selectorshttps://github.com/angular/angular/pull/34450/commits/f04513a7a84d21e8b01610a538cc3c9c0e943ff4
f04513ahttps://github.com/angular/angular/pull/34450/commits/f04513a7a84d21e8b01610a538cc3c9c0e943ff4
https://github.com/AndrewKushnir
fixup! fix(ivy): properly bootstrap components with attribute selectorshttps://github.com/angular/angular/pull/34450/commits/cb175f20c853666d6d776fa2727102ee81e30d39
cb175f2https://github.com/angular/angular/pull/34450/commits/cb175f20c853666d6d776fa2727102ee81e30d39
https://github.com/AndrewKushnir
fixup! fix(ivy): properly bootstrap components with attribute selectorshttps://github.com/angular/angular/pull/34450/commits/361303be118e93a16293e8a121c5e00e56be21b8
361303bhttps://github.com/angular/angular/pull/34450/commits/361303be118e93a16293e8a121c5e00e56be21b8
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
force-pushedhttps://github.com/angular/angular/compare/57fdfc72e483fe0ed17f1c66ab0f8618792931fd..361303be118e93a16293e8a121c5e00e56be21b8
57fdfc7https://github.com/angular/angular/commit/57fdfc72e483fe0ed17f1c66ab0f8618792931fd
361303bhttps://github.com/angular/angular/commit/361303be118e93a16293e8a121c5e00e56be21b8
Compare https://github.com/angular/angular/compare/57fdfc72e483fe0ed17f1c66ab0f8618792931fd..361303be118e93a16293e8a121c5e00e56be21b8
January 13, 2020 23:30https://github.com/angular/angular/pull/34450#event-2945146201
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jan 13, 2020 https://github.com/angular/angular/pull/34450#pullrequestreview-342209585
View reviewed changes https://github.com/angular/angular/pull/34450/files/361303be118e93a16293e8a121c5e00e56be21b8
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jan 13, 2020https://github.com/angular/angular/pull/34450#event-2945148455
https://github.com/AndrewKushnir
fixup! fix(ivy): properly bootstrap components with attribute selectorshttps://github.com/angular/angular/pull/34450/commits/1bd14bc33844bb482ed2e0674bdb3c0ae1ed53b5
1bd14bchttps://github.com/angular/angular/pull/34450/commits/1bd14bc33844bb482ed2e0674bdb3c0ae1ed53b5
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Jan 14, 2020https://github.com/angular/angular/pull/34450#event-2945240443
atscotthttps://github.com/atscott
Jan 14, 2020 https://github.com/angular/angular/pull/34450#ref-commit-2c0b9ea
https://github.com/pkozlowski-opensource
https://github.com/atscott
fix(ivy): properly bootstrap components with attribute selectors (https://github.com/angular/angular/commit/2c0b9ea310d04e15d27facac7ab46d341ce18410
#34450https://github.com/angular/angular/pull/34450
https://github.com/angular/angular/commit/2c0b9ea310d04e15d27facac7ab46d341ce18410#comments
2c0b9eahttps://github.com/angular/angular/commit/2c0b9ea310d04e15d27facac7ab46d341ce18410
https://github.com/angular/angular/pull/34450
#34349https://github.com/angular/angular/issues/34349
#34450https://github.com/angular/angular/pull/34450
https://github.com/atscott
atscotthttps://github.com/atscott
2776810https://github.com/angular/angular/commit/277681096d78eba35783b31f871771b33d999e64
Jan 14, 2020https://github.com/angular/angular/pull/34450#event-2948024139
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Feb 14, 2020https://github.com/angular/angular/pull/34450#issuecomment-586354995
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/34450
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Feb 14, 2020https://github.com/angular/angular/pull/34450#event-3039282012
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34450
https://github.com/AndrewKushnir
AndrewKushnir https://github.com/AndrewKushnir
https://github.com/angular/angular/pull/34450/files/361303be118e93a16293e8a121c5e00e56be21b8
https://github.com/kara
kara https://github.com/kara
https://github.com/angular/angular/pull/34450/files/b98cd44a4f8cc281a86d2e09af9e340238a19346
Please reload this pagehttps://github.com/angular/angular/pull/34450
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
needsTriage https://github.com/angular/angular/milestone/83
Attribute selector when running with Ivy https://github.com/angular/angular/issues/34349
Please reload this pagehttps://github.com/angular/angular/pull/34450
https://github.com/pkozlowski-opensource
https://github.com/AndrewKushnir
https://github.com/kara
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.