René's URL Explorer Experiment


Title: fix(core): Ensure checkNoChanges runs for OnPush components by atscott · Pull Request #34443 · angular/angular · GitHub

Open Graph Title: fix(core): Ensure checkNoChanges runs for OnPush components by atscott · Pull Request #34443 · angular/angular

X Title: fix(core): Ensure checkNoChanges runs for OnPush components by atscott · Pull Request #34443 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Add additional CheckNoChanges flag to indicate the view needs to be checked during CheckNoChanges pass. This fixes the problem of the dirty flag being cleared during regular change detection and th...

X Description: Add additional CheckNoChanges flag to indicate the view needs to be checked during CheckNoChanges pass. This fixes the problem of the dirty flag being cleared during regular change detection and th...

Opengraph URL: https://github.com/angular/angular/pull/34443

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fc830df8-1bc3-c0f5-209a-d1313ed685d2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9E72:DA744:B79E82:F78DB7:6B00F9AE
html-safe-nonce17445162fc1e001d40cce9d225b566ee7813397632725b54d1a8c338584ed12c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTcyOkRBNzQ0OkI3OUU4MjpGNzhEQjc6NkIwMEY5QUUiLCJ2aXNpdG9yX2lkIjoiNzQyODMzMjM1NDY5Mjc3NDMxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb1d528b2980fa5010c237a31c39b2a1b045ac61897fcea19c5e7631e42271129
hovercard-subject-tagpull_request:353835889
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34443/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/52d8962f2c268fff8a8b53d7ad25d0f72ef8f705c7b825e349a37c4221af312e/angular/angular/pull/34443
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/52d8962f2c268fff8a8b53d7ad25d0f72ef8f705c7b825e349a37c4221af312e/angular/angular/pull/34443
og:image:altAdd additional CheckNoChanges flag to indicate the view needs to be checked during CheckNoChanges pass. This fixes the problem of the dirty flag being cleared during regular change detection and th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameatscott
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/34443#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34443
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34443
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34443
Reloadhttps://github.com/angular/angular/pull/34443
Reloadhttps://github.com/angular/angular/pull/34443
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
atscotthttps://github.com/atscott
angular:masterhttps://github.com/angular/angular/tree/master
atscott:checknochangeshttps://github.com/atscott/angular/tree/checknochanges
Conversationhttps://github.com/angular/angular/pull/34443
Commits3 (3)https://github.com/angular/angular/pull/34443/commits
Checkshttps://github.com/angular/angular/pull/34443/checks
Files changedhttps://github.com/angular/angular/pull/34443/files
fix(core): Ensure checkNoChanges runs for OnPush componentshttps://github.com/angular/angular/pull/34443#top
atscotthttps://github.com/atscott
angular:masterhttps://github.com/angular/angular/tree/master
atscott:checknochangeshttps://github.com/atscott/angular/tree/checknochanges
https://github.com/atscott
atscotthttps://github.com/atscott
Dec 16, 2019https://github.com/angular/angular/pull/34443#issue-538737221
Please reload this pagehttps://github.com/angular/angular/pull/34443
Please reload this pagehttps://github.com/angular/angular/pull/34443
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Dec 16, 2019https://github.com/angular/angular/pull/34443#event-2887870489
https://github.com/atscott
atscotthttps://github.com/atscott
force-pushedhttps://github.com/angular/angular/compare/7e3331f7fce26fa8d5b513a72874b05cb65c0340..a0e3d7d99f0c3c16f3852fd533c201b3557ed0e1
7e3331fhttps://github.com/angular/angular/commit/7e3331f7fce26fa8d5b513a72874b05cb65c0340
a0e3d7dhttps://github.com/angular/angular/commit/a0e3d7d99f0c3c16f3852fd533c201b3557ed0e1
Compare https://github.com/angular/angular/compare/7e3331f7fce26fa8d5b513a72874b05cb65c0340..a0e3d7d99f0c3c16f3852fd533c201b3557ed0e1
December 17, 2019 00:47https://github.com/angular/angular/pull/34443#event-2888027958
https://github.com/atscott
atscotthttps://github.com/atscott
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
Dec 17, 2019https://github.com/angular/angular/pull/34443#event-2890487760
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Dec 17, 2019https://github.com/angular/angular/pull/34443#event-2890487924
https://github.com/atscott
atscotthttps://github.com/atscott
Dec 17, 2019https://github.com/angular/angular/pull/34443#issuecomment-566640525
Please reload this pagehttps://github.com/angular/angular/pull/34443
VE presubmithttps://test.corp.google.com/ui#id=OCL:286080206:BASE:286080251:1576627392180:617c172d
Ivy presubmithttps://test.corp.google.com/ui#id=OCL:286080206:BASE:286080251:1576627392217:3fa0f86f
Please reload this pagehttps://github.com/angular/angular/pull/34443
https://github.com/atscott
atscotthttps://github.com/atscott
force-pushedhttps://github.com/angular/angular/compare/069f23085a495472d2fce122b4fb0c433fa78858..9af7fd3a77d2871b436f0363f4a1a87176af28b5
069f230https://github.com/angular/angular/commit/069f23085a495472d2fce122b4fb0c433fa78858
9af7fd3https://github.com/angular/angular/commit/9af7fd3a77d2871b436f0363f4a1a87176af28b5
Compare https://github.com/angular/angular/compare/069f23085a495472d2fce122b4fb0c433fa78858..9af7fd3a77d2871b436f0363f4a1a87176af28b5
December 18, 2019 00:09https://github.com/angular/angular/pull/34443#event-2891782211
https://github.com/atscott
atscotthttps://github.com/atscott
Dec 19, 2019https://github.com/angular/angular/pull/34443#event-2898306405
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
AndrewKushnirhttps://github.com/AndrewKushnir
February 5, 2020 22:23https://github.com/angular/angular/pull/34443#event-3011825720
atscotthttps://github.com/atscott
March 6, 2020 09:36https://github.com/angular/angular/pull/34443#commits-pushed-0f5c43f
https://github.com/atscott
fix(core): Ensure checkNoChanges runs for OnPush componentshttps://github.com/angular/angular/pull/34443/commits/0f5c43ff283d642f2de31762ff6ac8474fd31330
0f5c43fhttps://github.com/angular/angular/pull/34443/commits/0f5c43ff283d642f2de31762ff6ac8474fd31330
https://github.com/atscott
fixup! fix(core): Ensure checkNoChanges runs for OnPush componentshttps://github.com/angular/angular/pull/34443/commits/65db978cb0fadcf71ea9da5d69822eed52ad2301
65db978https://github.com/angular/angular/pull/34443/commits/65db978cb0fadcf71ea9da5d69822eed52ad2301
https://github.com/atscott
fixup! fix(core): Ensure checkNoChanges runs for OnPush componentshttps://github.com/angular/angular/pull/34443/commits/e0e7def15bae30a2df158eb6d096e37d92c7f7a8
e0e7defhttps://github.com/angular/angular/pull/34443/commits/e0e7def15bae30a2df158eb6d096e37d92c7f7a8
https://github.com/atscott
atscotthttps://github.com/atscott
force-pushedhttps://github.com/angular/angular/compare/f589987eebe0929d83f9194799f7b49c15a70102..e0e7def15bae30a2df158eb6d096e37d92c7f7a8
f589987https://github.com/angular/angular/commit/f589987eebe0929d83f9194799f7b49c15a70102
e0e7defhttps://github.com/angular/angular/commit/e0e7def15bae30a2df158eb6d096e37d92c7f7a8
Compare https://github.com/angular/angular/compare/f589987eebe0929d83f9194799f7b49c15a70102..e0e7def15bae30a2df158eb6d096e37d92c7f7a8
March 6, 2020 18:48https://github.com/angular/angular/pull/34443#event-3106463300
https://github.com/atscott
atscotthttps://github.com/atscott
Mar 6, 2020 https://github.com/angular/angular/pull/34443#ref-pullrequest-577134660
fix(material-experimental/mdc-form-field): avoid expression changed a… angular/components#18741 https://github.com/angular/components/pull/18741
https://github.com/atscott
atscotthttps://github.com/atscott
Apr 16, 2020 https://github.com/angular/angular/pull/34443#ref-pullrequest-578108720
fix(core): Refresh transplanted views at insertion point only #35968 https://github.com/angular/angular/pull/35968
https://github.com/atscott
atscotthttps://github.com/atscott
Sep 11, 2020 https://github.com/angular/angular/pull/34443#ref-issue-342401920
OnPush change detection doesn't work for outputs emitted from lifecycle callbacks #24965 https://github.com/angular/angular/issues/24965
https://github.com/atscott
atscotthttps://github.com/atscott
Nov 2, 2020 https://github.com/angular/angular/pull/34443#ref-pullrequest-730919891
fix(core): dynamic onPush component should trigger change detection correctly #39463 https://github.com/angular/angular/pull/39463
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
December 1, 2020 05:45https://github.com/angular/angular/pull/34443#event-4055258446
https://github.com/atscott
atscotthttps://github.com/atscott
Aug 30, 2021https://github.com/angular/angular/pull/34443#issuecomment-908768982
Please reload this pagehttps://github.com/angular/angular/pull/34443
https://github.com/atscott
atscotthttps://github.com/atscott
Aug 30, 2021https://github.com/angular/angular/pull/34443#event-5229112670
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 30, 2021https://github.com/angular/angular/pull/34443#issuecomment-931463803
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/34443
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 30, 2021https://github.com/angular/angular/pull/34443#event-5388872810
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34443
Please reload this pagehttps://github.com/angular/angular/pull/34443
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/34443
https://github.com/atscott
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.