René's URL Explorer Experiment


Title: refactor(compiler-cli): avoid unnecessarily calling `getSourceFile()` twice in `PartialEvaluator` by gkalpak · Pull Request #34441 · angular/angular · GitHub

Open Graph Title: refactor(compiler-cli): avoid unnecessarily calling `getSourceFile()` twice in `PartialEvaluator` by gkalpak · Pull Request #34441 · angular/angular

X Title: refactor(compiler-cli): avoid unnecessarily calling `getSourceFile()` twice in `PartialEvaluator` by gkalpak · Pull Request #34441 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This is not expected to have any noticeable perf impact, but it wasteful nonetheless (and annoying when stepping through the code while debugging ngtsc/ngcc).

X Description: This is not expected to have any noticeable perf impact, but it wasteful nonetheless (and annoying when stepping through the code while debugging ngtsc/ngcc).

Opengraph URL: https://github.com/angular/angular/pull/34441

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:27b002e5-2677-d3ba-dce8-5c4bac7758b1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD83A:B53AF:11DACB7:17C7876:6B011D3F
html-safe-nonceae8ae647d70f1b952b92cb91ad71e8a1cc04c20e79651d7e28713c2bb031e5a1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODNBOkI1M0FGOjExREFDQjc6MTdDNzg3Njo2QjAxMUQzRiIsInZpc2l0b3JfaWQiOiIxMDEyNDM2MzM0NDkwNDkyMjIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf8a459fcd4f83c91e70465abf6f0872e094a1373ae148f0582fb0c06750b638e
hovercard-subject-tagpull_request:353764313
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34441/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dadc715807efdd09bf6d3fdcaec46c31f22aa6b46f144e3e6e29a2256ed7d01f/angular/angular/pull/34441
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dadc715807efdd09bf6d3fdcaec46c31f22aa6b46f144e3e6e29a2256ed7d01f/angular/angular/pull/34441
og:image:altThis is not expected to have any noticeable perf impact, but it wasteful nonetheless (and annoying when stepping through the code while debugging ngtsc/ngcc).
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegkalpak
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/34441#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34441
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34441
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34441
Reloadhttps://github.com/angular/angular/pull/34441
Reloadhttps://github.com/angular/angular/pull/34441
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:refactor-compiler-cli-minorhttps://github.com/gkalpak/angular/tree/refactor-compiler-cli-minor
Conversationhttps://github.com/angular/angular/pull/34441
Commits1 (1)https://github.com/angular/angular/pull/34441/commits
Checkshttps://github.com/angular/angular/pull/34441/checks
Files changedhttps://github.com/angular/angular/pull/34441/files
refactor(compiler-cli): avoid unnecessarily calling getSourceFile() twice in PartialEvaluatorhttps://github.com/angular/angular/pull/34441#top
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:refactor-compiler-cli-minorhttps://github.com/gkalpak/angular/tree/refactor-compiler-cli-minor
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 16, 2019https://github.com/angular/angular/pull/34441#issue-538654373
Please reload this pagehttps://github.com/angular/angular/pull/34441
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
December 16, 2019 20:58https://github.com/angular/angular/pull/34441#event-2887460730
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Dec 16, 2019https://github.com/angular/angular/pull/34441#event-2887460964
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
comp: ivy https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Dec 16, 2019https://github.com/angular/angular/pull/34441#event-2887463690
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Dec 16, 2019https://github.com/angular/angular/pull/34441#event-2887463872
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
refactoring https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Arefactoring
Dec 16, 2019https://github.com/angular/angular/pull/34441#event-2887464176
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Dec 16, 2019https://github.com/angular/angular/pull/34441#issuecomment-566243422
https://pr34441-4d64457.ngbuilds.io/https://pr34441-4d64457.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/34441
https://github.com/gkalpak
refactor(compiler-cli): avoid unnecessarily calling getSourceFile()…https://github.com/angular/angular/pull/34441/commits/f6ec49ab2fcc2070858a7a0549e1461dbc0b76ba
f6ec49ahttps://github.com/angular/angular/pull/34441/commits/f6ec49ab2fcc2070858a7a0549e1461dbc0b76ba
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/4d644578bc32fdde280d90d2471d9086cae2340e..f6ec49ab2fcc2070858a7a0549e1461dbc0b76ba
4d64457https://github.com/angular/angular/commit/4d644578bc32fdde280d90d2471d9086cae2340e
f6ec49ahttps://github.com/angular/angular/commit/f6ec49ab2fcc2070858a7a0549e1461dbc0b76ba
Compare https://github.com/angular/angular/compare/4d644578bc32fdde280d90d2471d9086cae2340e..f6ec49ab2fcc2070858a7a0549e1461dbc0b76ba
December 17, 2019 10:04https://github.com/angular/angular/pull/34441#event-2889203865
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 17, 2019 https://github.com/angular/angular/pull/34441#ref-pullrequest-530767200
fix(ngcc): several fixes #34169 https://github.com/angular/angular/pull/34169
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Dec 17, 2019https://github.com/angular/angular/pull/34441#issuecomment-566475409
f6ec49ahttps://github.com/angular/angular/commit/f6ec49ab2fcc2070858a7a0549e1461dbc0b76ba
https://pr34441-f6ec49a.ngbuilds.io/https://pr34441-f6ec49a.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/34441
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
Dec 17, 2019https://github.com/angular/angular/pull/34441#event-2890630267
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Dec 17, 2019 https://github.com/angular/angular/pull/34441#pullrequestreview-333453586
View reviewed changes https://github.com/angular/angular/pull/34441/files/f6ec49ab2fcc2070858a7a0549e1461dbc0b76ba
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Dec 17, 2019 https://github.com/angular/angular/pull/34441#pullrequestreview-333454080
View reviewed changes https://github.com/angular/angular/pull/34441/files/f6ec49ab2fcc2070858a7a0549e1461dbc0b76ba
https://github.com/kara
karahttps://github.com/kara
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Dec 17, 2019https://github.com/angular/angular/pull/34441#event-2891114883
https://github.com/kara
karahttps://github.com/kara
Dec 17, 2019https://github.com/angular/angular/pull/34441#issuecomment-566759085
presubmithttp://test/OCL:286046754:BASE:286046788:1576618236979:ab18bb92
Please reload this pagehttps://github.com/angular/angular/pull/34441
https://github.com/kara
karahttps://github.com/kara
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Dec 17, 2019https://github.com/angular/angular/pull/34441#event-2891435576
karahttps://github.com/kara
Dec 17, 2019 https://github.com/angular/angular/pull/34441#ref-commit-82dce68
https://github.com/gkalpak
https://github.com/kara
refactor(compiler-cli): avoid unnecessarily calling getSourceFile()…https://github.com/angular/angular/commit/82dce68e139b20a8e89e684561263b941d0eb05b
82dce68https://github.com/angular/angular/commit/82dce68e139b20a8e89e684561263b941d0eb05b
#34441https://github.com/angular/angular/pull/34441
#34441https://github.com/angular/angular/pull/34441
https://github.com/kara
karahttps://github.com/kara
7938ff3https://github.com/angular/angular/commit/7938ff34b171e4bbf362f39d9e6e2c8e1abf6486
Dec 17, 2019https://github.com/angular/angular/pull/34441#event-2891599751
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
December 18, 2019 09:35https://github.com/angular/angular/pull/34441#event-2892852485
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jan 18, 2020https://github.com/angular/angular/pull/34441#issuecomment-575912611
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/34441
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jan 18, 2020https://github.com/angular/angular/pull/34441#event-2960303518
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34441
https://github.com/JoostK
JoostK https://github.com/JoostK
https://github.com/angular/angular/pull/34441/files/f6ec49ab2fcc2070858a7a0549e1461dbc0b76ba
https://github.com/petebacondarwin
petebacondarwin https://github.com/petebacondarwin
https://github.com/angular/angular/pull/34441/files/f6ec49ab2fcc2070858a7a0549e1461dbc0b76ba
Please reload this pagehttps://github.com/angular/angular/pull/34441
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
refactoring https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Arefactoring
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/34441
https://github.com/gkalpak
https://github.com/mary-poppins
https://github.com/kara
https://github.com/petebacondarwin
https://github.com/JoostK
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.