| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:36b59a9d-5b81-0cf7-79c0-ba1409f538e4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D85E:3A4875:11D25AC:17BB2AC:6B011D45 |
| html-safe-nonce | a8860d5d1d41eab639e42f9fdfcaa12b2ff460b2af53292104aa1ffb0aaa7165 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODVFOjNBNDg3NToxMUQyNUFDOjE3QkIyQUM6NkIwMTFENDUiLCJ2aXNpdG9yX2lkIjoiMzIzNzI1OTU2MTY2ODc3OTMzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9864738513276ec8aad1374621c4fb9951a7c48abef817d6dfb236cff9d80e61 |
| hovercard-subject-tag | pull_request:353740279 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34437/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/05675c5bb40984e17256cd75ce622a959ca8134533f51d8b15fe983fd759ab96/angular/angular/pull/34437 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/05675c5bb40984e17256cd75ce622a959ca8134533f51d8b15fe983fd759ab96/angular/angular/pull/34437 |
| og:image:alt | A couple of minor ngcc refactorings (see individual commits for details):
refactor(ngcc): add debug messages to help with debugging in parallel mode
refactor(ngcc): un-nest accidentally nested des... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gkalpak |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/34437#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34437 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34437 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/34437 |
| Reload | https://github.com/angular/angular/pull/34437 |
| Reload | https://github.com/angular/angular/pull/34437 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:refactor-ngcc-misc | https://github.com/gkalpak/angular/tree/refactor-ngcc-misc |
| Conversation | https://github.com/angular/angular/pull/34437 |
| Commits2 (2) | https://github.com/angular/angular/pull/34437/commits |
| Checks | https://github.com/angular/angular/pull/34437/checks |
| Files changed | https://github.com/angular/angular/pull/34437/files |
| refactor(ngcc): a couple of minor refactorings | https://github.com/angular/angular/pull/34437#top |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:refactor-ngcc-misc | https://github.com/gkalpak/angular/tree/refactor-ngcc-misc |
|
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Dec 16, 2019 | https://github.com/angular/angular/pull/34437#issue-538626906 |
| Please reload this page | https://github.com/angular/angular/pull/34437 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| December 16, 2019 20:10 | https://github.com/angular/angular/pull/34437#event-2887319583 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Dec 16, 2019 | https://github.com/angular/angular/pull/34437#event-2887319819 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
comp: ngcc
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
|
refactoring
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Arefactoring |
| Dec 16, 2019 | https://github.com/angular/angular/pull/34437#event-2887321317 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Dec 16, 2019 | https://github.com/angular/angular/pull/34437#event-2887321404 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Dec 16, 2019 | https://github.com/angular/angular/pull/34437#event-2887322489 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Dec 16, 2019 | https://github.com/angular/angular/pull/34437#issuecomment-566225887 |
| https://pr34437-27a3737.ngbuilds.io/ | https://pr34437-27a3737.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34437 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/27a37370cb043dac7514259aaa5ce559b30a1cd5..b767076c9ee59c95a5b29601e2729a9748061b30 |
| 27a3737 | https://github.com/angular/angular/commit/27a37370cb043dac7514259aaa5ce559b30a1cd5 |
| b767076 | https://github.com/angular/angular/commit/b767076c9ee59c95a5b29601e2729a9748061b30 |
|
Compare
| https://github.com/angular/angular/compare/27a37370cb043dac7514259aaa5ce559b30a1cd5..b767076c9ee59c95a5b29601e2729a9748061b30 |
| December 16, 2019 20:54 | https://github.com/angular/angular/pull/34437#event-2887448079 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Dec 16, 2019 | https://github.com/angular/angular/pull/34437#issuecomment-566242819 |
| https://pr34437-b767076.ngbuilds.io/ | https://pr34437-b767076.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34437 |
| gkalpak | https://github.com/gkalpak |
| December 17, 2019 12:03 | https://github.com/angular/angular/pull/34437#commits-pushed-c42a635 |
|
| https://github.com/gkalpak |
| refactor(ngcc): add debug messages to help with debugging in parallel… | https://github.com/angular/angular/pull/34437/commits/c42a635167008cf60eb40231d29c9bd7e60733ee |
| c42a635 | https://github.com/angular/angular/pull/34437/commits/c42a635167008cf60eb40231d29c9bd7e60733ee |
|
| https://github.com/gkalpak |
| refactor(ngcc): un-nest accidentally nested describe() blocks | https://github.com/angular/angular/pull/34437/commits/5369a6b49e4029108061a8515fcce06c47434bf7 |
| 5369a6b | https://github.com/angular/angular/pull/34437/commits/5369a6b49e4029108061a8515fcce06c47434bf7 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/b767076c9ee59c95a5b29601e2729a9748061b30..5369a6b49e4029108061a8515fcce06c47434bf7 |
| b767076 | https://github.com/angular/angular/commit/b767076c9ee59c95a5b29601e2729a9748061b30 |
| 5369a6b | https://github.com/angular/angular/commit/5369a6b49e4029108061a8515fcce06c47434bf7 |
|
Compare
| https://github.com/angular/angular/compare/b767076c9ee59c95a5b29601e2729a9748061b30..5369a6b49e4029108061a8515fcce06c47434bf7 |
| December 17, 2019 10:03 | https://github.com/angular/angular/pull/34437#event-2889202997 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Dec 17, 2019
| https://github.com/angular/angular/pull/34437#ref-pullrequest-530767200 |
|
fix(ngcc): several fixes
#34169
| https://github.com/angular/angular/pull/34169 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Dec 17, 2019 | https://github.com/angular/angular/pull/34437#issuecomment-566475906 |
| 5369a6b | https://github.com/angular/angular/commit/5369a6b49e4029108061a8515fcce06c47434bf7 |
| https://pr34437-5369a6b.ngbuilds.io/ | https://pr34437-5369a6b.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34437 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Dec 17, 2019
| https://github.com/angular/angular/pull/34437#pullrequestreview-333401522 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34437/files/5369a6b49e4029108061a8515fcce06c47434bf7 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Dec 17, 2019 | https://github.com/angular/angular/pull/34437#event-2890624041 |
| kara | https://github.com/kara |
|
Dec 17, 2019
| https://github.com/angular/angular/pull/34437#ref-commit-e5d992c |
|
| https://github.com/gkalpak |
|
| https://github.com/kara |
| refactor(ngcc): add debug messages to help with debugging in parallel… | https://github.com/angular/angular/commit/e5d992c175bc2bd74a025b0780933250816a8da3 |
| e5d992c | https://github.com/angular/angular/commit/e5d992c175bc2bd74a025b0780933250816a8da3 |
| #34437 | https://github.com/angular/angular/pull/34437 |
| #34437 | https://github.com/angular/angular/pull/34437 |
| kara | https://github.com/kara |
|
Dec 17, 2019
| https://github.com/angular/angular/pull/34437#ref-commit-f48e807 |
|
| https://github.com/gkalpak |
|
| https://github.com/kara |
| refactor(ngcc): un-nest accidentally nested | https://github.com/angular/angular/commit/f48e807d9a4d95c75db6d89206b35a5b57af17d6 |
| describe() | https://github.com/angular/angular/commit/f48e807d9a4d95c75db6d89206b35a5b57af17d6 |
| blocks ( | https://github.com/angular/angular/commit/f48e807d9a4d95c75db6d89206b35a5b57af17d6 |
| #34437 | https://github.com/angular/angular/pull/34437 |
| ) | https://github.com/angular/angular/commit/f48e807d9a4d95c75db6d89206b35a5b57af17d6 |
| f48e807 | https://github.com/angular/angular/commit/f48e807d9a4d95c75db6d89206b35a5b57af17d6 |
| #34437 | https://github.com/angular/angular/pull/34437 |
| https://github.com/kara |
| kara | https://github.com/kara |
| cd8a837 | https://github.com/angular/angular/commit/cd8a837956a2e5ad76c4ff86453c88b29dd696fa |
| Dec 17, 2019 | https://github.com/angular/angular/pull/34437#event-2891111372 |
| kara | https://github.com/kara |
|
Dec 17, 2019
| https://github.com/angular/angular/pull/34437#ref-commit-9cabd66 |
|
| https://github.com/gkalpak |
|
| https://github.com/kara |
| refactor(ngcc): un-nest accidentally nested | https://github.com/angular/angular/commit/9cabd6638e8573ab785fc59cee36111848ea367f |
| describe() | https://github.com/angular/angular/commit/9cabd6638e8573ab785fc59cee36111848ea367f |
| blocks ( | https://github.com/angular/angular/commit/9cabd6638e8573ab785fc59cee36111848ea367f |
| #34437 | https://github.com/angular/angular/pull/34437 |
| ) | https://github.com/angular/angular/commit/9cabd6638e8573ab785fc59cee36111848ea367f |
| 9cabd66 | https://github.com/angular/angular/commit/9cabd6638e8573ab785fc59cee36111848ea367f |
| #34437 | https://github.com/angular/angular/pull/34437 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| December 17, 2019 21:42 | https://github.com/angular/angular/pull/34437#event-2891455547 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jan 17, 2020 | https://github.com/angular/angular/pull/34437#issuecomment-575687239 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/34437 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jan 17, 2020 | https://github.com/angular/angular/pull/34437#event-2958665623 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34437 |
|
| https://github.com/petebacondarwin |
|
petebacondarwin
| https://github.com/petebacondarwin |
|
| https://github.com/angular/angular/pull/34437/files/5369a6b49e4029108061a8515fcce06c47434bf7 |
| Please reload this page | https://github.com/angular/angular/pull/34437 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
refactoring
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Arefactoring |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
| Please reload this page | https://github.com/angular/angular/pull/34437 |
|
| https://github.com/gkalpak |
|
| https://github.com/mary-poppins |
|
| https://github.com/petebacondarwin |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |