René's URL Explorer Experiment


Title: fix(ngcc): handle imports in dts files when processing UMD by petebacondarwin · Pull Request #34356 · angular/angular · GitHub

Open Graph Title: fix(ngcc): handle imports in dts files when processing UMD by petebacondarwin · Pull Request #34356 · angular/angular

X Title: fix(ngcc): handle imports in dts files when processing UMD by petebacondarwin · Pull Request #34356 · angular/angular

Description: When statically evalulating UMD code it is possible to find that we are looking for the declaration of an identifier that actually came from a typings file (rather than a UMD file). Previously, the UMD reflection host would always try to use a UMD specific algorithm for finding identifier declarations, but when the id is actually in a typings file this resulted in the returned declaration being the containing file of the declaration rather than the declaration itself. Now the UMD reflection host will check to see if the file containing the identifier is a typings file and use the appropriate stategy.

Open Graph Description: When statically evalulating UMD code it is possible to find that we are looking for the declaration of an identifier that actually came from a typings file (rather than a UMD file). Previously, the...

X Description: When statically evalulating UMD code it is possible to find that we are looking for the declaration of an identifier that actually came from a typings file (rather than a UMD file). Previously, the...

Opengraph URL: https://github.com/angular/angular/pull/34356

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e1730c5f-d974-f62f-2646-b159e9f7eac0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC8E:3A05E7:44A792:5A7A76:6B01750C
html-safe-nonce11927cd4cf866f13d5378777aad1cc2743b7097119d8a5f0d554144c9a4dc41a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzhFOjNBMDVFNzo0NEE3OTI6NUE3QTc2OjZCMDE3NTBDIiwidmlzaXRvcl9pZCI6IjcyNDQ5NDk4OTk4MzIyOTI2MjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb91e899a8986a80e62a1d9a1e8481f3491d52be493a2590305f1658547d8282b
hovercard-subject-tagpull_request:352030604
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/34356/files
twitter:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
og:image:altWhen statically evalulating UMD code it is possible to find that we are looking for the declaration of an identifier that actually came from a typings file (rather than a UMD file). Previously, the...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/34356/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34356%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34356%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34356/files
Reloadhttps://github.com/angular/angular/pull/34356/files
Reloadhttps://github.com/angular/angular/pull/34356/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-umd-get-declaration-of-idhttps://github.com/petebacondarwin/angular/tree/ngcc-umd-get-declaration-of-id
Conversation 6 https://github.com/angular/angular/pull/34356
Commits 1 https://github.com/angular/angular/pull/34356/commits
Checks 0 https://github.com/angular/angular/pull/34356/checks
Files changed https://github.com/angular/angular/pull/34356/files
Please reload this pagehttps://github.com/angular/angular/pull/34356/files
fix(ngcc): handle imports in dts files when processing UMD https://github.com/angular/angular/pull/34356/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/34356/files
ccbb4c5 fix(ngcc): handle imports in dts files when processing UMD petebacondarwin Dec 11, 2019 https://github.com/angular/angular/pull/34356/commits/ccbb4c5e84bda06f058a822771a484230dbe61da
Clear filters https://github.com/angular/angular/pull/34356/files
Please reload this pagehttps://github.com/angular/angular/pull/34356/files
Please reload this pagehttps://github.com/angular/angular/pull/34356/files
umd_host.ts https://github.com/angular/angular/pull/34356/files#diff-5d0863b117d9dd32f96881acfdd6ae2a16b1090835527627e3df661d0a3df0ce
umd_host_spec.ts https://github.com/angular/angular/pull/34356/files#diff-284ab9d6a8ea565f9239b8ba018bd21140c2739accdf565dc7e7a8cae08cd893
packages/compiler-cli/ngcc/src/host/umd_host.tshttps://github.com/angular/angular/pull/34356/files#diff-5d0863b117d9dd32f96881acfdd6ae2a16b1090835527627e3df661d0a3df0ce
View file https://github.com/petebacondarwin/angular/blob/ccbb4c5e84bda06f058a822771a484230dbe61da/packages/compiler-cli/ngcc/src/host/umd_host.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34356/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34356/files#diff-5d0863b117d9dd32f96881acfdd6ae2a16b1090835527627e3df661d0a3df0ce
https://github.com/angular/angular/pull/34356/files#diff-5d0863b117d9dd32f96881acfdd6ae2a16b1090835527627e3df661d0a3df0ce
packages/compiler-cli/ngcc/test/host/umd_host_spec.tshttps://github.com/angular/angular/pull/34356/files#diff-284ab9d6a8ea565f9239b8ba018bd21140c2739accdf565dc7e7a8cae08cd893
View file https://github.com/petebacondarwin/angular/blob/ccbb4c5e84bda06f058a822771a484230dbe61da/packages/compiler-cli/ngcc/test/host/umd_host_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34356/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34356/files#diff-284ab9d6a8ea565f9239b8ba018bd21140c2739accdf565dc7e7a8cae08cd893
gkalpakhttps://github.com/gkalpak
Dec 11, 2019https://github.com/angular/angular/pull/34356/files#r356772452
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#34254https://github.com/angular/angular/pull/34254
Please reload this pagehttps://github.com/angular/angular/pull/34356/files
petebacondarwinhttps://github.com/petebacondarwin
Dec 11, 2019https://github.com/angular/angular/pull/34356/files#r356773940
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34356/files
petebacondarwinhttps://github.com/petebacondarwin
Dec 11, 2019https://github.com/angular/angular/pull/34356/files#r356794488
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34356/files
petebacondarwinhttps://github.com/petebacondarwin
Dec 11, 2019https://github.com/angular/angular/pull/34356/files#r356799083
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34356/files
https://github.com/angular/angular/pull/34356/files#diff-284ab9d6a8ea565f9239b8ba018bd21140c2739accdf565dc7e7a8cae08cd893
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.