René's URL Explorer Experiment


Title: fix(ngcc): handle imports in dts files when processing UMD by petebacondarwin · Pull Request #34356 · angular/angular · GitHub

Open Graph Title: fix(ngcc): handle imports in dts files when processing UMD by petebacondarwin · Pull Request #34356 · angular/angular

X Title: fix(ngcc): handle imports in dts files when processing UMD by petebacondarwin · Pull Request #34356 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: When statically evalulating UMD code it is possible to find that we are looking for the declaration of an identifier that actually came from a typings file (rather than a UMD file). Previously, the...

X Description: When statically evalulating UMD code it is possible to find that we are looking for the declaration of an identifier that actually came from a typings file (rather than a UMD file). Previously, the...

Opengraph URL: https://github.com/angular/angular/pull/34356

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:db801e7a-92c3-d2e6-b8fb-30d8580a3388
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id946E:BBAAA:1245AB9:181CB71:6B011605
html-safe-nonce32a9f83a496e7d7cffb02510c95899f2619a0b783fcc8c6180a158bd0eb272c1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDZFOkJCQUFBOjEyNDVBQjk6MTgxQ0I3MTo2QjAxMTYwNSIsInZpc2l0b3JfaWQiOiI4NzI4NTEzNjU5MjIwODU4MzczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac958a9b5d5d5c2184dab00f3baed3787b53037653d94cec39d728a96e2de7d670
hovercard-subject-tagpull_request:352030604
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34356/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/51fbce12616bf8d1920d8af7f4a384207a73444798082521b1f9ed7a37bd6840/angular/angular/pull/34356
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/51fbce12616bf8d1920d8af7f4a384207a73444798082521b1f9ed7a37bd6840/angular/angular/pull/34356
og:image:altWhen statically evalulating UMD code it is possible to find that we are looking for the declaration of an identifier that actually came from a typings file (rather than a UMD file). Previously, the...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepetebacondarwin
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/34356#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34356
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34356
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34356
Reloadhttps://github.com/angular/angular/pull/34356
Reloadhttps://github.com/angular/angular/pull/34356
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-umd-get-declaration-of-idhttps://github.com/petebacondarwin/angular/tree/ngcc-umd-get-declaration-of-id
Conversationhttps://github.com/angular/angular/pull/34356
Commits1 (1)https://github.com/angular/angular/pull/34356/commits
Checkshttps://github.com/angular/angular/pull/34356/checks
Files changedhttps://github.com/angular/angular/pull/34356/files
fix(ngcc): handle imports in dts files when processing UMDhttps://github.com/angular/angular/pull/34356#top
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-umd-get-declaration-of-idhttps://github.com/petebacondarwin/angular/tree/ngcc-umd-get-declaration-of-id
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Dec 11, 2019https://github.com/angular/angular/pull/34356#issue-536513352
Please reload this pagehttps://github.com/angular/angular/pull/34356
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
comp: ngcc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
Dec 11, 2019https://github.com/angular/angular/pull/34356#event-2875149730
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
December 11, 2019 17:27https://github.com/angular/angular/pull/34356#event-2875149738
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Dec 11, 2019https://github.com/angular/angular/pull/34356#event-2875149908
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Dec 11, 2019https://github.com/angular/angular/pull/34356#event-2875149997
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/c115983507b3062ac4e9c2b1967a1833f04e31e7..7cc2fd1c932e1f0bfb035440b94ee775b864570e
c115983https://github.com/angular/angular/commit/c115983507b3062ac4e9c2b1967a1833f04e31e7
7cc2fd1https://github.com/angular/angular/commit/7cc2fd1c932e1f0bfb035440b94ee775b864570e
Compare https://github.com/angular/angular/compare/c115983507b3062ac4e9c2b1967a1833f04e31e7..7cc2fd1c932e1f0bfb035440b94ee775b864570e
December 11, 2019 17:28https://github.com/angular/angular/pull/34356#event-2875154371
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 11, 2019 https://github.com/angular/angular/pull/34356#pullrequestreview-330763404
View reviewed changes https://github.com/angular/angular/pull/34356/files
gkalpakhttps://github.com/gkalpak
https://github.com/angular/angular/pull/34356#pullrequestreview-330763404
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34356
packages/compiler-cli/ngcc/test/host/umd_host_spec.tshttps://github.com/angular/angular/pull/34356/files#diff-284ab9d6a8ea565f9239b8ba018bd21140c2739accdf565dc7e7a8cae08cd893
gkalpakhttps://github.com/gkalpak
Dec 11, 2019https://github.com/angular/angular/pull/34356#discussion_r356772452
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#34254https://github.com/angular/angular/pull/34254
Please reload this pagehttps://github.com/angular/angular/pull/34356
petebacondarwinhttps://github.com/petebacondarwin
Dec 11, 2019https://github.com/angular/angular/pull/34356#discussion_r356773940
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34356
petebacondarwinhttps://github.com/petebacondarwin
Dec 11, 2019https://github.com/angular/angular/pull/34356#discussion_r356794488
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34356
petebacondarwinhttps://github.com/petebacondarwin
Dec 11, 2019https://github.com/angular/angular/pull/34356#discussion_r356799083
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34356
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Dec 11, 2019https://github.com/angular/angular/pull/34356#event-2875407895
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Dec 11, 2019 https://github.com/angular/angular/pull/34356#ref-issue-531479410
Ivy: NGCC incorrectly compiles the "@ngxs/router-plugin" as UMD #34191 https://github.com/angular/angular/issues/34191
https://github.com/petebacondarwin
fix(ngcc): handle imports in dts files when processing UMDhttps://github.com/angular/angular/pull/34356/commits/ccbb4c5e84bda06f058a822771a484230dbe61da
ccbb4c5https://github.com/angular/angular/pull/34356/commits/ccbb4c5e84bda06f058a822771a484230dbe61da
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/7cc2fd1c932e1f0bfb035440b94ee775b864570e..ccbb4c5e84bda06f058a822771a484230dbe61da
7cc2fd1https://github.com/angular/angular/commit/7cc2fd1c932e1f0bfb035440b94ee775b864570e
ccbb4c5https://github.com/angular/angular/commit/ccbb4c5e84bda06f058a822771a484230dbe61da
Compare https://github.com/angular/angular/compare/7cc2fd1c932e1f0bfb035440b94ee775b864570e..ccbb4c5e84bda06f058a822771a484230dbe61da
December 11, 2019 19:47https://github.com/angular/angular/pull/34356#event-2875563915
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Dec 11, 2019 https://github.com/angular/angular/pull/34356#ref-pullrequest-533403431
fix(ngcc): dts declaration mapping #34254 https://github.com/angular/angular/pull/34254
https://github.com/kara
karahttps://github.com/kara
c77656ehttps://github.com/angular/angular/commit/c77656e2dd959cf70d4999f0cfc419f20a6f9e9e
Dec 11, 2019https://github.com/angular/angular/pull/34356#event-2875827142
karahttps://github.com/kara
Dec 11, 2019 https://github.com/angular/angular/pull/34356#ref-commit-81c75cf
https://github.com/petebacondarwin
https://github.com/kara
fix(ngcc): handle imports in dts files when processing UMD (https://github.com/angular/angular/commit/81c75cf5604861f2308494c62970da8fe5293c91
#34356https://github.com/angular/angular/pull/34356
)https://github.com/angular/angular/commit/81c75cf5604861f2308494c62970da8fe5293c91
81c75cfhttps://github.com/angular/angular/commit/81c75cf5604861f2308494c62970da8fe5293c91
#34356https://github.com/angular/angular/pull/34356
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
December 12, 2019 08:27https://github.com/angular/angular/pull/34356#event-2877011665
https://github.com/naveedahmed1
naveedahmed1https://github.com/naveedahmed1
Jan 3, 2020 https://github.com/angular/angular/pull/34356#ref-issue-541795169
platform-server errors with ivy-ngcc - UMD module - Angular 9.0.0-rc.7 #34544 https://github.com/angular/angular/issues/34544
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jan 12, 2020https://github.com/angular/angular/pull/34356#issuecomment-573429647
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/34356
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jan 12, 2020https://github.com/angular/angular/pull/34356#event-2941329876
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34356
https://github.com/gkalpak
gkalpak https://github.com/gkalpak
https://github.com/angular/angular/pull/34356/files/7cc2fd1c932e1f0bfb035440b94ee775b864570e
Please reload this pagehttps://github.com/angular/angular/pull/34356
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/34356
https://github.com/petebacondarwin
https://github.com/gkalpak
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.