René's URL Explorer Experiment


Title: fix(ngcc): render UMD imports even if no prior imports by petebacondarwin · Pull Request #34353 · angular/angular · GitHub

Open Graph Title: fix(ngcc): render UMD imports even if no prior imports by petebacondarwin · Pull Request #34353 · angular/angular

X Title: fix(ngcc): render UMD imports even if no prior imports by petebacondarwin · Pull Request #34353 · angular/angular

Description: Previously the UMD rendering formatter assumed that there would already be import (and an export) arguments to the UMD factory function. This commit adds support for this corner case. Fixes #34138

Open Graph Description: Previously the UMD rendering formatter assumed that there would already be import (and an export) arguments to the UMD factory function. This commit adds support for this corner case. Fixes #34138

X Description: Previously the UMD rendering formatter assumed that there would already be import (and an export) arguments to the UMD factory function. This commit adds support for this corner case. Fixes #34138

Opengraph URL: https://github.com/angular/angular/pull/34353

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:36482505-b757-a3c7-7818-18b35a6f0c6b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB2C8:38E318:10C15A6:1519B6A:6B014EE4
html-safe-nonceeb2f020cf737102e790a8033a51b09d68746c8be4bcde1e74f307cda43aba0d7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMkM4OjM4RTMxODoxMEMxNUE2OjE1MTlCNkE6NkIwMTRFRTQiLCJ2aXNpdG9yX2lkIjoiMTI3NTEyMTA2NTUwNDM2MjIxMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf9d5b5717262d1964ec3fdeb30e1187a56c707ad13faefeb7bc008d6d297cd52
hovercard-subject-tagpull_request:351987957
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/34353/files
twitter:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
og:image:altPreviously the UMD rendering formatter assumed that there would already be import (and an export) arguments to the UMD factory function. This commit adds support for this corner case. Fixes #34138
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/34353/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34353%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34353%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34353/files
Reloadhttps://github.com/angular/angular/pull/34353/files
Reloadhttps://github.com/angular/angular/pull/34353/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-umd-no-parametershttps://github.com/petebacondarwin/angular/tree/ngcc-umd-no-parameters
Conversation 6 https://github.com/angular/angular/pull/34353
Commits 2 https://github.com/angular/angular/pull/34353/commits
Checks 0 https://github.com/angular/angular/pull/34353/checks
Files changed https://github.com/angular/angular/pull/34353/files
Please reload this pagehttps://github.com/angular/angular/pull/34353/files
fix(ngcc): render UMD imports even if no prior imports https://github.com/angular/angular/pull/34353/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/34353/files
eb3c6ec fix(ngcc): render UMD imports even if no prior imports petebacondarwin Dec 11, 2019 https://github.com/angular/angular/pull/34353/commits/eb3c6ec5ea3043d4d3df91ce560e215cc68a627f
82bfa29 fixup! fix(ngcc): render UMD imports even if no prior imports petebacondarwin Dec 12, 2019 https://github.com/angular/angular/pull/34353/commits/82bfa29a3d4777f207667e9be0ac6e7a9e0e0289
Clear filters https://github.com/angular/angular/pull/34353/files
Please reload this pagehttps://github.com/angular/angular/pull/34353/files
Please reload this pagehttps://github.com/angular/angular/pull/34353/files
umd_rendering_formatter.ts https://github.com/angular/angular/pull/34353/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5
umd_rendering_formatter_spec.ts https://github.com/angular/angular/pull/34353/files#diff-f314ca24a8682553ae5f18fa3ffad03f482fd8757f52c3c4b8dcc0560039862e
packages/compiler-cli/ngcc/src/rendering/umd_rendering_formatter.tshttps://github.com/angular/angular/pull/34353/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5
View file https://github.com/petebacondarwin/angular/blob/82bfa29a3d4777f207667e9be0ac6e7a9e0e0289/packages/compiler-cli/ngcc/src/rendering/umd_rendering_formatter.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34353/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34353/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5
https://github.com/angular/angular/pull/34353/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5
https://github.com/angular/angular/pull/34353/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5
https://github.com/angular/angular/pull/34353/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5
https://github.com/angular/angular/pull/34353/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5
packages/compiler-cli/ngcc/test/rendering/umd_rendering_formatter_spec.tshttps://github.com/angular/angular/pull/34353/files#diff-f314ca24a8682553ae5f18fa3ffad03f482fd8757f52c3c4b8dcc0560039862e
View file https://github.com/petebacondarwin/angular/blob/82bfa29a3d4777f207667e9be0ac6e7a9e0e0289/packages/compiler-cli/ngcc/test/rendering/umd_rendering_formatter_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34353/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34353/files#diff-f314ca24a8682553ae5f18fa3ffad03f482fd8757f52c3c4b8dcc0560039862e
https://github.com/angular/angular/pull/34353/files#diff-f314ca24a8682553ae5f18fa3ffad03f482fd8757f52c3c4b8dcc0560039862e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.