| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:36482505-b757-a3c7-7818-18b35a6f0c6b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B2C8:38E318:10C15A6:1519B6A:6B014EE4 |
| html-safe-nonce | eb2f020cf737102e790a8033a51b09d68746c8be4bcde1e74f307cda43aba0d7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMkM4OjM4RTMxODoxMEMxNUE2OjE1MTlCNkE6NkIwMTRFRTQiLCJ2aXNpdG9yX2lkIjoiMTI3NTEyMTA2NTUwNDM2MjIxMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f9d5b5717262d1964ec3fdeb30e1187a56c707ad13faefeb7bc008d6d297cd52 |
| hovercard-subject-tag | pull_request:351987957 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/34353/files |
| twitter:image | https://avatars.githubusercontent.com/u/15655?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/15655?s=400&v=4 |
| og:image:alt | Previously the UMD rendering formatter assumed that
there would already be import (and an export) arguments
to the UMD factory function.
This commit adds support for this corner case.
Fixes #34138 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/34353/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34353%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34353%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/34353/files |
| Reload | https://github.com/angular/angular/pull/34353/files |
| Reload | https://github.com/angular/angular/pull/34353/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| petebacondarwin | https://github.com/petebacondarwin |
| angular:master | https://github.com/angular/angular/tree/master |
| petebacondarwin:ngcc-umd-no-parameters | https://github.com/petebacondarwin/angular/tree/ngcc-umd-no-parameters |
|
Conversation
6
| https://github.com/angular/angular/pull/34353 |
|
Commits
2
| https://github.com/angular/angular/pull/34353/commits |
|
Checks
0
| https://github.com/angular/angular/pull/34353/checks |
|
Files changed
| https://github.com/angular/angular/pull/34353/files |
| Please reload this page | https://github.com/angular/angular/pull/34353/files |
|
fix(ngcc): render UMD imports even if no prior imports
| https://github.com/angular/angular/pull/34353/files#top |
|
Show all changes
2 commits
| https://github.com/angular/angular/pull/34353/files |
|
eb3c6ec
fix(ngcc): render UMD imports even if no prior imports
petebacondarwin Dec 11, 2019
| https://github.com/angular/angular/pull/34353/commits/eb3c6ec5ea3043d4d3df91ce560e215cc68a627f |
|
82bfa29
fixup! fix(ngcc): render UMD imports even if no prior imports
petebacondarwin Dec 12, 2019
| https://github.com/angular/angular/pull/34353/commits/82bfa29a3d4777f207667e9be0ac6e7a9e0e0289 |
|
Clear filters
| https://github.com/angular/angular/pull/34353/files |
| Please reload this page | https://github.com/angular/angular/pull/34353/files |
| Please reload this page | https://github.com/angular/angular/pull/34353/files |
|
umd_rendering_formatter.ts
| https://github.com/angular/angular/pull/34353/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5 |
|
umd_rendering_formatter_spec.ts
| https://github.com/angular/angular/pull/34353/files#diff-f314ca24a8682553ae5f18fa3ffad03f482fd8757f52c3c4b8dcc0560039862e |
| packages/compiler-cli/ngcc/src/rendering/umd_rendering_formatter.ts | https://github.com/angular/angular/pull/34353/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5 |
|
View file
| https://github.com/petebacondarwin/angular/blob/82bfa29a3d4777f207667e9be0ac6e7a9e0e0289/packages/compiler-cli/ngcc/src/rendering/umd_rendering_formatter.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/34353/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/34353/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5 |
|
| https://github.com/angular/angular/pull/34353/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5 |
|
| https://github.com/angular/angular/pull/34353/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5 |
|
| https://github.com/angular/angular/pull/34353/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5 |
|
| https://github.com/angular/angular/pull/34353/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5 |
| packages/compiler-cli/ngcc/test/rendering/umd_rendering_formatter_spec.ts | https://github.com/angular/angular/pull/34353/files#diff-f314ca24a8682553ae5f18fa3ffad03f482fd8757f52c3c4b8dcc0560039862e |
|
View file
| https://github.com/petebacondarwin/angular/blob/82bfa29a3d4777f207667e9be0ac6e7a9e0e0289/packages/compiler-cli/ngcc/test/rendering/umd_rendering_formatter_spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/34353/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/34353/files#diff-f314ca24a8682553ae5f18fa3ffad03f482fd8757f52c3c4b8dcc0560039862e |
|
| https://github.com/angular/angular/pull/34353/files#diff-f314ca24a8682553ae5f18fa3ffad03f482fd8757f52c3c4b8dcc0560039862e |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |