René's URL Explorer Experiment


Title: fix(ngcc): render UMD imports even if no prior imports by petebacondarwin · Pull Request #34353 · angular/angular · GitHub

Open Graph Title: fix(ngcc): render UMD imports even if no prior imports by petebacondarwin · Pull Request #34353 · angular/angular

X Title: fix(ngcc): render UMD imports even if no prior imports by petebacondarwin · Pull Request #34353 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Previously the UMD rendering formatter assumed that there would already be import (and an export) arguments to the UMD factory function. This commit adds support for this corner case. Fixes #34138

X Description: Previously the UMD rendering formatter assumed that there would already be import (and an export) arguments to the UMD factory function. This commit adds support for this corner case. Fixes #34138

Opengraph URL: https://github.com/angular/angular/pull/34353

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ff2312c8-7cb8-ae66-4c30-efd7e083e608
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD78C:3A347:159A237:1C967A0:6B012E15
html-safe-nonce48b32e4a780d1f5f223364e29186566d2e31d7426dd4504e6ec354ab23387038
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzhDOjNBMzQ3OjE1OUEyMzc6MUM5NjdBMDo2QjAxMkUxNSIsInZpc2l0b3JfaWQiOiI3NDYwMjEyNzc1OTQ0NTMxNDc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacffb26f9ebd3d89449a97cc97bd423ba01c820fc221bae7a913436bf39672eebd
hovercard-subject-tagpull_request:351987957
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34353/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/51fbce12616bf8d1920d8af7f4a384207a73444798082521b1f9ed7a37bd6840/angular/angular/pull/34353
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/51fbce12616bf8d1920d8af7f4a384207a73444798082521b1f9ed7a37bd6840/angular/angular/pull/34353
og:image:altPreviously the UMD rendering formatter assumed that there would already be import (and an export) arguments to the UMD factory function. This commit adds support for this corner case. Fixes #34138
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepetebacondarwin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/34353#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34353
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34353
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34353
Reloadhttps://github.com/angular/angular/pull/34353
Reloadhttps://github.com/angular/angular/pull/34353
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-umd-no-parametershttps://github.com/petebacondarwin/angular/tree/ngcc-umd-no-parameters
Conversationhttps://github.com/angular/angular/pull/34353
Commits2 (2)https://github.com/angular/angular/pull/34353/commits
Checkshttps://github.com/angular/angular/pull/34353/checks
Files changedhttps://github.com/angular/angular/pull/34353/files
fix(ngcc): render UMD imports even if no prior importshttps://github.com/angular/angular/pull/34353#top
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-umd-no-parametershttps://github.com/petebacondarwin/angular/tree/ngcc-umd-no-parameters
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Dec 11, 2019https://github.com/angular/angular/pull/34353#issue-536462342
#34138https://github.com/angular/angular/issues/34138
Please reload this pagehttps://github.com/angular/angular/pull/34353
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
comp: ngcc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
Dec 11, 2019https://github.com/angular/angular/pull/34353#event-2874829891
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
December 11, 2019 15:57https://github.com/angular/angular/pull/34353#event-2874829903
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Dec 11, 2019https://github.com/angular/angular/pull/34353#event-2874830097
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Dec 11, 2019https://github.com/angular/angular/pull/34353#event-2874830180
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Dec 11, 2019 https://github.com/angular/angular/pull/34353#ref-issue-530054543
ngcc cannot handle UMD factory without parameters ( renderFactoryParameters ) #34138 https://github.com/angular/angular/issues/34138
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 11, 2019 https://github.com/angular/angular/pull/34353#pullrequestreview-330824532
View reviewed changes https://github.com/angular/angular/pull/34353/files
gkalpakhttps://github.com/gkalpak
https://github.com/angular/angular/pull/34353#pullrequestreview-330824532
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34353
packages/compiler-cli/ngcc/test/rendering/umd_rendering_formatter_spec.tshttps://github.com/angular/angular/pull/34353/files#diff-f314ca24a8682553ae5f18fa3ffad03f482fd8757f52c3c4b8dcc0560039862e
Please reload this pagehttps://github.com/angular/angular/pull/34353
packages/compiler-cli/ngcc/test/rendering/umd_rendering_formatter_spec.tshttps://github.com/angular/angular/pull/34353/files#diff-f314ca24a8682553ae5f18fa3ffad03f482fd8757f52c3c4b8dcc0560039862e
Please reload this pagehttps://github.com/angular/angular/pull/34353
packages/compiler-cli/ngcc/test/rendering/umd_rendering_formatter_spec.tshttps://github.com/angular/angular/pull/34353/files#diff-f314ca24a8682553ae5f18fa3ffad03f482fd8757f52c3c4b8dcc0560039862e
Please reload this pagehttps://github.com/angular/angular/pull/34353
packages/compiler-cli/ngcc/src/rendering/umd_rendering_formatter.tshttps://github.com/angular/angular/pull/34353/files#diff-9198de4ec8ef00a0441c0cf2c8313682242c63065cba163bcf5309c28d0e12c5
Please reload this pagehttps://github.com/angular/angular/pull/34353
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Dec 11, 2019https://github.com/angular/angular/pull/34353#event-2875729242
petebacondarwinhttps://github.com/petebacondarwin
December 12, 2019 08:35https://github.com/angular/angular/pull/34353#commits-pushed-eb3c6ec
https://github.com/petebacondarwin
fix(ngcc): render UMD imports even if no prior importshttps://github.com/angular/angular/pull/34353/commits/eb3c6ec5ea3043d4d3df91ce560e215cc68a627f
eb3c6echttps://github.com/angular/angular/pull/34353/commits/eb3c6ec5ea3043d4d3df91ce560e215cc68a627f
angular#34138https://github.com/angular/angular/issues/34138
https://github.com/petebacondarwin
fixup! fix(ngcc): render UMD imports even if no prior importshttps://github.com/angular/angular/pull/34353/commits/82bfa29a3d4777f207667e9be0ac6e7a9e0e0289
82bfa29https://github.com/angular/angular/pull/34353/commits/82bfa29a3d4777f207667e9be0ac6e7a9e0e0289
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/f2597f3451b8242b7dfcaf245b82504e9bd4f829..82bfa29a3d4777f207667e9be0ac6e7a9e0e0289
f2597f3https://github.com/angular/angular/commit/f2597f3451b8242b7dfcaf245b82504e9bd4f829
82bfa29https://github.com/angular/angular/commit/82bfa29a3d4777f207667e9be0ac6e7a9e0e0289
Compare https://github.com/angular/angular/compare/f2597f3451b8242b7dfcaf245b82504e9bd4f829..82bfa29a3d4777f207667e9be0ac6e7a9e0e0289
December 12, 2019 08:38https://github.com/angular/angular/pull/34353#event-2877041800
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Dec 12, 2019https://github.com/angular/angular/pull/34353#event-2877049982
karahttps://github.com/kara
Dec 12, 2019 https://github.com/angular/angular/pull/34353#ref-commit-c26738d
https://github.com/petebacondarwin
https://github.com/kara
fix(ngcc): render UMD imports even if no prior imports (https://github.com/angular/angular/commit/c26738df1234e25925d7bd9fe8eca1ebd92fe07e
#34353https://github.com/angular/angular/pull/34353
)https://github.com/angular/angular/commit/c26738df1234e25925d7bd9fe8eca1ebd92fe07e
c26738dhttps://github.com/angular/angular/commit/c26738df1234e25925d7bd9fe8eca1ebd92fe07e
#34138https://github.com/angular/angular/issues/34138
#34353https://github.com/angular/angular/pull/34353
https://github.com/kara
karahttps://github.com/kara
05c1398https://github.com/angular/angular/commit/05c1398b4dfb903f031656dce3cc58438d1b2121
Dec 12, 2019https://github.com/angular/angular/pull/34353#event-2878710798
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
December 19, 2019 09:44https://github.com/angular/angular/pull/34353#event-2896555703
gkalpakhttps://github.com/gkalpak
Dec 23, 2019 https://github.com/angular/angular/pull/34353#ref-commit-0e6f183
https://github.com/gkalpak
fix(ngcc): do not add trailing commas in UMD importshttps://github.com/gkalpak/angular/commit/0e6f183f3123ef2d7fa1d5548a21757432dd98c1
0e6f183https://github.com/gkalpak/angular/commit/0e6f183f3123ef2d7fa1d5548a21757432dd98c1
angular#34353https://github.com/angular/angular/pull/34353
angular#34525https://github.com/angular/angular/issues/34525
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 23, 2019 https://github.com/angular/angular/pull/34353#ref-pullrequest-541798618
fix(ngcc): do not add trailing commas in UMD imports #34545 https://github.com/angular/angular/pull/34545
alxhubhttps://github.com/alxhub
Jan 7, 2020 https://github.com/angular/angular/pull/34353#ref-commit-e6850a3
https://github.com/gkalpak
https://github.com/alxhub
fix(ngcc): do not add trailing commas in UMD imports (https://github.com/angular/angular/commit/e6850a3c519846d2742f29707a910e977edd5997
#34545https://github.com/angular/angular/pull/34545
)https://github.com/angular/angular/commit/e6850a3c519846d2742f29707a910e977edd5997
e6850a3https://github.com/angular/angular/commit/e6850a3c519846d2742f29707a910e977edd5997
#34353https://github.com/angular/angular/pull/34353
#34525https://github.com/angular/angular/issues/34525
#34545https://github.com/angular/angular/pull/34545
alxhubhttps://github.com/alxhub
Jan 7, 2020 https://github.com/angular/angular/pull/34353#ref-commit-10e2935
https://github.com/gkalpak
https://github.com/alxhub
fix(ngcc): do not add trailing commas in UMD imports (https://github.com/angular/angular/commit/10e29355db1864ba89cf5695dfc9c1e4017afc98
#34545https://github.com/angular/angular/pull/34545
)https://github.com/angular/angular/commit/10e29355db1864ba89cf5695dfc9c1e4017afc98
10e2935https://github.com/angular/angular/commit/10e29355db1864ba89cf5695dfc9c1e4017afc98
#34353https://github.com/angular/angular/pull/34353
#34525https://github.com/angular/angular/issues/34525
#34545https://github.com/angular/angular/pull/34545
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jan 19, 2020https://github.com/angular/angular/pull/34353#issuecomment-576019465
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/34353
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jan 19, 2020https://github.com/angular/angular/pull/34353#event-2960983362
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34353
https://github.com/gkalpak
gkalpak https://github.com/gkalpak
https://github.com/angular/angular/pull/34353/files/f2597f3451b8242b7dfcaf245b82504e9bd4f829
Please reload this pagehttps://github.com/angular/angular/pull/34353
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
ngcc cannot handle UMD factory without parameters ( renderFactoryParameters ) https://github.com/angular/angular/issues/34138
Please reload this pagehttps://github.com/angular/angular/pull/34353
https://github.com/petebacondarwin
https://github.com/gkalpak
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.