René's URL Explorer Experiment


Title: fix(ivy): generate a better error for template var writes by alxhub · Pull Request #34339 · angular/angular · GitHub

Open Graph Title: fix(ivy): generate a better error for template var writes by alxhub · Pull Request #34339 · angular/angular

X Title: fix(ivy): generate a better error for template var writes by alxhub · Pull Request #34339 · angular/angular

Description: In Ivy it's illegal for a template to write to a template variable. So the template: is erroneous and previously would fail to compile with an assertion error from the TemplateDefinitionBuilder. This error wasn't particularly user- friendly, though, as it lacked the context of which template or where the error occurred. In this commit, a new check in template type-checking is added which detects such erroneous writes and produces a true diagnostic with the appropriate context information.

Open Graph Description: In Ivy it's illegal for a template to write to a template variable. So the template: <ng-template let-somevar> <button (click)="somevar = 3">Set var to 3</button> ...

X Description: In Ivy it&#39;s illegal for a template to write to a template variable. So the template: &lt;ng-template let-somevar&gt; &lt;button (click)=&quot;somevar = 3&quot;&gt;...

Opengraph URL: https://github.com/angular/angular/pull/34339

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:14786bbd-b496-330c-a620-b6c66a9dd528
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A80:311640:1A717B4:219CD27:6B014ED2
html-safe-nonce6a36b8269c956d74d295f2d99073a1cb5ed6ff3b417b8dcf579dab9fab0eb7de
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTgwOjMxMTY0MDoxQTcxN0I0OjIxOUNEMjc6NkIwMTRFRDIiLCJ2aXNpdG9yX2lkIjoiMzcyMjQ5ODMwNTI3NjU5NTkyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac323dd8ee261a1960eefd004b352a2e7f98a74e7bd0bfc30b852a5a1dc2f792ef
hovercard-subject-tagpull_request:351685271
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/34339/files
twitter:imagehttps://avatars.githubusercontent.com/u/4175141?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4175141?s=400&v=4
og:image:altIn Ivy it's illegal for a template to write to a template variable. So the template: <ng-template let-somevar> <button (click)="somevar = 3">Set var to 3</button> ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/34339/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34339%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34339%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34339/files
Reloadhttps://github.com/angular/angular/pull/34339/files
Reloadhttps://github.com/angular/angular/pull/34339/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
alxhubhttps://github.com/alxhub
angular:masterhttps://github.com/angular/angular/tree/master
alxhub:ngtsc/template-var-assignmenthttps://github.com/alxhub/angular/tree/ngtsc/template-var-assignment
Conversation 6 https://github.com/angular/angular/pull/34339
Commits 1 https://github.com/angular/angular/pull/34339/commits
Checks 0 https://github.com/angular/angular/pull/34339/checks
Files changed https://github.com/angular/angular/pull/34339/files
Please reload this pagehttps://github.com/angular/angular/pull/34339/files
fix(ivy): generate a better error for template var writes https://github.com/angular/angular/pull/34339/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/34339/files
8486471 fix(ivy): generate a better error for template var writes alxhub Dec 11, 2019 https://github.com/angular/angular/pull/34339/commits/8486471ee36fe4a04f1eaf17b1a24280169809da
Clear filters https://github.com/angular/angular/pull/34339/files
Please reload this pagehttps://github.com/angular/angular/pull/34339/files
Please reload this pagehttps://github.com/angular/angular/pull/34339/files
code.ts https://github.com/angular/angular/pull/34339/files#diff-45cb08a4c5971f12609933b6cc1dd4ae36b9cb51ab2d24082aacae929459e25f
diagnostics.ts https://github.com/angular/angular/pull/34339/files#diff-665b728d3d70d8449025a8798ebbdd565358d7a5074c317aaa3920db260e8bc4
oob.ts https://github.com/angular/angular/pull/34339/files#diff-50f9918c2a4813f5182f3ea879372d773ef9e0de7d1864f2923fb46a89953ef0
template_semantics.ts https://github.com/angular/angular/pull/34339/files#diff-39446004e90ec3aad2add8d467d696d3ac4e6f6be0c32bcf72ef744d0efc6f81
type_check_block.ts https://github.com/angular/angular/pull/34339/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
test_utils.ts https://github.com/angular/angular/pull/34339/files#diff-2bf4eba9f2fc57abc04d96b11f4d4ecb1c43f1d7dec431226b8fe13fe4dd70c1
type_check_block_spec.ts https://github.com/angular/angular/pull/34339/files#diff-c664b10cc3e60eb082c77548dd2c01c0d1793df11feac5af833504dddaddf3ad
template_typecheck_spec.ts https://github.com/angular/angular/pull/34339/files#diff-4338bcab035efc17fedac8da7ef2cdfaa3f171d673ed2cd22cbe42641c998fb1
packages/compiler-cli/src/ngtsc/diagnostics/src/code.tshttps://github.com/angular/angular/pull/34339/files#diff-45cb08a4c5971f12609933b6cc1dd4ae36b9cb51ab2d24082aacae929459e25f
View file https://github.com/alxhub/angular/blob/8486471ee36fe4a04f1eaf17b1a24280169809da/packages/compiler-cli/src/ngtsc/diagnostics/src/code.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34339/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34339/files#diff-45cb08a4c5971f12609933b6cc1dd4ae36b9cb51ab2d24082aacae929459e25f
https://github.com/angular/angular/pull/34339/files#diff-45cb08a4c5971f12609933b6cc1dd4ae36b9cb51ab2d24082aacae929459e25f
packages/compiler-cli/src/ngtsc/typecheck/src/diagnostics.tshttps://github.com/angular/angular/pull/34339/files#diff-665b728d3d70d8449025a8798ebbdd565358d7a5074c317aaa3920db260e8bc4
View file https://github.com/alxhub/angular/blob/8486471ee36fe4a04f1eaf17b1a24280169809da/packages/compiler-cli/src/ngtsc/typecheck/src/diagnostics.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34339/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34339/files#diff-665b728d3d70d8449025a8798ebbdd565358d7a5074c317aaa3920db260e8bc4
https://github.com/angular/angular/pull/34339/files#diff-665b728d3d70d8449025a8798ebbdd565358d7a5074c317aaa3920db260e8bc4
https://github.com/angular/angular/pull/34339/files#diff-665b728d3d70d8449025a8798ebbdd565358d7a5074c317aaa3920db260e8bc4
https://github.com/angular/angular/pull/34339/files#diff-665b728d3d70d8449025a8798ebbdd565358d7a5074c317aaa3920db260e8bc4
https://github.com/angular/angular/pull/34339/files#diff-665b728d3d70d8449025a8798ebbdd565358d7a5074c317aaa3920db260e8bc4
packages/compiler-cli/src/ngtsc/typecheck/src/oob.tshttps://github.com/angular/angular/pull/34339/files#diff-50f9918c2a4813f5182f3ea879372d773ef9e0de7d1864f2923fb46a89953ef0
View file https://github.com/alxhub/angular/blob/8486471ee36fe4a04f1eaf17b1a24280169809da/packages/compiler-cli/src/ngtsc/typecheck/src/oob.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34339/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34339/files#diff-50f9918c2a4813f5182f3ea879372d773ef9e0de7d1864f2923fb46a89953ef0
https://github.com/angular/angular/pull/34339/files#diff-50f9918c2a4813f5182f3ea879372d773ef9e0de7d1864f2923fb46a89953ef0
https://github.com/angular/angular/pull/34339/files#diff-50f9918c2a4813f5182f3ea879372d773ef9e0de7d1864f2923fb46a89953ef0
https://github.com/angular/angular/pull/34339/files#diff-50f9918c2a4813f5182f3ea879372d773ef9e0de7d1864f2923fb46a89953ef0
https://github.com/angular/angular/pull/34339/files#diff-50f9918c2a4813f5182f3ea879372d773ef9e0de7d1864f2923fb46a89953ef0
packages/compiler-cli/src/ngtsc/typecheck/src/template_semantics.tshttps://github.com/angular/angular/pull/34339/files#diff-39446004e90ec3aad2add8d467d696d3ac4e6f6be0c32bcf72ef744d0efc6f81
View file https://github.com/alxhub/angular/blob/8486471ee36fe4a04f1eaf17b1a24280169809da/packages/compiler-cli/src/ngtsc/typecheck/src/template_semantics.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34339/{{ revealButtonHref }}
packages/compiler-cli/src/ngtsc/typecheck/src/type_check_block.tshttps://github.com/angular/angular/pull/34339/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
View file https://github.com/alxhub/angular/blob/8486471ee36fe4a04f1eaf17b1a24280169809da/packages/compiler-cli/src/ngtsc/typecheck/src/type_check_block.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34339/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34339/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
https://github.com/angular/angular/pull/34339/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
https://github.com/angular/angular/pull/34339/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
https://github.com/angular/angular/pull/34339/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
https://github.com/angular/angular/pull/34339/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
https://github.com/angular/angular/pull/34339/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
https://github.com/angular/angular/pull/34339/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
https://github.com/angular/angular/pull/34339/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
JoostKhttps://github.com/JoostK
Dec 11, 2019https://github.com/angular/angular/pull/34339/files#r356823700
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34339/files
alxhubhttps://github.com/alxhub
Dec 12, 2019https://github.com/angular/angular/pull/34339/files#r357305058
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34339/files
https://github.com/angular/angular/pull/34339/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
packages/compiler-cli/src/ngtsc/typecheck/test/test_utils.tshttps://github.com/angular/angular/pull/34339/files#diff-2bf4eba9f2fc57abc04d96b11f4d4ecb1c43f1d7dec431226b8fe13fe4dd70c1
View file https://github.com/alxhub/angular/blob/8486471ee36fe4a04f1eaf17b1a24280169809da/packages/compiler-cli/src/ngtsc/typecheck/test/test_utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34339/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34339/files#diff-2bf4eba9f2fc57abc04d96b11f4d4ecb1c43f1d7dec431226b8fe13fe4dd70c1
packages/compiler-cli/src/ngtsc/typecheck/test/type_check_block_spec.tshttps://github.com/angular/angular/pull/34339/files#diff-c664b10cc3e60eb082c77548dd2c01c0d1793df11feac5af833504dddaddf3ad
View file https://github.com/alxhub/angular/blob/8486471ee36fe4a04f1eaf17b1a24280169809da/packages/compiler-cli/src/ngtsc/typecheck/test/type_check_block_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34339/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34339/files#diff-c664b10cc3e60eb082c77548dd2c01c0d1793df11feac5af833504dddaddf3ad
https://github.com/angular/angular/pull/34339/files#diff-c664b10cc3e60eb082c77548dd2c01c0d1793df11feac5af833504dddaddf3ad
packages/compiler-cli/test/ngtsc/template_typecheck_spec.tshttps://github.com/angular/angular/pull/34339/files#diff-4338bcab035efc17fedac8da7ef2cdfaa3f171d673ed2cd22cbe42641c998fb1
View file https://github.com/alxhub/angular/blob/8486471ee36fe4a04f1eaf17b1a24280169809da/packages/compiler-cli/test/ngtsc/template_typecheck_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34339/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34339/files#diff-4338bcab035efc17fedac8da7ef2cdfaa3f171d673ed2cd22cbe42641c998fb1
https://github.com/angular/angular/pull/34339/files#diff-4338bcab035efc17fedac8da7ef2cdfaa3f171d673ed2cd22cbe42641c998fb1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.