René's URL Explorer Experiment


Title: fix(ivy): generate a better error for template var writes by alxhub · Pull Request #34339 · angular/angular · GitHub

Open Graph Title: fix(ivy): generate a better error for template var writes by alxhub · Pull Request #34339 · angular/angular

X Title: fix(ivy): generate a better error for template var writes by alxhub · Pull Request #34339 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: In Ivy it's illegal for a template to write to a template variable. So the template: <ng-template let-somevar> <button (click)="somevar = 3">Set var to 3</button> ...

X Description: In Ivy it&#39;s illegal for a template to write to a template variable. So the template: &lt;ng-template let-somevar&gt; &lt;button (click)=&quot;somevar = 3&quot;&gt;...

Opengraph URL: https://github.com/angular/angular/pull/34339

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:45197d02-a2ef-ddf0-bcf0-22e39f96c1ae
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD28A:76F02:160DCC8:1C40E7F:6B0128FA
html-safe-noncebcc8cdc598f9f6a1860d85aad09ea79d85941ab03b2239d34f4c35154a704a15
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjhBOjc2RjAyOjE2MERDQzg6MUM0MEU3Rjo2QjAxMjhGQSIsInZpc2l0b3JfaWQiOiIyNjAxODQ4Mjk1ODczNjUyOTg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacde8474655d082ca5cd59deeebc54f6636c7056b571441c82a412785f3ab1097b
hovercard-subject-tagpull_request:351685271
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34339/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c5b810d44de7a6c183f1c6bbcd922cbdd62e3ea71171cf1560036df56a032b2b/angular/angular/pull/34339
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c5b810d44de7a6c183f1c6bbcd922cbdd62e3ea71171cf1560036df56a032b2b/angular/angular/pull/34339
og:image:altIn Ivy it's illegal for a template to write to a template variable. So the template: <ng-template let-somevar> <button (click)="somevar = 3">Set var to 3</button> ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealxhub
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/34339#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34339
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34339
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34339
Reloadhttps://github.com/angular/angular/pull/34339
Reloadhttps://github.com/angular/angular/pull/34339
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
alxhubhttps://github.com/alxhub
angular:masterhttps://github.com/angular/angular/tree/master
alxhub:ngtsc/template-var-assignmenthttps://github.com/alxhub/angular/tree/ngtsc/template-var-assignment
Conversationhttps://github.com/angular/angular/pull/34339
Commits1 (1)https://github.com/angular/angular/pull/34339/commits
Checkshttps://github.com/angular/angular/pull/34339/checks
Files changedhttps://github.com/angular/angular/pull/34339/files
fix(ivy): generate a better error for template var writeshttps://github.com/angular/angular/pull/34339#top
alxhubhttps://github.com/alxhub
angular:masterhttps://github.com/angular/angular/tree/master
alxhub:ngtsc/template-var-assignmenthttps://github.com/alxhub/angular/tree/ngtsc/template-var-assignment
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Dec 11, 2019https://github.com/angular/angular/pull/34339#issue-536092308
Please reload this pagehttps://github.com/angular/angular/pull/34339
https://github.com/alxhub
alxhubhttps://github.com/alxhub
December 11, 2019 01:46https://github.com/angular/angular/pull/34339#event-2872666233
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Dec 11, 2019https://github.com/angular/angular/pull/34339#event-2872666339
https://github.com/alxhub
alxhubhttps://github.com/alxhub
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Dec 11, 2019https://github.com/angular/angular/pull/34339#event-2872666545
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Dec 11, 2019https://github.com/angular/angular/pull/34339#event-2872666621
https://github.com/alxhub
alxhubhttps://github.com/alxhub
force-pushedhttps://github.com/angular/angular/compare/bb269b1980f7413a322cab1df834ee25751b1db6..8ea6d45c7e4536f498a4aa61d65e63afc6db57c6
bb269b1https://github.com/angular/angular/commit/bb269b1980f7413a322cab1df834ee25751b1db6
8ea6d45https://github.com/angular/angular/commit/8ea6d45c7e4536f498a4aa61d65e63afc6db57c6
Compare https://github.com/angular/angular/compare/bb269b1980f7413a322cab1df834ee25751b1db6..8ea6d45c7e4536f498a4aa61d65e63afc6db57c6
December 11, 2019 01:48https://github.com/angular/angular/pull/34339#event-2872669576
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Dec 11, 2019 https://github.com/angular/angular/pull/34339#pullrequestreview-330829543
View reviewed changes https://github.com/angular/angular/pull/34339/files
JoostKhttps://github.com/JoostK
https://github.com/angular/angular/pull/34339#pullrequestreview-330829543
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34339
packages/compiler-cli/src/ngtsc/typecheck/src/type_check_block.tshttps://github.com/angular/angular/pull/34339/files#diff-7006c2f80b66b223816fab95fbfd31bc7e096377199ecacb03271860b564586f
JoostKhttps://github.com/JoostK
Dec 11, 2019https://github.com/angular/angular/pull/34339#discussion_r356823700
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34339
alxhubhttps://github.com/alxhub
Dec 12, 2019https://github.com/angular/angular/pull/34339#discussion_r357305058
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34339
https://github.com/kara
karahttps://github.com/kara
Dec 11, 2019 https://github.com/angular/angular/pull/34339#pullrequestreview-330848020
View reviewed changes https://github.com/angular/angular/pull/34339/files
karahttps://github.com/kara
https://github.com/angular/angular/pull/34339#pullrequestreview-330848020
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34339
https://github.com/kara
karahttps://github.com/kara
Dec 11, 2019 https://github.com/angular/angular/pull/34339#ref-issue-519576729
Add diagnostics error for template var assignment issue #33674 https://github.com/angular/angular/issues/33674
https://github.com/kara
karahttps://github.com/kara
comp: ivy https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
Dec 11, 2019https://github.com/angular/angular/pull/34339#event-2875816030
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Dec 11, 2019https://github.com/angular/angular/pull/34339#event-2875816131
https://github.com/kara
karahttps://github.com/kara
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Dec 11, 2019https://github.com/angular/angular/pull/34339#event-2875816151
https://github.com/kara
karahttps://github.com/kara
alxhubhttps://github.com/alxhub
Dec 11, 2019https://github.com/angular/angular/pull/34339#event-2875827309
https://github.com/alxhub
fix(ivy): generate a better error for template var writeshttps://github.com/angular/angular/pull/34339/commits/8486471ee36fe4a04f1eaf17b1a24280169809da
8486471https://github.com/angular/angular/pull/34339/commits/8486471ee36fe4a04f1eaf17b1a24280169809da
angular#33674https://github.com/angular/angular/issues/33674
https://github.com/alxhub
alxhubhttps://github.com/alxhub
force-pushedhttps://github.com/angular/angular/compare/8ea6d45c7e4536f498a4aa61d65e63afc6db57c6..8486471ee36fe4a04f1eaf17b1a24280169809da
8ea6d45https://github.com/angular/angular/commit/8ea6d45c7e4536f498a4aa61d65e63afc6db57c6
8486471https://github.com/angular/angular/commit/8486471ee36fe4a04f1eaf17b1a24280169809da
Compare https://github.com/angular/angular/compare/8ea6d45c7e4536f498a4aa61d65e63afc6db57c6..8486471ee36fe4a04f1eaf17b1a24280169809da
December 12, 2019 18:36https://github.com/angular/angular/pull/34339#event-2878961241
https://github.com/alxhub
alxhubhttps://github.com/alxhub
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Dec 12, 2019https://github.com/angular/angular/pull/34339#event-2878962510
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Dec 12, 2019https://github.com/angular/angular/pull/34339#issuecomment-565140588
Presubmithttps://test.corp.google.com/ui#id=OCL:285221233:BASE:285221288:1576175884792:b7ce2ead
Ivy Presubmithttps://test.corp.google.com/ui#id=OCL:285221233:BASE:285221288:1576175884739:ffaa1999
Please reload this pagehttps://github.com/angular/angular/pull/34339
https://github.com/kara
karahttps://github.com/kara
6ba5fdchttps://github.com/angular/angular/commit/6ba5fdc2082cc668f53f82afc36776f2cb24dcd6
Dec 12, 2019https://github.com/angular/angular/pull/34339#event-2879400409
karahttps://github.com/kara
Dec 12, 2019 https://github.com/angular/angular/pull/34339#ref-commit-418d586
https://github.com/alxhub
https://github.com/kara
fix(ivy): generate a better error for template var writes (https://github.com/angular/angular/commit/418d5869086715d8a54a23467d6b0ec7be00dca1
#34339https://github.com/angular/angular/pull/34339
)https://github.com/angular/angular/commit/418d5869086715d8a54a23467d6b0ec7be00dca1
418d586https://github.com/angular/angular/commit/418d5869086715d8a54a23467d6b0ec7be00dca1
#33674https://github.com/angular/angular/issues/33674
#34339https://github.com/angular/angular/pull/34339
angular 9 / Ivy => async 'as' leads to error #34405 https://github.com/angular/angular/issues/34405
CLI: 8.3.0 + iVY = ERROR in Error: Cannot assign to a reference or variable! #32695 https://github.com/angular/angular/issues/32695
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jan 12, 2020https://github.com/angular/angular/pull/34339#issuecomment-573429694
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/34339
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jan 12, 2020https://github.com/angular/angular/pull/34339#event-2941330098
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34339
https://github.com/JoostK
JoostK https://github.com/JoostK
https://github.com/angular/angular/pull/34339/files/8ea6d45c7e4536f498a4aa61d65e63afc6db57c6
https://github.com/kara
kara https://github.com/kara
https://github.com/angular/angular/pull/34339/files/8ea6d45c7e4536f498a4aa61d65e63afc6db57c6
Please reload this pagehttps://github.com/angular/angular/pull/34339
https://github.com/alxhub
alxhub https://github.com/alxhub
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/34339
https://github.com/alxhub
https://github.com/JoostK
https://github.com/kara
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.