| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0e3ace13-6607-5f84-32b0-f7374dbc02c6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9B4E:163C6E:102FB1:158D3B:6B016077 |
| html-safe-nonce | 48db1fef02e7511093565bf63449f578bedd40ef0069c4d95a332c03c0520faf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjRFOjE2M0M2RToxMDJGQjE6MTU4RDNCOjZCMDE2MDc3IiwidmlzaXRvcl9pZCI6IjgyNDAzNDY4OTQ2NzM0Njk1NTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 59ae52d5f06310f06dd02e9b62c70a88e3cde5b84dddab2f52e6522af25d8bbc |
| hovercard-subject-tag | pull_request:349483818 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/34254/files |
| twitter:image | https://avatars.githubusercontent.com/u/15655?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/15655?s=400&v=4 |
| og:image:alt | The naïve matching algorithm we previously used to match declarations in
source files to declarations in typings files was based only on the name
of the thing being declared. This did not handle c... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/34254/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34254%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34254%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/34254/files |
| Reload | https://github.com/angular/angular/pull/34254/files |
| Reload | https://github.com/angular/angular/pull/34254/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| petebacondarwin | https://github.com/petebacondarwin |
| angular:master | https://github.com/angular/angular/tree/master |
| petebacondarwin:ngcc-dts-declaration-mapping | https://github.com/petebacondarwin/angular/tree/ngcc-dts-declaration-mapping |
|
Conversation
36
| https://github.com/angular/angular/pull/34254 |
|
Commits
7
| https://github.com/angular/angular/pull/34254/commits |
|
Checks
0
| https://github.com/angular/angular/pull/34254/checks |
|
Files changed
43
| https://github.com/angular/angular/pull/34254/files |
|
fix(ngcc): dts declaration mapping
| https://github.com/angular/angular/pull/34254/files#top |
|
Show all changes
7 commits
| https://github.com/angular/angular/pull/34254/files |
|
69aca12
refactor(ngcc): use bundle src to create reflection hosts
petebacondarwin Dec 18, 2019
| https://github.com/angular/angular/pull/34254/commits/69aca120cdb13066b65129be5b3889e80e3942fc |
|
bb34c4c
fix(ngcc): handle CommonJS re-exports by reference
petebacondarwin Dec 18, 2019
| https://github.com/angular/angular/pull/34254/commits/bb34c4cf4f5db040730fa2837490201c0f2ab51d |
|
0604964
fix(ngcc): handle UMD re-exports
petebacondarwin Dec 18, 2019
| https://github.com/angular/angular/pull/34254/commits/060496460509b6222913fabc82114d1223bd789a |
|
292e749
fix(ngcc): correctly match aliased classes between src and dts files
petebacondarwin Dec 18, 2019
| https://github.com/angular/angular/pull/34254/commits/292e7498a9936761167f2b4390d9f4f3dc69a510 |
|
5313d71
fix(ngcc): use the correct identifiers when updating typings files
petebacondarwin Dec 18, 2019
| https://github.com/angular/angular/pull/34254/commits/5313d71890a180200da95f54bfaf758ec3e889d0 |
|
53328a7
refactor(ngcc): slightly improve the info in error messages
petebacondarwin Dec 18, 2019
| https://github.com/angular/angular/pull/34254/commits/53328a7f3daa36aa3d5c2ee364ba438703d312f2 |
|
e779e4a
refactor(ngcc): remove private declaration aliases
petebacondarwin Dec 18, 2019
| https://github.com/angular/angular/pull/34254/commits/e779e4afdc68330ddbbc3caaf320f8e88fa2d465 |
|
Clear filters
| https://github.com/angular/angular/pull/34254/files |
| Please reload this page | https://github.com/angular/angular/pull/34254/files |
| Please reload this page | https://github.com/angular/angular/pull/34254/files |
|
private_declarations_analyzer.ts
| https://github.com/angular/angular/pull/34254/files#diff-6ae5804b236f9734a3211d7ec75a914f842b43d995f2e7db4a55f5d71b092b47 |
|
commonjs_host.ts
| https://github.com/angular/angular/pull/34254/files#diff-39b1d4e5eef7a09fe5e7d016596c2e5faca423bd2a3a6b394da7f755d537712e |
|
esm2015_host.ts
| https://github.com/angular/angular/pull/34254/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04 |
|
umd_host.ts
| https://github.com/angular/angular/pull/34254/files#diff-5d0863b117d9dd32f96881acfdd6ae2a16b1090835527627e3df661d0a3df0ce |
|
main.ts
| https://github.com/angular/angular/pull/34254/files#diff-75ccb9d1ac3b7ae04e2108aa0e157036641f2cbbc88e09b315075a669f2d22be |
|
transformer.ts
| https://github.com/angular/angular/pull/34254/files#diff-65f61d8d76fba850ad89ea5a1c2058af1a66f3e3904104ea2b05d5a0fffef7ae |
|
dts_renderer.ts
| https://github.com/angular/angular/pull/34254/files#diff-bf6dc45866aaaf4b7caddd8cb6c98d742f3cb480ff80ecf354c149a7ad51ec9a |
|
esm_rendering_formatter.ts
| https://github.com/angular/angular/pull/34254/files#diff-a7ce6285a47dfe55b18d33cb40b7b18d1e71a6e4e7adce0045a23e427b8cacb7 |
|
utils.ts
| https://github.com/angular/angular/pull/34254/files#diff-80d7bef7a408f6f49d97d8436ae6ab20186b2f133c9101a65735943b0cd61b7d |
|
decoration_analyzer_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-e8650a61025a99f4301da5b57cf1f46c788e761f40b54be2a8f0462addff4177 |
|
module_with_providers_analyzer_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-e9af37d997b6b72fd5b01c7275c1b5c70bd589d4978997a78784505496c17f25 |
|
private_declarations_analyzer_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-bbe689351cd9401a5eeff8109378f9a1acff9d1b921758f1f10a7c1a0945b2a2 |
|
switch_marker_analyzer_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-7c47768b8c01e82339f3d572d404d4f29a1cb305bba58067c7268eec9a745db6 |
|
commonjs_host_import_helper_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-fb80ce2d54669578e4b3787f884baed7b337406afbb4ae0275f2b0bacdd69f2c |
|
commonjs_host_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-0db82dee3e42c4dd42541af6804480af5c328f5b679cf2d9f33972527eca27c5 |
|
esm2015_host_import_helper_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-d8a2c53dd69dec92c391e47679bf6027a6d4c308c4c4c0caa6bd1c66b46128fc |
|
esm2015_host_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-18452185ddea0470affbb7aeb782082f03c1950adf928cf5a5c12ed88045f427 |
|
esm5_host_import_helper_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-d1791039d9dde9827fa21bf2463f6bd8ddde9b19c4d54ecd6ca0fda067823ff1 |
|
esm5_host_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-42557bc6689586acf48908cc8f6488ebcb7bd0239e54fe478ed2b8f008eb58b6 |
|
umd_host_import_helper_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-e28d29624a29f4ae79ae609bcdd49a2c5e11644dc71abaf8686e74c192f1fcb2 |
|
umd_host_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-284ab9d6a8ea565f9239b8ba018bd21140c2739accdf565dc7e7a8cae08cd893 |
|
ngcc_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39 |
|
missing_injectable_migration_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-5c72c695f66e90d317a5a50a37bc46211070e5b0b62637251885d366a4554207 |
|
undecorated_parent_migration_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-ce3f4b2d8f777e62773523628339b13e5fa2180bc7c447c20caec41761c61808 |
|
commonjs_rendering_formatter_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-2ceff9c84e6c94d41403567d69981875cc771b138c8d9f9ef185c7bc03e24e57 |
|
dts_renderer_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-1980c819c97be7e3f0d033efdde002129e15fecf69990308cc347bd6c295439f |
|
esm5_rendering_formatter_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-8ff836bc6f3de0d1a50c5b56d7475691f06603629e2e37f0305ce905d3b3ce9c |
|
esm_rendering_formatter_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-92c6090cd33562162301a9ee259408a6f49e8f522b171164de293a36f901fece |
|
renderer_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-aa88f3eff534cc2fcade2a1dbc721f01ba9130cf5c8474ef7d1db508ca3bda4d |
|
umd_rendering_formatter_spec.ts
| https://github.com/angular/angular/pull/34254/files#diff-f314ca24a8682553ae5f18fa3ffad03f482fd8757f52c3c4b8dcc0560039862e |
|
directive.ts
| https://github.com/angular/angular/pull/34254/files#diff-bbe73773517a54ab50859c4ea219d8716d708910e4637889f5013b1094fe8400 |
|
injectable.ts
| https://github.com/angular/angular/pull/34254/files#diff-ff6958d9fff47e0156915cac8202d78930adcf33d353c70e60b230981cc36f20 |
|
ng_module.ts
| https://github.com/angular/angular/pull/34254/files#diff-8b9c0d2955b2182ee8ebd745a4f737de1207244d83ef08bdc00f9c8d9139c2a8 |
|
pipe.ts
| https://github.com/angular/angular/pull/34254/files#diff-cca09745361bb2d9844269a54bb34dfc82c87e86ceac4f72ffe7b740634b2437 |
|
util.ts
| https://github.com/angular/angular/pull/34254/files#diff-b408a07768aaddc7b73f38b26fb08aaeab74710c98a446ea03942fd875638e43 |
|
injectable_compiler_2.ts
| https://github.com/angular/angular/pull/34254/files#diff-51170a6686ecc9b080d05b256d647f76db0f646f178667ddee80b4ad1ca6bd1d |
|
jit_compiler_facade.ts
| https://github.com/angular/angular/pull/34254/files#diff-01d6d00c4d4bc32fd756511329b51832d5992d909f137cd0f29a85448b05207d |
|
r3_factory.ts
| https://github.com/angular/angular/pull/34254/files#diff-933238d1270d97a57cab4c7d7425cf7b112d514d23e17ed65faf8b4d4348aba8 |
|
r3_module_compiler.ts
| https://github.com/angular/angular/pull/34254/files#diff-46eddfe0653c3d025ebd259fa5fbcdc433e419a5a259c490c4ad27822d4cef76 |
|
r3_pipe_compiler.ts
| https://github.com/angular/angular/pull/34254/files#diff-571fa8bef5bb5fea52e8b076f41ae19f43dd15c611ea9209ea411438628994b8 |
|
util.ts
| https://github.com/angular/angular/pull/34254/files#diff-295b9b0e4955d53bf8083febe7b82104fde7e39a1a4e70eb8d1e4f53adf22803 |
|
api.ts
| https://github.com/angular/angular/pull/34254/files#diff-73bd90f92ccea688d3ee38be460e3e8c533a0683beff0ecff22cad8d4d3fa885 |
|
compiler.ts
| https://github.com/angular/angular/pull/34254/files#diff-647cc0586b8318c1805d5c42c57358ba468889567f85c7c381e2c635bdcb1fd6 |
| packages/compiler-cli/ngcc/src/analysis/private_declarations_analyzer.ts | https://github.com/angular/angular/pull/34254/files#diff-6ae5804b236f9734a3211d7ec75a914f842b43d995f2e7db4a55f5d71b092b47 |
|
View file
| https://github.com/petebacondarwin/angular/blob/e779e4afdc68330ddbbc3caaf320f8e88fa2d465/packages/compiler-cli/ngcc/src/analysis/private_declarations_analyzer.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/34254/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/34254/files#diff-6ae5804b236f9734a3211d7ec75a914f842b43d995f2e7db4a55f5d71b092b47 |
|
| https://github.com/angular/angular/pull/34254/files#diff-6ae5804b236f9734a3211d7ec75a914f842b43d995f2e7db4a55f5d71b092b47 |
|
| https://github.com/angular/angular/pull/34254/files#diff-6ae5804b236f9734a3211d7ec75a914f842b43d995f2e7db4a55f5d71b092b47 |
|
| https://github.com/angular/angular/pull/34254/files#diff-6ae5804b236f9734a3211d7ec75a914f842b43d995f2e7db4a55f5d71b092b47 |
| packages/compiler-cli/ngcc/src/host/commonjs_host.ts | https://github.com/angular/angular/pull/34254/files#diff-39b1d4e5eef7a09fe5e7d016596c2e5faca423bd2a3a6b394da7f755d537712e |
|
View file
| https://github.com/petebacondarwin/angular/blob/e779e4afdc68330ddbbc3caaf320f8e88fa2d465/packages/compiler-cli/ngcc/src/host/commonjs_host.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/34254/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/34254/files#diff-39b1d4e5eef7a09fe5e7d016596c2e5faca423bd2a3a6b394da7f755d537712e |
|
| https://github.com/angular/angular/pull/34254/files#diff-39b1d4e5eef7a09fe5e7d016596c2e5faca423bd2a3a6b394da7f755d537712e |
|
| https://github.com/angular/angular/pull/34254/files#diff-39b1d4e5eef7a09fe5e7d016596c2e5faca423bd2a3a6b394da7f755d537712e |
|
| https://github.com/angular/angular/pull/34254/files#diff-39b1d4e5eef7a09fe5e7d016596c2e5faca423bd2a3a6b394da7f755d537712e |
|
| https://github.com/angular/angular/pull/34254/files#diff-39b1d4e5eef7a09fe5e7d016596c2e5faca423bd2a3a6b394da7f755d537712e |
|
| https://github.com/angular/angular/pull/34254/files#diff-39b1d4e5eef7a09fe5e7d016596c2e5faca423bd2a3a6b394da7f755d537712e |
| Please reload this page | https://github.com/angular/angular/pull/34254/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |