| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:44204d1f-4173-1da1-b972-ffd43b77b19f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C1BE:2F9718:1092F93:163F4D8:6B011D3A |
| html-safe-nonce | 10957e937f1c8981bccf9d5eba83e61f3de44337d6ab09ca764746dd872effac |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUJFOjJGOTcxODoxMDkyRjkzOjE2M0Y0RDg6NkIwMTFEM0EiLCJ2aXNpdG9yX2lkIjoiODQwOTMwMDQ4NDIxMjQ2NDk1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d49ebd5b20fb2701f79c8a5787b5977b91ee680d3e86d61aff933939c8878c8e |
| hovercard-subject-tag | pull_request:349483818 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34254/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/51fbce12616bf8d1920d8af7f4a384207a73444798082521b1f9ed7a37bd6840/angular/angular/pull/34254 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/51fbce12616bf8d1920d8af7f4a384207a73444798082521b1f9ed7a37bd6840/angular/angular/pull/34254 |
| og:image:alt | The naïve matching algorithm we previously used to match declarations in
source files to declarations in typings files was based only on the name
of the thing being declared. This did not handle c... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | petebacondarwin |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/34254#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34254 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34254 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/34254 |
| Reload | https://github.com/angular/angular/pull/34254 |
| Reload | https://github.com/angular/angular/pull/34254 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| petebacondarwin | https://github.com/petebacondarwin |
| angular:master | https://github.com/angular/angular/tree/master |
| petebacondarwin:ngcc-dts-declaration-mapping | https://github.com/petebacondarwin/angular/tree/ngcc-dts-declaration-mapping |
| Conversation | https://github.com/angular/angular/pull/34254 |
| Commits7 (7) | https://github.com/angular/angular/pull/34254/commits |
| Checks | https://github.com/angular/angular/pull/34254/checks |
| Files changed | https://github.com/angular/angular/pull/34254/files |
| fix(ngcc): dts declaration mapping | https://github.com/angular/angular/pull/34254#top |
| petebacondarwin | https://github.com/petebacondarwin |
| angular:master | https://github.com/angular/angular/tree/master |
| petebacondarwin:ngcc-dts-declaration-mapping | https://github.com/petebacondarwin/angular/tree/ngcc-dts-declaration-mapping |
|
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Dec 5, 2019 | https://github.com/angular/angular/pull/34254#issue-533403431 |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
| #33593 | https://github.com/angular/angular/issues/33593 |
| #34191 | https://github.com/angular/angular/issues/34191 |
| #32442 | https://github.com/angular/angular/issues/32442 |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Dec 5, 2019 | https://github.com/angular/angular/pull/34254#event-2858130406 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| force-pushed | https://github.com/angular/angular/compare/504814cfba1af8922a752750ce1c4dedd504f77c..ddd998b1676e311c774956bf8f336568ab053898 |
| 504814c | https://github.com/angular/angular/commit/504814cfba1af8922a752750ce1c4dedd504f77c |
| ddd998b | https://github.com/angular/angular/commit/ddd998b1676e311c774956bf8f336568ab053898 |
|
Compare
| https://github.com/angular/angular/compare/504814cfba1af8922a752750ce1c4dedd504f77c..ddd998b1676e311c774956bf8f336568ab053898 |
| December 7, 2019 20:11 | https://github.com/angular/angular/pull/34254#event-2863754558 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Dec 7, 2019
| https://github.com/angular/angular/pull/34254#pullrequestreview-328573368 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34254/files |
| packages/compiler/src/render3/r3_pipe_compiler.ts | https://github.com/angular/angular/pull/34254/files#diff-571fa8bef5bb5fea52e8b076f41ae19f43dd15c611ea9209ea411438628994b8 |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| December 7, 2019 20:14 | https://github.com/angular/angular/pull/34254#event-2863756203 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| December 7, 2019 20:14 | https://github.com/angular/angular/pull/34254#event-2863756207 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
area: compiler
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22 |
|
comp: ngcc
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Dec 7, 2019 | https://github.com/angular/angular/pull/34254#event-2863756380 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Dec 7, 2019 | https://github.com/angular/angular/pull/34254#event-2863756397 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Dec 7, 2019
| https://github.com/angular/angular/pull/34254#ref-pullrequest-526669077 |
|
Add and update Kendo UI packages
angular/ngcc-validation#608
| https://github.com/angular/ngcc-validation/pull/608 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| force-pushed | https://github.com/angular/angular/compare/ddd998b1676e311c774956bf8f336568ab053898..9c47295e6e4b6da2b99ef7e032dff6e2dac05208 |
| ddd998b | https://github.com/angular/angular/commit/ddd998b1676e311c774956bf8f336568ab053898 |
| 9c47295 | https://github.com/angular/angular/commit/9c47295e6e4b6da2b99ef7e032dff6e2dac05208 |
|
Compare
| https://github.com/angular/angular/compare/ddd998b1676e311c774956bf8f336568ab053898..9c47295e6e4b6da2b99ef7e032dff6e2dac05208 |
| December 8, 2019 16:49 | https://github.com/angular/angular/pull/34254#event-2864305851 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Dec 11, 2019
| https://github.com/angular/angular/pull/34254#ref-issue-531479410 |
|
Ivy: NGCC incorrectly compiles the "@ngxs/router-plugin" as UMD
#34191
| https://github.com/angular/angular/issues/34191 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Dec 11, 2019
| https://github.com/angular/angular/pull/34254#pullrequestreview-330469078 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34254/files |
| gkalpak | https://github.com/gkalpak |
| https://github.com/angular/angular/pull/34254#pullrequestreview-330469078 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
| packages/compiler-cli/ngcc/src/host/esm2015_host.ts | https://github.com/angular/angular/pull/34254/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04 |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
| packages/compiler-cli/ngcc/src/packages/transformer.ts | https://github.com/angular/angular/pull/34254/files#diff-65f61d8d76fba850ad89ea5a1c2058af1a66f3e3904104ea2b05d5a0fffef7ae |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
| packages/compiler-cli/ngcc/test/rendering/dts_renderer_spec.ts | https://github.com/angular/angular/pull/34254/files#diff-1980c819c97be7e3f0d033efdde002129e15fecf69990308cc347bd6c295439f |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| force-pushed | https://github.com/angular/angular/compare/3d12e8ee0868590b80f4162c8c55937627ad2c44..aaa17332c2abcec4ecca2ada964c61a2e43e8f4d |
| 3d12e8e | https://github.com/angular/angular/commit/3d12e8ee0868590b80f4162c8c55937627ad2c44 |
| aaa1733 | https://github.com/angular/angular/commit/aaa17332c2abcec4ecca2ada964c61a2e43e8f4d |
|
Compare
| https://github.com/angular/angular/compare/3d12e8ee0868590b80f4162c8c55937627ad2c44..aaa17332c2abcec4ecca2ada964c61a2e43e8f4d |
| December 11, 2019 14:28 | https://github.com/angular/angular/pull/34254#event-2874487861 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Dec 11, 2019
| https://github.com/angular/angular/pull/34254#pullrequestreview-330752412 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34254/files |
| packages/compiler-cli/ngcc/src/analysis/private_declarations_analyzer.ts | https://github.com/angular/angular/pull/34254/files#diff-6ae5804b236f9734a3211d7ec75a914f842b43d995f2e7db4a55f5d71b092b47 |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Dec 11, 2019
| https://github.com/angular/angular/pull/34254#ref-pullrequest-536513352 |
|
fix(ngcc): handle imports in dts files when processing UMD
#34356
| https://github.com/angular/angular/pull/34356 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| force-pushed | https://github.com/angular/angular/compare/aaa17332c2abcec4ecca2ada964c61a2e43e8f4d..a5ac79347ede586396e3779cc8831ed567d1202c |
| aaa1733 | https://github.com/angular/angular/commit/aaa17332c2abcec4ecca2ada964c61a2e43e8f4d |
| a5ac793 | https://github.com/angular/angular/commit/a5ac79347ede586396e3779cc8831ed567d1202c |
|
Compare
| https://github.com/angular/angular/compare/aaa17332c2abcec4ecca2ada964c61a2e43e8f4d..a5ac79347ede586396e3779cc8831ed567d1202c |
| December 11, 2019 19:46 | https://github.com/angular/angular/pull/34254#event-2875560804 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| December 11, 2019 19:46 | https://github.com/angular/angular/pull/34254#event-2875560807 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Dec 11, 2019 | https://github.com/angular/angular/pull/34254#issuecomment-564702862 |
| Go here | https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34254 |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Dec 11, 2019 | https://github.com/angular/angular/pull/34254#event-2875561253 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| Dec 18, 2019 | https://github.com/angular/angular/pull/34254#issuecomment-567159659 |
| Presubmit | https://test.corp.google.com/ui#id=OCL:286221348:BASE:286221394:1576694400309:aa213af6 |
| Ivy Presubmit | https://test.corp.google.com/ui#id=OCL:286221348:BASE:286221394:1576694400309:c0c11529 |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Dec 18, 2019 | https://github.com/angular/angular/pull/34254#event-2894615983 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| gkalpak | https://github.com/gkalpak |
| December 18, 2019 18:56 | https://github.com/angular/angular/pull/34254#event-2894649340 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Dec 18, 2019
| https://github.com/angular/angular/pull/34254#pullrequestreview-334193742 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34254/files/060496460509b6222913fabc82114d1223bd789a |
| packages/compiler-cli/ngcc/src/host/umd_host.ts | https://github.com/angular/angular/pull/34254/files/bb34c4cf4f5db040730fa2837490201c0f2ab51d..060496460509b6222913fabc82114d1223bd789a#diff-5d0863b117d9dd32f96881acfdd6ae2a16b1090835527627e3df661d0a3df0ce |
| gkalpak | https://github.com/gkalpak |
| Dec 18, 2019 | https://github.com/angular/angular/pull/34254#discussion_r359515373 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
| petebacondarwin | https://github.com/petebacondarwin |
| Dec 18, 2019 | https://github.com/angular/angular/pull/34254#discussion_r359564542 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
| gkalpak | https://github.com/gkalpak |
| Dec 19, 2019 | https://github.com/angular/angular/pull/34254#discussion_r360003643 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| simplified CommonJS wrapping | https://requirejs.org/docs/whyamd.html#sugar |
| TS playground example | https://www.typescriptlang.org/play/?target=1&module=3&ssl=1&ssc=1&pln=28&pc=1#code/JYWwDg9gTgLgBAIhgOwM4FoDG0Cm6QQAmArgDY6oD0AhmGKcJtTMBMggNwBQXOAHpFhwAVHABmUCCEQA6SvWZjoILFILtu-QfFESps+aUXLOvAdB3jJ0hHIUwlUFahjNGprRZFX9tw8ad0MEkAN2BCHChUD3MhXWsDKAoIYihMPFIIagioUzNtbz0bOWQ3EIpMKGAwGBkCEnIYgvjfOWwQdTzPOJ9iykliGEimrxa+sWBydFQATxccEBGeooMACxgYMCwGHGQYJcsVv0cQaO58rwBvLjhbuAA1YBwAdwBhI1RUABobu8eX97UT4AWRwrh+dweT2eACVkqRylAIXcAOZg-5vD7fX63NEwDGg8E4uDAVAAaWQEGeyAxyNuSRRpKGUAAouQQLsYD8AL69Aw4dmc9AMplQGZ5bBoeBKCBwAC8cAA2jIVQByACMACYAMyqgC63CAA |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
| petebacondarwin | https://github.com/petebacondarwin |
| Dec 19, 2019 | https://github.com/angular/angular/pull/34254#discussion_r360021103 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/umdjs/umd | https://github.com/umdjs/umd |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
| gkalpak | https://github.com/gkalpak |
| Dec 19, 2019 | https://github.com/angular/angular/pull/34254#discussion_r360045271 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
| gkalpak | https://github.com/gkalpak |
| Dec 20, 2019 | https://github.com/angular/angular/pull/34254#discussion_r360432028 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #34512 | https://github.com/angular/angular/pull/34512 |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
| https://github.com/kara |
| kara | https://github.com/kara |
| 0b837e2 | https://github.com/angular/angular/commit/0b837e2f0d4ac178b0ddd8f50c46c1dc97e9b12c |
| Dec 18, 2019 | https://github.com/angular/angular/pull/34254#event-2894737290 |
| kara | https://github.com/kara |
|
Dec 18, 2019
| https://github.com/angular/angular/pull/34254#ref-commit-47666f5 |
|
| https://github.com/petebacondarwin |
|
| https://github.com/kara |
| fix(ngcc): handle CommonJS re-exports by reference ( | https://github.com/angular/angular/commit/47666f548c8a475a79d95ffb5f4264f4bb76233f |
| #34254 | https://github.com/angular/angular/pull/34254 |
| ) | https://github.com/angular/angular/commit/47666f548c8a475a79d95ffb5f4264f4bb76233f |
| 47666f5 | https://github.com/angular/angular/commit/47666f548c8a475a79d95ffb5f4264f4bb76233f |
| #34254 | https://github.com/angular/angular/pull/34254 |
| kara | https://github.com/kara |
|
Dec 18, 2019
| https://github.com/angular/angular/pull/34254#ref-commit-e9fb5fd |
|
| https://github.com/petebacondarwin |
|
| https://github.com/kara |
| fix(ngcc): handle UMD re-exports ( | https://github.com/angular/angular/commit/e9fb5fdb894b30c78e6f23f51f3a634ce325a7d0 |
| #34254 | https://github.com/angular/angular/pull/34254 |
| ) | https://github.com/angular/angular/commit/e9fb5fdb894b30c78e6f23f51f3a634ce325a7d0 |
| e9fb5fd | https://github.com/angular/angular/commit/e9fb5fdb894b30c78e6f23f51f3a634ce325a7d0 |
| #34254 | https://github.com/angular/angular/pull/34254 |
| kara | https://github.com/kara |
|
Dec 18, 2019
| https://github.com/angular/angular/pull/34254#ref-commit-f22a6eb |
|
| https://github.com/petebacondarwin |
|
| https://github.com/kara |
| fix(ngcc): correctly match aliased classes between src and dts files ( | https://github.com/angular/angular/commit/f22a6eb00ea91037656753971ddaa9ad8554d3ec |
| #… | https://github.com/angular/angular/pull/34254 |
| f22a6eb | https://github.com/angular/angular/commit/f22a6eb00ea91037656753971ddaa9ad8554d3ec |
| …34254 | https://github.com/angular/angular/pull/34254 |
| #33593 | https://github.com/angular/angular/issues/33593 |
| #34254 | https://github.com/angular/angular/pull/34254 |
| kara | https://github.com/kara |
|
Dec 18, 2019
| https://github.com/angular/angular/pull/34254#ref-commit-31be29a |
|
| https://github.com/petebacondarwin |
|
| https://github.com/kara |
| fix(ngcc): use the correct identifiers when updating typings files ( | https://github.com/angular/angular/commit/31be29a9f302fee7184d1824634d98e03df9caf2 |
| #… | https://github.com/angular/angular/pull/34254 |
| 31be29a | https://github.com/angular/angular/commit/31be29a9f302fee7184d1824634d98e03df9caf2 |
| …34254 | https://github.com/angular/angular/pull/34254 |
| angular/ngcc-validation#608 | https://github.com/angular/ngcc-validation/pull/608 |
| #34254 | https://github.com/angular/angular/pull/34254 |
| kara | https://github.com/kara |
|
Dec 18, 2019
| https://github.com/angular/angular/pull/34254#ref-commit-918d8c9 |
|
| https://github.com/petebacondarwin |
|
| https://github.com/kara |
| refactor(ngcc): slightly improve the info in error messages ( | https://github.com/angular/angular/commit/918d8c990904b35ba67ea60c4b985f22fab1e853 |
| #34254 | https://github.com/angular/angular/pull/34254 |
| ) | https://github.com/angular/angular/commit/918d8c990904b35ba67ea60c4b985f22fab1e853 |
| 918d8c9 | https://github.com/angular/angular/commit/918d8c990904b35ba67ea60c4b985f22fab1e853 |
| #34254 | https://github.com/angular/angular/pull/34254 |
| kara | https://github.com/kara |
|
Dec 18, 2019
| https://github.com/angular/angular/pull/34254#ref-commit-9264f43 |
|
| https://github.com/petebacondarwin |
|
| https://github.com/kara |
| refactor(ngcc): remove private declaration aliases ( | https://github.com/angular/angular/commit/9264f43511a14e72058951dc1ee7597a5b554388 |
| #34254 | https://github.com/angular/angular/pull/34254 |
| ) | https://github.com/angular/angular/commit/9264f43511a14e72058951dc1ee7597a5b554388 |
| 9264f43 | https://github.com/angular/angular/commit/9264f43511a14e72058951dc1ee7597a5b554388 |
| #34254 | https://github.com/angular/angular/pull/34254 |
| kara | https://github.com/kara |
|
Dec 18, 2019
| https://github.com/angular/angular/pull/34254#ref-commit-b2a8466 |
|
| https://github.com/petebacondarwin |
|
| https://github.com/kara |
| refactor(ngcc): use bundle src to create reflection hosts ( | https://github.com/angular/angular/commit/b2a8466e4546d37905bb2ca4e76b2a88dbe7fcbb |
| #34254 | https://github.com/angular/angular/pull/34254 |
| ) | https://github.com/angular/angular/commit/b2a8466e4546d37905bb2ca4e76b2a88dbe7fcbb |
| b2a8466 | https://github.com/angular/angular/commit/b2a8466e4546d37905bb2ca4e76b2a88dbe7fcbb |
| #34254 | https://github.com/angular/angular/pull/34254 |
| kara | https://github.com/kara |
|
Dec 18, 2019
| https://github.com/angular/angular/pull/34254#ref-commit-9ca5faa |
|
| https://github.com/petebacondarwin |
|
| https://github.com/kara |
| fix(ngcc): handle CommonJS re-exports by reference ( | https://github.com/angular/angular/commit/9ca5faab472e5c5546921afb03a959958ff2638d |
| #34254 | https://github.com/angular/angular/pull/34254 |
| ) | https://github.com/angular/angular/commit/9ca5faab472e5c5546921afb03a959958ff2638d |
| 9ca5faa | https://github.com/angular/angular/commit/9ca5faab472e5c5546921afb03a959958ff2638d |
| #34254 | https://github.com/angular/angular/pull/34254 |
| kara | https://github.com/kara |
|
Dec 18, 2019
| https://github.com/angular/angular/pull/34254#ref-commit-84a7d8a |
|
| https://github.com/petebacondarwin |
|
| https://github.com/kara |
| fix(ngcc): handle UMD re-exports ( | https://github.com/angular/angular/commit/84a7d8a4e482c66c0fe16b209b6390ac9363c137 |
| #34254 | https://github.com/angular/angular/pull/34254 |
| ) | https://github.com/angular/angular/commit/84a7d8a4e482c66c0fe16b209b6390ac9363c137 |
| 84a7d8a | https://github.com/angular/angular/commit/84a7d8a4e482c66c0fe16b209b6390ac9363c137 |
| #34254 | https://github.com/angular/angular/pull/34254 |
| kara | https://github.com/kara |
|
Dec 18, 2019
| https://github.com/angular/angular/pull/34254#ref-commit-4bffb6b |
|
| https://github.com/petebacondarwin |
|
| https://github.com/kara |
| fix(ngcc): correctly match aliased classes between src and dts files ( | https://github.com/angular/angular/commit/4bffb6bd6ef4bceb6038ce86a11003df3c5aa07a |
| #… | https://github.com/angular/angular/pull/34254 |
| 4bffb6b | https://github.com/angular/angular/commit/4bffb6bd6ef4bceb6038ce86a11003df3c5aa07a |
| …34254 | https://github.com/angular/angular/pull/34254 |
| #33593 | https://github.com/angular/angular/issues/33593 |
| #34254 | https://github.com/angular/angular/pull/34254 |
| kara | https://github.com/kara |
|
Dec 18, 2019
| https://github.com/angular/angular/pull/34254#ref-commit-c0c2ab3 |
|
| https://github.com/petebacondarwin |
|
| https://github.com/kara |
| fix(ngcc): use the correct identifiers when updating typings files ( | https://github.com/angular/angular/commit/c0c2ab30cb38f99b4d5570d8b7beffff07dcd717 |
| #… | https://github.com/angular/angular/pull/34254 |
| c0c2ab3 | https://github.com/angular/angular/commit/c0c2ab30cb38f99b4d5570d8b7beffff07dcd717 |
| …34254 | https://github.com/angular/angular/pull/34254 |
| angular/ngcc-validation#608 | https://github.com/angular/ngcc-validation/pull/608 |
| #34254 | https://github.com/angular/angular/pull/34254 |
| kara | https://github.com/kara |
|
Dec 18, 2019
| https://github.com/angular/angular/pull/34254#ref-commit-4403488 |
|
| https://github.com/petebacondarwin |
|
| https://github.com/kara |
| refactor(ngcc): slightly improve the info in error messages ( | https://github.com/angular/angular/commit/44034888fc022cfdea946ec814647d026680473e |
| #34254 | https://github.com/angular/angular/pull/34254 |
| ) | https://github.com/angular/angular/commit/44034888fc022cfdea946ec814647d026680473e |
| 4403488 | https://github.com/angular/angular/commit/44034888fc022cfdea946ec814647d026680473e |
| #34254 | https://github.com/angular/angular/pull/34254 |
| kara | https://github.com/kara |
|
Dec 18, 2019
| https://github.com/angular/angular/pull/34254#ref-commit-2ef633e |
|
| https://github.com/petebacondarwin |
|
| https://github.com/kara |
| refactor(ngcc): remove private declaration aliases ( | https://github.com/angular/angular/commit/2ef633ef8b1e2ed88511e7c1c086366e6983730c |
| #34254 | https://github.com/angular/angular/pull/34254 |
| ) | https://github.com/angular/angular/commit/2ef633ef8b1e2ed88511e7c1c086366e6983730c |
| 2ef633e | https://github.com/angular/angular/commit/2ef633ef8b1e2ed88511e7c1c086366e6983730c |
| #34254 | https://github.com/angular/angular/pull/34254 |
| https://github.com/tsvetomir |
| tsvetomir | https://github.com/tsvetomir |
|
Dec 19, 2019
| https://github.com/angular/angular/pull/34254#ref-issue-454568853 |
|
Build and run-time errors when using Ivy
telerik/kendo-angular#2321
| https://github.com/telerik/kendo-angular/issues/2321 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| December 19, 2019 09:30 | https://github.com/angular/angular/pull/34254#event-2896509408 |
| gkalpak | https://github.com/gkalpak |
|
Jan 8, 2020
| https://github.com/angular/angular/pull/34254#ref-commit-4ea6b5e |
|
| https://github.com/gkalpak |
| fix(ngcc): correctly handle inline exports in UMD | https://github.com/gkalpak/angular/commit/4ea6b5efd27bb65aed99b6132cba190fd6efb99c |
| 4ea6b5e | https://github.com/gkalpak/angular/commit/4ea6b5efd27bb65aed99b6132cba190fd6efb99c |
| 02bab8c | https://github.com/gkalpak/angular/commit/02bab8cf90bba06ee723e87938e436918dc86bb0 |
| 02bab8c | https://github.com/gkalpak/angular/commit/02bab8cf90bba06ee723e87938e436918dc86bb0 |
| angular#34254 | https://github.com/angular/angular/pull/34254 |
| alxhub | https://github.com/alxhub |
|
Jan 8, 2020
| https://github.com/angular/angular/pull/34254#ref-commit-7bbfccf |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| fix(ngcc): correctly handle inline exports in UMD ( | https://github.com/angular/angular/commit/7bbfccfcd83cfdab6ccc94133246dd9fd29f9d17 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| ) | https://github.com/angular/angular/commit/7bbfccfcd83cfdab6ccc94133246dd9fd29f9d17 |
| 7bbfccf | https://github.com/angular/angular/commit/7bbfccfcd83cfdab6ccc94133246dd9fd29f9d17 |
| 02bab8c | https://github.com/angular/angular/commit/02bab8cf90bba06ee723e87938e436918dc86bb0 |
| 02bab8c | https://github.com/angular/angular/commit/02bab8cf90bba06ee723e87938e436918dc86bb0 |
| #34254 | https://github.com/angular/angular/pull/34254 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| alxhub | https://github.com/alxhub |
|
Jan 8, 2020
| https://github.com/angular/angular/pull/34254#ref-commit-6654f82 |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| fix(ngcc): correctly handle inline exports in UMD ( | https://github.com/angular/angular/commit/6654f82522bffba139e15fc2d63fed43cd647cb3 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| ) | https://github.com/angular/angular/commit/6654f82522bffba139e15fc2d63fed43cd647cb3 |
| 6654f82 | https://github.com/angular/angular/commit/6654f82522bffba139e15fc2d63fed43cd647cb3 |
| 02bab8c | https://github.com/angular/angular/commit/02bab8cf90bba06ee723e87938e436918dc86bb0 |
| 02bab8c | https://github.com/angular/angular/commit/02bab8cf90bba06ee723e87938e436918dc86bb0 |
| #34254 | https://github.com/angular/angular/pull/34254 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jan 20, 2020 | https://github.com/angular/angular/pull/34254#issuecomment-576337629 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jan 20, 2020 | https://github.com/angular/angular/pull/34254#event-2963484905 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34254 |
|
| https://github.com/alxhub |
|
alxhub
| https://github.com/alxhub |
|
| https://github.com/angular/angular/pull/34254/files/e779e4afdc68330ddbbc3caaf320f8e88fa2d465 |
|
| https://github.com/gkalpak |
|
gkalpak
| https://github.com/gkalpak |
|
| https://github.com/angular/angular/pull/34254/files/e779e4afdc68330ddbbc3caaf320f8e88fa2d465 |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: compiler
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
|
Ivy: NGCC incorrectly compiles the "@ngxs/router-plugin" as UMD
| https://github.com/angular/angular/issues/34191 |
|
Compatibility Compiler Fails When Dependency has Multiple Modules with Same Named Pipe
| https://github.com/angular/angular/issues/33593 |
|
Ivy error TS-996002, when using compiled esm5 files
| https://github.com/angular/angular/issues/32442 |
| Please reload this page | https://github.com/angular/angular/pull/34254 |
|
| https://github.com/petebacondarwin |
|
| https://github.com/googlebot |
|
| https://github.com/alxhub |
|
| https://github.com/gkalpak |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |