René's URL Explorer Experiment


Title: fix(ivy): properly parenthesize ternary expressions when emitted by alxhub · Pull Request #34221 · angular/angular · GitHub

Open Graph Title: fix(ivy): properly parenthesize ternary expressions when emitted by alxhub · Pull Request #34221 · angular/angular

X Title: fix(ivy): properly parenthesize ternary expressions when emitted by alxhub · Pull Request #34221 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Previously, ternary expressions were emitted as: condExpr ? trueCase : falseCase However, this causes problems when ternary operations are nested. In particular, a template expression of the form: ...

X Description: Previously, ternary expressions were emitted as: condExpr ? trueCase : falseCase However, this causes problems when ternary operations are nested. In particular, a template expression of the form: ...

Opengraph URL: https://github.com/angular/angular/pull/34221

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c6a9c80e-e5d2-baba-7567-78d5484a8c37
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id80D6:38C5CF:1AF403E:224AD38:6B013729
html-safe-nonce57e520aa323f5234b594c61ed3ba858848a383b624d7e636eace689276ffda36
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEQ2OjM4QzVDRjoxQUY0MDNFOjIyNEFEMzg6NkIwMTM3MjkiLCJ2aXNpdG9yX2lkIjoiMzk2MzcxNDM0MTYxMzY4MDQyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2a97d094613b768513cffab89ef3406aa68fdea8892edf940b146cd4ee4fe805
hovercard-subject-tagpull_request:348618860
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34221/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/edddeb766dc8870d8fcad2d4097fb8f6dc36a17e1e02902066c8dff4997cb42a/angular/angular/pull/34221
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/edddeb766dc8870d8fcad2d4097fb8f6dc36a17e1e02902066c8dff4997cb42a/angular/angular/pull/34221
og:image:altPreviously, ternary expressions were emitted as: condExpr ? trueCase : falseCase However, this causes problems when ternary operations are nested. In particular, a template expression of the form: ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealxhub
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/34221#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34221
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34221
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34221
Reloadhttps://github.com/angular/angular/pull/34221
Reloadhttps://github.com/angular/angular/pull/34221
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
alxhubhttps://github.com/alxhub
angular:masterhttps://github.com/angular/angular/tree/master
alxhub:ngtsc/parens-conditionalhttps://github.com/alxhub/angular/tree/ngtsc/parens-conditional
Conversationhttps://github.com/angular/angular/pull/34221
Commits1 (1)https://github.com/angular/angular/pull/34221/commits
Checkshttps://github.com/angular/angular/pull/34221/checks
Files changedhttps://github.com/angular/angular/pull/34221/files
fix(ivy): properly parenthesize ternary expressions when emittedhttps://github.com/angular/angular/pull/34221#top
alxhubhttps://github.com/alxhub
angular:masterhttps://github.com/angular/angular/tree/master
alxhub:ngtsc/parens-conditionalhttps://github.com/alxhub/angular/tree/ngtsc/parens-conditional
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Dec 4, 2019https://github.com/angular/angular/pull/34221#issue-532351186
Please reload this pagehttps://github.com/angular/angular/pull/34221
https://github.com/alxhub
alxhubhttps://github.com/alxhub
December 4, 2019 00:05https://github.com/angular/angular/pull/34221#event-2852123821
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Dec 4, 2019https://github.com/angular/angular/pull/34221#event-2852123947
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Dec 4, 2019 https://github.com/angular/angular/pull/34221#ref-issue-529432288
ivy: accessing undefined ViewChild properly with elvis operator in template breaks #34087 https://github.com/angular/angular/issues/34087
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Dec 4, 2019 https://github.com/angular/angular/pull/34221#pullrequestreview-326537564
View reviewed changes https://github.com/angular/angular/pull/34221/files
AndrewKushnirhttps://github.com/AndrewKushnir
https://github.com/angular/angular/pull/34221#pullrequestreview-326537564
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34221
https://github.com/kara
karahttps://github.com/kara
Dec 4, 2019 https://github.com/angular/angular/pull/34221#pullrequestreview-326541759
View reviewed changes https://github.com/angular/angular/pull/34221/files
karahttps://github.com/kara
https://github.com/angular/angular/pull/34221#pullrequestreview-326541759
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34221
https://github.com/kara
karahttps://github.com/kara
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
comp: ivy https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Dec 4, 2019https://github.com/angular/angular/pull/34221#event-2852199390
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Dec 4, 2019https://github.com/angular/angular/pull/34221#event-2852199469
https://github.com/kara
karahttps://github.com/kara
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Dec 4, 2019https://github.com/angular/angular/pull/34221#event-2852199587
https://github.com/kara
karahttps://github.com/kara
alxhubhttps://github.com/alxhub
Dec 4, 2019https://github.com/angular/angular/pull/34221#event-2852200052
https://github.com/alxhub
alxhubhttps://github.com/alxhub
force-pushedhttps://github.com/angular/angular/compare/73cab8ab047351ee3374c41ceca89eab450755fd..9842512cfa23ed40eee531edb347275c37f5fb65
73cab8ahttps://github.com/angular/angular/commit/73cab8ab047351ee3374c41ceca89eab450755fd
9842512https://github.com/angular/angular/commit/9842512cfa23ed40eee531edb347275c37f5fb65
Compare https://github.com/angular/angular/compare/73cab8ab047351ee3374c41ceca89eab450755fd..9842512cfa23ed40eee531edb347275c37f5fb65
December 4, 2019 01:48https://github.com/angular/angular/pull/34221#event-2852321064
https://github.com/alxhub
alxhubhttps://github.com/alxhub
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Dec 4, 2019https://github.com/angular/angular/pull/34221#event-2852322029
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Dec 4, 2019 https://github.com/angular/angular/pull/34221#pullrequestreview-326561123
View reviewed changes https://github.com/angular/angular/pull/34221/files
AndrewKushnirhttps://github.com/AndrewKushnir
Please reload this pagehttps://github.com/angular/angular/pull/34221
https://github.com/angular/angular/pull/34221#pullrequestreview-326561123
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34221
https://github.com/alxhub
fix(ivy): properly parenthesize ternary expressions when emittedhttps://github.com/angular/angular/pull/34221/commits/025bf0d4b2d6b212a12154a1e652a1f33c833c11
025bf0dhttps://github.com/angular/angular/pull/34221/commits/025bf0d4b2d6b212a12154a1e652a1f33c833c11
angular#34087https://github.com/angular/angular/issues/34087
https://github.com/alxhub
alxhubhttps://github.com/alxhub
force-pushedhttps://github.com/angular/angular/compare/9842512cfa23ed40eee531edb347275c37f5fb65..025bf0d4b2d6b212a12154a1e652a1f33c833c11
9842512https://github.com/angular/angular/commit/9842512cfa23ed40eee531edb347275c37f5fb65
025bf0dhttps://github.com/angular/angular/commit/025bf0d4b2d6b212a12154a1e652a1f33c833c11
Compare https://github.com/angular/angular/compare/9842512cfa23ed40eee531edb347275c37f5fb65..025bf0d4b2d6b212a12154a1e652a1f33c833c11
December 4, 2019 17:57https://github.com/angular/angular/pull/34221#event-2854965790
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Dec 6, 2019https://github.com/angular/angular/pull/34221#issuecomment-562709555
Presubmithttp://test/OCL:284228209:BASE:284228253:1575661085709:6916b13a
Please reload this pagehttps://github.com/angular/angular/pull/34221
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Dec 6, 2019https://github.com/angular/angular/pull/34221#event-2862537440
AndrewKushnirhttps://github.com/AndrewKushnir
Dec 6, 2019 https://github.com/angular/angular/pull/34221#ref-commit-af36bc6
https://github.com/alxhub
https://github.com/AndrewKushnir
fix(ivy): properly parenthesize ternary expressions when emitted (https://github.com/angular/angular/commit/af36bc6ba3d0e1e451239708909b6521e7b0346f
#34221https://github.com/angular/angular/pull/34221
af36bc6https://github.com/angular/angular/commit/af36bc6ba3d0e1e451239708909b6521e7b0346f
https://github.com/angular/angular/pull/34221
#34087https://github.com/angular/angular/issues/34087
#34221https://github.com/angular/angular/pull/34221
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
718d7fehttps://github.com/angular/angular/commit/718d7fe5fefd6a77f7fffed04559eb610acd5a57
Dec 6, 2019https://github.com/angular/angular/pull/34221#event-2862744066
https://github.com/mgechev
mgechevhttps://github.com/mgechev
Dec 12, 2019 https://github.com/angular/angular/pull/34221#ref-issue-537250738
Align with the optional chaining spec #34385 https://github.com/angular/angular/issues/34385
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jan 6, 2020https://github.com/angular/angular/pull/34221#issuecomment-571197538
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/34221
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jan 6, 2020https://github.com/angular/angular/pull/34221#event-2924681757
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34221
https://github.com/AndrewKushnir
AndrewKushnir https://github.com/AndrewKushnir
https://github.com/angular/angular/pull/34221/files/9842512cfa23ed40eee531edb347275c37f5fb65
https://github.com/kara
kara https://github.com/kara
https://github.com/angular/angular/pull/34221/files/776c305920f3b323554d158e4eed985b74e8653d
Please reload this pagehttps://github.com/angular/angular/pull/34221
https://github.com/alxhub
alxhub https://github.com/alxhub
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/34221
https://github.com/alxhub
https://github.com/AndrewKushnir
https://github.com/kara
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.