| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:35de0d2d-ee1e-d43b-3275-efb58a858e9d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A6A4:23CF06:13B47D3:193ED3C:6B011642 |
| html-safe-nonce | f7eafdc69aa617733e55de438ffa5c84d4fd7ea58d709fa176b57d7d2e7b774f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkE0OjIzQ0YwNjoxM0I0N0QzOjE5M0VEM0M6NkIwMTE2NDIiLCJ2aXNpdG9yX2lkIjoiNDkyMTY0NDczMDQxNDA3NzUwNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6724155577949fc8bd73c1c067081abe58e560c7c02b0cfd028d1411ee27d2e7 |
| hovercard-subject-tag | pull_request:347352500 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34169/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/aae01f41b526d1efbdfebaf6d5ee9b4230e2a7ba0d2952cee0d31574d35eef35/angular/angular/pull/34169 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/aae01f41b526d1efbdfebaf6d5ee9b4230e2a7ba0d2952cee0d31574d35eef35/angular/angular/pull/34169 |
| og:image:alt | This PR includes several ngcc fixes. With these fixes, ngcc should be able to successfully process NativeScript. See individual commits for details.
Jira issue: FW-1689
TODO:
Determine whether i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gkalpak |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/34169#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34169 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34169 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/34169 |
| Reload | https://github.com/angular/angular/pull/34169 |
| Reload | https://github.com/angular/angular/pull/34169 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-ngcc-nativescript | https://github.com/gkalpak/angular/tree/fix-ngcc-nativescript |
| Conversation | https://github.com/angular/angular/pull/34169 |
| Commits6 (6) | https://github.com/angular/angular/pull/34169/commits |
| Checks | https://github.com/angular/angular/pull/34169/checks |
| Files changed | https://github.com/angular/angular/pull/34169/files |
| fix(ngcc): several fixes | https://github.com/angular/angular/pull/34169#top |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-ngcc-nativescript | https://github.com/gkalpak/angular/tree/fix-ngcc-nativescript |
|
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Dec 1, 2019 | https://github.com/angular/angular/pull/34169#issue-530767200 |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| FW-1689 | https://angular-team.atlassian.net/browse/FW-1689 |
| function declaration | https://github.com/angular/angular/commit/e28ac708e#diff-3814db5d5b51f278653eb80c9ac981c1R235 |
| non-synthetic | https://github.com/angular/angular/blob/023c9bebe/packages/compiler-cli/src/ngtsc/partial_evaluator/src/interpreter.ts#L242-L244 |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
|
comp: ngcc
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22 |
| Dec 1, 2019 | https://github.com/angular/angular/pull/34169#event-2843616896 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Dec 1, 2019 | https://github.com/angular/angular/pull/34169#event-2843616913 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Dec 1, 2019 | https://github.com/angular/angular/pull/34169#event-2843616937 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Dec 1, 2019 | https://github.com/angular/angular/pull/34169#issuecomment-560136539 |
| 5fdc4a2 | https://github.com/angular/angular/commit/5fdc4a2c5e546adffe9ef7dc690d23ff733098db |
| https://pr34169-5fdc4a2.ngbuilds.io/ | https://pr34169-5fdc4a2.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Dec 1, 2019 | https://github.com/angular/angular/pull/34169#issuecomment-560140363 |
| https://pr34169-263efda.ngbuilds.io/ | https://pr34169-263efda.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/263efdaa5b70a605d015509ac75e71d9cabef48d..8077ce10f5cd654b9d56c7ae9f6616a64d55e637 |
| 263efda | https://github.com/angular/angular/commit/263efdaa5b70a605d015509ac75e71d9cabef48d |
| 8077ce1 | https://github.com/angular/angular/commit/8077ce10f5cd654b9d56c7ae9f6616a64d55e637 |
|
Compare
| https://github.com/angular/angular/compare/263efdaa5b70a605d015509ac75e71d9cabef48d..8077ce10f5cd654b9d56c7ae9f6616a64d55e637 |
| December 2, 2019 19:19 | https://github.com/angular/angular/pull/34169#event-2846936122 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Dec 2, 2019 | https://github.com/angular/angular/pull/34169#issuecomment-560544608 |
| https://pr34169-8077ce1.ngbuilds.io/ | https://pr34169-8077ce1.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/8077ce10f5cd654b9d56c7ae9f6616a64d55e637..b0cc9d95a623bb1d7f5b7b07741be49aaecad5fa |
| 8077ce1 | https://github.com/angular/angular/commit/8077ce10f5cd654b9d56c7ae9f6616a64d55e637 |
| b0cc9d9 | https://github.com/angular/angular/commit/b0cc9d95a623bb1d7f5b7b07741be49aaecad5fa |
|
Compare
| https://github.com/angular/angular/compare/8077ce10f5cd654b9d56c7ae9f6616a64d55e637..b0cc9d95a623bb1d7f5b7b07741be49aaecad5fa |
| December 3, 2019 21:03 | https://github.com/angular/angular/pull/34169#event-2851642493 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Dec 3, 2019 | https://github.com/angular/angular/pull/34169#issuecomment-561358606 |
| https://pr34169-b0cc9d9.ngbuilds.io/ | https://pr34169-b0cc9d9.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/b0cc9d95a623bb1d7f5b7b07741be49aaecad5fa..a45d1bb6c56f5fac407078ca5437e60be5b6e82a |
| b0cc9d9 | https://github.com/angular/angular/commit/b0cc9d95a623bb1d7f5b7b07741be49aaecad5fa |
| a45d1bb | https://github.com/angular/angular/commit/a45d1bb6c56f5fac407078ca5437e60be5b6e82a |
|
Compare
| https://github.com/angular/angular/compare/b0cc9d95a623bb1d7f5b7b07741be49aaecad5fa..a45d1bb6c56f5fac407078ca5437e60be5b6e82a |
| December 4, 2019 20:39 | https://github.com/angular/angular/pull/34169#event-2855452687 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Dec 4, 2019 | https://github.com/angular/angular/pull/34169#issuecomment-561831807 |
| https://pr34169-a45d1bb.ngbuilds.io/ | https://pr34169-a45d1bb.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/a45d1bb6c56f5fac407078ca5437e60be5b6e82a..363218f2cf71ec29366187e90a0690750965e08d |
| a45d1bb | https://github.com/angular/angular/commit/a45d1bb6c56f5fac407078ca5437e60be5b6e82a |
| 363218f | https://github.com/angular/angular/commit/363218f2cf71ec29366187e90a0690750965e08d |
|
Compare
| https://github.com/angular/angular/compare/a45d1bb6c56f5fac407078ca5437e60be5b6e82a..363218f2cf71ec29366187e90a0690750965e08d |
| December 5, 2019 16:38 | https://github.com/angular/angular/pull/34169#event-2858511465 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Dec 5, 2019 | https://github.com/angular/angular/pull/34169#issuecomment-562213492 |
| https://pr34169-363218f.ngbuilds.io/ | https://pr34169-363218f.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/363218f2cf71ec29366187e90a0690750965e08d..08f17b8c17473c69bd2c9c873a22d989dccfc1de |
| 363218f | https://github.com/angular/angular/commit/363218f2cf71ec29366187e90a0690750965e08d |
| 08f17b8 | https://github.com/angular/angular/commit/08f17b8c17473c69bd2c9c873a22d989dccfc1de |
|
Compare
| https://github.com/angular/angular/compare/363218f2cf71ec29366187e90a0690750965e08d..08f17b8c17473c69bd2c9c873a22d989dccfc1de |
| December 5, 2019 18:38 | https://github.com/angular/angular/pull/34169#event-2858885423 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Dec 5, 2019 | https://github.com/angular/angular/pull/34169#issuecomment-562262065 |
| https://pr34169-08f17b8.ngbuilds.io/ | https://pr34169-08f17b8.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Dec 5, 2019 | https://github.com/angular/angular/pull/34169#event-2858932190 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Dec 5, 2019 | https://github.com/angular/angular/pull/34169#event-2858932850 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Dec 5, 2019 | https://github.com/angular/angular/pull/34169#event-2858942760 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| December 5, 2019 18:58 | https://github.com/angular/angular/pull/34169#event-2858943467 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| December 5, 2019 18:58 | https://github.com/angular/angular/pull/34169#event-2858943496 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/08f17b8c17473c69bd2c9c873a22d989dccfc1de..e28ac708e3b5696b7c1bcb592e6fd5b35d24c233 |
| 08f17b8 | https://github.com/angular/angular/commit/08f17b8c17473c69bd2c9c873a22d989dccfc1de |
| e28ac70 | https://github.com/angular/angular/commit/e28ac708e3b5696b7c1bcb592e6fd5b35d24c233 |
|
Compare
| https://github.com/angular/angular/compare/08f17b8c17473c69bd2c9c873a22d989dccfc1de..e28ac708e3b5696b7c1bcb592e6fd5b35d24c233 |
| December 5, 2019 19:03 | https://github.com/angular/angular/pull/34169#event-2858958785 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Dec 5, 2019 | https://github.com/angular/angular/pull/34169#issuecomment-562271873 |
| https://pr34169-e28ac70.ngbuilds.io/ | https://pr34169-e28ac70.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Dec 5, 2019 | https://github.com/angular/angular/pull/34169#issuecomment-562316745 |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Dec 5, 2019 | https://github.com/angular/angular/pull/34169#issuecomment-562318171 |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Dec 6, 2019 | https://github.com/angular/angular/pull/34169#issuecomment-562489983 |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Dec 6, 2019
| https://github.com/angular/angular/pull/34169#pullrequestreview-328065692 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34169/files |
| petebacondarwin | https://github.com/petebacondarwin |
| https://github.com/angular/angular/pull/34169#pullrequestreview-328065692 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| packages/compiler-cli/ngcc/src/host/commonjs_host.ts | https://github.com/angular/angular/pull/34169/files#diff-39b1d4e5eef7a09fe5e7d016596c2e5faca423bd2a3a6b394da7f755d537712e |
| petebacondarwin | https://github.com/petebacondarwin |
| Dec 6, 2019 | https://github.com/angular/angular/pull/34169#discussion_r354721477 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| packages/compiler-cli/ngcc/src/host/commonjs_host.ts | https://github.com/angular/angular/pull/34169/files#diff-39b1d4e5eef7a09fe5e7d016596c2e5faca423bd2a3a6b394da7f755d537712e |
| petebacondarwin | https://github.com/petebacondarwin |
| Dec 6, 2019 | https://github.com/angular/angular/pull/34169#discussion_r354721958 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| packages/compiler-cli/ngcc/test/dependencies/commonjs_dependency_host_spec.ts | https://github.com/angular/angular/pull/34169/files#diff-b9a434ddeccf672f64c9b14a05be7b3fca1e12d1be9af84b641b65eec8806e35 |
| petebacondarwin | https://github.com/petebacondarwin |
| Dec 6, 2019 | https://github.com/angular/angular/pull/34169#discussion_r354726072 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| packages/compiler-cli/ngcc/src/dependencies/commonjs_dependency_host.ts | https://github.com/angular/angular/pull/34169/files#diff-b22df43fa91ac4fb3eb58b54367c574d3b2cd7f6206ffc150025652c31f4a7b2 |
| petebacondarwin | https://github.com/petebacondarwin |
| Dec 6, 2019 | https://github.com/angular/angular/pull/34169#discussion_r354729263 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| packages/compiler-cli/ngcc/src/dependencies/commonjs_dependency_host.ts | https://github.com/angular/angular/pull/34169/files#diff-b22df43fa91ac4fb3eb58b54367c574d3b2cd7f6206ffc150025652c31f4a7b2 |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Dec 6, 2019
| https://github.com/angular/angular/pull/34169#pullrequestreview-328130252 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34169/files |
| packages/compiler-cli/ngcc/src/host/esm5_host.ts | https://github.com/angular/angular/pull/34169/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0 |
| petebacondarwin | https://github.com/petebacondarwin |
| Dec 6, 2019 | https://github.com/angular/angular/pull/34169#discussion_r354774583 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Dec 6, 2019
| https://github.com/angular/angular/pull/34169#pullrequestreview-328132150 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34169/files |
| petebacondarwin | https://github.com/petebacondarwin |
| https://github.com/angular/angular/pull/34169#pullrequestreview-328132150 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Dec 10, 2019
| https://github.com/angular/angular/pull/34169#ref-issue-531479410 |
|
Ivy: NGCC incorrectly compiles the "@ngxs/router-plugin" as UMD
#34191
| https://github.com/angular/angular/issues/34191 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Dec 11, 2019 | https://github.com/angular/angular/pull/34169#issuecomment-564664069 |
| @gkalpak | https://github.com/gkalpak |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Dec 12, 2019 | https://github.com/angular/angular/pull/34169#issuecomment-564988407 |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/e28ac708e3b5696b7c1bcb592e6fd5b35d24c233..2b6e20ea694066a1fba87c95eb348c1bee2c5968 |
| e28ac70 | https://github.com/angular/angular/commit/e28ac708e3b5696b7c1bcb592e6fd5b35d24c233 |
| 2b6e20e | https://github.com/angular/angular/commit/2b6e20ea694066a1fba87c95eb348c1bee2c5968 |
|
Compare
| https://github.com/angular/angular/compare/e28ac708e3b5696b7c1bcb592e6fd5b35d24c233..2b6e20ea694066a1fba87c95eb348c1bee2c5968 |
| December 17, 2019 10:03 | https://github.com/angular/angular/pull/34169#event-2889202530 |
| gkalpak | https://github.com/gkalpak |
| December 17, 2019 12:04 | https://github.com/angular/angular/pull/34169#commits-pushed-aff45c2 |
|
| https://github.com/gkalpak |
| fix(ngcc): recognize more re-export formats in CommonJS | https://github.com/angular/angular/pull/34169/commits/aff45c2ec399743a445f56ec8d63eab229fc261d |
| aff45c2 | https://github.com/angular/angular/pull/34169/commits/aff45c2ec399743a445f56ec8d63eab229fc261d |
| https://www.typescriptlang.org/docs/handbook/compiler-options.html | https://www.typescriptlang.org/docs/handbook/compiler-options.html |
| https://www.npmjs.com/package/tslib | https://www.npmjs.com/package/tslib |
|
| https://github.com/gkalpak |
| fixup! fix(ngcc): recognize more re-export formats in CommonJS | https://github.com/angular/angular/pull/34169/commits/12e9773083d50c83cea2fd16185f8e8aa6a4deb6 |
| 12e9773 | https://github.com/angular/angular/pull/34169/commits/12e9773083d50c83cea2fd16185f8e8aa6a4deb6 |
|
| https://github.com/gkalpak |
| fix(ngcc): correctly detect dependencies in CommonJS | https://github.com/angular/angular/pull/34169/commits/d4c9f953ddb26008bdf27e0143039a48d7d22ed9 |
| d4c9f95 | https://github.com/angular/angular/pull/34169/commits/d4c9f953ddb26008bdf27e0143039a48d7d22ed9 |
|
| https://github.com/gkalpak |
| fixup! fix(ngcc): correctly detect dependencies in CommonJS | https://github.com/angular/angular/pull/34169/commits/1c42fb38860eebd3d56ec9cd9096be3a80ffe2d1 |
| 1c42fb3 | https://github.com/angular/angular/pull/34169/commits/1c42fb38860eebd3d56ec9cd9096be3a80ffe2d1 |
|
| https://github.com/gkalpak |
| fix(ngcc): correctly detect emitted TS helpers in ES5 | https://github.com/angular/angular/pull/34169/commits/0b89f17c3613aafb056ae63d7f3e3bc1a950ee1f |
| 0b89f17 | https://github.com/angular/angular/pull/34169/commits/0b89f17c3613aafb056ae63d7f3e3bc1a950ee1f |
|
| https://github.com/gkalpak |
| fixup! fix(ngcc): correctly detect emitted TS helpers in ES5 | https://github.com/angular/angular/pull/34169/commits/8c37785814dfffd843546b461fa86cbf0eb9fda2 |
| 8c37785 | https://github.com/angular/angular/pull/34169/commits/8c37785814dfffd843546b461fa86cbf0eb9fda2 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/2b6e20ea694066a1fba87c95eb348c1bee2c5968..8c37785814dfffd843546b461fa86cbf0eb9fda2 |
| 2b6e20e | https://github.com/angular/angular/commit/2b6e20ea694066a1fba87c95eb348c1bee2c5968 |
| 8c37785 | https://github.com/angular/angular/commit/8c37785814dfffd843546b461fa86cbf0eb9fda2 |
|
Compare
| https://github.com/angular/angular/compare/2b6e20ea694066a1fba87c95eb348c1bee2c5968..8c37785814dfffd843546b461fa86cbf0eb9fda2 |
| December 17, 2019 10:06 | https://github.com/angular/angular/pull/34169#event-2889210262 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Dec 17, 2019 | https://github.com/angular/angular/pull/34169#issuecomment-566473622 |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| @petebacondarwin | https://github.com/petebacondarwin |
| #34437 | https://github.com/angular/angular/pull/34437 |
| #34441 | https://github.com/angular/angular/pull/34441 |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Dec 17, 2019 | https://github.com/angular/angular/pull/34169#issuecomment-566475768 |
| 8c37785 | https://github.com/angular/angular/commit/8c37785814dfffd843546b461fa86cbf0eb9fda2 |
| https://pr34169-8c37785.ngbuilds.io/ | https://pr34169-8c37785.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Dec 21, 2019 | https://github.com/angular/angular/pull/34169#issuecomment-568191909 |
| #34512 | https://github.com/angular/angular/pull/34512 |
| #34527 | https://github.com/angular/angular/pull/34527 |
| #34528 | https://github.com/angular/angular/pull/34528 |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
state: blocked
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Jan 10, 2020 | https://github.com/angular/angular/pull/34169#event-2937930459 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Jan 14, 2020 | https://github.com/angular/angular/pull/34169#issuecomment-574139372 |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| 0b89f17 | https://github.com/angular/angular/commit/0b89f17c3613aafb056ae63d7f3e3bc1a950ee1f |
| angular/ngcc-validation#762 | https://github.com/angular/ngcc-validation/pull/762 |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Jan 14, 2020
| https://github.com/angular/angular/pull/34169#ref-pullrequest-546323557 |
|
fix(ngcc): libraries using spread in object literals cannot be processed
#34661
| https://github.com/angular/angular/pull/34661 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Feb 6, 2020 | https://github.com/angular/angular/pull/34169#issuecomment-583021583 |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| #35139 | https://github.com/angular/angular/issues/35139 |
| #35191 | https://github.com/angular/angular/pull/35191 |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Feb 6, 2020 | https://github.com/angular/angular/pull/34169#event-3014829729 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Mar 8, 2020 | https://github.com/angular/angular/pull/34169#issuecomment-596221758 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Mar 8, 2020 | https://github.com/angular/angular/pull/34169#event-3108521816 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| October 2, 2020 09:20 | https://github.com/angular/angular/pull/34169#event-3833106252 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34169 |
|
| https://github.com/petebacondarwin |
|
petebacondarwin
| https://github.com/petebacondarwin |
|
| https://github.com/angular/angular/pull/34169/files/e28ac708e3b5696b7c1bcb592e6fd5b35d24c233 |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
state: blocked
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
| Please reload this page | https://github.com/angular/angular/pull/34169 |
|
| https://github.com/gkalpak |
|
| https://github.com/mary-poppins |
|
| https://github.com/petebacondarwin |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |