René's URL Explorer Experiment


Title: fix(ngcc): several fixes by gkalpak · Pull Request #34169 · angular/angular · GitHub

Open Graph Title: fix(ngcc): several fixes by gkalpak · Pull Request #34169 · angular/angular

X Title: fix(ngcc): several fixes by gkalpak · Pull Request #34169 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This PR includes several ngcc fixes. With these fixes, ngcc should be able to successfully process NativeScript. See individual commits for details. Jira issue: FW-1689 TODO: Determine whether i...

X Description: This PR includes several ngcc fixes. With these fixes, ngcc should be able to successfully process NativeScript. See individual commits for details. Jira issue: FW-1689 TODO: Determine whether i...

Opengraph URL: https://github.com/angular/angular/pull/34169

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:35de0d2d-ee1e-d43b-3275-efb58a858e9d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA6A4:23CF06:13B47D3:193ED3C:6B011642
html-safe-noncef7eafdc69aa617733e55de438ffa5c84d4fd7ea58d709fa176b57d7d2e7b774f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkE0OjIzQ0YwNjoxM0I0N0QzOjE5M0VEM0M6NkIwMTE2NDIiLCJ2aXNpdG9yX2lkIjoiNDkyMTY0NDczMDQxNDA3NzUwNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6724155577949fc8bd73c1c067081abe58e560c7c02b0cfd028d1411ee27d2e7
hovercard-subject-tagpull_request:347352500
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34169/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/aae01f41b526d1efbdfebaf6d5ee9b4230e2a7ba0d2952cee0d31574d35eef35/angular/angular/pull/34169
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/aae01f41b526d1efbdfebaf6d5ee9b4230e2a7ba0d2952cee0d31574d35eef35/angular/angular/pull/34169
og:image:altThis PR includes several ngcc fixes. With these fixes, ngcc should be able to successfully process NativeScript. See individual commits for details. Jira issue: FW-1689 TODO: Determine whether i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegkalpak
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/34169#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34169
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34169
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34169
Reloadhttps://github.com/angular/angular/pull/34169
Reloadhttps://github.com/angular/angular/pull/34169
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-ngcc-nativescripthttps://github.com/gkalpak/angular/tree/fix-ngcc-nativescript
Conversationhttps://github.com/angular/angular/pull/34169
Commits6 (6)https://github.com/angular/angular/pull/34169/commits
Checkshttps://github.com/angular/angular/pull/34169/checks
Files changedhttps://github.com/angular/angular/pull/34169/files
fix(ngcc): several fixeshttps://github.com/angular/angular/pull/34169#top
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-ngcc-nativescripthttps://github.com/gkalpak/angular/tree/fix-ngcc-nativescript
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 1, 2019https://github.com/angular/angular/pull/34169#issue-530767200
Please reload this pagehttps://github.com/angular/angular/pull/34169
FW-1689https://angular-team.atlassian.net/browse/FW-1689
function declarationhttps://github.com/angular/angular/commit/e28ac708e#diff-3814db5d5b51f278653eb80c9ac981c1R235
non-synthetichttps://github.com/angular/angular/blob/023c9bebe/packages/compiler-cli/src/ngtsc/partial_evaluator/src/interpreter.ts#L242-L244
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
comp: ngcc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
Dec 1, 2019https://github.com/angular/angular/pull/34169#event-2843616896
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Dec 1, 2019https://github.com/angular/angular/pull/34169#event-2843616913
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Dec 1, 2019https://github.com/angular/angular/pull/34169#event-2843616937
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Dec 1, 2019https://github.com/angular/angular/pull/34169#issuecomment-560136539
5fdc4a2https://github.com/angular/angular/commit/5fdc4a2c5e546adffe9ef7dc690d23ff733098db
https://pr34169-5fdc4a2.ngbuilds.io/https://pr34169-5fdc4a2.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Dec 1, 2019https://github.com/angular/angular/pull/34169#issuecomment-560140363
https://pr34169-263efda.ngbuilds.io/https://pr34169-263efda.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/263efdaa5b70a605d015509ac75e71d9cabef48d..8077ce10f5cd654b9d56c7ae9f6616a64d55e637
263efdahttps://github.com/angular/angular/commit/263efdaa5b70a605d015509ac75e71d9cabef48d
8077ce1https://github.com/angular/angular/commit/8077ce10f5cd654b9d56c7ae9f6616a64d55e637
Compare https://github.com/angular/angular/compare/263efdaa5b70a605d015509ac75e71d9cabef48d..8077ce10f5cd654b9d56c7ae9f6616a64d55e637
December 2, 2019 19:19https://github.com/angular/angular/pull/34169#event-2846936122
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Dec 2, 2019https://github.com/angular/angular/pull/34169#issuecomment-560544608
https://pr34169-8077ce1.ngbuilds.io/https://pr34169-8077ce1.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/8077ce10f5cd654b9d56c7ae9f6616a64d55e637..b0cc9d95a623bb1d7f5b7b07741be49aaecad5fa
8077ce1https://github.com/angular/angular/commit/8077ce10f5cd654b9d56c7ae9f6616a64d55e637
b0cc9d9https://github.com/angular/angular/commit/b0cc9d95a623bb1d7f5b7b07741be49aaecad5fa
Compare https://github.com/angular/angular/compare/8077ce10f5cd654b9d56c7ae9f6616a64d55e637..b0cc9d95a623bb1d7f5b7b07741be49aaecad5fa
December 3, 2019 21:03https://github.com/angular/angular/pull/34169#event-2851642493
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Dec 3, 2019https://github.com/angular/angular/pull/34169#issuecomment-561358606
https://pr34169-b0cc9d9.ngbuilds.io/https://pr34169-b0cc9d9.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/b0cc9d95a623bb1d7f5b7b07741be49aaecad5fa..a45d1bb6c56f5fac407078ca5437e60be5b6e82a
b0cc9d9https://github.com/angular/angular/commit/b0cc9d95a623bb1d7f5b7b07741be49aaecad5fa
a45d1bbhttps://github.com/angular/angular/commit/a45d1bb6c56f5fac407078ca5437e60be5b6e82a
Compare https://github.com/angular/angular/compare/b0cc9d95a623bb1d7f5b7b07741be49aaecad5fa..a45d1bb6c56f5fac407078ca5437e60be5b6e82a
December 4, 2019 20:39https://github.com/angular/angular/pull/34169#event-2855452687
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Dec 4, 2019https://github.com/angular/angular/pull/34169#issuecomment-561831807
https://pr34169-a45d1bb.ngbuilds.io/https://pr34169-a45d1bb.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/a45d1bb6c56f5fac407078ca5437e60be5b6e82a..363218f2cf71ec29366187e90a0690750965e08d
a45d1bbhttps://github.com/angular/angular/commit/a45d1bb6c56f5fac407078ca5437e60be5b6e82a
363218fhttps://github.com/angular/angular/commit/363218f2cf71ec29366187e90a0690750965e08d
Compare https://github.com/angular/angular/compare/a45d1bb6c56f5fac407078ca5437e60be5b6e82a..363218f2cf71ec29366187e90a0690750965e08d
December 5, 2019 16:38https://github.com/angular/angular/pull/34169#event-2858511465
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Dec 5, 2019https://github.com/angular/angular/pull/34169#issuecomment-562213492
https://pr34169-363218f.ngbuilds.io/https://pr34169-363218f.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/363218f2cf71ec29366187e90a0690750965e08d..08f17b8c17473c69bd2c9c873a22d989dccfc1de
363218fhttps://github.com/angular/angular/commit/363218f2cf71ec29366187e90a0690750965e08d
08f17b8https://github.com/angular/angular/commit/08f17b8c17473c69bd2c9c873a22d989dccfc1de
Compare https://github.com/angular/angular/compare/363218f2cf71ec29366187e90a0690750965e08d..08f17b8c17473c69bd2c9c873a22d989dccfc1de
December 5, 2019 18:38https://github.com/angular/angular/pull/34169#event-2858885423
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Dec 5, 2019https://github.com/angular/angular/pull/34169#issuecomment-562262065
https://pr34169-08f17b8.ngbuilds.io/https://pr34169-08f17b8.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 5, 2019https://github.com/angular/angular/pull/34169#event-2858932190
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 5, 2019https://github.com/angular/angular/pull/34169#event-2858932850
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
Dec 5, 2019https://github.com/angular/angular/pull/34169#event-2858942760
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
December 5, 2019 18:58https://github.com/angular/angular/pull/34169#event-2858943467
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
December 5, 2019 18:58https://github.com/angular/angular/pull/34169#event-2858943496
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/08f17b8c17473c69bd2c9c873a22d989dccfc1de..e28ac708e3b5696b7c1bcb592e6fd5b35d24c233
08f17b8https://github.com/angular/angular/commit/08f17b8c17473c69bd2c9c873a22d989dccfc1de
e28ac70https://github.com/angular/angular/commit/e28ac708e3b5696b7c1bcb592e6fd5b35d24c233
Compare https://github.com/angular/angular/compare/08f17b8c17473c69bd2c9c873a22d989dccfc1de..e28ac708e3b5696b7c1bcb592e6fd5b35d24c233
December 5, 2019 19:03https://github.com/angular/angular/pull/34169#event-2858958785
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Dec 5, 2019https://github.com/angular/angular/pull/34169#issuecomment-562271873
https://pr34169-e28ac70.ngbuilds.io/https://pr34169-e28ac70.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Dec 5, 2019https://github.com/angular/angular/pull/34169#issuecomment-562316745
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Dec 5, 2019https://github.com/angular/angular/pull/34169#issuecomment-562318171
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Dec 6, 2019https://github.com/angular/angular/pull/34169#issuecomment-562489983
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Dec 6, 2019 https://github.com/angular/angular/pull/34169#pullrequestreview-328065692
View reviewed changes https://github.com/angular/angular/pull/34169/files
petebacondarwinhttps://github.com/petebacondarwin
https://github.com/angular/angular/pull/34169#pullrequestreview-328065692
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34169
packages/compiler-cli/ngcc/src/host/commonjs_host.tshttps://github.com/angular/angular/pull/34169/files#diff-39b1d4e5eef7a09fe5e7d016596c2e5faca423bd2a3a6b394da7f755d537712e
petebacondarwinhttps://github.com/petebacondarwin
Dec 6, 2019https://github.com/angular/angular/pull/34169#discussion_r354721477
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34169
packages/compiler-cli/ngcc/src/host/commonjs_host.tshttps://github.com/angular/angular/pull/34169/files#diff-39b1d4e5eef7a09fe5e7d016596c2e5faca423bd2a3a6b394da7f755d537712e
petebacondarwinhttps://github.com/petebacondarwin
Dec 6, 2019https://github.com/angular/angular/pull/34169#discussion_r354721958
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34169
packages/compiler-cli/ngcc/test/dependencies/commonjs_dependency_host_spec.tshttps://github.com/angular/angular/pull/34169/files#diff-b9a434ddeccf672f64c9b14a05be7b3fca1e12d1be9af84b641b65eec8806e35
petebacondarwinhttps://github.com/petebacondarwin
Dec 6, 2019https://github.com/angular/angular/pull/34169#discussion_r354726072
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34169
packages/compiler-cli/ngcc/src/dependencies/commonjs_dependency_host.tshttps://github.com/angular/angular/pull/34169/files#diff-b22df43fa91ac4fb3eb58b54367c574d3b2cd7f6206ffc150025652c31f4a7b2
petebacondarwinhttps://github.com/petebacondarwin
Dec 6, 2019https://github.com/angular/angular/pull/34169#discussion_r354729263
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34169
packages/compiler-cli/ngcc/src/dependencies/commonjs_dependency_host.tshttps://github.com/angular/angular/pull/34169/files#diff-b22df43fa91ac4fb3eb58b54367c574d3b2cd7f6206ffc150025652c31f4a7b2
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Dec 6, 2019 https://github.com/angular/angular/pull/34169#pullrequestreview-328130252
View reviewed changes https://github.com/angular/angular/pull/34169/files
packages/compiler-cli/ngcc/src/host/esm5_host.tshttps://github.com/angular/angular/pull/34169/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
petebacondarwinhttps://github.com/petebacondarwin
Dec 6, 2019https://github.com/angular/angular/pull/34169#discussion_r354774583
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Dec 6, 2019 https://github.com/angular/angular/pull/34169#pullrequestreview-328132150
View reviewed changes https://github.com/angular/angular/pull/34169/files
petebacondarwinhttps://github.com/petebacondarwin
https://github.com/angular/angular/pull/34169#pullrequestreview-328132150
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 10, 2019 https://github.com/angular/angular/pull/34169#ref-issue-531479410
Ivy: NGCC incorrectly compiles the "@ngxs/router-plugin" as UMD #34191 https://github.com/angular/angular/issues/34191
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Dec 11, 2019https://github.com/angular/angular/pull/34169#issuecomment-564664069
@gkalpakhttps://github.com/gkalpak
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 12, 2019https://github.com/angular/angular/pull/34169#issuecomment-564988407
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/e28ac708e3b5696b7c1bcb592e6fd5b35d24c233..2b6e20ea694066a1fba87c95eb348c1bee2c5968
e28ac70https://github.com/angular/angular/commit/e28ac708e3b5696b7c1bcb592e6fd5b35d24c233
2b6e20ehttps://github.com/angular/angular/commit/2b6e20ea694066a1fba87c95eb348c1bee2c5968
Compare https://github.com/angular/angular/compare/e28ac708e3b5696b7c1bcb592e6fd5b35d24c233..2b6e20ea694066a1fba87c95eb348c1bee2c5968
December 17, 2019 10:03https://github.com/angular/angular/pull/34169#event-2889202530
gkalpakhttps://github.com/gkalpak
December 17, 2019 12:04https://github.com/angular/angular/pull/34169#commits-pushed-aff45c2
https://github.com/gkalpak
fix(ngcc): recognize more re-export formats in CommonJShttps://github.com/angular/angular/pull/34169/commits/aff45c2ec399743a445f56ec8d63eab229fc261d
aff45c2https://github.com/angular/angular/pull/34169/commits/aff45c2ec399743a445f56ec8d63eab229fc261d
https://www.typescriptlang.org/docs/handbook/compiler-options.htmlhttps://www.typescriptlang.org/docs/handbook/compiler-options.html
https://www.npmjs.com/package/tslibhttps://www.npmjs.com/package/tslib
https://github.com/gkalpak
fixup! fix(ngcc): recognize more re-export formats in CommonJShttps://github.com/angular/angular/pull/34169/commits/12e9773083d50c83cea2fd16185f8e8aa6a4deb6
12e9773https://github.com/angular/angular/pull/34169/commits/12e9773083d50c83cea2fd16185f8e8aa6a4deb6
https://github.com/gkalpak
fix(ngcc): correctly detect dependencies in CommonJShttps://github.com/angular/angular/pull/34169/commits/d4c9f953ddb26008bdf27e0143039a48d7d22ed9
d4c9f95https://github.com/angular/angular/pull/34169/commits/d4c9f953ddb26008bdf27e0143039a48d7d22ed9
https://github.com/gkalpak
fixup! fix(ngcc): correctly detect dependencies in CommonJShttps://github.com/angular/angular/pull/34169/commits/1c42fb38860eebd3d56ec9cd9096be3a80ffe2d1
1c42fb3https://github.com/angular/angular/pull/34169/commits/1c42fb38860eebd3d56ec9cd9096be3a80ffe2d1
https://github.com/gkalpak
fix(ngcc): correctly detect emitted TS helpers in ES5https://github.com/angular/angular/pull/34169/commits/0b89f17c3613aafb056ae63d7f3e3bc1a950ee1f
0b89f17https://github.com/angular/angular/pull/34169/commits/0b89f17c3613aafb056ae63d7f3e3bc1a950ee1f
https://github.com/gkalpak
fixup! fix(ngcc): correctly detect emitted TS helpers in ES5https://github.com/angular/angular/pull/34169/commits/8c37785814dfffd843546b461fa86cbf0eb9fda2
8c37785https://github.com/angular/angular/pull/34169/commits/8c37785814dfffd843546b461fa86cbf0eb9fda2
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/2b6e20ea694066a1fba87c95eb348c1bee2c5968..8c37785814dfffd843546b461fa86cbf0eb9fda2
2b6e20ehttps://github.com/angular/angular/commit/2b6e20ea694066a1fba87c95eb348c1bee2c5968
8c37785https://github.com/angular/angular/commit/8c37785814dfffd843546b461fa86cbf0eb9fda2
Compare https://github.com/angular/angular/compare/2b6e20ea694066a1fba87c95eb348c1bee2c5968..8c37785814dfffd843546b461fa86cbf0eb9fda2
December 17, 2019 10:06https://github.com/angular/angular/pull/34169#event-2889210262
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 17, 2019https://github.com/angular/angular/pull/34169#issuecomment-566473622
Please reload this pagehttps://github.com/angular/angular/pull/34169
@petebacondarwinhttps://github.com/petebacondarwin
#34437https://github.com/angular/angular/pull/34437
#34441https://github.com/angular/angular/pull/34441
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Dec 17, 2019https://github.com/angular/angular/pull/34169#issuecomment-566475768
8c37785https://github.com/angular/angular/commit/8c37785814dfffd843546b461fa86cbf0eb9fda2
https://pr34169-8c37785.ngbuilds.io/https://pr34169-8c37785.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Dec 21, 2019https://github.com/angular/angular/pull/34169#issuecomment-568191909
#34512https://github.com/angular/angular/pull/34512
#34527https://github.com/angular/angular/pull/34527
#34528https://github.com/angular/angular/pull/34528
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Jan 10, 2020https://github.com/angular/angular/pull/34169#event-2937930459
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jan 14, 2020https://github.com/angular/angular/pull/34169#issuecomment-574139372
Please reload this pagehttps://github.com/angular/angular/pull/34169
0b89f17https://github.com/angular/angular/commit/0b89f17c3613aafb056ae63d7f3e3bc1a950ee1f
angular/ngcc-validation#762https://github.com/angular/ngcc-validation/pull/762
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jan 14, 2020 https://github.com/angular/angular/pull/34169#ref-pullrequest-546323557
fix(ngcc): libraries using spread in object literals cannot be processed #34661 https://github.com/angular/angular/pull/34661
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Feb 6, 2020https://github.com/angular/angular/pull/34169#issuecomment-583021583
Please reload this pagehttps://github.com/angular/angular/pull/34169
#35139https://github.com/angular/angular/issues/35139
#35191https://github.com/angular/angular/pull/35191
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Feb 6, 2020https://github.com/angular/angular/pull/34169#event-3014829729
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Mar 8, 2020https://github.com/angular/angular/pull/34169#issuecomment-596221758
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Mar 8, 2020https://github.com/angular/angular/pull/34169#event-3108521816
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
October 2, 2020 09:20https://github.com/angular/angular/pull/34169#event-3833106252
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34169
https://github.com/petebacondarwin
petebacondarwin https://github.com/petebacondarwin
https://github.com/angular/angular/pull/34169/files/e28ac708e3b5696b7c1bcb592e6fd5b35d24c233
Please reload this pagehttps://github.com/angular/angular/pull/34169
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/34169
https://github.com/gkalpak
https://github.com/mary-poppins
https://github.com/petebacondarwin
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.