| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:492cf1e8-cc69-c214-1d4e-defb607c9b9c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 938C:237673:11D2ABB:17D2EA2:6B011FB1 |
| html-safe-nonce | 756bc7b396a1437890011e15232ceaeef4198aad2e5381bccd77520ecdbd49c9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzhDOjIzNzY3MzoxMUQyQUJCOjE3RDJFQTI6NkIwMTFGQjEiLCJ2aXNpdG9yX2lkIjoiNjI4MjA3NDAwMjIxOTQwOTMyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4672c0ec54245e6d6d7d92e90590538caeaab127956798f30a8f824f32f7a300 |
| hovercard-subject-tag | pull_request:347228360 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34162/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/064736c2568b647dc0b5673c3311c306c85ae186f46bea64bf658af0021cdcf3/angular/angular/pull/34162 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/064736c2568b647dc0b5673c3311c306c85ae186f46bea64bf658af0021cdcf3/angular/angular/pull/34162 |
| og:image:alt | PR Checklist
Please check if your PR fulfills the following requirements:
The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests f... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JiaLiPassion |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/34162#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34162 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34162 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/34162 |
| Reload | https://github.com/angular/angular/pull/34162 |
| Reload | https://github.com/angular/angular/pull/34162 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| JiaLiPassion | https://github.com/JiaLiPassion |
| angular:master | https://github.com/angular/angular/tree/master |
| JiaLiPassion:zone-defineproperty-promise | https://github.com/JiaLiPassion/angular/tree/zone-defineproperty-promise |
| Conversation | https://github.com/angular/angular/pull/34162 |
| Commits1 (1) | https://github.com/angular/angular/pull/34162/commits |
| Checks | https://github.com/angular/angular/pull/34162/checks |
| Files changed | https://github.com/angular/angular/pull/34162/files |
| fix: implement Symbol.species of Promise | https://github.com/angular/angular/pull/34162#top |
| JiaLiPassion | https://github.com/JiaLiPassion |
| angular:master | https://github.com/angular/angular/tree/master |
| JiaLiPassion:zone-defineproperty-promise | https://github.com/JiaLiPassion/angular/tree/zone-defineproperty-promise |
|
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
| Nov 30, 2019 | https://github.com/angular/angular/pull/34162#issue-530584868 |
| Please reload this page | https://github.com/angular/angular/pull/34162 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| #34105 | https://github.com/angular/angular/issues/34105 |
| #33989 | https://github.com/angular/angular/issues/33989 |
| Please reload this page | https://github.com/angular/angular/pull/34162 |
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
| November 30, 2019 14:21 | https://github.com/angular/angular/pull/34162#event-2842743356 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Nov 30, 2019 | https://github.com/angular/angular/pull/34162#event-2842743384 |
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
| Nov 30, 2019 | https://github.com/angular/angular/pull/34162#event-2842753369 |
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Nov 30, 2019 | https://github.com/angular/angular/pull/34162#event-2842753442 |
|
| https://github.com/JiaLiPassion |
| fix: implement Symbol.specics of Promise | https://github.com/angular/angular/pull/34162/commits/91accd3269d9f76a8609a7af0d7cd56fc5de5e53 |
| 91accd3 | https://github.com/angular/angular/pull/34162/commits/91accd3269d9f76a8609a7af0d7cd56fc5de5e53 |
| angular#34105 | https://github.com/angular/angular/issues/34105 |
| angular#33989 | https://github.com/angular/angular/issues/33989 |
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
| force-pushed | https://github.com/angular/angular/compare/b7bad351d601de1a399dcb63f706d7ecce7a7eac..91accd3269d9f76a8609a7af0d7cd56fc5de5e53 |
| b7bad35 | https://github.com/angular/angular/commit/b7bad351d601de1a399dcb63f706d7ecce7a7eac |
| 91accd3 | https://github.com/angular/angular/commit/91accd3269d9f76a8609a7af0d7cd56fc5de5e53 |
|
Compare
| https://github.com/angular/angular/compare/b7bad351d601de1a399dcb63f706d7ecce7a7eac..91accd3269d9f76a8609a7af0d7cd56fc5de5e53 |
| December 1, 2019 03:28 | https://github.com/angular/angular/pull/34162#event-2843121911 |
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
| Dec 1, 2019 | https://github.com/angular/angular/pull/34162#event-2843122516 |
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
|
area: zones
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Dec 1, 2019 | https://github.com/angular/angular/pull/34162#event-2843350469 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Dec 1, 2019 | https://github.com/angular/angular/pull/34162#event-2843350480 |
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
| mhevery | https://github.com/mhevery |
| December 1, 2019 11:00 | https://github.com/angular/angular/pull/34162#event-2843350523 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
Dec 2, 2019
| https://github.com/angular/angular/pull/34162#pullrequestreview-325550354 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34162/files/91accd3269d9f76a8609a7af0d7cd56fc5de5e53 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| Dec 2, 2019 | https://github.com/angular/angular/pull/34162#issuecomment-560553407 |
| presubmit | http://test/OCL:283385083:BASE:283385136:1575316252556:94c7c6ff |
| Please reload this page | https://github.com/angular/angular/pull/34162 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Dec 2, 2019 | https://github.com/angular/angular/pull/34162#event-2847039057 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| 539d8f0 | https://github.com/angular/angular/commit/539d8f09e01fb4c577bc8a289d2e124360d4c6b1 |
| Dec 3, 2019 | https://github.com/angular/angular/pull/34162#event-2851153336 |
| mhevery | https://github.com/mhevery |
|
Dec 3, 2019
| https://github.com/angular/angular/pull/34162#ref-commit-1bab8c2 |
|
| https://github.com/JiaLiPassion |
|
| https://github.com/mhevery |
| fix: implement Symbol.specics of Promise ( | https://github.com/angular/angular/commit/1bab8c27577a557c6f702e8f5894d3ac23ada69f |
| #34162 | https://github.com/angular/angular/pull/34162 |
| ) | https://github.com/angular/angular/commit/1bab8c27577a557c6f702e8f5894d3ac23ada69f |
| 1bab8c2 | https://github.com/angular/angular/commit/1bab8c27577a557c6f702e8f5894d3ac23ada69f |
| #34105 | https://github.com/angular/angular/issues/34105 |
| #33989 | https://github.com/angular/angular/issues/33989 |
| #34162 | https://github.com/angular/angular/pull/34162 |
|
Unhandled Promise rejection: Zone.js has detected that ZoneAwarePromise (window|global).Promise has been overwritten. Most likely cause is that a Promise polyfill has been loaded after Zone.js (Polyfilling Promise api is not necessary when zone.js is loaded. If you must load one, do so before loading zone.js.) ; Zone: ; Task: Promise.then ;
#31724
| https://github.com/angular/angular/issues/31724 |
|
Make ZoneAwarePromise spec compliant and compatible with core-js
#33989
| https://github.com/angular/angular/issues/33989 |
| https://github.com/TroelsWibergJensen |
| TroelsWibergJensen | https://github.com/TroelsWibergJensen |
| Dec 18, 2019 | https://github.com/angular/angular/pull/34162#issuecomment-566857936 |
| @mhevery | https://github.com/mhevery |
| @JiaLiPassion | https://github.com/JiaLiPassion |
| Please reload this page | https://github.com/angular/angular/pull/34162 |
| https://github.com/JiaLiPassion |
| JiaLiPassion | https://github.com/JiaLiPassion |
|
Dec 22, 2019
| https://github.com/angular/angular/pull/34162#ref-pullrequest-541405381 |
|
fix: should also allow subclass Promise without Symbol.species
#34533
| https://github.com/angular/angular/pull/34533 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jan 18, 2020 | https://github.com/angular/angular/pull/34162#issuecomment-575912608 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/34162 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jan 18, 2020 | https://github.com/angular/angular/pull/34162#event-2960303482 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34162 |
|
| https://github.com/mhevery |
|
mhevery
| https://github.com/mhevery |
|
| https://github.com/angular/angular/pull/34162/files/91accd3269d9f76a8609a7af0d7cd56fc5de5e53 |
| Please reload this page | https://github.com/angular/angular/pull/34162 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: zones
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
| Please reload this page | https://github.com/angular/angular/pull/34162 |
|
| https://github.com/JiaLiPassion |
|
| https://github.com/mhevery |
|
| https://github.com/TroelsWibergJensen |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |