René's URL Explorer Experiment


Title: fix: implement Symbol.species of Promise by JiaLiPassion · Pull Request #34162 · angular/angular · GitHub

Open Graph Title: fix: implement Symbol.species of Promise by JiaLiPassion · Pull Request #34162 · angular/angular

X Title: fix: implement Symbol.species of Promise by JiaLiPassion · Pull Request #34162 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

Opengraph URL: https://github.com/angular/angular/pull/34162

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:492cf1e8-cc69-c214-1d4e-defb607c9b9c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id938C:237673:11D2ABB:17D2EA2:6B011FB1
html-safe-nonce756bc7b396a1437890011e15232ceaeef4198aad2e5381bccd77520ecdbd49c9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzhDOjIzNzY3MzoxMUQyQUJCOjE3RDJFQTI6NkIwMTFGQjEiLCJ2aXNpdG9yX2lkIjoiNjI4MjA3NDAwMjIxOTQwOTMyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4672c0ec54245e6d6d7d92e90590538caeaab127956798f30a8f824f32f7a300
hovercard-subject-tagpull_request:347228360
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34162/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/064736c2568b647dc0b5673c3311c306c85ae186f46bea64bf658af0021cdcf3/angular/angular/pull/34162
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/064736c2568b647dc0b5673c3311c306c85ae186f46bea64bf658af0021cdcf3/angular/angular/pull/34162
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJiaLiPassion
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/34162#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34162
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34162
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34162
Reloadhttps://github.com/angular/angular/pull/34162
Reloadhttps://github.com/angular/angular/pull/34162
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
JiaLiPassionhttps://github.com/JiaLiPassion
angular:masterhttps://github.com/angular/angular/tree/master
JiaLiPassion:zone-defineproperty-promisehttps://github.com/JiaLiPassion/angular/tree/zone-defineproperty-promise
Conversationhttps://github.com/angular/angular/pull/34162
Commits1 (1)https://github.com/angular/angular/pull/34162/commits
Checkshttps://github.com/angular/angular/pull/34162/checks
Files changedhttps://github.com/angular/angular/pull/34162/files
fix: implement Symbol.species of Promisehttps://github.com/angular/angular/pull/34162#top
JiaLiPassionhttps://github.com/JiaLiPassion
angular:masterhttps://github.com/angular/angular/tree/master
JiaLiPassion:zone-defineproperty-promisehttps://github.com/JiaLiPassion/angular/tree/zone-defineproperty-promise
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
Nov 30, 2019https://github.com/angular/angular/pull/34162#issue-530584868
Please reload this pagehttps://github.com/angular/angular/pull/34162
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
#34105https://github.com/angular/angular/issues/34105
#33989https://github.com/angular/angular/issues/33989
Please reload this pagehttps://github.com/angular/angular/pull/34162
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
November 30, 2019 14:21https://github.com/angular/angular/pull/34162#event-2842743356
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Nov 30, 2019https://github.com/angular/angular/pull/34162#event-2842743384
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
Nov 30, 2019https://github.com/angular/angular/pull/34162#event-2842753369
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
Nov 30, 2019https://github.com/angular/angular/pull/34162#event-2842753442
https://github.com/JiaLiPassion
fix: implement Symbol.specics of Promisehttps://github.com/angular/angular/pull/34162/commits/91accd3269d9f76a8609a7af0d7cd56fc5de5e53
91accd3https://github.com/angular/angular/pull/34162/commits/91accd3269d9f76a8609a7af0d7cd56fc5de5e53
angular#34105https://github.com/angular/angular/issues/34105
angular#33989https://github.com/angular/angular/issues/33989
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
force-pushedhttps://github.com/angular/angular/compare/b7bad351d601de1a399dcb63f706d7ecce7a7eac..91accd3269d9f76a8609a7af0d7cd56fc5de5e53
b7bad35https://github.com/angular/angular/commit/b7bad351d601de1a399dcb63f706d7ecce7a7eac
91accd3https://github.com/angular/angular/commit/91accd3269d9f76a8609a7af0d7cd56fc5de5e53
Compare https://github.com/angular/angular/compare/b7bad351d601de1a399dcb63f706d7ecce7a7eac..91accd3269d9f76a8609a7af0d7cd56fc5de5e53
December 1, 2019 03:28https://github.com/angular/angular/pull/34162#event-2843121911
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
Dec 1, 2019https://github.com/angular/angular/pull/34162#event-2843122516
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
area: zones https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
Dec 1, 2019https://github.com/angular/angular/pull/34162#event-2843350469
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Dec 1, 2019https://github.com/angular/angular/pull/34162#event-2843350480
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
mheveryhttps://github.com/mhevery
December 1, 2019 11:00https://github.com/angular/angular/pull/34162#event-2843350523
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Dec 2, 2019 https://github.com/angular/angular/pull/34162#pullrequestreview-325550354
View reviewed changes https://github.com/angular/angular/pull/34162/files/91accd3269d9f76a8609a7af0d7cd56fc5de5e53
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Dec 2, 2019https://github.com/angular/angular/pull/34162#issuecomment-560553407
presubmithttp://test/OCL:283385083:BASE:283385136:1575316252556:94c7c6ff
Please reload this pagehttps://github.com/angular/angular/pull/34162
https://github.com/mhevery
mheveryhttps://github.com/mhevery
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Dec 2, 2019https://github.com/angular/angular/pull/34162#event-2847039057
https://github.com/mhevery
mheveryhttps://github.com/mhevery
539d8f0https://github.com/angular/angular/commit/539d8f09e01fb4c577bc8a289d2e124360d4c6b1
Dec 3, 2019https://github.com/angular/angular/pull/34162#event-2851153336
mheveryhttps://github.com/mhevery
Dec 3, 2019 https://github.com/angular/angular/pull/34162#ref-commit-1bab8c2
https://github.com/JiaLiPassion
https://github.com/mhevery
fix: implement Symbol.specics of Promise (https://github.com/angular/angular/commit/1bab8c27577a557c6f702e8f5894d3ac23ada69f
#34162https://github.com/angular/angular/pull/34162
)https://github.com/angular/angular/commit/1bab8c27577a557c6f702e8f5894d3ac23ada69f
1bab8c2https://github.com/angular/angular/commit/1bab8c27577a557c6f702e8f5894d3ac23ada69f
#34105https://github.com/angular/angular/issues/34105
#33989https://github.com/angular/angular/issues/33989
#34162https://github.com/angular/angular/pull/34162
Unhandled Promise rejection: Zone.js has detected that ZoneAwarePromise (window|global).Promise has been overwritten. Most likely cause is that a Promise polyfill has been loaded after Zone.js (Polyfilling Promise api is not necessary when zone.js is loaded. If you must load one, do so before loading zone.js.) ; Zone: ; Task: Promise.then ; #31724 https://github.com/angular/angular/issues/31724
Make ZoneAwarePromise spec compliant and compatible with core-js #33989 https://github.com/angular/angular/issues/33989
https://github.com/TroelsWibergJensen
TroelsWibergJensenhttps://github.com/TroelsWibergJensen
Dec 18, 2019https://github.com/angular/angular/pull/34162#issuecomment-566857936
@mheveryhttps://github.com/mhevery
@JiaLiPassionhttps://github.com/JiaLiPassion
Please reload this pagehttps://github.com/angular/angular/pull/34162
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
Dec 22, 2019 https://github.com/angular/angular/pull/34162#ref-pullrequest-541405381
fix: should also allow subclass Promise without Symbol.species #34533 https://github.com/angular/angular/pull/34533
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jan 18, 2020https://github.com/angular/angular/pull/34162#issuecomment-575912608
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/34162
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jan 18, 2020https://github.com/angular/angular/pull/34162#event-2960303482
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34162
https://github.com/mhevery
mhevery https://github.com/mhevery
https://github.com/angular/angular/pull/34162/files/91accd3269d9f76a8609a7af0d7cd56fc5de5e53
Please reload this pagehttps://github.com/angular/angular/pull/34162
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: zones https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/34162
https://github.com/JiaLiPassion
https://github.com/mhevery
https://github.com/TroelsWibergJensen
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.