René's URL Explorer Experiment


Title: fix(ivy): i18n - correctly parse XLIFF placeholders by petebacondarwin · Pull Request #34155 · angular/angular · GitHub

Open Graph Title: fix(ivy): i18n - correctly parse XLIFF placeholders by petebacondarwin · Pull Request #34155 · angular/angular

X Title: fix(ivy): i18n - correctly parse XLIFF placeholders by petebacondarwin · Pull Request #34155 · angular/angular

Description: The ViewEngine translation extractor does not convert - to _ for placeholders that represent custom elements. For example gets converted to placeholders like START_TAG_APP-COMPONENT. In $localize placeholders are expected to be snake-case, not kebab-case. So we must normalize them when parsing a translation file that might have been created via the View Engine translation extractor. The $localize extraction code will normalize these placeholders when creating translation files in the first place. Fixes #34151

Open Graph Description: The ViewEngine translation extractor does not convert - to _ for placeholders that represent custom elements. For example <app-component> gets converted to placeholders like START_TAG_APP-COM...

X Description: The ViewEngine translation extractor does not convert - to _ for placeholders that represent custom elements. For example &lt;app-component&gt; gets converted to placeholders like START_TAG...

Opengraph URL: https://github.com/angular/angular/pull/34155

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:17bff938-2f90-d336-ccae-8e4d93623289
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF66:29AEE8:C36F14:105D894:6B00F8DE
html-safe-nonce9e6468d4d36d78c86952b099630fb76fad3bd5dabf29368b710738c4eb557cd7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjY2OjI5QUVFODpDMzZGMTQ6MTA1RDg5NDo2QjAwRjhERSIsInZpc2l0b3JfaWQiOiIyODYzNTU3NjkxMzU0MTgzOTAyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd6260e842e6582ffa94b621119399b166d63787b74d4842fb9a3df011eccba3a
hovercard-subject-tagpull_request:347128719
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/34155/files
twitter:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
og:image:altThe ViewEngine translation extractor does not convert - to _ for placeholders that represent custom elements. For example <app-component> gets converted to placeholders like START_TAG_APP-COM...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/34155/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34155%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34155%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34155/files
Reloadhttps://github.com/angular/angular/pull/34155/files
Reloadhttps://github.com/angular/angular/pull/34155/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:i18n-placeholdershttps://github.com/petebacondarwin/angular/tree/i18n-placeholders
Conversation 5 https://github.com/angular/angular/pull/34155
Commits 1 https://github.com/angular/angular/pull/34155/commits
Checks 0 https://github.com/angular/angular/pull/34155/checks
Files changed https://github.com/angular/angular/pull/34155/files
Please reload this pagehttps://github.com/angular/angular/pull/34155/files
fix(ivy): i18n - correctly parse XLIFF placeholders https://github.com/angular/angular/pull/34155/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/34155/files
a8399a1 fix(ivy): i18n - correctly parse XLIFF placeholders petebacondarwin Nov 29, 2019 https://github.com/angular/angular/pull/34155/commits/a8399a1ae98a2a71c01e35baf56820ac5b975eb3
Clear filters https://github.com/angular/angular/pull/34155/files
Please reload this pagehttps://github.com/angular/angular/pull/34155/files
Please reload this pagehttps://github.com/angular/angular/pull/34155/files
target_message_renderer.ts https://github.com/angular/angular/pull/34155/files#diff-7d338c96e8986ac36bb9410f6ea34bf545e6389a6dbf7d0c39fd0af1be70e842
xliff1_translation_parser_spec.ts https://github.com/angular/angular/pull/34155/files#diff-03086ea5fe8c9ecbb2ac5b6aa1f6b916e8a610144483f27f5b3cb9177e13b5e3
...rc/tools/src/translate/translation_files/message_serialization/target_message_renderer.tshttps://github.com/angular/angular/pull/34155/files#diff-7d338c96e8986ac36bb9410f6ea34bf545e6389a6dbf7d0c39fd0af1be70e842
View file https://github.com/petebacondarwin/angular/blob/a8399a1ae98a2a71c01e35baf56820ac5b975eb3/packages/localize/src/tools/src/translate/translation_files/message_serialization/target_message_renderer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34155/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34155/files#diff-7d338c96e8986ac36bb9410f6ea34bf545e6389a6dbf7d0c39fd0af1be70e842
https://github.com/angular/angular/pull/34155/files#diff-7d338c96e8986ac36bb9410f6ea34bf545e6389a6dbf7d0c39fd0af1be70e842
...ls/test/translate/translation_files/translation_parsers/xliff1_translation_parser_spec.tshttps://github.com/angular/angular/pull/34155/files#diff-03086ea5fe8c9ecbb2ac5b6aa1f6b916e8a610144483f27f5b3cb9177e13b5e3
View file https://github.com/petebacondarwin/angular/blob/a8399a1ae98a2a71c01e35baf56820ac5b975eb3/packages/localize/src/tools/test/translate/translation_files/translation_parsers/xliff1_translation_parser_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34155/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34155/files#diff-03086ea5fe8c9ecbb2ac5b6aa1f6b916e8a610144483f27f5b3cb9177e13b5e3
https://github.com/angular/angular/pull/34155/files#diff-03086ea5fe8c9ecbb2ac5b6aa1f6b916e8a610144483f27f5b3cb9177e13b5e3
https://github.com/angular/angular/pull/34155/files#diff-03086ea5fe8c9ecbb2ac5b6aa1f6b916e8a610144483f27f5b3cb9177e13b5e3
https://github.com/angular/angular/pull/34155/files#diff-03086ea5fe8c9ecbb2ac5b6aa1f6b916e8a610144483f27f5b3cb9177e13b5e3
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.