| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6acc5aa5-a386-2a96-f0d6-7d41a832feb1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CD80:269AD9:A670B8:E029DA:6B00EE9F |
| html-safe-nonce | 98b07b57cdd56f7dd3772254dc4fbc7b2a7da1235275b526fdcbdd899f528125 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDgwOjI2OUFEOTpBNjcwQjg6RTAyOURBOjZCMDBFRTlGIiwidmlzaXRvcl9pZCI6IjI4NjM0ODMxNzM2NzE1OTU2NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 75cbb2a04c00080d306e091f74c8d3d9debce935750c43c6551bb13d348b1758 |
| hovercard-subject-tag | pull_request:347128719 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34155/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/064736c2568b647dc0b5673c3311c306c85ae186f46bea64bf658af0021cdcf3/angular/angular/pull/34155 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/064736c2568b647dc0b5673c3311c306c85ae186f46bea64bf658af0021cdcf3/angular/angular/pull/34155 |
| og:image:alt | The ViewEngine translation extractor does not convert - to _ for
placeholders that represent custom elements. For example
<app-component> gets converted to placeholders like
START_TAG_APP-COM... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | petebacondarwin |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/34155#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34155 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34155 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/34155 |
| Reload | https://github.com/angular/angular/pull/34155 |
| Reload | https://github.com/angular/angular/pull/34155 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests140 (140) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| petebacondarwin | https://github.com/petebacondarwin |
| angular:master | https://github.com/angular/angular/tree/master |
| petebacondarwin:i18n-placeholders | https://github.com/petebacondarwin/angular/tree/i18n-placeholders |
| Conversation | https://github.com/angular/angular/pull/34155 |
| Commits1 (1) | https://github.com/angular/angular/pull/34155/commits |
| Checks | https://github.com/angular/angular/pull/34155/checks |
| Files changed | https://github.com/angular/angular/pull/34155/files |
| fix(ivy): i18n - correctly parse XLIFF placeholders | https://github.com/angular/angular/pull/34155#top |
| petebacondarwin | https://github.com/petebacondarwin |
| angular:master | https://github.com/angular/angular/tree/master |
| petebacondarwin:i18n-placeholders | https://github.com/petebacondarwin/angular/tree/i18n-placeholders |
|
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Nov 29, 2019 | https://github.com/angular/angular/pull/34155#issue-530448750 |
| #34151 | https://github.com/angular/angular/issues/34151 |
| Please reload this page | https://github.com/angular/angular/pull/34155 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Nov 29, 2019 | https://github.com/angular/angular/pull/34155#event-2842027649 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
area: i18n
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22 |
|
comp: ivy
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Nov 29, 2019 | https://github.com/angular/angular/pull/34155#event-2842028173 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
| Nov 29, 2019 | https://github.com/angular/angular/pull/34155#issuecomment-559855179 |
| Please reload this page | https://github.com/angular/angular/pull/34155 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Nov 29, 2019 | https://github.com/angular/angular/pull/34155#event-2842028211 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Nov 29, 2019 | https://github.com/angular/angular/pull/34155#event-2842028217 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Nov 30, 2019 | https://github.com/angular/angular/pull/34155#event-2842534268 |
|
| https://github.com/petebacondarwin |
| fix(ivy): i18n - correctly parse XLIFF placeholders | https://github.com/angular/angular/pull/34155/commits/a8399a1ae98a2a71c01e35baf56820ac5b975eb3 |
| a8399a1 | https://github.com/angular/angular/pull/34155/commits/a8399a1ae98a2a71c01e35baf56820ac5b975eb3 |
| angular#34151 | https://github.com/angular/angular/issues/34151 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| force-pushed | https://github.com/angular/angular/compare/7894e9821d9f365d269ad82b83b46d027c5cfcb9..a8399a1ae98a2a71c01e35baf56820ac5b975eb3 |
| 7894e98 | https://github.com/angular/angular/commit/7894e9821d9f365d269ad82b83b46d027c5cfcb9 |
| a8399a1 | https://github.com/angular/angular/commit/a8399a1ae98a2a71c01e35baf56820ac5b975eb3 |
|
Compare
| https://github.com/angular/angular/compare/7894e9821d9f365d269ad82b83b46d027c5cfcb9..a8399a1ae98a2a71c01e35baf56820ac5b975eb3 |
| November 30, 2019 07:58 | https://github.com/angular/angular/pull/34155#event-2842535002 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| November 30, 2019 07:59 | https://github.com/angular/angular/pull/34155#event-2842535575 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| November 30, 2019 07:59 | https://github.com/angular/angular/pull/34155#event-2842535578 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Dec 2, 2019
| https://github.com/angular/angular/pull/34155#pullrequestreview-324980855 |
|
View reviewed changes
| https://github.com/angular/angular/pull/34155/files/a8399a1ae98a2a71c01e35baf56820ac5b975eb3 |
| AndrewKushnir | https://github.com/AndrewKushnir |
| https://github.com/angular/angular/pull/34155#pullrequestreview-324980855 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/34155 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Dec 2, 2019 | https://github.com/angular/angular/pull/34155#event-2843948343 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Dec 2, 2019 | https://github.com/angular/angular/pull/34155#event-2844684303 |
| https://github.com/timofei-iatsenko |
| timofei-iatsenko | https://github.com/timofei-iatsenko |
| Dec 2, 2019 | https://github.com/angular/angular/pull/34155#issuecomment-560293155 |
| Please reload this page | https://github.com/angular/angular/pull/34155 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Dec 2, 2019 | https://github.com/angular/angular/pull/34155#issuecomment-560295571 |
| #32912 | https://github.com/angular/angular/pull/32912 |
| Please reload this page | https://github.com/angular/angular/pull/34155 |
| mhevery | https://github.com/mhevery |
|
Dec 2, 2019
| https://github.com/angular/angular/pull/34155#ref-commit-d5a48b2 |
|
| https://github.com/petebacondarwin |
|
| https://github.com/mhevery |
| fix(ivy): i18n - correctly parse XLIFF placeholders ( | https://github.com/angular/angular/commit/d5a48b2cc0f77921b4e2e196a369b2ec9e451e41 |
| #34155 | https://github.com/angular/angular/pull/34155 |
| ) | https://github.com/angular/angular/commit/d5a48b2cc0f77921b4e2e196a369b2ec9e451e41 |
| d5a48b2 | https://github.com/angular/angular/commit/d5a48b2cc0f77921b4e2e196a369b2ec9e451e41 |
| #34151 | https://github.com/angular/angular/issues/34151 |
| #34155 | https://github.com/angular/angular/pull/34155 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| d529b55 | https://github.com/angular/angular/commit/d529b55651739219bbd80c2630defe9a55d149f5 |
| Dec 2, 2019 | https://github.com/angular/angular/pull/34155#event-2846952672 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| December 2, 2019 19:39 | https://github.com/angular/angular/pull/34155#event-2847000740 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jan 2, 2020 | https://github.com/angular/angular/pull/34155#issuecomment-570253129 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/34155 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jan 2, 2020 | https://github.com/angular/angular/pull/34155#event-2918097879 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34155 |
|
| https://github.com/AndrewKushnir |
|
AndrewKushnir
| https://github.com/AndrewKushnir |
|
| https://github.com/angular/angular/pull/34155/files/a8399a1ae98a2a71c01e35baf56820ac5b975eb3 |
| Please reload this page | https://github.com/angular/angular/pull/34155 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: i18n
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
|
ivy i18n Wrong placeholders generated for components with dash
| https://github.com/angular/angular/issues/34151 |
| Please reload this page | https://github.com/angular/angular/pull/34155 |
|
| https://github.com/petebacondarwin |
|
| https://github.com/googlebot |
|
| https://github.com/timofei-iatsenko |
|
| https://github.com/AndrewKushnir |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |