René's URL Explorer Experiment


Title: fix(ivy): i18n - correctly parse XLIFF placeholders by petebacondarwin · Pull Request #34155 · angular/angular · GitHub

Open Graph Title: fix(ivy): i18n - correctly parse XLIFF placeholders by petebacondarwin · Pull Request #34155 · angular/angular

X Title: fix(ivy): i18n - correctly parse XLIFF placeholders by petebacondarwin · Pull Request #34155 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: The ViewEngine translation extractor does not convert - to _ for placeholders that represent custom elements. For example <app-component> gets converted to placeholders like START_TAG_APP-COM...

X Description: The ViewEngine translation extractor does not convert - to _ for placeholders that represent custom elements. For example &lt;app-component&gt; gets converted to placeholders like START_TAG...

Opengraph URL: https://github.com/angular/angular/pull/34155

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6acc5aa5-a386-2a96-f0d6-7d41a832feb1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD80:269AD9:A670B8:E029DA:6B00EE9F
html-safe-nonce98b07b57cdd56f7dd3772254dc4fbc7b2a7da1235275b526fdcbdd899f528125
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDgwOjI2OUFEOTpBNjcwQjg6RTAyOURBOjZCMDBFRTlGIiwidmlzaXRvcl9pZCI6IjI4NjM0ODMxNzM2NzE1OTU2NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac75cbb2a04c00080d306e091f74c8d3d9debce935750c43c6551bb13d348b1758
hovercard-subject-tagpull_request:347128719
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34155/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/064736c2568b647dc0b5673c3311c306c85ae186f46bea64bf658af0021cdcf3/angular/angular/pull/34155
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/064736c2568b647dc0b5673c3311c306c85ae186f46bea64bf658af0021cdcf3/angular/angular/pull/34155
og:image:altThe ViewEngine translation extractor does not convert - to _ for placeholders that represent custom elements. For example <app-component> gets converted to placeholders like START_TAG_APP-COM...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepetebacondarwin
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/34155#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34155
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34155
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34155
Reloadhttps://github.com/angular/angular/pull/34155
Reloadhttps://github.com/angular/angular/pull/34155
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:i18n-placeholdershttps://github.com/petebacondarwin/angular/tree/i18n-placeholders
Conversationhttps://github.com/angular/angular/pull/34155
Commits1 (1)https://github.com/angular/angular/pull/34155/commits
Checkshttps://github.com/angular/angular/pull/34155/checks
Files changedhttps://github.com/angular/angular/pull/34155/files
fix(ivy): i18n - correctly parse XLIFF placeholdershttps://github.com/angular/angular/pull/34155#top
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:i18n-placeholdershttps://github.com/petebacondarwin/angular/tree/i18n-placeholders
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Nov 29, 2019https://github.com/angular/angular/pull/34155#issue-530448750
#34151https://github.com/angular/angular/issues/34151
Please reload this pagehttps://github.com/angular/angular/pull/34155
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Nov 29, 2019https://github.com/angular/angular/pull/34155#event-2842027649
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
area: i18n https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
comp: ivy https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Nov 29, 2019https://github.com/angular/angular/pull/34155#event-2842028173
https://github.com/googlebot
googlebothttps://github.com/googlebot
Nov 29, 2019https://github.com/angular/angular/pull/34155#issuecomment-559855179
Please reload this pagehttps://github.com/angular/angular/pull/34155
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Nov 29, 2019https://github.com/angular/angular/pull/34155#event-2842028211
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Nov 29, 2019https://github.com/angular/angular/pull/34155#event-2842028217
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
Nov 30, 2019https://github.com/angular/angular/pull/34155#event-2842534268
https://github.com/petebacondarwin
fix(ivy): i18n - correctly parse XLIFF placeholdershttps://github.com/angular/angular/pull/34155/commits/a8399a1ae98a2a71c01e35baf56820ac5b975eb3
a8399a1https://github.com/angular/angular/pull/34155/commits/a8399a1ae98a2a71c01e35baf56820ac5b975eb3
angular#34151https://github.com/angular/angular/issues/34151
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/7894e9821d9f365d269ad82b83b46d027c5cfcb9..a8399a1ae98a2a71c01e35baf56820ac5b975eb3
7894e98https://github.com/angular/angular/commit/7894e9821d9f365d269ad82b83b46d027c5cfcb9
a8399a1https://github.com/angular/angular/commit/a8399a1ae98a2a71c01e35baf56820ac5b975eb3
Compare https://github.com/angular/angular/compare/7894e9821d9f365d269ad82b83b46d027c5cfcb9..a8399a1ae98a2a71c01e35baf56820ac5b975eb3
November 30, 2019 07:58https://github.com/angular/angular/pull/34155#event-2842535002
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
November 30, 2019 07:59https://github.com/angular/angular/pull/34155#event-2842535575
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
November 30, 2019 07:59https://github.com/angular/angular/pull/34155#event-2842535578
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Dec 2, 2019 https://github.com/angular/angular/pull/34155#pullrequestreview-324980855
View reviewed changes https://github.com/angular/angular/pull/34155/files/a8399a1ae98a2a71c01e35baf56820ac5b975eb3
AndrewKushnirhttps://github.com/AndrewKushnir
https://github.com/angular/angular/pull/34155#pullrequestreview-324980855
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34155
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Dec 2, 2019https://github.com/angular/angular/pull/34155#event-2843948343
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Dec 2, 2019https://github.com/angular/angular/pull/34155#event-2844684303
https://github.com/timofei-iatsenko
timofei-iatsenkohttps://github.com/timofei-iatsenko
Dec 2, 2019https://github.com/angular/angular/pull/34155#issuecomment-560293155
Please reload this pagehttps://github.com/angular/angular/pull/34155
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Dec 2, 2019https://github.com/angular/angular/pull/34155#issuecomment-560295571
#32912https://github.com/angular/angular/pull/32912
Please reload this pagehttps://github.com/angular/angular/pull/34155
mheveryhttps://github.com/mhevery
Dec 2, 2019 https://github.com/angular/angular/pull/34155#ref-commit-d5a48b2
https://github.com/petebacondarwin
https://github.com/mhevery
fix(ivy): i18n - correctly parse XLIFF placeholders (https://github.com/angular/angular/commit/d5a48b2cc0f77921b4e2e196a369b2ec9e451e41
#34155https://github.com/angular/angular/pull/34155
)https://github.com/angular/angular/commit/d5a48b2cc0f77921b4e2e196a369b2ec9e451e41
d5a48b2https://github.com/angular/angular/commit/d5a48b2cc0f77921b4e2e196a369b2ec9e451e41
#34151https://github.com/angular/angular/issues/34151
#34155https://github.com/angular/angular/pull/34155
https://github.com/mhevery
mheveryhttps://github.com/mhevery
d529b55https://github.com/angular/angular/commit/d529b55651739219bbd80c2630defe9a55d149f5
Dec 2, 2019https://github.com/angular/angular/pull/34155#event-2846952672
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
December 2, 2019 19:39https://github.com/angular/angular/pull/34155#event-2847000740
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jan 2, 2020https://github.com/angular/angular/pull/34155#issuecomment-570253129
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/34155
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jan 2, 2020https://github.com/angular/angular/pull/34155#event-2918097879
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34155
https://github.com/AndrewKushnir
AndrewKushnir https://github.com/AndrewKushnir
https://github.com/angular/angular/pull/34155/files/a8399a1ae98a2a71c01e35baf56820ac5b975eb3
Please reload this pagehttps://github.com/angular/angular/pull/34155
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: i18n https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20i18n%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
ivy i18n Wrong placeholders generated for components with dash https://github.com/angular/angular/issues/34151
Please reload this pagehttps://github.com/angular/angular/pull/34155
https://github.com/petebacondarwin
https://github.com/googlebot
https://github.com/timofei-iatsenko
https://github.com/AndrewKushnir
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.