Title: Avoid problem with uninitialized ngElementStrategy · Pull Request #34037 · angular/angular · GitHub
Open Graph Title: Avoid problem with uninitialized ngElementStrategy · Pull Request #34037 · angular/angular
X Title: Avoid problem with uninitialized ngElementStrategy · Pull Request #34037 · angular/angular
Description: The main problem is the already in the file mentioned not existing reliability on the constructor-call. Some properties were already patched with the if-initialisation of the injector, but not the inputs.map-section at the bottom. We created a fixed fork of angular-elements-builds to fix our own website. In the following you can find a simple Git-case to reproduce the issue. A fixed fork of the issue, which links to the fixed angular-elements-repository. Reported original problem happens on IE/Edge: https://stackoverflow.com/questions/58834546/angular-elements-8-does-not-work-with-edge-ie11-when-using-input Repro-Case of the problem: https://github.com/4nderss/angular-elements-ie11 Fork of angular-elements-build: https://github.com/danielswars/elements-builds which contains the here implemented bugfix danielswars/elements-builds@c9da737#diff-dceee3652527313b8b6c341dbda09e2d Fixed Repro-Case: https://github.com/DennisNeuendorfNetlight/angular-elements-ie11 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: N/A What is the new behavior? Does this PR introduce a breaking change? Yes No Other information
Open Graph Description: The main problem is the already in the file mentioned not existing reliability on the constructor-call. Some properties were already patched with the if-initialisation of the injector, but not the ...
X Description: The main problem is the already in the file mentioned not existing reliability on the constructor-call. Some properties were already patched with the if-initialisation of the injector, but not the ...
Opengraph URL: https://github.com/angular/angular/pull/34037
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:53607629-5b47-644c-d976-198c41b2851e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 901E:361639:1B4AC58:245BE5A:6B016157 |
| html-safe-nonce | 99b7dd6d73f5856724072af46d6e49fe24ff71ea2b6b06949d6cd1b1e4c32f33 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDFFOjM2MTYzOToxQjRBQzU4OjI0NUJFNUE6NkIwMTYxNTciLCJ2aXNpdG9yX2lkIjoiMzU5NDg3NzExODc2MjI3OTI1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 46596848d309b41e70ce74fdea914cbbbe0ca81be84895287c3170788df601f0 |
| hovercard-subject-tag | pull_request:345322455 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/34037/files |
| twitter:image | https://avatars.githubusercontent.com/u/10137?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10137?s=400&v=4 |
| og:image:alt | The main problem is the already in the file mentioned not existing reliability on the constructor-call. Some properties were already patched with the if-initialisation of the injector, but not the ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width