René's URL Explorer Experiment


Title: Avoid problem with uninitialized ngElementStrategy · Pull Request #34037 · angular/angular · GitHub

Open Graph Title: Avoid problem with uninitialized ngElementStrategy · Pull Request #34037 · angular/angular

X Title: Avoid problem with uninitialized ngElementStrategy · Pull Request #34037 · angular/angular

Description: The main problem is the already in the file mentioned not existing reliability on the constructor-call. Some properties were already patched with the if-initialisation of the injector, but not the inputs.map-section at the bottom. We created a fixed fork of angular-elements-builds to fix our own website. In the following you can find a simple Git-case to reproduce the issue. A fixed fork of the issue, which links to the fixed angular-elements-repository. Reported original problem happens on IE/Edge: https://stackoverflow.com/questions/58834546/angular-elements-8-does-not-work-with-edge-ie11-when-using-input Repro-Case of the problem: https://github.com/4nderss/angular-elements-ie11 Fork of angular-elements-build: https://github.com/danielswars/elements-builds which contains the here implemented bugfix danielswars/elements-builds@c9da737#diff-dceee3652527313b8b6c341dbda09e2d Fixed Repro-Case: https://github.com/DennisNeuendorfNetlight/angular-elements-ie11 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: N/A What is the new behavior? Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: The main problem is the already in the file mentioned not existing reliability on the constructor-call. Some properties were already patched with the if-initialisation of the injector, but not the ...

X Description: The main problem is the already in the file mentioned not existing reliability on the constructor-call. Some properties were already patched with the if-initialisation of the injector, but not the ...

Opengraph URL: https://github.com/angular/angular/pull/34037

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:53607629-5b47-644c-d976-198c41b2851e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id901E:361639:1B4AC58:245BE5A:6B016157
html-safe-nonce99b7dd6d73f5856724072af46d6e49fe24ff71ea2b6b06949d6cd1b1e4c32f33
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDFFOjM2MTYzOToxQjRBQzU4OjI0NUJFNUE6NkIwMTYxNTciLCJ2aXNpdG9yX2lkIjoiMzU5NDg3NzExODc2MjI3OTI1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac46596848d309b41e70ce74fdea914cbbbe0ca81be84895287c3170788df601f0
hovercard-subject-tagpull_request:345322455
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/34037/files
twitter:imagehttps://avatars.githubusercontent.com/u/10137?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10137?s=400&v=4
og:image:altThe main problem is the already in the file mentioned not existing reliability on the constructor-call. Some properties were already patched with the if-initialisation of the injector, but not the ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/34037/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34037%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34037%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34037/files
Reloadhttps://github.com/angular/angular/pull/34037/files
Reloadhttps://github.com/angular/angular/pull/34037/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
ghosthttps://github.com/ghost
angular:masterhttps://github.com/angular/angular/tree/master
Conversation 5 https://github.com/angular/angular/pull/34037
Commits 1 https://github.com/angular/angular/pull/34037/commits
Checks 0 https://github.com/angular/angular/pull/34037/checks
Files changed https://github.com/angular/angular/pull/34037/files
Please reload this pagehttps://github.com/angular/angular/pull/34037/files
Avoid problem with uninitialized ngElementStrategy https://github.com/angular/angular/pull/34037/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/34037/files
15eebe3 fix: Avoid issue with uninitialized ngElementStrategy Nov 25, 2019 https://github.com/angular/angular/pull/34037/commits/15eebe3093846392d0aecf221b75416b58d073ea
Clear filters https://github.com/angular/angular/pull/34037/files
Please reload this pagehttps://github.com/angular/angular/pull/34037/files
Please reload this pagehttps://github.com/angular/angular/pull/34037/files
packages/elements/src/create-custom-element.tshttps://github.com/angular/angular/pull/34037/files#diff-29ff2f1056101122683f947eec3e341f2da21cafd94cb3d903a3fe4e05b8fae6
View file https://github.com/angular/angular/blob/15eebe3093846392d0aecf221b75416b58d073ea/packages/elements/src/create-custom-element.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34037/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34037/files#diff-29ff2f1056101122683f947eec3e341f2da21cafd94cb3d903a3fe4e05b8fae6
https://github.com/angular/angular/pull/34037/files#diff-29ff2f1056101122683f947eec3e341f2da21cafd94cb3d903a3fe4e05b8fae6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.