René's URL Explorer Experiment


Title: fix(ivy): prevent unknown element check for AOT-compiled components by AndrewKushnir · Pull Request #34024 · angular/angular · GitHub

Open Graph Title: fix(ivy): prevent unknown element check for AOT-compiled components by AndrewKushnir · Pull Request #34024 · angular/angular

X Title: fix(ivy): prevent unknown element check for AOT-compiled components by AndrewKushnir · Pull Request #34024 · angular/angular

Description: Prior to this commit, the unknown element can happen twice for AOT-compiled components: once during compilation and once again at runtime. Due to the fact that schemas information is not present on Component and NgModule defs after AOT compilation, the second check (at runtime) may fail, even though the same check was successful at compile time. This commit updates the code to avoid the second check for AOT-compiled components by checking whether schemas information is present in a logic that executes the unknown element check. This PR resolves FW-1736. Resolves #33976. PR Type What kind of change does this PR introduce? Bugfix Does this PR introduce a breaking change? Yes No

Open Graph Description: Prior to this commit, the unknown element can happen twice for AOT-compiled components: once during compilation and once again at runtime. Due to the fact that schemas information is not present on...

X Description: Prior to this commit, the unknown element can happen twice for AOT-compiled components: once during compilation and once again at runtime. Due to the fact that schemas information is not present on...

Opengraph URL: https://github.com/angular/angular/pull/34024

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b7a29817-697b-b078-615a-bd593ffa0e79
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEBD0:3F8AB1:21B35FE:2AD3FF0:6B015ECB
html-safe-nonce375eb873e38853ff1ba1e41da9b52bef22bdc98075161deb687a06c77a33389b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkQwOjNGOEFCMToyMUIzNUZFOjJBRDNGRjA6NkIwMTVFQ0IiLCJ2aXNpdG9yX2lkIjoiNzA0NjQxMDkxMzQwNjA4Mjc2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac90cbb97bdf7689e758d95d49863f03bb9e8e53a8a45a955e7a1dde39a19013aa
hovercard-subject-tagpull_request:344953121
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/34024/files
twitter:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
og:image:altPrior to this commit, the unknown element can happen twice for AOT-compiled components: once during compilation and once again at runtime. Due to the fact that schemas information is not present on...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/34024/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34024%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34024%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34024/files
Reloadhttps://github.com/angular/angular/pull/34024/files
Reloadhttps://github.com/angular/angular/pull/34024/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:FW-1736_unknown_element_check_jithttps://github.com/AndrewKushnir/angular/tree/FW-1736_unknown_element_check_jit
Conversation 11 https://github.com/angular/angular/pull/34024
Commits 2 https://github.com/angular/angular/pull/34024/commits
Checks 0 https://github.com/angular/angular/pull/34024/checks
Files changed https://github.com/angular/angular/pull/34024/files
Please reload this pagehttps://github.com/angular/angular/pull/34024/files
fix(ivy): prevent unknown element check for AOT-compiled components https://github.com/angular/angular/pull/34024/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/34024/files
508bee0 fix(ivy): prevent unknown element check for AOT-compiled components AndrewKushnir Nov 24, 2019 https://github.com/angular/angular/pull/34024/commits/508bee0ec059bd2c8b4c91866e4ab90f1b963cb5
a7fdeae fixup! fix(ivy): prevent unknown element check for AOT-compiled compo… AndrewKushnir Nov 24, 2019 https://github.com/angular/angular/pull/34024/commits/a7fdeaeb1217014714635c1a1166a3bfff706ef2
Clear filters https://github.com/angular/angular/pull/34024/files
Please reload this pagehttps://github.com/angular/angular/pull/34024/files
Please reload this pagehttps://github.com/angular/angular/pull/34024/files
ngtsc_spec.ts https://github.com/angular/angular/pull/34024/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
element.ts https://github.com/angular/angular/pull/34024/files#diff-d872dd53a3ca6fcd2ed09a36f6a49d09cfdb185270dd090b50837b2e1f3d9c0c
module.ts https://github.com/angular/angular/pull/34024/files#diff-d7312b298dbbe322603ff75633c99e8074bc20ed5d4370392ec2b80d86c3bf62
ng_module_spec.ts https://github.com/angular/angular/pull/34024/files#diff-76ec2d30f55f180ab909e763f698a3ee3a0d060c1a241d1ba891a271a4cecd36
packages/compiler-cli/test/ngtsc/ngtsc_spec.tshttps://github.com/angular/angular/pull/34024/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
View file https://github.com/AndrewKushnir/angular/blob/a7fdeaeb1217014714635c1a1166a3bfff706ef2/packages/compiler-cli/test/ngtsc/ngtsc_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34024/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34024/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
https://github.com/angular/angular/pull/34024/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
packages/core/src/render3/instructions/element.tshttps://github.com/angular/angular/pull/34024/files#diff-d872dd53a3ca6fcd2ed09a36f6a49d09cfdb185270dd090b50837b2e1f3d9c0c
View file https://github.com/AndrewKushnir/angular/blob/a7fdeaeb1217014714635c1a1166a3bfff706ef2/packages/core/src/render3/instructions/element.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34024/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34024/files#diff-d872dd53a3ca6fcd2ed09a36f6a49d09cfdb185270dd090b50837b2e1f3d9c0c
Please reload this pagehttps://github.com/angular/angular/pull/34024/files
https://github.com/angular/angular/pull/34024/files#diff-d872dd53a3ca6fcd2ed09a36f6a49d09cfdb185270dd090b50837b2e1f3d9c0c
packages/core/src/render3/jit/module.tshttps://github.com/angular/angular/pull/34024/files#diff-d7312b298dbbe322603ff75633c99e8074bc20ed5d4370392ec2b80d86c3bf62
View file https://github.com/AndrewKushnir/angular/blob/a7fdeaeb1217014714635c1a1166a3bfff706ef2/packages/core/src/render3/jit/module.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34024/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34024/files#diff-d7312b298dbbe322603ff75633c99e8074bc20ed5d4370392ec2b80d86c3bf62
Please reload this pagehttps://github.com/angular/angular/pull/34024/files
https://github.com/angular/angular/pull/34024/files#diff-d7312b298dbbe322603ff75633c99e8074bc20ed5d4370392ec2b80d86c3bf62
packages/core/test/acceptance/ng_module_spec.tshttps://github.com/angular/angular/pull/34024/files#diff-76ec2d30f55f180ab909e763f698a3ee3a0d060c1a241d1ba891a271a4cecd36
View file https://github.com/AndrewKushnir/angular/blob/a7fdeaeb1217014714635c1a1166a3bfff706ef2/packages/core/test/acceptance/ng_module_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/34024/{{ revealButtonHref }}
https://github.com/angular/angular/pull/34024/files#diff-76ec2d30f55f180ab909e763f698a3ee3a0d060c1a241d1ba891a271a4cecd36
https://github.com/angular/angular/pull/34024/files#diff-76ec2d30f55f180ab909e763f698a3ee3a0d060c1a241d1ba891a271a4cecd36
https://github.com/angular/angular/pull/34024/files#diff-76ec2d30f55f180ab909e763f698a3ee3a0d060c1a241d1ba891a271a4cecd36
https://github.com/angular/angular/pull/34024/files#diff-76ec2d30f55f180ab909e763f698a3ee3a0d060c1a241d1ba891a271a4cecd36
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.