René's URL Explorer Experiment


Title: fix(ivy): prevent unknown element check for AOT-compiled components by AndrewKushnir · Pull Request #34024 · angular/angular · GitHub

Open Graph Title: fix(ivy): prevent unknown element check for AOT-compiled components by AndrewKushnir · Pull Request #34024 · angular/angular

X Title: fix(ivy): prevent unknown element check for AOT-compiled components by AndrewKushnir · Pull Request #34024 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Prior to this commit, the unknown element can happen twice for AOT-compiled components: once during compilation and once again at runtime. Due to the fact that schemas information is not present on...

X Description: Prior to this commit, the unknown element can happen twice for AOT-compiled components: once during compilation and once again at runtime. Due to the fact that schemas information is not present on...

Opengraph URL: https://github.com/angular/angular/pull/34024

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:77b993c5-0ca7-ff27-cb5b-b5b6e097a81b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC6E6:DA744:1756CFC:1F5E524:6B014CB9
html-safe-nonce87969ad7952c2f55ce716ebea049afa58a3847552daaa7fd95bc7d31e002c54e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNkU2OkRBNzQ0OjE3NTZDRkM6MUY1RTUyNDo2QjAxNENCOSIsInZpc2l0b3JfaWQiOiI1OTQxNjEwODcwOTIzNjc2ODU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace32688f9c0163c7f5de9deaab5e000f8da776a7001c7d894ac5e02c00f61e0f5
hovercard-subject-tagpull_request:344953121
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/34024/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4354fb49d1946b5b9949293e12912f7dce3719bff1f0c5657fd0be013e76fea4/angular/angular/pull/34024
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4354fb49d1946b5b9949293e12912f7dce3719bff1f0c5657fd0be013e76fea4/angular/angular/pull/34024
og:image:altPrior to this commit, the unknown element can happen twice for AOT-compiled components: once during compilation and once again at runtime. Due to the fact that schemas information is not present on...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAndrewKushnir
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/34024#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34024
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34024
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/34024
Reloadhttps://github.com/angular/angular/pull/34024
Reloadhttps://github.com/angular/angular/pull/34024
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:FW-1736_unknown_element_check_jithttps://github.com/AndrewKushnir/angular/tree/FW-1736_unknown_element_check_jit
Conversationhttps://github.com/angular/angular/pull/34024
Commits2 (2)https://github.com/angular/angular/pull/34024/commits
Checkshttps://github.com/angular/angular/pull/34024/checks
Files changedhttps://github.com/angular/angular/pull/34024/files
fix(ivy): prevent unknown element check for AOT-compiled componentshttps://github.com/angular/angular/pull/34024#top
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:FW-1736_unknown_element_check_jithttps://github.com/AndrewKushnir/angular/tree/FW-1736_unknown_element_check_jit
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Nov 24, 2019https://github.com/angular/angular/pull/34024#issue-527762808
Please reload this pagehttps://github.com/angular/angular/pull/34024
#33976https://github.com/angular/angular/issues/33976
Please reload this pagehttps://github.com/angular/angular/pull/34024
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
comp: ivy https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
Nov 24, 2019https://github.com/angular/angular/pull/34024#event-2826255773
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Nov 24, 2019https://github.com/angular/angular/pull/34024#event-2826255803
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Nov 24, 2019https://github.com/angular/angular/pull/34024#event-2826255813
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Nov 24, 2019https://github.com/angular/angular/pull/34024#issuecomment-557931887
@petebacondarwinhttps://github.com/petebacondarwin
@crisbetohttps://github.com/crisbeto
Please reload this pagehttps://github.com/angular/angular/pull/34024
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Nov 25, 2019 https://github.com/angular/angular/pull/34024#pullrequestreview-322061798
View reviewed changes https://github.com/angular/angular/pull/34024/files
packages/core/src/render3/jit/module.tshttps://github.com/angular/angular/pull/34024/files#diff-d7312b298dbbe322603ff75633c99e8074bc20ed5d4370392ec2b80d86c3bf62
Please reload this pagehttps://github.com/angular/angular/pull/34024
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Nov 25, 2019 https://github.com/angular/angular/pull/34024#pullrequestreview-322203316
View reviewed changes https://github.com/angular/angular/pull/34024/files
packages/core/src/render3/instructions/element.tshttps://github.com/angular/angular/pull/34024/files#diff-d872dd53a3ca6fcd2ed09a36f6a49d09cfdb185270dd090b50837b2e1f3d9c0c
Please reload this pagehttps://github.com/angular/angular/pull/34024
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
Nov 25, 2019https://github.com/angular/angular/pull/34024#event-2829191350
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
November 25, 2019 18:35https://github.com/angular/angular/pull/34024#event-2829191829
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
November 25, 2019 18:36https://github.com/angular/angular/pull/34024#event-2829191845
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Nov 25, 2019https://github.com/angular/angular/pull/34024#event-2829192680
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Nov 25, 2019 https://github.com/angular/angular/pull/34024#pullrequestreview-322619624
View reviewed changes https://github.com/angular/angular/pull/34024/files
crisbetohttps://github.com/crisbeto
https://github.com/angular/angular/pull/34024#pullrequestreview-322619624
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/34024
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Nov 25, 2019https://github.com/angular/angular/pull/34024#issuecomment-558383672
Please reload this pagehttps://github.com/angular/angular/pull/34024
VE Presubmithttp://test/OCL:282443870:BASE:282443911:1574723884160:5a4baac7
Ivy Presubmithttps://test.corp.google.com/OCL:282443870:BASE:282444098:1574723942999:db608469
Please reload this pagehttps://github.com/angular/angular/pull/34024
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Nov 25, 2019https://github.com/angular/angular/pull/34024#event-2829960597
https://github.com/kara
karahttps://github.com/kara
November 25, 2019 23:21https://github.com/angular/angular/pull/34024#event-2829979023
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
Nov 26, 2019 https://github.com/angular/angular/pull/34024#pullrequestreview-323030843
View reviewed changes https://github.com/angular/angular/pull/34024/files
AndrewKushnirhttps://github.com/AndrewKushnir
November 26, 2019 17:31https://github.com/angular/angular/pull/34024#commits-pushed-508bee0
https://github.com/AndrewKushnir
fix(ivy): prevent unknown element check for AOT-compiled componentshttps://github.com/angular/angular/pull/34024/commits/508bee0ec059bd2c8b4c91866e4ab90f1b963cb5
508bee0https://github.com/angular/angular/pull/34024/commits/508bee0ec059bd2c8b4c91866e4ab90f1b963cb5
https://github.com/AndrewKushnir
fixup! fix(ivy): prevent unknown element check for AOT-compiled compo…https://github.com/angular/angular/pull/34024/commits/a7fdeaeb1217014714635c1a1166a3bfff706ef2
a7fdeaehttps://github.com/angular/angular/pull/34024/commits/a7fdeaeb1217014714635c1a1166a3bfff706ef2
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
force-pushedhttps://github.com/angular/angular/compare/e956bf94dd2e3749b163a4b9d703b98fcd54d06f..a7fdeaeb1217014714635c1a1166a3bfff706ef2
e956bf9https://github.com/angular/angular/commit/e956bf94dd2e3749b163a4b9d703b98fcd54d06f
a7fdeaehttps://github.com/angular/angular/commit/a7fdeaeb1217014714635c1a1166a3bfff706ef2
Compare https://github.com/angular/angular/compare/e956bf94dd2e3749b163a4b9d703b98fcd54d06f..a7fdeaeb1217014714635c1a1166a3bfff706ef2
November 27, 2019 01:31https://github.com/angular/angular/pull/34024#event-2833998279
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Nov 27, 2019https://github.com/angular/angular/pull/34024#event-2836702297
https://github.com/kara
karahttps://github.com/kara
November 27, 2019 20:39https://github.com/angular/angular/pull/34024#event-2836956534
https://github.com/mhevery
mheveryhttps://github.com/mhevery
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Nov 27, 2019https://github.com/angular/angular/pull/34024#event-2836966949
mheveryhttps://github.com/mhevery
Nov 27, 2019 https://github.com/angular/angular/pull/34024#ref-commit-955a312
https://github.com/AndrewKushnir
https://github.com/mhevery
fix(ivy): prevent unknown element check for AOT-compiled components (https://github.com/angular/angular/commit/955a3129f0f8851304578d6e730df91e5ba0ce04
#…https://github.com/angular/angular/pull/34024
955a312https://github.com/angular/angular/commit/955a3129f0f8851304578d6e730df91e5ba0ce04
…34024https://github.com/angular/angular/pull/34024
#34024https://github.com/angular/angular/pull/34024
https://github.com/mhevery
mheveryhttps://github.com/mhevery
658087bhttps://github.com/angular/angular/commit/658087be7e3bcae0685fcced15afad2a22a4b1e6
Nov 27, 2019https://github.com/angular/angular/pull/34024#event-2836968568
https://github.com/IgorMinar
IgorMinarhttps://github.com/IgorMinar
Nov 27, 2019 https://github.com/angular/angular/pull/34024#ref-issue-526882207
bug(ivy): runtime error for unknown element even with NO_ERRORS_SCHEMA #33976 https://github.com/angular/angular/issues/33976
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Dec 28, 2019https://github.com/angular/angular/pull/34024#issuecomment-569428644
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/34024
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Dec 28, 2019https://github.com/angular/angular/pull/34024#event-2911978114
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F34024
https://github.com/crisbeto
crisbeto https://github.com/crisbeto
https://github.com/angular/angular/pull/34024/files/e956bf94dd2e3749b163a4b9d703b98fcd54d06f
https://github.com/petebacondarwin
petebacondarwin https://github.com/petebacondarwin
https://github.com/angular/angular/pull/34024/files/e956bf94dd2e3749b163a4b9d703b98fcd54d06f
https://github.com/IgorMinar
IgorMinar https://github.com/IgorMinar
https://github.com/angular/angular/pull/34024/files/e956bf94dd2e3749b163a4b9d703b98fcd54d06f
Please reload this pagehttps://github.com/angular/angular/pull/34024
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
bug(ivy): runtime error for unknown element even with NO_ERRORS_SCHEMA https://github.com/angular/angular/issues/33976
Please reload this pagehttps://github.com/angular/angular/pull/34024
https://github.com/AndrewKushnir
https://github.com/petebacondarwin
https://github.com/IgorMinar
https://github.com/crisbeto
https://github.com/mhevery
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.