| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:026cb162-2820-4f80-47db-12b7cf96cb4a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D1E8:229B2E:DA3D0E:12139EB:6B00FAC2 |
| html-safe-nonce | afd1348038143e1ecc476bc3896f8ed35ca4fcc8d66756326b1df19bda3fccea |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUU4OjIyOUIyRTpEQTNEMEU6MTIxMzlFQjo2QjAwRkFDMiIsInZpc2l0b3JfaWQiOiIzMjc3NDE5OTIzOTUyOTU4MTQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a042f8ef22e0db231d7c20087cf469e5135b87cd6496b07b79438bd0ae1fbb08 |
| hovercard-subject-tag | pull_request:344711615 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/33997/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/59182ca7abf85bc01d0477d565fe869d534ff9e7916d1322084dadef8fc5b5bc/angular/angular/pull/33997 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/59182ca7abf85bc01d0477d565fe869d534ff9e7916d1322084dadef8fc5b5bc/angular/angular/pull/33997 |
| og:image:alt | Fixes NgForOf not reflecting the type of its input in the NgForOfContext. Also fixes NgIf which was typed to any.
Fixes #33527.
Fixes #31556. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | crisbeto |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/33997#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33997 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33997 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/33997 |
| Reload | https://github.com/angular/angular/pull/33997 |
| Reload | https://github.com/angular/angular/pull/33997 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| crisbeto | https://github.com/crisbeto |
| angular:master | https://github.com/angular/angular/tree/master |
| crisbeto:FW-1738/ngfor-input-type | https://github.com/crisbeto/angular/tree/FW-1738/ngfor-input-type |
| Conversation | https://github.com/angular/angular/pull/33997 |
| Commits2 (2) | https://github.com/angular/angular/pull/33997/commits |
| Checks | https://github.com/angular/angular/pull/33997/checks |
| Files changed | https://github.com/angular/angular/pull/33997/files |
| fix(common): reflect input type in context | https://github.com/angular/angular/pull/33997#top |
| crisbeto | https://github.com/crisbeto |
| angular:master | https://github.com/angular/angular/tree/master |
| crisbeto:FW-1738/ngfor-input-type | https://github.com/crisbeto/angular/tree/FW-1738/ngfor-input-type |
|
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| Nov 22, 2019 | https://github.com/angular/angular/pull/33997#issue-527429791 |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| #33527 | https://github.com/angular/angular/issues/33527 |
| #31556 | https://github.com/angular/angular/issues/31556 |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Nov 22, 2019 | https://github.com/angular/angular/pull/33997#event-2824677960 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| force-pushed | https://github.com/angular/angular/compare/4d4e40472157657200192be7a931f7ba1e73c195..adf9934fcf02757f831e7c9a0f4731ea7051f6ef |
| 4d4e404 | https://github.com/angular/angular/commit/4d4e40472157657200192be7a931f7ba1e73c195 |
| adf9934 | https://github.com/angular/angular/commit/adf9934fcf02757f831e7c9a0f4731ea7051f6ef |
|
Compare
| https://github.com/angular/angular/compare/4d4e40472157657200192be7a931f7ba1e73c195..adf9934fcf02757f831e7c9a0f4731ea7051f6ef |
| November 22, 2019 22:02 | https://github.com/angular/angular/pull/33997#event-2824716835 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
|
area: common
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20common%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
| Nov 22, 2019 | https://github.com/angular/angular/pull/33997#event-2824761575 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Nov 22, 2019 | https://github.com/angular/angular/pull/33997#event-2824761626 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| November 22, 2019 22:23 | https://github.com/angular/angular/pull/33997#event-2824761660 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| November 22, 2019 22:23 | https://github.com/angular/angular/pull/33997#event-2824761669 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
| Nov 26, 2019 | https://github.com/angular/angular/pull/33997#issuecomment-558484533 |
| presubmit | https://test.corp.google.com/ui#id=OCL:282499489:BASE:282499508:1574750327811:3bf9d550 |
| ivy presubmit | https://test.corp.google.com/ui#id=OCL:282499489:BASE:282499650:1574750420705:1637d262 |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Nov 26, 2019 | https://github.com/angular/angular/pull/33997#event-2830697240 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
Nov 26, 2019
| https://github.com/angular/angular/pull/33997#pullrequestreview-322757979 |
|
View reviewed changes
| https://github.com/angular/angular/pull/33997/files |
| IgorMinar | https://github.com/IgorMinar |
| https://github.com/angular/angular/pull/33997#pullrequestreview-322757979 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #33527 | https://github.com/angular/angular/issues/33527 |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
| Nov 26, 2019 | https://github.com/angular/angular/pull/33997#event-2830708272 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
| Nov 26, 2019 | https://github.com/angular/angular/pull/33997#issuecomment-558486254 |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Nov 26, 2019
| https://github.com/angular/angular/pull/33997#pullrequestreview-322853980 |
|
View reviewed changes
| https://github.com/angular/angular/pull/33997/files |
| JoostK | https://github.com/JoostK |
| https://github.com/angular/angular/pull/33997#pullrequestreview-322853980 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/microsoft/dtslint | https://github.com/microsoft/dtslint |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| packages/common/src/directives/ng_for_of.ts | https://github.com/angular/angular/pull/33997/files#diff-2c3c0064b078b42233a34aab2761dd1b2790adada099105f3fc4f8f69e039d19 |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| packages/common/src/directives/ng_if.ts | https://github.com/angular/angular/pull/33997/files#diff-bc2a64986fd7bb7d2e6c22feeb7f835260695b17224408fc7f4d824441f53abd |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| packages/common/src/directives/ng_if.ts | https://github.com/angular/angular/pull/33997/files#diff-bc2a64986fd7bb7d2e6c22feeb7f835260695b17224408fc7f4d824441f53abd |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| force-pushed | https://github.com/angular/angular/compare/adf9934fcf02757f831e7c9a0f4731ea7051f6ef..42c316d2d432a1343cc6a150a35e806fcfb0464d |
| adf9934 | https://github.com/angular/angular/commit/adf9934fcf02757f831e7c9a0f4731ea7051f6ef |
| 42c316d | https://github.com/angular/angular/commit/42c316d2d432a1343cc6a150a35e806fcfb0464d |
|
Compare
| https://github.com/angular/angular/compare/adf9934fcf02757f831e7c9a0f4731ea7051f6ef..42c316d2d432a1343cc6a150a35e806fcfb0464d |
| November 26, 2019 19:58 | https://github.com/angular/angular/pull/33997#event-2833270944 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Nov 26, 2019 | https://github.com/angular/angular/pull/33997#event-2833278471 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| Nov 26, 2019 | https://github.com/angular/angular/pull/33997#issuecomment-558794804 |
| @JoostK | https://github.com/JoostK |
| @IgorMinar | https://github.com/IgorMinar |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| force-pushed | https://github.com/angular/angular/compare/42c316d2d432a1343cc6a150a35e806fcfb0464d..df1e8445bab4924849aeb78973c60eea8655ac32 |
| 42c316d | https://github.com/angular/angular/commit/42c316d2d432a1343cc6a150a35e806fcfb0464d |
| df1e844 | https://github.com/angular/angular/commit/df1e8445bab4924849aeb78973c60eea8655ac32 |
|
Compare
| https://github.com/angular/angular/compare/42c316d2d432a1343cc6a150a35e806fcfb0464d..df1e8445bab4924849aeb78973c60eea8655ac32 |
| November 26, 2019 20:06 | https://github.com/angular/angular/pull/33997#event-2833292845 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Nov 27, 2019
| https://github.com/angular/angular/pull/33997#pullrequestreview-323922150 |
|
View reviewed changes
| https://github.com/angular/angular/pull/33997/files |
| JoostK | https://github.com/JoostK |
| https://github.com/angular/angular/pull/33997#pullrequestreview-323922150 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| packages/common/src/directives/ng_if.ts | https://github.com/angular/angular/pull/33997/files#diff-bc2a64986fd7bb7d2e6c22feeb7f835260695b17224408fc7f4d824441f53abd |
| JoostK | https://github.com/JoostK |
| Nov 27, 2019 | https://github.com/angular/angular/pull/33997#discussion_r351479314 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
Nov 27, 2019
| https://github.com/angular/angular/pull/33997#pullrequestreview-323952083 |
|
View reviewed changes
| https://github.com/angular/angular/pull/33997/files |
| IgorMinar | https://github.com/IgorMinar |
| https://github.com/angular/angular/pull/33997#pullrequestreview-323952083 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @crisbeto | https://github.com/crisbeto |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Nov 27, 2019 | https://github.com/angular/angular/pull/33997#event-2837051637 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| Nov 27, 2019 | https://github.com/angular/angular/pull/33997#issuecomment-559270425 |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
|
| https://github.com/crisbeto |
| fix(common): reflect input type in NgForOf context | https://github.com/angular/angular/pull/33997/commits/de4840dc8b6c8772668910b66410c831068f5c09 |
| de4840d | https://github.com/angular/angular/pull/33997/commits/de4840dc8b6c8772668910b66410c831068f5c09 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| force-pushed | https://github.com/angular/angular/compare/df1e8445bab4924849aeb78973c60eea8655ac32..ac43930d83002fec78d1630a5b4446d1492614bf |
| df1e844 | https://github.com/angular/angular/commit/df1e8445bab4924849aeb78973c60eea8655ac32 |
| ac43930 | https://github.com/angular/angular/commit/ac43930d83002fec78d1630a5b4446d1492614bf |
|
Compare
| https://github.com/angular/angular/compare/df1e8445bab4924849aeb78973c60eea8655ac32..ac43930d83002fec78d1630a5b4446d1492614bf |
| November 28, 2019 18:47 | https://github.com/angular/angular/pull/33997#event-2839733027 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| November 28, 2019 18:47 | https://github.com/angular/angular/pull/33997#event-2839733029 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| Nov 28, 2019 | https://github.com/angular/angular/pull/33997#issuecomment-559585406 |
| @JoostK | https://github.com/JoostK |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Nov 28, 2019 | https://github.com/angular/angular/pull/33997#event-2839755584 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Nov 29, 2019
| https://github.com/angular/angular/pull/33997#pullrequestreview-324860135 |
|
View reviewed changes
| https://github.com/angular/angular/pull/33997/files |
| JoostK | https://github.com/JoostK |
| https://github.com/angular/angular/pull/33997#pullrequestreview-324860135 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #31556 | https://github.com/angular/angular/issues/31556 |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| packages/common/src/directives/ng_if.ts | https://github.com/angular/angular/pull/33997/files#diff-bc2a64986fd7bb7d2e6c22feeb7f835260695b17224408fc7f4d824441f53abd |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
|
| https://github.com/crisbeto |
| fix(common): reflect input type in NgIf context | https://github.com/angular/angular/pull/33997/commits/66e8ed4ca8c7bd140e7dd3de0493e21382d2d755 |
| 66e8ed4 | https://github.com/angular/angular/pull/33997/commits/66e8ed4ca8c7bd140e7dd3de0493e21382d2d755 |
| angular#31556 | https://github.com/angular/angular/issues/31556 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| force-pushed | https://github.com/angular/angular/compare/ac43930d83002fec78d1630a5b4446d1492614bf..66e8ed4ca8c7bd140e7dd3de0493e21382d2d755 |
| ac43930 | https://github.com/angular/angular/commit/ac43930d83002fec78d1630a5b4446d1492614bf |
| 66e8ed4 | https://github.com/angular/angular/commit/66e8ed4ca8c7bd140e7dd3de0493e21382d2d755 |
|
Compare
| https://github.com/angular/angular/compare/ac43930d83002fec78d1630a5b4446d1492614bf..66e8ed4ca8c7bd140e7dd3de0493e21382d2d755 |
| November 29, 2019 22:11 | https://github.com/angular/angular/pull/33997#event-2842297421 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| Nov 29, 2019 | https://github.com/angular/angular/pull/33997#issuecomment-559887263 |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| stale review | https://github.com/angular/angular/pull/33997#pullrequestreview-323922150 |
| December 2, 2019 09:32 | https://github.com/angular/angular/pull/33997#event-2844912642 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
|
Dec 2, 2019
| https://github.com/angular/angular/pull/33997#pullrequestreview-325443550 |
|
View reviewed changes
| https://github.com/angular/angular/pull/33997/files/66e8ed4ca8c7bd140e7dd3de0493e21382d2d755 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Dec 2, 2019 | https://github.com/angular/angular/pull/33997#event-2846876757 |
| mhevery | https://github.com/mhevery |
|
Dec 2, 2019
| https://github.com/angular/angular/pull/33997#ref-commit-b640d38 |
|
| https://github.com/crisbeto |
|
| https://github.com/mhevery |
| fix(common): reflect input type in NgForOf context ( | https://github.com/angular/angular/commit/b640d38fd1b19c20ebe17d33b87ffa4020e930d4 |
| #33997 | https://github.com/angular/angular/pull/33997 |
| ) | https://github.com/angular/angular/commit/b640d38fd1b19c20ebe17d33b87ffa4020e930d4 |
| b640d38 | https://github.com/angular/angular/commit/b640d38fd1b19c20ebe17d33b87ffa4020e930d4 |
| #33997 | https://github.com/angular/angular/pull/33997 |
| mhevery | https://github.com/mhevery |
|
Dec 2, 2019
| https://github.com/angular/angular/pull/33997#ref-commit-7504543 |
|
| https://github.com/crisbeto |
|
| https://github.com/mhevery |
| fix(common): reflect input type in NgIf context ( | https://github.com/angular/angular/commit/7504543962818147d773ab53606f40bac2bb502f |
| #33997 | https://github.com/angular/angular/pull/33997 |
| ) | https://github.com/angular/angular/commit/7504543962818147d773ab53606f40bac2bb502f |
| 7504543 | https://github.com/angular/angular/commit/7504543962818147d773ab53606f40bac2bb502f |
| #31556 | https://github.com/angular/angular/issues/31556 |
| #33997 | https://github.com/angular/angular/pull/33997 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| a6b6d74 | https://github.com/angular/angular/commit/a6b6d74c006cebb24f43593e6400782434266629 |
| Dec 2, 2019 | https://github.com/angular/angular/pull/33997#event-2846985194 |
| mhevery | https://github.com/mhevery |
|
Dec 2, 2019
| https://github.com/angular/angular/pull/33997#ref-commit-02958c0 |
|
| https://github.com/crisbeto |
|
| https://github.com/mhevery |
| fix(common): reflect input type in NgIf context ( | https://github.com/angular/angular/commit/02958c07f60ca6cd951b48cd37f50cc23d220b82 |
| #33997 | https://github.com/angular/angular/pull/33997 |
| ) | https://github.com/angular/angular/commit/02958c07f60ca6cd951b48cd37f50cc23d220b82 |
| 02958c0 | https://github.com/angular/angular/commit/02958c07f60ca6cd951b48cd37f50cc23d220b82 |
| #31556 | https://github.com/angular/angular/issues/31556 |
| #33997 | https://github.com/angular/angular/pull/33997 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Dec 3, 2019
| https://github.com/angular/angular/pull/33997#ref-issue-516011539 |
|
Ivy: fullTemplateTypeCheck errors with NgIterable
#33527
| https://github.com/angular/angular/issues/33527 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
|
Dec 3, 2019
| https://github.com/angular/angular/pull/33997#ref-pullrequest-531801750 |
|
refactor(common): add defaults to new generic parameters
#34206
| https://github.com/angular/angular/pull/34206 |
| crisbeto | https://github.com/crisbeto |
|
Dec 3, 2019
| https://github.com/angular/angular/pull/33997#ref-commit-49c20b2 |
|
| https://github.com/crisbeto |
| refactor(common): add defaults to new generic parameters | https://github.com/crisbeto/angular/commit/49c20b234c4e8cdcd68d718752d4d761667013b9 |
| 49c20b2 | https://github.com/crisbeto/angular/commit/49c20b234c4e8cdcd68d718752d4d761667013b9 |
| angular#33997 | https://github.com/angular/angular/pull/33997 |
| mhevery | https://github.com/mhevery |
|
Dec 4, 2019
| https://github.com/angular/angular/pull/33997#ref-commit-cca2616 |
|
| https://github.com/crisbeto |
|
| https://github.com/mhevery |
| refactor(common): add defaults to new generic parameters ( | https://github.com/angular/angular/commit/cca26166376d4920f5905b168e70ea2e8d70da77 |
| #34206 | https://github.com/angular/angular/pull/34206 |
| ) | https://github.com/angular/angular/commit/cca26166376d4920f5905b168e70ea2e8d70da77 |
| cca2616 | https://github.com/angular/angular/commit/cca26166376d4920f5905b168e70ea2e8d70da77 |
| #33997 | https://github.com/angular/angular/pull/33997 |
| #34206 | https://github.com/angular/angular/pull/34206 |
| mhevery | https://github.com/mhevery |
|
Dec 4, 2019
| https://github.com/angular/angular/pull/33997#ref-commit-c92c9f7 |
|
| https://github.com/crisbeto |
|
| https://github.com/mhevery |
| refactor(common): add defaults to new generic parameters ( | https://github.com/angular/angular/commit/c92c9f7e21bb29e2a5c23be6761ecc2fed919538 |
| #34206 | https://github.com/angular/angular/pull/34206 |
| ) | https://github.com/angular/angular/commit/c92c9f7e21bb29e2a5c23be6761ecc2fed919538 |
| c92c9f7 | https://github.com/angular/angular/commit/c92c9f7e21bb29e2a5c23be6761ecc2fed919538 |
| #33997 | https://github.com/angular/angular/pull/33997 |
| #34206 | https://github.com/angular/angular/pull/34206 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Dec 7, 2019
| https://github.com/angular/angular/pull/33997#ref-pullrequest-468182607 |
|
feat(ivy): support types narrowing for template context of NgIf
#31568
| https://github.com/angular/angular/pull/31568 |
| https://github.com/Splaktar |
| Splaktar | https://github.com/Splaktar |
|
Dec 17, 2019
| https://github.com/angular/angular/pull/33997#ref-pullrequest-537968642 |
|
build: enable strictPropertyInitialization
angular/material.angular.io#689
| https://github.com/angular/material.angular.io/pull/689 |
| https://github.com/Splaktar |
| Splaktar | https://github.com/Splaktar |
| Dec 17, 2019 | https://github.com/angular/angular/pull/33997#issuecomment-566343502 |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| https://github.com/Splaktar |
| Splaktar | https://github.com/Splaktar |
|
Dec 27, 2019
| https://github.com/angular/angular/pull/33997#ref-issue-542720719 |
|
ngIf with async pipe causes new template type checking errors when template variables are used in rc.5
#34572
| https://github.com/angular/angular/issues/34572 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jan 17, 2020 | https://github.com/angular/angular/pull/33997#issuecomment-575686664 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Jan 17, 2020 | https://github.com/angular/angular/pull/33997#event-2958663421 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33997 |
|
| https://github.com/JoostK |
|
JoostK
| https://github.com/JoostK |
|
| https://github.com/angular/angular/pull/33997/files/ac43930d83002fec78d1630a5b4446d1492614bf |
|
| https://github.com/alxhub |
|
alxhub
| https://github.com/alxhub |
|
| https://github.com/angular/angular/pull/33997/files/66e8ed4ca8c7bd140e7dd3de0493e21382d2d755 |
|
| https://github.com/IgorMinar |
|
IgorMinar
| https://github.com/IgorMinar |
|
| https://github.com/angular/angular/pull/33997/files/df1e8445bab4924849aeb78973c60eea8655ac32 |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: common
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20common%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
|
Ivy: fullTemplateTypeCheck errors with NgIterable
| https://github.com/angular/angular/issues/33527 |
|
Type check directive template context
| https://github.com/angular/angular/issues/31556 |
| Please reload this page | https://github.com/angular/angular/pull/33997 |
|
| https://github.com/crisbeto |
|
| https://github.com/IgorMinar |
|
| https://github.com/Splaktar |
|
| https://github.com/JoostK |
|
| https://github.com/alxhub |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |