René's URL Explorer Experiment


Title: fix(ngcc): report errors from `analyze` and `resolve` processing by petebacondarwin · Pull Request #33964 · angular/angular · GitHub

Open Graph Title: fix(ngcc): report errors from `analyze` and `resolve` processing by petebacondarwin · Pull Request #33964 · angular/angular

X Title: fix(ngcc): report errors from `analyze` and `resolve` processing by petebacondarwin · Pull Request #33964 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Previously, these errors were being swallowed, which made it hard to debug problems with packages. See #33685 (comment)

X Description: Previously, these errors were being swallowed, which made it hard to debug problems with packages. See #33685 (comment)

Opengraph URL: https://github.com/angular/angular/pull/33964

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:069b1a46-ef7d-fb55-ed4b-e417f676170f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC204:215B92:1839486:203C845:6B01499D
html-safe-nonce07806b55b78438f135ace11c04b602b3ac8540e5cd5476730bcb51a3065016ff
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjA0OjIxNUI5MjoxODM5NDg2OjIwM0M4NDU6NkIwMTQ5OUQiLCJ2aXNpdG9yX2lkIjoiNzQzNzY3MjE2MDUwOTkwNTMwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac035296bb8dd3cf8a2d786410b823cb1fc83445ba6793935ac1135f0a410fb465
hovercard-subject-tagpull_request:344133149
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/33964/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/295d09fa62dd132149dd461a07f195c66e37076377464c02cd8bad400019cbb0/angular/angular/pull/33964
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/295d09fa62dd132149dd461a07f195c66e37076377464c02cd8bad400019cbb0/angular/angular/pull/33964
og:image:altPreviously, these errors were being swallowed, which made it hard to debug problems with packages. See #33685 (comment)
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepetebacondarwin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/33964#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33964
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33964
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/33964
Reloadhttps://github.com/angular/angular/pull/33964
Reloadhttps://github.com/angular/angular/pull/33964
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-error-reportinghttps://github.com/petebacondarwin/angular/tree/ngcc-error-reporting
Conversationhttps://github.com/angular/angular/pull/33964
Commits2 (2)https://github.com/angular/angular/pull/33964/commits
Checkshttps://github.com/angular/angular/pull/33964/checks
Files changedhttps://github.com/angular/angular/pull/33964/files
fix(ngcc): report errors from analyze and resolve processinghttps://github.com/angular/angular/pull/33964#top
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-error-reportinghttps://github.com/petebacondarwin/angular/tree/ngcc-error-reporting
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Nov 21, 2019https://github.com/angular/angular/pull/33964#issue-526719308
#33685 (comment)https://github.com/angular/angular/issues/33685#issuecomment-557091719
Please reload this pagehttps://github.com/angular/angular/pull/33964
https://github.com/petebacondarwin
fix(ngcc): report errors from analyze and resolve processinghttps://github.com/angular/angular/pull/33964/commits/3a71282824c124d89b2a3d8c5ec6c12147a69241
3a71282https://github.com/angular/angular/pull/33964/commits/3a71282824c124d89b2a3d8c5ec6c12147a69241
angular#33685 (comment)https://github.com/angular/angular/issues/33685#issuecomment-557091719
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
comp: ngcc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
Nov 21, 2019https://github.com/angular/angular/pull/33964#event-2820406599
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
November 21, 2019 16:53https://github.com/angular/angular/pull/33964#event-2820406613
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Nov 21, 2019https://github.com/angular/angular/pull/33964#event-2820406788
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Nov 21, 2019https://github.com/angular/angular/pull/33964#event-2820406827
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Nov 21, 2019 https://github.com/angular/angular/pull/33964#ref-issue-519974676
ivy throw [tagName] is not a known element #33685 https://github.com/angular/angular/issues/33685
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Nov 21, 2019 https://github.com/angular/angular/pull/33964#pullrequestreview-321051321
View reviewed changes https://github.com/angular/angular/pull/33964/files/3a71282824c124d89b2a3d8c5ec6c12147a69241
packages/compiler-cli/ngcc/test/analysis/decoration_analyzer_spec.tshttps://github.com/angular/angular/pull/33964/files/3a71282824c124d89b2a3d8c5ec6c12147a69241#diff-e8650a61025a99f4301da5b57cf1f46c788e761f40b54be2a8f0462addff4177
Please reload this pagehttps://github.com/angular/angular/pull/33964
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Nov 21, 2019https://github.com/angular/angular/pull/33964#event-2820484423
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Nov 21, 2019 https://github.com/angular/angular/pull/33964#pullrequestreview-321052308
View reviewed changes https://github.com/angular/angular/pull/33964/files/3a71282824c124d89b2a3d8c5ec6c12147a69241
packages/compiler-cli/ngcc/test/analysis/decoration_analyzer_spec.tshttps://github.com/angular/angular/pull/33964/files/3a71282824c124d89b2a3d8c5ec6c12147a69241#diff-e8650a61025a99f4301da5b57cf1f46c788e761f40b54be2a8f0462addff4177
Please reload this pagehttps://github.com/angular/angular/pull/33964
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Nov 21, 2019https://github.com/angular/angular/pull/33964#issuecomment-557185325
Please reload this pagehttps://github.com/angular/angular/pull/33964
Please reload this pagehttps://github.com/angular/angular/pull/33964
https://github.com/petebacondarwin
fixup! fix(ngcc): report errors from analyze and resolve processinghttps://github.com/angular/angular/pull/33964/commits/f32266a5fcacc1be4b54c862b359510139173add
f32266ahttps://github.com/angular/angular/pull/33964/commits/f32266a5fcacc1be4b54c862b359510139173add
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Nov 21, 2019https://github.com/angular/angular/pull/33964#event-2820509535
alxhubhttps://github.com/alxhub
Nov 21, 2019 https://github.com/angular/angular/pull/33964#ref-commit-ca5d772
https://github.com/petebacondarwin
https://github.com/alxhub
fix(ngcc): report errors fromhttps://github.com/angular/angular/commit/ca5d7723fffb1a4f9f43a8c20c847270f9cbbe10
analyzehttps://github.com/angular/angular/commit/ca5d7723fffb1a4f9f43a8c20c847270f9cbbe10
andhttps://github.com/angular/angular/commit/ca5d7723fffb1a4f9f43a8c20c847270f9cbbe10
resolvehttps://github.com/angular/angular/commit/ca5d7723fffb1a4f9f43a8c20c847270f9cbbe10
processing (https://github.com/angular/angular/commit/ca5d7723fffb1a4f9f43a8c20c847270f9cbbe10
#33964https://github.com/angular/angular/pull/33964
ca5d772https://github.com/angular/angular/commit/ca5d7723fffb1a4f9f43a8c20c847270f9cbbe10
https://github.com/angular/angular/pull/33964
#33685 (comment)https://github.com/angular/angular/issues/33685#issuecomment-557091719
#33964https://github.com/angular/angular/pull/33964
https://github.com/alxhub
alxhubhttps://github.com/alxhub
715d02ahttps://github.com/angular/angular/commit/715d02aa146bb8edbbae5b190ae90fd9d1672b29
Nov 21, 2019https://github.com/angular/angular/pull/33964#event-2820754722
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
November 22, 2019 07:42https://github.com/angular/angular/pull/33964#event-2822305361
JoostKhttps://github.com/JoostK
Nov 22, 2019 https://github.com/angular/angular/pull/33964#ref-commit-ad75ae5
https://github.com/JoostK
Accept new failures due to reporting diagnosticshttps://github.com/JoostK/ngcc-validation/commit/ad75ae55d2a1675b3d5bfcad11298971a2cefe2e
ad75ae5https://github.com/JoostK/ngcc-validation/commit/ad75ae55d2a1675b3d5bfcad11298971a2cefe2e
angular/angular#33964https://github.com/angular/angular/pull/33964
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Nov 22, 2019 https://github.com/angular/angular/pull/33964#ref-pullrequest-527403391
Accept new failures due to reporting diagnostics angular/ngcc-validation#611 https://github.com/angular/ngcc-validation/pull/611
mgechevhttps://github.com/mgechev
Nov 23, 2019 https://github.com/angular/angular/pull/33964#ref-commit-e904315
https://github.com/JoostK
https://github.com/mgechev
Accept new failures due to reporting diagnostics (https://github.com/angular/ngcc-validation/commit/e9043152fc803bedcb6a271a692f619b816ef253
#611https://github.com/angular/ngcc-validation/pull/611
)https://github.com/angular/ngcc-validation/commit/e9043152fc803bedcb6a271a692f619b816ef253
e904315https://github.com/angular/ngcc-validation/commit/e9043152fc803bedcb6a271a692f619b816ef253
angular/angular#33964https://github.com/angular/angular/pull/33964
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Dec 23, 2019https://github.com/angular/angular/pull/33964#issuecomment-568513100
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/33964
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Dec 23, 2019https://github.com/angular/angular/pull/33964#event-2905113944
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33964
https://github.com/gkalpak
gkalpak https://github.com/gkalpak
https://github.com/angular/angular/pull/33964/files/3a71282824c124d89b2a3d8c5ec6c12147a69241
Please reload this pagehttps://github.com/angular/angular/pull/33964
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/33964
https://github.com/petebacondarwin
https://github.com/gkalpak
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.