René's URL Explorer Experiment


Title: fix: should not tick nested timer in fakeAsync test by JiaLiPassion · Pull Request #33838 · angular/angular · GitHub

Open Graph Title: fix: should not tick nested timer in fakeAsync test by JiaLiPassion · Pull Request #33838 · angular/angular

X Title: fix: should not tick nested timer in fakeAsync test by JiaLiPassion · Pull Request #33838 · angular/angular

Description: Close #33799 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: #33799 function waitTwice(callback: () => any): void { setTimeout(() => setTimeout(() => callback()) ); } describe('fakeAsync', () => { it('nested timers', fakeAsync(() => { const callback = jasmine.createSpy('callback'); waitTwice(callback); expect(callback).not.toHaveBeenCalled(); tick(); expect(callback).toHaveBeenCalled(); tick(); expect(callback).toHaveBeenCalled(); })); }); By default, The callback will be called after the first tick. describe('fakeAsync', () => { it('nested timers', fakeAsync(() => { const callback = jasmine.createSpy('callback'); waitTwice(callback); expect(callback).not.toHaveBeenCalled(); tick(0, true); expect(callback).not.toHaveBeenCalled(); tick(); expect(callback).toHaveBeenCalled(); })); }); ## What is the new behavior? with `tick(0, true)`, the second parameter is `ignoreNestedTimeout`, after the `first tick`, the `nested timeout` will not be invoked. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No

Open Graph Description: Close #33799 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#co...

X Description: Close #33799 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#co...

Opengraph URL: https://github.com/angular/angular/pull/33838

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8ae4c115-9a24-bade-70aa-ba645badc887
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id975A:FC5BE:1A1395C:2294183:6B015392
html-safe-noncedc650048951afd911c0000e968ef3868ecdfaf89e9ecd97f7d8f9f5566959396
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzVBOkZDNUJFOjFBMTM5NUM6MjI5NDE4Mzo2QjAxNTM5MiIsInZpc2l0b3JfaWQiOiIzNzM1OTg0MTI4OTIzODgyMzg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace5596d84e0938cceee6f48f993e0e86fe1bb6067130fb753d8bf575f917806e9
hovercard-subject-tagpull_request:341241998
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/33838/files
twitter:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
og:image:altClose #33799 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#co...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/33838/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33838%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F33838%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/33838/files
Reloadhttps://github.com/angular/angular/pull/33838/files
Reloadhttps://github.com/angular/angular/pull/33838/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JiaLiPassionhttps://github.com/JiaLiPassion
angular:masterhttps://github.com/angular/angular/tree/master
JiaLiPassion:fakeasync-nested-timeouthttps://github.com/JiaLiPassion/angular/tree/fakeasync-nested-timeout
Conversation 27 https://github.com/angular/angular/pull/33838
Commits 1 https://github.com/angular/angular/pull/33838/commits
Checks 0 https://github.com/angular/angular/pull/33838/checks
Files changed https://github.com/angular/angular/pull/33838/files
Please reload this pagehttps://github.com/angular/angular/pull/33838/files
fix: should not tick nested timer in fakeAsync test https://github.com/angular/angular/pull/33838/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/33838/files
284f8b2 feat: add an tickOptions parameter with property processNewMacroTasks… JiaLiPassion Dec 2, 2019 https://github.com/angular/angular/pull/33838/commits/284f8b23de8ff37cf60cc0a0efcffb30bb46837b
Clear filters https://github.com/angular/angular/pull/33838/files
Please reload this pagehttps://github.com/angular/angular/pull/33838/files
Please reload this pagehttps://github.com/angular/angular/pull/33838/files
async-helper.spec.ts https://github.com/angular/angular/pull/33838/files#diff-8774e303eac1d2089c5a8e1e755cc39b9c2a7ae377884dcfd2f22368fd4a8968
testing.md https://github.com/angular/angular/pull/33838/files#diff-eb727bc330033526ca0840faa251f13304106d93e362f54acf3c459118733482
fake_async_spec.ts https://github.com/angular/angular/pull/33838/files#diff-0f351a13f1ccb5208fec6cb40734e790d2fd219919412086cfa74d1b089531bf
fake_async.ts https://github.com/angular/angular/pull/33838/files#diff-d0a1d56a62d8bc687d0c19d59aadd08cf7d57c4e234281e6dc5cad26d098d885
fake_async_fallback.ts https://github.com/angular/angular/pull/33838/files#diff-0169795daf44d032df85fa16e6d6483808f8d3e3b5022ea6827040b44643aadd
fake-async.ts https://github.com/angular/angular/pull/33838/files#diff-191e1f319d6e4463bde4b5f9ab1c29a79513bb914f5c57894c6c9ce12670c13b
fake-async-test.ts https://github.com/angular/angular/pull/33838/files#diff-75182ba0ff0b69de6f6041bb4f50c13f0799e180d54dee9304db4cd01d688480
fake-async-test.spec.ts https://github.com/angular/angular/pull/33838/files#diff-f88858cb9f75f303f1dbd34588d17c6a7804f867db1f8debf30b90bcd5cf036e
testing.d.ts https://github.com/angular/angular/pull/33838/files#diff-96824c870545138205c9037520842c1c97ea53163ca43a80e6d074ecc4b60606
aio/content/examples/testing/src/app/demo/async-helper.spec.tshttps://github.com/angular/angular/pull/33838/files#diff-8774e303eac1d2089c5a8e1e755cc39b9c2a7ae377884dcfd2f22368fd4a8968
View file https://github.com/JiaLiPassion/angular/blob/284f8b23de8ff37cf60cc0a0efcffb30bb46837b/aio/content/examples/testing/src/app/demo/async-helper.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33838/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33838/files#diff-8774e303eac1d2089c5a8e1e755cc39b9c2a7ae377884dcfd2f22368fd4a8968
https://github.com/angular/angular/pull/33838/files#diff-8774e303eac1d2089c5a8e1e755cc39b9c2a7ae377884dcfd2f22368fd4a8968
https://github.com/angular/angular/pull/33838/files#diff-8774e303eac1d2089c5a8e1e755cc39b9c2a7ae377884dcfd2f22368fd4a8968
aio/content/guide/testing.mdhttps://github.com/angular/angular/pull/33838/files#diff-eb727bc330033526ca0840faa251f13304106d93e362f54acf3c459118733482
View file https://github.com/JiaLiPassion/angular/blob/284f8b23de8ff37cf60cc0a0efcffb30bb46837b/aio/content/guide/testing.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33838/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33838/files#diff-eb727bc330033526ca0840faa251f13304106d93e362f54acf3c459118733482
https://github.com/angular/angular/pull/33838/files#diff-eb727bc330033526ca0840faa251f13304106d93e362f54acf3c459118733482
https://github.com/angular/angular/pull/33838/files#diff-eb727bc330033526ca0840faa251f13304106d93e362f54acf3c459118733482
packages/core/test/fake_async_spec.tshttps://github.com/angular/angular/pull/33838/files#diff-0f351a13f1ccb5208fec6cb40734e790d2fd219919412086cfa74d1b089531bf
View file https://github.com/JiaLiPassion/angular/blob/284f8b23de8ff37cf60cc0a0efcffb30bb46837b/packages/core/test/fake_async_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33838/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33838/files#diff-0f351a13f1ccb5208fec6cb40734e790d2fd219919412086cfa74d1b089531bf
https://github.com/angular/angular/pull/33838/files#diff-0f351a13f1ccb5208fec6cb40734e790d2fd219919412086cfa74d1b089531bf
packages/core/testing/src/fake_async.tshttps://github.com/angular/angular/pull/33838/files#diff-d0a1d56a62d8bc687d0c19d59aadd08cf7d57c4e234281e6dc5cad26d098d885
View file https://github.com/JiaLiPassion/angular/blob/284f8b23de8ff37cf60cc0a0efcffb30bb46837b/packages/core/testing/src/fake_async.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33838/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33838/files#diff-d0a1d56a62d8bc687d0c19d59aadd08cf7d57c4e234281e6dc5cad26d098d885
https://github.com/angular/angular/pull/33838/files#diff-d0a1d56a62d8bc687d0c19d59aadd08cf7d57c4e234281e6dc5cad26d098d885
packages/core/testing/src/fake_async_fallback.tshttps://github.com/angular/angular/pull/33838/files#diff-0169795daf44d032df85fa16e6d6483808f8d3e3b5022ea6827040b44643aadd
View file https://github.com/JiaLiPassion/angular/blob/284f8b23de8ff37cf60cc0a0efcffb30bb46837b/packages/core/testing/src/fake_async_fallback.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33838/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33838/files#diff-0169795daf44d032df85fa16e6d6483808f8d3e3b5022ea6827040b44643aadd
https://github.com/angular/angular/pull/33838/files#diff-0169795daf44d032df85fa16e6d6483808f8d3e3b5022ea6827040b44643aadd
packages/zone.js/lib/testing/fake-async.tshttps://github.com/angular/angular/pull/33838/files#diff-191e1f319d6e4463bde4b5f9ab1c29a79513bb914f5c57894c6c9ce12670c13b
View file https://github.com/JiaLiPassion/angular/blob/284f8b23de8ff37cf60cc0a0efcffb30bb46837b/packages/zone.js/lib/testing/fake-async.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/33838/{{ revealButtonHref }}
https://github.com/angular/angular/pull/33838/files#diff-191e1f319d6e4463bde4b5f9ab1c29a79513bb914f5c57894c6c9ce12670c13b
https://github.com/angular/angular/pull/33838/files#diff-191e1f319d6e4463bde4b5f9ab1c29a79513bb914f5c57894c6c9ce12670c13b
Please reload this pagehttps://github.com/angular/angular/pull/33838/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.